def test_A_Breathing(self):
rev_id = self._createNonEmptyRevision('test_A_Breathing')
conduit = self.phabConduit
phlcon_differential.create_inline_comment(
conduit, rev_id, 'readme', 2, 'this is an inline comment')
phlcon_differential.create_inline_comment(
conduit, rev_id, 'readme', 3, 'this another inline comment')
phlcon_differential.create_comment(
conduit, rev_id, 'this is a message', attach_inlines=True)
def test_A_Breathing(self):
rev_id = self._createNonEmptyRevision('test_A_Breathing')
conduit = self.phabConduit
phlcon_differential.create_inline_comment(
conduit, rev_id, 'readme', 2, 'this is an inline comment')
phlcon_differential.create_inline_comment(
conduit, rev_id, 'readme', 3, 'this another inline comment')
phlcon_differential.create_comment(
conduit, rev_id, 'this is a message', attach_inlines=True)
def linterate(args, conduit, revision, error_revisions, error_filter):
if not args.silent:
print(revision.id, revision.title)
try:
errors = None
if os.path.isdir('right'):
errors = phlsys_cppcheck.run('right')
errors = error_filter.filter_ignored(revision, errors)
if errors:
if args.silent:
print(revision.id, revision.title)
print(phlsys_cppcheck.summarize_results(errors))
print(revision.uri)
error_revisions.append(str(revision.id))
if not args.non_interactive and phlsys_choice.yes_or_no('comment'):
print("commenting..")
for e in errors:
first_line = min(e.line_numbers)
last_line = max(e.line_numbers)
line_range = last_line - first_line
if line_range > 10:
for line in e.line_numbers:
phlcon_differential.create_inline_comment(
conduit, revision.id, e.path, line, e.message)
else:
phlcon_differential.create_inline_comment(
conduit,
revision.id,
e.path,
first_line,
e.message,
line_count=line_range)
# XXX: only leave draft inline comments for now, so the user
# may review them in context and manually finish the
# comment
#
# message = "LINTERATOR SEE POSSIBLE ERROR"
# phlcon_differential.create_comment(
# conduit, revision.id, message, attach_inlines=True)
print()
except phlsys_subprocess.CalledProcessError as e:
if not args.silent:
print(' ', e)
def linterate(args, conduit, revision, error_revisions, error_filter):
if not args.silent:
print(revision.id, revision.title)
try:
errors = None
if os.path.isdir('right'):
errors = phlsys_cppcheck.run('right')
errors = error_filter.filter_ignored(revision, errors)
if errors:
if args.silent:
print(revision.id, revision.title)
print(phlsys_cppcheck.summarize_results(errors))
print(revision.uri)
error_revisions.append(str(revision.id))
if not args.non_interactive and phlsys_choice.yes_or_no('comment'):
print("commenting..")
for e in errors:
first_line = min(e.line_numbers)
last_line = max(e.line_numbers)
line_range = last_line - first_line
if line_range > 10:
for line in e.line_numbers:
phlcon_differential.create_inline_comment(
conduit, revision.id, e.path, line, e.message)
else:
phlcon_differential.create_inline_comment(
conduit,
revision.id,
e.path,
first_line,
e.message,
line_count=line_range)
# XXX: only leave draft inline comments for now, so the user
# may review them in context and manually finish the
# comment
#
# message = "LINTERATOR SEE POSSIBLE ERROR"
# phlcon_differential.create_comment(
# conduit, revision.id, message, attach_inlines=True)
print()
except phlsys_subprocess.CalledProcessError as e:
if not args.silent:
print(' ', e)
def process(args):
conduit = phlsys_makeconduit.make_conduit(args.uri, args.user, args.cert,
args.act_as_user)
message = args.message
if args.message_file:
message += args.message_file.read()
result = phlcon_differential.create_inline_comment(
conduit, args.id, args.filepath, args.start_line, message,
not args.left_side, args.end_line_offset)
print(result)
def process(args):
conduit = phlsys_makeconduit.make_conduit(
args.uri, args.user, args.cert, args.act_as_user)
message = args.message
if args.message_file:
message += args.message_file.read()
result = phlcon_differential.create_inline_comment(
conduit,
args.id,
args.filepath,
args.start_line,
message,
not args.left_side,
args.end_line_offset)
print result
def test_A_Breathing(self):
rev_id = self._createNonEmptyRevision("test_A_Breathing")
conduit = self.phabConduit
phlcon_differential.create_inline_comment(conduit, rev_id, "readme", 2, "this is an inline comment")
phlcon_differential.create_inline_comment(conduit, rev_id, "readme", 3, "this another inline comment")
phlcon_differential.create_comment(conduit, rev_id, "this is a message", attach_inlines=True)
