forked from webrtc-uwp/depot_tools
/
my_reviews.py
executable file
·396 lines (345 loc) · 11.8 KB
/
my_reviews.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
#!/usr/bin/env python
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Get rietveld stats about the review you done, or forgot to do.
Example:
- my_reviews.py -r me@chromium.org -Q for stats for last quarter.
"""
import datetime
import math
import optparse
import os
import sys
import auth
import rietveld
try:
import dateutil # pylint: disable=import-error
import dateutil.parser
from dateutil.relativedelta import relativedelta
except ImportError:
print 'python-dateutil package required'
exit(1)
def username(email):
"""Keeps the username of an email address."""
return email.split('@', 1)[0]
def to_datetime(string):
"""Load UTC time as a string into a datetime object."""
try:
# Format is 2011-07-05 01:26:12.084316
return datetime.datetime.strptime(
string.split('.', 1)[0], '%Y-%m-%d %H:%M:%S')
except ValueError:
return datetime.datetime.strptime(string, '%Y-%m-%d')
def to_time(seconds):
"""Convert a number of seconds into human readable compact string."""
prefix = ''
if seconds < 0:
prefix = '-'
seconds *= -1
minutes = math.floor(seconds / 60)
seconds -= minutes * 60
hours = math.floor(minutes / 60)
minutes -= hours * 60
days = math.floor(hours / 24)
hours -= days * 24
out = []
if days > 0:
out.append('%dd' % days)
if hours > 0 or days > 0:
out.append('%02dh' % hours)
if minutes > 0 or hours > 0 or days > 0:
out.append('%02dm' % minutes)
if seconds > 0 and not out:
# Skip seconds unless there's only seconds.
out.append('%02ds' % seconds)
return prefix + ''.join(out)
class Stats(object):
def __init__(self):
self.total = 0
self.actually_reviewed = 0
self.latencies = []
self.lgtms = 0
self.multiple_lgtms = 0
self.drive_by = 0
self.not_requested = 0
self.self_review = 0
self.percent_lgtm = 0.
self.percent_drive_by = 0.
self.percent_not_requested = 0.
self.days = 0
@property
def average_latency(self):
if not self.latencies:
return 0
return sum(self.latencies) / float(len(self.latencies))
@property
def median_latency(self):
if not self.latencies:
return 0
length = len(self.latencies)
latencies = sorted(self.latencies)
if (length & 1) == 0:
return (latencies[length/2] + latencies[length/2-1]) / 2.
else:
return latencies[length/2]
@property
def percent_done(self):
if not self.total:
return 0
return self.actually_reviewed * 100. / self.total
@property
def review_per_day(self):
if not self.days:
return 0
return self.total * 1. / self.days
@property
def review_done_per_day(self):
if not self.days:
return 0
return self.actually_reviewed * 1. / self.days
def finalize(self, first_day, last_day):
if self.actually_reviewed:
assert self.actually_reviewed > 0
self.percent_lgtm = (self.lgtms * 100. / self.actually_reviewed)
self.percent_drive_by = (self.drive_by * 100. / self.actually_reviewed)
self.percent_not_requested = (
self.not_requested * 100. / self.actually_reviewed)
assert bool(first_day) == bool(last_day)
if first_day and last_day:
assert first_day <= last_day
self.days = (to_datetime(last_day) - to_datetime(first_day)).days + 1
assert self.days > 0
def _process_issue_lgtms(issue, reviewer, stats):
"""Calculates LGTMs stats."""
stats.actually_reviewed += 1
reviewer_lgtms = len([
msg for msg in issue['messages']
if msg['approval'] and msg['sender'] == reviewer])
if reviewer_lgtms > 1:
stats.multiple_lgtms += 1
return ' X '
if reviewer_lgtms:
stats.lgtms += 1
return ' x '
else:
return ' o '
def _process_issue_latency(issue, reviewer, stats):
"""Calculates latency for an issue that was actually reviewed."""
from_owner = [
msg for msg in issue['messages'] if msg['sender'] == issue['owner_email']
]
if not from_owner:
# Probably requested by email.
stats.not_requested += 1
return '<no rqst sent>'
first_msg_from_owner = None
latency = None
received = False
for index, msg in enumerate(issue['messages']):
if not first_msg_from_owner and msg['sender'] == issue['owner_email']:
first_msg_from_owner = msg
if index and not received and msg['sender'] == reviewer:
# Not first email, reviewer never received one, reviewer sent a mesage.
stats.drive_by += 1
return '<drive-by>'
received |= reviewer in msg['recipients']
if first_msg_from_owner and msg['sender'] == reviewer:
delta = msg['date'] - first_msg_from_owner['date']
latency = delta.seconds + delta.days * 24 * 3600
break
if latency is None:
stats.not_requested += 1
return '<no rqst sent>'
if latency > 0:
stats.latencies.append(latency)
else:
stats.not_requested += 1
return to_time(latency)
def _process_issue(issue):
"""Preprocesses the issue to simplify the remaining code."""
issue['owner_email'] = username(issue['owner_email'])
issue['reviewers'] = set(username(r) for r in issue['reviewers'])
# By default, hide commit-bot.
issue['reviewers'] -= set(['commit-bot'])
for msg in issue['messages']:
msg['sender'] = username(msg['sender'])
msg['recipients'] = [username(r) for r in msg['recipients']]
# Convert all times to datetime instances.
msg['date'] = to_datetime(msg['date'])
issue['messages'].sort(key=lambda x: x['date'])
def print_issue(issue, reviewer, stats):
"""Process an issue and prints stats about it."""
stats.total += 1
_process_issue(issue)
if issue['owner_email'] == reviewer:
stats.self_review += 1
latency = '<self review>'
reviewed = ''
elif any(msg['sender'] == reviewer for msg in issue['messages']):
reviewed = _process_issue_lgtms(issue, reviewer, stats)
latency = _process_issue_latency(issue, reviewer, stats)
else:
latency = 'N/A'
reviewed = ''
# More information is available, print issue.keys() to see them.
print '%7d %10s %3s %14s %-15s %s' % (
issue['issue'],
issue['created'][:10],
reviewed,
latency,
issue['owner_email'],
', '.join(sorted(issue['reviewers'])))
def print_reviews(
reviewer, created_after, created_before, instance_url, auth_config):
"""Prints issues |reviewer| received and potentially reviewed."""
remote = rietveld.Rietveld(instance_url, auth_config)
# The stats we gather. Feel free to send me a CL to get more stats.
stats = Stats()
# Column sizes need to match print_issue() output.
print >> sys.stderr, (
'Issue Creation Did Latency Owner Reviewers')
# See def search() in rietveld.py to see all the filters you can use.
issues = []
for issue in remote.search(
reviewer=reviewer,
created_after=created_after,
created_before=created_before,
with_messages=True):
issues.append(issue)
print_issue(issue, username(reviewer), stats)
issues.sort(key=lambda x: x['created'])
first_day = None
last_day = None
if issues:
first_day = issues[0]['created'][:10]
last_day = issues[-1]['created'][:10]
stats.finalize(first_day, last_day)
print >> sys.stderr, (
'%s reviewed %d issues out of %d (%1.1f%%). %d were self-review.' %
(reviewer, stats.actually_reviewed, stats.total, stats.percent_done,
stats.self_review))
print >> sys.stderr, (
'%4.1f review request/day during %3d days (%4.1f r/d done).' % (
stats.review_per_day, stats.days, stats.review_done_per_day))
print >> sys.stderr, (
'%4d were drive-bys (%5.1f%% of reviews done).' % (
stats.drive_by, stats.percent_drive_by))
print >> sys.stderr, (
'%4d were requested over IM or irc (%5.1f%% of reviews done).' % (
stats.not_requested, stats.percent_not_requested))
print >> sys.stderr, (
('%4d issues LGTM\'d (%5.1f%% of reviews done),'
' gave multiple LGTMs on %d issues.') % (
stats.lgtms, stats.percent_lgtm, stats.multiple_lgtms))
print >> sys.stderr, (
'Average latency from request to first comment is %s.' %
to_time(stats.average_latency))
print >> sys.stderr, (
'Median latency from request to first comment is %s.' %
to_time(stats.median_latency))
def print_count(
reviewer, created_after, created_before, instance_url, auth_config):
remote = rietveld.Rietveld(instance_url, auth_config)
print len(list(remote.search(
reviewer=reviewer,
created_after=created_after,
created_before=created_before,
keys_only=True)))
def get_previous_quarter(today):
"""There are four quarters, 01-03, 04-06, 07-09, 10-12.
If today is in the last month of a quarter, assume it's the current quarter
that is requested.
"""
end_year = today.year
end_month = today.month - (today.month % 3) + 1
if end_month <= 0:
end_year -= 1
end_month += 12
if end_month > 12:
end_year += 1
end_month -= 12
end = '%d-%02d-01' % (end_year, end_month)
begin_year = end_year
begin_month = end_month - 3
if begin_month <= 0:
begin_year -= 1
begin_month += 12
begin = '%d-%02d-01' % (begin_year, begin_month)
return begin, end
def main():
# Silence upload.py.
rietveld.upload.verbosity = 0
today = datetime.date.today()
begin, end = get_previous_quarter(today)
default_email = os.environ.get('EMAIL_ADDRESS')
if not default_email:
user = os.environ.get('USER')
if user:
default_email = user + '@chromium.org'
parser = optparse.OptionParser(description=__doc__)
parser.add_option(
'--count', action='store_true',
help='Just count instead of printing individual issues')
parser.add_option(
'-r', '--reviewer', metavar='<email>', default=default_email,
help='Filter on issue reviewer, default=%default')
parser.add_option(
'-b', '--begin', metavar='<date>',
help='Filter issues created after the date')
parser.add_option(
'-e', '--end', metavar='<date>',
help='Filter issues created before the date')
parser.add_option(
'-Q', '--last_quarter', action='store_true',
help='Use last quarter\'s dates, e.g. %s to %s' % (begin, end))
parser.add_option(
'-i', '--instance_url', metavar='<host>',
default='http://codereview.chromium.org',
help='Host to use, default is %default')
auth.add_auth_options(parser)
# Remove description formatting
parser.format_description = (
lambda _: parser.description) # pylint: disable=no-member
options, args = parser.parse_args()
auth_config = auth.extract_auth_config_from_options(options)
if args:
parser.error('Args unsupported')
if options.reviewer is None:
parser.error('$EMAIL_ADDRESS and $USER are not set, please use -r')
print >> sys.stderr, 'Searching for reviews by %s' % options.reviewer
if options.last_quarter:
options.begin = begin
options.end = end
print >> sys.stderr, 'Using range %s to %s' % (
options.begin, options.end)
else:
if options.begin is None or options.end is None:
parser.error('Please specify either --last_quarter or --begin and --end')
# Validate dates.
try:
options.begin = dateutil.parser.parse(options.begin).strftime('%Y-%m-%d')
options.end = dateutil.parser.parse(options.end).strftime('%Y-%m-%d')
except ValueError as e:
parser.error('%s: %s - %s' % (e, options.begin, options.end))
if options.count:
print_count(
options.reviewer,
options.begin,
options.end,
options.instance_url,
auth_config)
else:
print_reviews(
options.reviewer,
options.begin,
options.end,
options.instance_url,
auth_config)
return 0
if __name__ == '__main__':
try:
sys.exit(main())
except KeyboardInterrupt:
sys.stderr.write('interrupted\n')
sys.exit(1)