"""Superclass for all linters.

When subclassing, override either process_files or process (or both,

though if you override process_files then it doesn't matter what

process does).

"""

def process_files(self, files):

"""Print lint errors for a list of filenames and return error count."""

num_errors = 0

for f in files:

try:

contents = open(f, 'U').read()

except (IOError, OSError) as why:

six.print_("SKIPPING lint of %s: %s" % (f, why.args[1]))

num_errors += 1

continue

num_errors += self.process(f, contents)

return num_errors

def process(self, file, contents):

"""Lint one file given its path and contents, returning error count."""

"""Call fn(*args, **kwargs) and return (fn_retval, fn_stdout_output_fp)."""

try:

orig_stdout = sys.stdout

sys.stdout = StringIO()

retval = fn(*args, **kwargs)

sys.stdout.seek(0) # so new read()/readlines() calls will return

return (retval, sys.stdout)

finally:

"""Linter for python. process() processes one file."""

GLOBAL_IGNORES = [

'E266', # too many leading '#' for block comment

'W291', # trailing whitespace

'W293', # blank line contains whitespace

'W391', # blank line at end of file

'E402', # module level import not at top of file

'W503', # line break before binary operator

'E712', # comparison to True must be 'if cond is True:' or 'if cond:'

'E731', # do not assign a lambda expression

]

def __init__(self, pep8_args, propose_arc_fixes=False):

pep8.process_options(pep8_args + ['dummy'])

self._propose_arc_fixes = propose_arc_fixes

# Our version of pep8 thinks that python3-style type annotaions are

# multiple statements on one line. We therefore ignore this rule for

# python3. (E701 is "multiple statements on one line".)

# TODO(colin): it would be nice to use this lint rule. Change pep8 to

# pycodestyle (its successor; pep8 has had its final release), which

# correctly recognizes these annotations, and then remove this ignore.

if six.PY3:

Pep8.GLOBAL_IGNORES.append('E701')

def _munge_output_line(self, line):

"""Modify the line to have the canonical form for lint lines."""

# Canonical form: <file>:<line>[:<col>]: <E|W><code> <msg>

# Pep8 already has that form, so we're good. We only need to

# strip the trailing newline.

return line.rstrip()

def _maybe_add_arc_fix(self, lintline, bad_line):

"""Optionally add a patch for arc lint to use for autofixing."""

if not self._propose_arc_fixes:

return lintline

errcode = lintline.split(' ')[1]

# expected 2 blank lines, found 1

if errcode == 'E302':

return lint_util.add_arc_fix_str(lintline, bad_line, '', '\n')

# at least two spaces before inline comment

if errcode == 'E261':

return lint_util.add_arc_fix_str(lintline, bad_line, '', ' ')

return lintline

def _process_one_line(self, output_line, contents_lines, ignored_rules):

"""If line is an 'error', print it and return 1. Else return 0.

pep8 prints all errors to stdout. But we want to ignore some

'errors' that are ok for us but cannot be suppressed via pep8

flags, such as lines marked with @Nolint. To do this, we

intercept stdin and remove these lines.

Arguments:

output_line: one line of the pep8 error-output

contents_lines: the contents of the file being linted,

as a list of lines.

ignored_rules: a list of rules (like 'E501') that will be

ignored

Returns:

1 (indicating one error) if we print the error line, 0 else.

"""

# Get the lint message to a canonical format so we can parse it.

lintline = self._munge_output_line(output_line)

bad_linenum = int(lintline.split(':', 2)[1]) # first line is '1'

bad_line = contents_lines[bad_linenum - 1] # convert to 0-index

if '@Nolint' in bad_line:

return 0

if any(rule in lintline

for rule in (self.GLOBAL_IGNORES + ignored_rules)):

return 0

# We allow lines to be arbitrarily long if they are urls,

# since splitting urls at 80 columns can be annoying.

if ('E501 line too long' in lintline and

('http://' in bad_line or 'https://' in bad_line)):

return 0

# We sometimes embed json in docstrings (as documentation of

# command output), and don't want to have to do weird

# line-wraps for that.

# We do a cheap check for a plausible json-like line: starts

# and ends with a ". (The end-check is kosher because only

# strings can be really long in our use-case.) If that check

# passes, we do a simple syntax-check that we're in a

# docstring: going up until we see a line with a """, the line

# above it starts with 'def' or 'class' (we do some simple

# checking for multi-line def's). This can be fooled, but

# should work well enough.

if ('E501 line too long' in lintline and

bad_line.lstrip().startswith('"') and

bad_line.rstrip(',\n').endswith('"') and

bad_linenum):

linenum = 0 # in case the xrange() below is empty

for linenum in xrange(bad_linenum - 1, 0, -1):

if (contents_lines[linenum].lstrip().startswith('"""') or

contents_lines[linenum].lstrip().startswith("'''")):

break

# Now check that the line before the """ is a def or class.

# Since def's (and classes) can be multiple lines long, we

# may have to check backwards a few lines. We basically look

# at previous lines until we reach a line that starts with

# def or class (good), a line with a """ (bad, it means the

# """ above was ending a docstring, not starting one) or a

# blank line (bad, it means the """ is in some random place).

for prev_linenum in xrange(linenum - 1, -1, -1):

prev = contents_lines[prev_linenum].strip()

if (not prev or

prev.startswith('"""') or prev.startswith("'''")):

break

if prev.startswith('def ') or prev.startswith('class '):

return 0

# OK, looks like it's a legitimate error.

six.print_(self._maybe_add_arc_fix(lintline, bad_line))

return 1

def _get_file_level_nolint_rules(self, contents_lines):

"""Get a list of rules disabled at the file-level.

This allows us to upgrade linter without having to fix all the lint

immediately.

We check the first three lines (three to allow for a shebang, and a

TODO to fix the lint) for a comment that looks like:

# pep8-disable:E101,E102,W405

where the part following the colon is a comma-separated list of rules

to ignore in the file. These must all start with E or W.

"""

for line in contents_lines[:3]:

match = re.search(r'pep8-disable:([^\s]+)', line)

if match:

return [

rule for rule in match.group(1).split(',')

if rule.startswith('E') or rule.startswith('W')]

return []

def process(self, f, contents_of_f):

contents_lines = contents_of_f.splitlines(True)

file_level_nolint = self._get_file_level_nolint_rules(contents_lines)

(num_candidate_errors, pep8_stdout) = _capture_stdout_of(

pep8.Checker(f, lines=contents_lines).check_all)

# Go through the output and remove the 'actually ok' lines.

if num_candidate_errors == 0:

return 0

num_errors = 0

for output_line in pep8_stdout.readlines():

num_errors += self._process_one_line(

output_line, contents_lines, file_level_nolint)

"""Linter for python. process() processes one file."""

def __init__(self, propose_arc_fixes=False):

self._propose_arc_fixes = propose_arc_fixes

def _munge_output_line(self, line):

"""Modify the line to have the canonical form for lint lines."""

# Canonical form: <file>:<line>[:<col>]: <E|W><code> <msg>

# pyflakes just needs to add the "E<code>" or "W<code>". For

# now we only use E, since everything we print is an error.

# pyflakes doesn't have an error code, so we just use

# 'pyflakes'. We also strip the trailing newline.

# We limit the number of splits as error messages can occasionally

# contain :.

(file, line, error) = line.rstrip().split(':', 2)

return '%s:%s:1: E=pyflakes=%s' % (file, line, error)

def _maybe_add_arc_fix(self, lintline, bad_line):

"""Optionally add a patch for arc lint to use for autofixing."""

if not self._propose_arc_fixes:

return lintline

if 'imported but unused' in lintline:

return lint_util.add_arc_fix_str(lintline, bad_line,

bad_line + '\n', '')

return lintline

def _process_one_line(self, output_line, contents_lines):

"""If line is an 'error', print it and return 1. Else return 0.

pyflakes prints all errors to stdout. But we want to ignore

some 'errors' that are ok for us: code like

try:

import unittest2 as unittest

except ImportError:

import unittest

To do this, we intercept stdin and remove these lines.

Arguments:

output_line: one line of the pyflakes error-output

contents_lines: the contents of the file being linted,

as a list of lines.

Returns:

1 (indicating one error) if we print the error line, 0 else.

"""

# The 'try/except ImportError' example described above.

if 'redefinition of unused' in output_line:

return 0

# We follow python convention of allowing an unused variable

# if it's named '_' or starts with 'unused_'.

if ('assigned to but never used' in output_line and

("local variable '_'" in output_line or

"local variable 'unused_" in output_line)):

return 0

# It's OK to redefine variables that are unused by convention.

if ("list comprehension redefines '_'" in output_line or

"list comprehension redefines 'unused_" in output_line):

return 0

# Get rid of some warnings too.

if 'unable to detect undefined names' in output_line:

return 0

# -- The next set of warnings need to look at the error line.

# Get the lint message to a canonical format so we can parse it.

lintline = self._munge_output_line(output_line)

bad_linenum = int(lintline.split(':', 2)[1]) # first line is '1'

bad_line = contents_lines[bad_linenum - 1] # convert to 0-index

# If the line has a nolint directive, ignore it.

if '@Nolint' in bad_line:

return 0

# An old nolint directive that's specific to imports

if ('@UnusedImport' in bad_line and

'imported but unused' in lintline):

return 0

# OK, looks like it's a legitimate error.

six.print_(self._maybe_add_arc_fix(lintline, bad_line))

return 1

def process(self, f, contents_of_f):

# pyflakes's ast-parser fails if the file doesn't end in a newline,

# so make sure it does.

if not contents_of_f.endswith('\n'):

contents_of_f += '\n'

(num_candidate_errors, pyflakes_stdout) = _capture_stdout_of(

pyflakes.check, contents_of_f, f)

# Now go through the output and remove the 'actually ok' lines.

if num_candidate_errors == 0:

return 0

num_errors = 0

contents_lines = contents_of_f.splitlines() # need these for filtering

for output_line in pyflakes_stdout.readlines():

num_errors += self._process_one_line(output_line,

contents_lines)

"""A linter for generic python errors that are not caught by pep8/pyflakes.

This is a linter for general (as opposed to application-specific)

python errors that are not caught by third-party linters. We add

those checks here.

"""

def _bad_super(self, line):

# We don't want this linter to fire on this line itself!

return ('super(type(self)' in line or # @Nolint

'super(self.__class__' in line) # @Nolint

def process(self, f, contents_of_f):

num_errors = 0

for (linenum_minus_1, line) in enumerate(contents_of_f.splitlines()):

if '@Nolint' in line:

continue

if self._bad_super(line):

# Canonical form: <file>:<line>[:<col>]: <E|W><code> <msg>

six.print_('%s:%s: E999 first argument to super() must be '

'an explicit classname, not type(self)'

% (f, linenum_minus_1 + 1))

num_errors += 1

"""Complain if the file has git merge-conflict markers in it.

git will merrily let you 'resolve' a file that still has merge

conflict markers in it. This lint check will hopefully catch

that.

"""

# We don't check for ======= because it might legitimately be in

# a file (for purposes other than as a git conflict marker).

_MARKERS = ('<' * 7, '|' * 7, '>' * 7)

_MARKERS_RE = re.compile(r'^(%s)( |$)'

% '|'.join(re.escape(m) for m in _MARKERS),

re.MULTILINE)

def process(self, f, contents_of_f):

# Ignore files that git thinks are binary; those don't ever

# get merge conflict markers. This is how we check, sez

# http://stackoverflow.com/questions/6119956/how-to-determine-if-git-handles-a-file-as-binary-or-as-text:

if '\0' in contents_of_f[:8000]:

return 0 # a binary file

num_errors = 0

for m in self._MARKERS_RE.finditer(contents_of_f):

linenum = contents_of_f.count('\n', 0, m.start()) + 1

six.print_('%s:%s:1: E1 git conflict marker "%s" found'

% (f, linenum, m.group(1)))

num_errors += 1

"""Linter for javascript. process() processes one file.

Arguments:

config_path: the path of the eslintrc file

"""

def __init__(self, config_path, propose_arc_fixes=False):

self._config_path = config_path

self._propose_arc_fixes = propose_arc_fixes

def _maybe_add_arc_fix(self, lintline, bad_line):

"""Optionally add a patch for arc lint to use for autofixing."""

if not self._propose_arc_fixes:

return lintline

(file_line_col, errcode, msg) = lintline.split(' ', 2)

if errcode == 'Esemi':

return lint_util.add_arc_fix_str(lintline, bad_line, '', ';')

if errcode == 'Eno-extra-semi':

return lint_util.add_arc_fix_str(lintline, bad_line, ';', '')

if errcode == 'Ecomma-dangle':

return lint_util.add_arc_fix_str(lintline, bad_line, '', ',')

if errcode == 'Ecomma-spacing':

return lint_util.add_arc_fix_str(lintline, bad_line, ',', ', ')

if errcode == 'Espace-before-function-paren':

return lint_util.add_arc_fix_str(lintline, bad_line,

re.compile(r' +'), '')

if errcode == 'Eprefer-const':

return lint_util.add_arc_fix_str(lintline, bad_line,

'let', 'const',

search_backwards=True)

if errcode == 'Ereact/jsx-closing-bracket-location':

try:

col = file_line_col.split(':')[2]

except IndexError:

col = None

m = re.search(r'\(expected column (\d+)\)', msg)

if col is not None and m is not None:

spaces_to_add = int(m.group(1)) - int(col)

if spaces_to_add > 0:

return lint_util.add_arc_fix_str(

lintline, bad_line, '', ' ' * spaces_to_add)

else:

return lint_util.add_arc_fix_str(

lintline, bad_line, ' ' * -spaces_to_add, '',

search_backwards=True)

# Also handle the case the \> should go on the next line

m = re.search(r'\(expected column (\d+) on the next line\)', msg)

if m:

indent = int(m.group(1)) - 1

if indent >= 0:

return lint_util.add_arc_fix_str(

lintline, bad_line, '', '\n' + ' ' * indent)

if errcode == 'Eindent':

m = re.search(r'Expected indentation of (\d+) space characters '

r'but found (\d+)',

msg)

if m:

spaces_to_add = int(m.group(1)) - int(m.group(2))

if spaces_to_add > 0:

return lint_util.add_arc_fix_str(

lintline, bad_line, '', ' ' * spaces_to_add)

else:

return lint_util.add_arc_fix_str(

lintline, bad_line, ' ' * -spaces_to_add, '',

search_backwards=True)

if errcode in {'Ecomputed-property-spacing', 'Earray-bracket-spacing',

'Eobject-curly-spacing'}:

search_backwards = 'space before' in lintline

return lint_util.add_arc_fix_str(lintline, bad_line,

re.compile(r' +'), '',

search_backwards=search_backwards)

if errcode == 'Espace-in-parens':

try:

col = int(file_line_col.split(':')[2]) - 2

except IndexError:

col = None

if col is not None:

paren = bad_line[col]

search_backwards = {'(': False, ')': True}.get(paren)

if search_backwards is not None:

return lint_util.add_arc_fix_str(

lintline, bad_line, re.compile(r' +'), '',

search_backwards=search_backwards)

if errcode == 'Eprettier/prettier':

ascii_lintline = self._ascii_prettier_string(lintline)

insert = re.search(r'Insert `(.*?)`?$', msg)

if insert:

to_add = self._clean_prettier_string(insert.group(1))

return lint_util.add_arc_fix_str(

ascii_lintline, bad_line, '',

to_add, limit_to_80=False)

remove = re.search(r'Delete `(.*?)`?$', msg)

if remove:

return lint_util.add_arc_fix_str(

ascii_lintline, bad_line,

self._clean_prettier_string(remove.group(1)), '')

replace = re.search(r'Replace `(.*?)` with `(.*?)`?$', msg)

if replace:

to_add = self._clean_prettier_string(replace.group(2))

return lint_util.add_arc_fix_str(

ascii_lintline, bad_line,

self._clean_prettier_string(replace.group(1)),

to_add,

limit_to_80=False)

return lintline

def _ascii_prettier_string(self, prettier_string):

return prettier_string.replace(u'·', ' ').replace(

u'↹', '\\t').replace(u'⏎', '\\n')

def _clean_prettier_string(self, prettier_string):

return prettier_string.replace(u'·', ' ').replace(

u'↹', '\t').replace(u'⏎', '\n')

def _process_one_line(self, filename, output_line, contents_lines):

"""If line is an 'error', print it and return 1. Else return 0.

eslint prints all errors to stdout. But we want to

ignore some 'errors' that are ok for us, in particular ones

that have been commented out with @Nolint.

Arguments:

filename: path to file being linted

output_line: one line of the eslint error-output

contents_lines: the contents of the file being linted,

as a list of lines.

Returns:

1 (indicating one error) if we print the error line, 0 else.

"""

# output_line is like:

# <file>:<line>:<col>: W<code> <message>

# which is just what we need!

bad_linenum = int(output_line.split(':', 2)[1]) # first line is '1'

bad_line = contents_lines[bad_linenum - 1] # convert to 0-index

# If the line has a nolint directive, ignore it.

if '@Nolint' in bad_line:

return 0

# Allow long lines in fixture files, which just hold test data.

if (' Emax-len ' in output_line and

filename.endswith(('.fixture.js', 'fixture.jsx'))):

return 0

# I don't know why it prints this. Shrug.

if 'File ignored because of your .eslintignore file' in output_line:

return 0

(file_line_col, errcode, msg) = output_line.split(' ', 2)

err_type = errcode[1:]

if err_type != "prettier/prettier":

output_line += " (Mute with // eslint-disable-line %s)" % (

err_type)

six.print_(self._maybe_add_arc_fix(output_line, bad_line))

return 1

def process(self, f, contents_of_f, eslint_lines):

num_errors = 0

contents_lines = contents_of_f.splitlines() # need these for filtering

for output_line in eslint_lines:

num_errors += self._process_one_line(f, output_line,

contents_lines)

return num_errors

def lint_files(self, files):

"""Execute a linter on a list of files and return the stdout for each.

Arguments:

exec_path: A path to the linter's executable

files: A list of filenames

extra_flags: (optional) A list of commandline flags to include in

the subprocess call

Returns:

dict of {f: stdout_lines} from filename to stdout as an array of

stdout lines only containing files that had output; if there are

no lint errors, an empty dict.

"""

exec_path = os.path.join(_CWD, 'node_modules', '.bin', 'eslint')

reporter_path = os.path.join(_CWD, 'eslint_reporter.js')

assert os.path.isfile(exec_path), (

"Vendoring error: eslint is missing from '%s'" % exec_path)

# TODO(csilvers): split out files based on whether they're intended

# for node.js or not, and use eslintrc.node for the node.js files.

# Two ways to tell:

# 1) shebang line at the top of the file

# 2) '"use strict";' in the file somewhere

subprocess_args = [exec_path, '--config', self._config_path,

'-f', reporter_path, '--no-color'] + files

env = os.environ.copy()

if 'NODE_PATH' in env:

env['NODE_PATH'] += ':' + os.path.dirname(self._config_path)

else:

env['NODE_PATH'] = os.path.dirname(self._config_path)

pipe = subprocess.Popen(

subprocess_args,

stdout=subprocess.PIPE,

stderr=subprocess.PIPE,

env=env)

stdout, stderr = pipe.communicate()

stdout, stderr = stdout.decode('utf-8'), stderr.decode('utf-8')

if stderr:

raise RuntimeError("Unexpected stderr from linter:\n%s" % stderr)

output = {}

# eslint_reporter specifies that errors are reported on

# individual lines starting with "filename:line:col". It

# converts all filenames to an absolute path; we convert them

# back to relpaths here.

lint_lines = []

for line in stdout.splitlines():

parts = line.split(':', 1)

if len(parts) != 2:

raise RuntimeError("Unexpected stdout from linter:\n%s" %

stdout)

lint_lines.append('%s:%s' % (os.path.relpath(parts[0]), parts[1]))

get_filename = lambda line: line.split(':', 1)[0]

lines = sorted(lint_lines, key=get_filename)

for filename, flines in itertools.groupby(lines, get_filename):

output[filename] = list(flines)

return output

def process_files(self, files):

"""Lint a series of files, and self.process() each with an error."""

num_errors = 0

file_to_lint_output = self.lint_files(files)

for filename in files:

if filename in file_to_lint_output:

lintlines = file_to_lint_output[filename]

try:

contents = open(filename, 'U').read()

except (IOError, OSError) as why:

six.print_(

"SKIPPING lint of %s: %s" % (filename, why.args[1]))

num_errors += 1

continue

num_errors += self.process(filename, contents, lintlines)

"""Linter for less."""

def _process_one_line(self, filename, output_line, contents_lines):

# output_line is like:

# <file>:<line>:<col>: W<code> <message>

bad_linenum = int(output_line.split(':', 2)[1]) # first line is '1'

bad_line = contents_lines[bad_linenum - 1] # convert to 0-index

# If the line has a nolint directive, ignore it.

if '@Nolint' in bad_line:

return 0

six.print_(output_line)

return 1

def process(self, f, contents_of_f, lesshint_lines):

num_errors = 0

contents_lines = contents_of_f.splitlines() # need these for filtering

for output_line in lesshint_lines:

num_errors += self._process_one_line(f, output_line,

contents_lines)

return num_errors

def lint_files(self, files):

"""Execute a linter on a list of files and return the stdout for each.

Returns:

dict of {f: stdout_lines} from filename to stdout as an array of

stdout lines only containing files that had output; if there are

no lint errors, an empty dict.

"""

exec_path = os.path.join(_CWD, 'node_modules', '.bin', 'lesshint')

reporter_path = os.path.join(_CWD, 'lesshint_reporter.js')

assert os.path.isfile(exec_path), (

"Vendoring error: lesshint is missing from '%s'" % exec_path)

subprocess_args = [exec_path, '--reporter', reporter_path] + files

pipe = subprocess.Popen(

subprocess_args,

stdout=subprocess.PIPE,

stderr=subprocess.PIPE)

stdout, stderr = pipe.communicate()

if stderr:

raise RuntimeError("Unexpected stderr from lesshint:\n%s" % stderr)

output = {}

# lesshint_reporter specifies that errors are reported on individual

# lines starting with "filename:line:col"

get_filename = lambda line: line.split(':', 1)[0]

lines = sorted(stdout.splitlines(), key=get_filename)

for filename, flines in itertools.groupby(lines, get_filename):

output[filename] = list(flines)

return output

def process_files(self, files):

"""Lint a series of files, and self.process() each with an error."""

num_errors = 0

file_to_lint_output = self.lint_files(files)

for filename in files:

if filename in file_to_lint_output:

lintlines = file_to_lint_output[filename]

try:

contents = open(filename, 'U').read()

except (IOError, OSError) as why:

six.print_(

"SKIPPING lint of %s: %s" % (filename, why.args[1]))

num_errors += 1

continue

num_errors += self.process(filename, contents, lintlines)

"""Linter for html. process() processes one file.

The main thing we look for with html is that the static images

are properly escaped using the |static_url filter. This is

applied only to files in the 'templates' directory.

"""

def process(self, f, contents_of_f):

if ('templates' + os.sep) in f:

# s_c_r.lint_one_file() happily ignores @Nolint lines for us.

errors = static_content_refs.lint_one_file(f, contents_of_f)

for (fname, linenum, colnum, unused_endcol, msg) in errors:

# Canonical form: <file>:<line>[:<col>]: <E|W><code> <msg>

six.print_('%s:%s:%s: E=static_url= %s'

% (fname, linenum, colnum, msg))

return len(errors)

else:

"""Linter for kotlin, using the vendored copy of `ktlint`.

TODO(colin): add autofixing using `ktlint -F`

"""

def _is_not_skipped(self, file, lint_err_lines):

"""For each lint error in the given file check if it's nolinted.

Args:

lint_err_lines: a list of (line (0-indexed), message) tuples

Returns:

a list of booleans, one per input, True if that lint error has

not been skipped via `@Nolint`.

"""

with open(file) as f:

lines = f.readlines()

return ['@Nolint' not in lines[lint_err[0]]

for lint_err in lint_err_lines]

def process_files(self, files):

exec_path = os.path.abspath(os.path.join(_CWD, 'vendor', 'ktlint'))

assert os.path.isfile(exec_path), (

"Vendoring error: ktlint is missing from '%s'" % exec_path)

pipe = subprocess.Popen(

[exec_path] + files,

stdout=subprocess.PIPE,

stderr=subprocess.PIPE)

stdout, stderr = pipe.communicate()

stdout, stderr = stdout.decode('utf-8'), stderr.decode('utf-8')

if stderr:

raise RuntimeError("Unexpected stderr from linter:\n%s" % stderr)

num_errors = 0

lint_by_file = {}

for line in stdout.splitlines():

# Lint line format is file:line:col:message

parts = line.split(':')

if len(parts) != 4:

raise RuntimeError("Unexpected stdout from linter:\n%s" %

stdout)

file, line_number, _, _ = parts

lint_by_file.setdefault(file, [])

lint_by_file[file].append((int(line_number) - 1, line))

for file, lint in lint_by_file.items():

for _, lint_err in itertools.compress(

lint, self._is_not_skipped(file, lint)):

six.print_(lint_err)

num_errors += 1