def __init__(self, filepath, checksums, size, component_and_section,
priority, package, version, changes, policy, logger):
"""Construct a DSCFile instance.
This takes all NascentUploadFile constructor parameters plus package
and version.
Can raise UploadError.
"""
# Avoid circular imports.
from lp.archiveuploader.nascentupload import EarlyReturnUploadError
SourceUploadFile.__init__(self, filepath, checksums, size,
component_and_section, priority, package,
version, changes, policy, logger)
self.parse(verify_signature=not policy.unsigned_dsc_ok, as_bytes=True)
self.logger.debug("Performing DSC verification.")
for mandatory_field in self.mandatory_fields:
if mandatory_field not in self._dict:
raise UploadError("Unable to find mandatory field %s in %s" %
(mandatory_field, self.filename))
self.maintainer = self.parseAddress(self._dict['Maintainer'])
# If format is not present, assume 1.0. At least one tool in
# the wild generates dsc files with format missing, and we need
# to accept them.
if 'Format' not in self._dict:
self._dict['Format'] = "1.0"
if self.format is None:
raise EarlyReturnUploadError("Unsupported source format: %s" %
self._dict['Format'])
def __init__(self, filepath, checksums, size, component_and_section,
priority, package, version, changes, policy, logger):
"""Construct a DSCFile instance.
This takes all NascentUploadFile constructor parameters plus package
and version.
Can raise UploadError.
"""
# Avoid circular imports.
from lp.archiveuploader.nascentupload import EarlyReturnUploadError
SourceUploadFile.__init__(
self, filepath, checksums, size, component_and_section, priority,
package, version, changes, policy, logger)
self.parse(verify_signature=not policy.unsigned_dsc_ok)
self.logger.debug("Performing DSC verification.")
for mandatory_field in self.mandatory_fields:
if mandatory_field not in self._dict:
raise UploadError(
"Unable to find mandatory field %s in %s" % (
mandatory_field, self.filename))
self.maintainer = self.parseAddress(self._dict['Maintainer'])
# If format is not present, assume 1.0. At least one tool in
# the wild generates dsc files with format missing, and we need
# to accept them.
if 'Format' not in self._dict:
self._dict['Format'] = "1.0"
if self.format is None:
raise EarlyReturnUploadError(
"Unsupported source format: %s" % self._dict['Format'])
def verify(self):
"""Verify the uploaded .dsc file.
This method is an error generator, i.e, it returns an iterator over
all exceptions that are generated while processing DSC file checks.
"""
for error in SourceUploadFile.verify(self):
yield error
# Check size and checksum of the DSC file itself
try:
self.checkSizeAndCheckSum()
except UploadError as error:
yield error
try:
raw_files = parse_and_merge_file_lists(self._dict, changes=False)
except UploadError as e:
yield e
return
files = []
for attr in raw_files:
filename, hashes, size = attr
if not re_issource.match(filename):
# DSC files only really hold on references to source
# files; they are essentially a description of a source
# package. Anything else is crack.
yield UploadError("%s: File %s does not look sourceful." %
(self.filename, filename))
continue
filepath = os.path.join(self.dirname, filename)
try:
file_instance = DSCUploadedFile(filepath, hashes, size,
self.policy, self.logger)
except UploadError as error:
yield error
else:
files.append(file_instance)
self.files = files
if not re_valid_pkg_name.match(self.source):
yield UploadError("%s: invalid source name %s" %
(self.filename, self.source))
if not re_valid_version.match(self.dsc_version):
yield UploadError("%s: invalid version %s" %
(self.filename, self.dsc_version))
if not self.policy.distroseries.isSourcePackageFormatPermitted(
self.format):
yield UploadError(
"%s: format '%s' is not permitted in %s." %
(self.filename, self.format, self.policy.distroseries.name))
# Validate the build dependencies
for field_name in ['Build-Depends', 'Build-Depends-Indep']:
field = self._dict.get(field_name, None)
if field is not None:
if field.startswith("ARRAY"):
yield UploadError(
"%s: invalid %s field produced by a broken version "
"of dpkg-dev (1.10.11)" % (self.filename, field_name))
try:
with warnings.catch_warnings():
warnings.simplefilter("error")
PkgRelation.parse_relations(field)
except Warning as error:
yield UploadError(
"%s: invalid %s field; cannot be parsed by deb822: %s"
% (self.filename, field_name, error))
# Verify if version declared in changesfile is the same than that
# in DSC (including epochs).
if self.dsc_version != self.version:
yield UploadError(
"%s: version ('%s') in .dsc does not match version "
"('%s') in .changes." %
(self.filename, self.dsc_version, self.version))
for error in self.checkFiles():
yield error
def verify(self):
"""Verify the uploaded .dsc file.
This method is an error generator, i.e, it returns an iterator over
all exceptions that are generated while processing DSC file checks.
"""
for error in SourceUploadFile.verify(self):
yield error
# Check size and checksum of the DSC file itself
try:
self.checkSizeAndCheckSum()
except UploadError as error:
yield error
try:
raw_files = parse_and_merge_file_lists(self._dict, changes=False)
except UploadError as e:
yield e
return
files = []
for attr in raw_files:
filename, hashes, size = attr
if not re_issource.match(filename):
# DSC files only really hold on references to source
# files; they are essentially a description of a source
# package. Anything else is crack.
yield UploadError("%s: File %s does not look sourceful." % (
self.filename, filename))
continue
filepath = os.path.join(self.dirname, filename)
try:
file_instance = DSCUploadedFile(
filepath, hashes, size, self.policy, self.logger)
except UploadError as error:
yield error
else:
files.append(file_instance)
self.files = files
if not re_valid_pkg_name.match(self.source):
yield UploadError(
"%s: invalid source name %s" % (self.filename, self.source))
if not re_valid_version.match(self.dsc_version):
yield UploadError(
"%s: invalid version %s" % (self.filename, self.dsc_version))
if not self.policy.distroseries.isSourcePackageFormatPermitted(
self.format):
yield UploadError(
"%s: format '%s' is not permitted in %s." %
(self.filename, self.format, self.policy.distroseries.name))
# Validate the build dependencies
for field_name in ['Build-Depends', 'Build-Depends-Indep']:
field = self._dict.get(field_name, None)
if field is not None:
if field.startswith("ARRAY"):
yield UploadError(
"%s: invalid %s field produced by a broken version "
"of dpkg-dev (1.10.11)" % (self.filename, field_name))
try:
apt_pkg.parse_src_depends(field)
except (SystemExit, KeyboardInterrupt):
raise
except Exception as error:
# Swallow everything apt_pkg throws at us because
# it is not desperately pythonic and can raise odd
# or confusing exceptions at times and is out of
# our control.
yield UploadError(
"%s: invalid %s field; cannot be parsed by apt: %s"
% (self.filename, field_name, error))
# Verify if version declared in changesfile is the same than that
# in DSC (including epochs).
if self.dsc_version != self.version:
yield UploadError(
"%s: version ('%s') in .dsc does not match version "
"('%s') in .changes."
% (self.filename, self.dsc_version, self.version))
for error in self.checkFiles():
yield error
