def test_phabricator_analyzers(
analyzers_skipped,
valid_issues,
valid_patches,
mock_config,
mock_phabricator,
mock_try_task,
mock_task,
):
"""
Test analyzers filtering on phabricator reporter
"""
with mock_phabricator as api:
# Skip commenting on phabricator
# we only care about filtering issues
api.comment = unittest.mock.Mock(return_value=True)
# Always use the same setup, only varies the analyzers
revision = Revision.from_try(mock_try_task, api)
revision.mercurial_revision = "deadbeef1234"
revision.repository = "https://hg.mozilla.org/try"
revision.repository_try_name = "try"
revision.lines = {"test.cpp": [0, 41, 42, 43], "dom/test.cpp": [42]}
reporter = PhabricatorReporter(
{"analyzers_skipped": analyzers_skipped}, api=api)
issues = [
ClangFormatIssue(
mock_task(ClangFormatTask, "mock-clang-format"),
"dom/test.cpp",
[
(41, 41, b"no change"),
(42, None, b"deletion"),
(None, 42, b"change here"),
],
revision,
),
ClangTidyIssue(
mock_task(ClangTidyTask, "mock-clang-tidy"),
revision,
"test.cpp",
"42",
"51",
"modernize-use-nullptr",
"dummy message",
),
InferIssue(
mock_task(InferTask, "mock-infer"),
{
"file": "test.cpp",
"line": 42,
"column": 1,
"bug_type": "dummy",
"kind": "WARNING",
"qualifier": "dummy message.",
},
revision,
),
MozLintIssue(
mock_task(MozLintTask, "mock-lint-flake8"),
"test.cpp",
1,
"error",
42,
"flake8",
"Python error",
"EXXX",
revision,
),
CoverageIssue(
mock_task(ZeroCoverageTask, "coverage"),
"test.cpp",
0,
"This file is uncovered",
revision,
),
]
assert all(i.is_publishable() for i in issues)
revision.improvement_patches = [
ImprovementPatch(mock_task(DefaultTask, "dummy"), repr(revision),
"Whatever"),
ImprovementPatch(mock_task(ClangTidyTask, "mock-clang-tidy"),
repr(revision), "Some C fixes"),
ImprovementPatch(
mock_task(ClangFormatTask, "mock-clang-format"),
repr(revision),
"Some lint fixes",
),
ImprovementPatch(mock_task(InferTask, "mock-infer"), repr(revision),
"Some java fixes"),
ImprovementPatch(mock_task(MozLintTask, "mock-lint-flake8"),
repr(revision), "Some js fixes"),
]
list(map(lambda p: p.write(),
revision.improvement_patches)) # trigger local write
issues, patches = reporter.publish(issues, revision, [])
# Check issues & patches analyzers
assert len(issues) == len(valid_issues)
assert len(patches) == len(valid_patches)
assert [i.analyzer.name for i in issues] == valid_issues
assert [p.analyzer.name for p in patches] == valid_patches
