def test_get_connection_coordinates_other_direction(monkeypatch):
"""
Same as test_get_connection_coordinates() but in the other
direction of travel (from Zürich, Messe/Hallenstadion to Zürich, Hallenbad Oerlikon).
Should return the start public transport stop on the other side of the street
as in test_get_connection_coordinates().
Public transport stops at Zürich, Messe/Hallenstadion have the uic_ref 8591273.
Public transport stops at Zürich, Hallenbad Oerlikon have the uic_ref 8591175.
"""
current_location = (8.55240, 47.41077)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591273'
exit_stop_uicref = '8591175'
bus_number = '94'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert (8.5528703, 47.4107102) == start_position
assert (8.5562254, 47.4107647) == exit_position
def test_get_connection_coordinates_one_line_both_directions_other_direction(
monkeypatch):
"""
Tests a line that has only one mapped relation for both directions of travel.
Volketswil, In der Höh to Volketswil, Zimikon
Returns the fallback coordinates, because the first try fails because just one relation exists
and the second try fails because the public transport stops doesn't belong to a relation with the same uic_ref.
"""
current_location = (8.66828, 47.38491)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8576139'
exit_stop_uicref = '8589106'
bus_number = '725'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def test_get_connection_coordinates(monkeypatch):
"""
To get from Zürich, Messe/Hallenstadion to Zürich, Sternen Oerlikon you have to take
the bus with the number 94 that travels from Zentrum Glatt to Zürich, Bahnhof Oerlikon
at a specific start public transport stop (node with id 701735028 and (8,5520512, 47,4106724)).
Public transport stops at Zürich, Messe/Hallenstadion have the uic_ref 8591273.
Public transport stops at Zürich, Sternen Oerlikon have the uic_ref 8591382.
"""
current_location = (8.55240, 47.41077)
fallback_start_position = (1, 1) # irrelevant and will not be used
fallback_exit_position = (1, 1) # irrelevant and will not be used
start_stop_uicref = '8591273'
exit_stop_uicref = '8591382'
bus_number = '94'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert (8.5520512, 47.4106724) == start_position
assert (8.5467743, 47.4102250) == exit_position
def test_get_connection_coordinates_end_terminal(monkeypatch):
"""
Terminals have usually the nature that both direction of travel
are served from the same stop.
Public transport stops at Zürich, Sternen Oerlikon have the uic_ref 8591382.
Public transport stops at Zürich, Bahnhof Oerlikon have the uic_ref 8580449.
"""
current_location = (8.54679, 47.41025)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591382'
exit_stop_uicref = '8580449'
bus_number = '94'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert (8.5467743, 47.4102250) == start_position
assert (8.5447442, 47.4114541) == exit_position
def test_get_connection_coordinates_corrupt_relation(monkeypatch):
"""
Start and exit stop position for the line S6 to get from Zürich, Bahnhof Oerlikon to Zürich, Hardbrücke.
The stop in Zürich, Bahnhof Oerlikon does not provide an uic_ref for the line S6.
The fallback method will be used in this case.
The relation for the S6 is wrongly (order of nodes is not correct) mapped and the fallback method will fail too.
Thus the last option is chosen and the fallback positions will be returned.
Public transport stops at Zürich, Bahnhof Oerlikon have the uic_ref 8503006.
Public transport stops at Zürich, Hardbrücke have the uic_ref 8503020.
"""
current_location = (8.54644, 47.41012)
fallback_start_position = (8.544113562238525, 47.41152601531714)
fallback_exit_position = (8.51768587257564, 47.385087296919714)
start_stop_uicref = '8503006'
exit_stop_uicref = '8503020'
train_number = 'S6'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
train_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def test_get_connection_coordinates_start_terminal(monkeypatch):
"""
Same as test_get_connection_coordinates_end_terminal
but with a terminal (Zürich, Bahnhof Oerlikon) as an start stop position.
Public transport stops at Zürich, Bahnhof Oerlikon have the uic_ref 8580449.
Public transport stops at Zürich, Sternen Oerlikon have the uic_ref 8591382.
"""
current_location = (8.54466, 47.41142)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8580449'
exit_stop_uicref = '8591382'
bus_number = '94'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert (8.5447442, 47.4114541) == start_position
assert (8.5468917, 47.4102351) == exit_position
def test_get_connection_coordinates_empty_result():
""" an empty result set is returned by the Overpass queries based on provided parameters """
current_location = (8.53531, 47.36343)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591317'
exit_stop_uicref = '8591058'
tram_number = '23'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
tram_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def optimize_public_transport_connection(
public_transport_connection: dict) -> dict:
""" retrieves accurate coordinates for the public transport stops in each leg """
for leg in public_transport_connection['path']:
logger.debug(
f'optimize public transport connection leg: {leg["start"]} to {leg["destination"]}'
)
fallback_start_position = tuple(leg['start_position'])
fallback_exit_position = tuple(leg['exit_position'])
lookup_position = fallback_start_position
start_position, exit_position = overpass_service.get_connection_coordinates(
lookup_position, leg['start_stop_uicref'], leg['exit_stop_uicref'],
leg['line'], fallback_start_position, fallback_exit_position)
leg['start_position'] = [*start_position]
leg['exit_position'] = [*exit_position]
return public_transport_connection
def test_get_connection_coordinates_unavailable_service(monkeypatch):
"""
get_connection_coordinates() catches the ServiceError and will return the fallback coordinates.
"""
mock.mock_overpass_unavailable_url(monkeypatch)
current_location = (8.55240, 47.41077)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591273'
exit_stop_uicref = '8591382'
bus_number = '94'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def test_get_connection_coordinates_multiple_relations_for_line():
"""
Tram 5 has multiple lines with different terminals that serve the stop Zürich, Rentenanstalt
to Zürich, Bahnhof Enge. All lines are a possible option and all start from the same stop.
"""
current_location = (8.53528, 47.36331)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591317'
exit_stop_uicref = '8591058'
tram_number = '5'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
tram_number,
fallback_start_position,
fallback_exit_position)
assert (8.5345459, 47.3634506) == start_position
assert (8.5314535, 47.3640971) == exit_position
def test_get_connection_coordinates_breaking_changes(monkeypatch):
"""
Uses different service to test breaking changes in the api.
get_connection_coordinates() catches the ServiceError and will return the fallback coordinates.
"""
mock.mock_overpass_wrong_url(monkeypatch)
current_location = (8.55240, 47.41077)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591273'
exit_stop_uicref = '8591382'
bus_number = '94'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def test_get_connection_coordinates_one_line_both_directions_no_exit_uic_ref():
"""
Tests a line that has only one mapped relation for both directions of travel.
Volketswil, Zimikon to Schwerzenbach ZH, Bahnhof
Returns the fallback coordinates because the exit stop position doesn't have an uic_ref.
"""
current_location = (8.67316, 47.38566)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8589106'
exit_stop_uicref = '8576127'
bus_number = '725'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def test_get_connection_coordinates_multiple_relations_for_line_one_option():
"""
Tram 5 has multiple lines with different terminals that serve the stop Zürich, Rentenanstalt
to Zürich, Bahnhof Enge. But to get from Zürich, Rentenanstalt to Bahnhof Enge/Bederstrasse
just on line is a possible option.
"""
current_location = (8.53528, 47.36331)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8591317'
exit_stop_uicref = '8591059'
tram_number = '5'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
tram_number,
fallback_start_position,
fallback_exit_position)
assert (8.5345459, 47.3634506) == start_position
assert (8.5302541, 47.3645340) == exit_position
def test_get_connection_coordinates_relation_without_uic_ref():
"""
Start node has an uic_ref, the exit node however does not hold one. The first retrieval method fill fail
because of this. For the exit node it is not possible to retrieve relations based on the exit_uic_ref because there
does not exist a relation with it. Thus the last option is chosen and the fallback positions will be
returned.
"""
current_location = (8.66724, 47.38510)
fallback_start_position = (8.659549027875455, 47.383981347638574)
fallback_exit_position = (8.668385753719784, 47.38524594245153)
start_stop_uicref = '8576139'
exit_stop_uicref = '8576127'
bus_number = '720'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert fallback_start_position == start_position
assert fallback_exit_position == exit_position
def test_get_connection_coordinates_fallback():
"""
Start and exit stop position for the line 161 to get from Zürich, Rote Fabrik to Zürich, Seerose.
Both stops do not provide an uic_ref so the fallback method will be used
to determine the start and exit public transport stop position.
"""
current_location = (8.53608, 47.34252)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8587347'
exit_stop_uicref = '8591357'
bus_number = '161'
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert (8.5363033, 47.3424100) == start_position
assert (8.5383420, 47.3385681) == exit_position
def test_get_connection_coordinates_fallback(monkeypatch):
"""
Start and exit stop position for the line 161 to get from Rüschlikon, Bodengasse to Rüschlikon, Schlossstrasse.
Both stops do not provide an uic_ref so the fallback method will be used
to determine the start and exit public transport stop position.
"""
current_location = (8.55283, 47.31044)
fallback_start_position = (1, 1)
fallback_exit_position = (1, 1)
start_stop_uicref = '8590773'
exit_stop_uicref = '8590783'
bus_number = '165'
mock.mock_get_connection_coordinates_query(monkeypatch, current_location,
exit_stop_uicref)
start_position, exit_position = \
overpass_service.get_connection_coordinates(current_location,
start_stop_uicref, exit_stop_uicref,
bus_number,
fallback_start_position,
fallback_exit_position)
assert (8.5531976, 47.3098602) == start_position
assert (8.5539173, 47.3138841) == exit_position
