def _check_commit_messages():
MAX_COLS = 100
error = False
changes = git.get_in_flight_commits()
for change in changes:
msg = git.get_commit_message(change)
seen_change_id = False
trailing_lines = False
for line_num, line in enumerate(msg):
if len(line) > MAX_COLS:
print "Commit %s line %d is too long:" % (change, line_num + 1)
print line
print (" " * MAX_COLS) + ("^" * (len(line) - MAX_COLS))
error = True
if seen_change_id:
trailing_lines = True
if line.startswith("Change-Id:"):
seen_change_id = True
if not seen_change_id:
print "Commit %s does not have a Change-Id label" % change
error = True
elif trailing_lines:
print "Commit %s has trailing lines after Change-Id label" % change
error = True
if error:
return -1
return 0
def _check_commit_messages():
MAX_COLS = 100
error = False
changes = git.get_in_flight_commits()
for change in changes:
msg = git.get_commit_message(change)
seen_change_id = False
trailing_lines = False
for line_num, line in enumerate(msg):
if len(line) > MAX_COLS:
print 'Commit %s line %d is too long:' % (change, line_num + 1)
print line
print(' ' * MAX_COLS) + ('^' * (len(line) - MAX_COLS))
error = True
if seen_change_id:
trailing_lines = True
if line.startswith('Change-Id:'):
seen_change_id = True
if not seen_change_id:
print 'Commit %s does not have a Change-Id label' % change
error = True
elif trailing_lines:
print 'Commit %s has trailing lines after Change-Id label' % change
error = True
if error:
return -1
return 0
def suggest_reviewer_set_for_in_flight_commits(verbose):
in_flight_commits = git.get_in_flight_commits()
if not in_flight_commits:
print 'All commits have already been landed on this branch'
return False
db = get_owners_db()
for commit in in_flight_commits:
reviewer_set = _get_reviewer_set_for_commit(db, commit)
print ('REVIEWERS FOR "%s":\n %s' %
(git.get_oneline_for_commit(commit),
format_reviewer_set_in_conjunctive_normal_form(reviewer_set)))
if verbose:
explain_reviewer_set(reviewer_set)
if verbose:
print ''
else:
print ('For more details run: '
'./src/build/suggest_reviewers.py push -v')
def suggest_reviewer_set_for_in_flight_commits(verbose):
in_flight_commits = git.get_in_flight_commits()
if not in_flight_commits:
print 'All commits have already been landed on this branch'
return False
db = get_owners_db()
for commit in in_flight_commits:
reviewer_set = _get_reviewer_set_for_commit(db, commit)
print('REVIEWERS FOR "%s":\n %s' %
(git.get_oneline_for_commit(commit),
format_reviewer_set_in_conjunctive_normal_form(reviewer_set)))
if verbose:
explain_reviewer_set(reviewer_set)
if verbose:
print ''
else:
print(
'For more details run: '
'./src/build/suggest_reviewers.py push -v')
