Beispiel #1
0
def CMDrun(parser, args):
    """Runs the test executable in an isolated (temporary) directory.

  All the dependencies are mapped into the temporary directory and the
  directory is cleaned up after the target exits.

  Argument processing stops at -- and these arguments are appended to the
  command line of the target to run. For example, use:
    isolate.py run --isolated foo.isolated -- --gtest_filter=Foo.Bar
  """
    add_isolate_options(parser)
    add_skip_refresh_option(parser)
    options, args = parser.parse_args(args)
    process_isolate_options(parser, options, require_isolated=False)
    complete_state = load_complete_state(options, os.getcwd(), None,
                                         options.skip_refresh)
    cmd = complete_state.saved_state.command + args
    if not cmd:
        raise ExecutionError('No command to run.')
    cmd = tools.fix_python_cmd(cmd)

    outdir = run_isolated.make_temp_dir(
        u'isolate-%s' % datetime.date.today(),
        os.path.dirname(complete_state.root_dir))
    try:
        # TODO(maruel): Use run_isolated.run_tha_test().
        cwd = create_isolate_tree(outdir, complete_state.root_dir,
                                  complete_state.saved_state.files,
                                  complete_state.saved_state.relative_cwd,
                                  complete_state.saved_state.read_only)
        file_path.ensure_command_has_abs_path(cmd, cwd)
        logging.info('Running %s, cwd=%s' % (cmd, cwd))
        try:
            result = subprocess.call(cmd, cwd=cwd)
        except OSError:
            sys.stderr.write(
                'Failed to executed the command; executable is missing, maybe you\n'
                'forgot to map it in the .isolate file?\n  %s\n  in %s\n' %
                (' '.join(cmd), cwd))
            result = 1
    finally:
        file_path.rmtree(outdir)

    if complete_state.isolated_filepath:
        complete_state.save_files()
    return result
Beispiel #2
0
def CMDrun(parser, args):
    """Runs the test executable in an isolated (temporary) directory.

  All the dependencies are mapped into the temporary directory and the
  directory is cleaned up after the target exits.

  Argument processing stops at -- and these arguments are appended to the
  command line of the target to run. For example, use:
    isolate.py run --isolated foo.isolated -- --gtest_filter=Foo.Bar
  """
    add_isolate_options(parser)
    add_skip_refresh_option(parser)
    options, args = parser.parse_args(args)
    process_isolate_options(parser, options, require_isolated=False)
    complete_state = load_complete_state(options, os.getcwd(), None, options.skip_refresh)
    cmd = complete_state.saved_state.command + args
    if not cmd:
        raise ExecutionError("No command to run.")
    cmd = tools.fix_python_path(cmd)

    outdir = run_isolated.make_temp_dir(u"isolate-%s" % datetime.date.today(), os.path.dirname(complete_state.root_dir))
    try:
        # TODO(maruel): Use run_isolated.run_tha_test().
        cwd = create_isolate_tree(
            outdir,
            complete_state.root_dir,
            complete_state.saved_state.files,
            complete_state.saved_state.relative_cwd,
            complete_state.saved_state.read_only,
        )
        file_path.ensure_command_has_abs_path(cmd, cwd)
        logging.info("Running %s, cwd=%s" % (cmd, cwd))
        try:
            result = subprocess.call(cmd, cwd=cwd)
        except OSError:
            sys.stderr.write(
                "Failed to executed the command; executable is missing, maybe you\n"
                "forgot to map it in the .isolate file?\n  %s\n  in %s\n" % (" ".join(cmd), cwd)
            )
            result = 1
    finally:
        file_path.rmtree(outdir)

    if complete_state.isolated_filepath:
        complete_state.save_files()
    return result
def map_and_run(
    isolated_hash, storage, cache, leak_temp_dir, root_dir, hard_timeout,
    grace_period, extra_args):
  """Maps and run the command. Returns metadata about the result."""
  # TODO(maruel): Include performance statistics.
  result = {
    'exit_code': None,
    'had_hard_timeout': False,
    'internal_failure': None,
    'outputs_ref': None,
    'version': 2,
  }
  if root_dir:
    if not fs.isdir(root_dir):
      fs.makedirs(root_dir, 0700)
    prefix = u''
  else:
    root_dir = os.path.dirname(cache.cache_dir) if cache.cache_dir else None
    prefix = u'isolated_'
  run_dir = make_temp_dir(prefix + u'run', root_dir)
  out_dir = make_temp_dir(prefix + u'out', root_dir)
  tmp_dir = make_temp_dir(prefix + u'tmp', root_dir)
  try:
    bundle = isolateserver.fetch_isolated(
        isolated_hash=isolated_hash,
        storage=storage,
        cache=cache,
        outdir=run_dir,
        require_command=True)

    change_tree_read_only(run_dir, bundle.read_only)
    cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
    command = bundle.command + extra_args
    file_path.ensure_command_has_abs_path(command, cwd)
    result['exit_code'], result['had_hard_timeout'] = run_command(
        process_command(command, out_dir), cwd, tmp_dir, hard_timeout,
        grace_period)
  except Exception as e:
    # An internal error occured. Report accordingly so the swarming task will be
    # retried automatically.
    logging.exception('internal failure: %s', e)
    result['internal_failure'] = str(e)
    on_error.report(None)
  finally:
    try:
      if leak_temp_dir:
        logging.warning(
            'Deliberately leaking %s for later examination', run_dir)
      else:
        # On Windows rmtree(run_dir) call above has a synchronization effect: it
        # finishes only when all task child processes terminate (since a running
        # process locks *.exe file). Examine out_dir only after that call
        # completes (since child processes may write to out_dir too and we need
        # to wait for them to finish).
        if fs.isdir(run_dir):
          try:
            success = file_path.rmtree(run_dir)
          except OSError as e:
            logging.error('Failure with %s', e)
            success = False
          if not success:
            print >> sys.stderr, (
                'Failed to delete the run directory, forcibly failing\n'
                'the task because of it. No zombie process can outlive a\n'
                'successful task run and still be marked as successful.\n'
                'Fix your stuff.')
            if result['exit_code'] == 0:
              result['exit_code'] = 1
        if fs.isdir(tmp_dir):
          try:
            success = file_path.rmtree(tmp_dir)
          except OSError as e:
            logging.error('Failure with %s', e)
            success = False
          if not success:
            print >> sys.stderr, (
                'Failed to delete the temporary directory, forcibly failing\n'
                'the task because of it. No zombie process can outlive a\n'
                'successful task run and still be marked as successful.\n'
                'Fix your stuff.')
            if result['exit_code'] == 0:
              result['exit_code'] = 1

      # This deletes out_dir if leak_temp_dir is not set.
      result['outputs_ref'], success = delete_and_upload(
          storage, out_dir, leak_temp_dir)
      if not success and result['exit_code'] == 0:
        result['exit_code'] = 1
    except Exception as e:
      # Swallow any exception in the main finally clause.
      logging.exception('Leaking out_dir %s: %s', out_dir, e)
      result['internal_failure'] = str(e)
  return result
Beispiel #4
0
def map_and_run(command, isolated_hash, storage, isolate_cache, outputs,
                init_named_caches, leak_temp_dir, root_dir, hard_timeout,
                grace_period, bot_file, install_packages_fn, use_symlinks,
                constant_run_path):
    """Runs a command with optional isolated input/output.

  See run_tha_test for argument documentation.

  Returns metadata about the result.
  """
    assert isinstance(command, list), command
    assert root_dir or root_dir is None
    result = {
        'duration': None,
        'exit_code': None,
        'had_hard_timeout': False,
        'internal_failure': None,
        'stats': {
            # 'isolated': {
            #    'cipd': {
            #      'duration': 0.,
            #      'get_client_duration': 0.,
            #    },
            #    'download': {
            #      'duration': 0.,
            #      'initial_number_items': 0,
            #      'initial_size': 0,
            #      'items_cold': '<large.pack()>',
            #      'items_hot': '<large.pack()>',
            #    },
            #    'upload': {
            #      'duration': 0.,
            #      'items_cold': '<large.pack()>',
            #      'items_hot': '<large.pack()>',
            #    },
            #  },
        },
        # 'cipd_pins': {
        #   'packages': [
        #     {'package_name': ..., 'version': ..., 'path': ...},
        #     ...
        #   ],
        #  'client_package': {'package_name': ..., 'version': ...},
        # },
        'outputs_ref': None,
        'version': 5,
    }

    if root_dir:
        file_path.ensure_tree(root_dir, 0700)
    elif isolate_cache.cache_dir:
        root_dir = os.path.dirname(isolate_cache.cache_dir)
    # See comment for these constants.
    # If root_dir is not specified, it is not constant.
    # TODO(maruel): This is not obvious. Change this to become an error once we
    # make the constant_run_path an exposed flag.
    if constant_run_path and root_dir:
        run_dir = os.path.join(root_dir, ISOLATED_RUN_DIR)
        os.mkdir(run_dir)
    else:
        run_dir = make_temp_dir(ISOLATED_RUN_DIR, root_dir)
    # storage should be normally set but don't crash if it is not. This can happen
    # as Swarming task can run without an isolate server.
    out_dir = make_temp_dir(ISOLATED_OUT_DIR, root_dir) if storage else None
    tmp_dir = make_temp_dir(ISOLATED_TMP_DIR, root_dir)
    cwd = run_dir

    try:
        with install_packages_fn(run_dir) as cipd_info:
            if cipd_info:
                result['stats']['cipd'] = cipd_info.stats
                result['cipd_pins'] = cipd_info.pins

            if isolated_hash:
                isolated_stats = result['stats'].setdefault('isolated', {})
                bundle, isolated_stats['download'] = fetch_and_map(
                    isolated_hash=isolated_hash,
                    storage=storage,
                    cache=isolate_cache,
                    outdir=run_dir,
                    use_symlinks=use_symlinks)
                change_tree_read_only(run_dir, bundle.read_only)
                cwd = os.path.normpath(os.path.join(cwd, bundle.relative_cwd))
                # Inject the command
                if bundle.command:
                    command = bundle.command + command

            if not command:
                # Handle this as a task failure, not an internal failure.
                sys.stderr.write(
                    '<No command was specified!>\n'
                    '<Please secify a command when triggering your Swarming task>\n'
                )
                result['exit_code'] = 1
                return result

            # If we have an explicit list of files to return, make sure their
            # directories exist now.
            if storage and outputs:
                isolateserver.create_directories(run_dir, outputs)

            command = tools.fix_python_path(command)
            command = process_command(command, out_dir, bot_file)
            file_path.ensure_command_has_abs_path(command, cwd)

            with init_named_caches(run_dir):
                sys.stdout.flush()
                start = time.time()
                try:
                    result['exit_code'], result[
                        'had_hard_timeout'] = run_command(
                            command, cwd, get_command_env(tmp_dir, cipd_info),
                            hard_timeout, grace_period)
                finally:
                    result['duration'] = max(time.time() - start, 0)
    except Exception as e:
        # An internal error occurred. Report accordingly so the swarming task will
        # be retried automatically.
        logging.exception('internal failure: %s', e)
        result['internal_failure'] = str(e)
        on_error.report(None)

    # Clean up
    finally:
        try:
            # Try to link files to the output directory, if specified.
            if out_dir:
                link_outputs_to_outdir(run_dir, out_dir, outputs)

            success = False
            if leak_temp_dir:
                success = True
                logging.warning(
                    'Deliberately leaking %s for later examination', run_dir)
            else:
                # On Windows rmtree(run_dir) call above has a synchronization effect: it
                # finishes only when all task child processes terminate (since a running
                # process locks *.exe file). Examine out_dir only after that call
                # completes (since child processes may write to out_dir too and we need
                # to wait for them to finish).
                if fs.isdir(run_dir):
                    try:
                        success = file_path.rmtree(run_dir)
                    except OSError as e:
                        logging.error('Failure with %s', e)
                        success = False
                    if not success:
                        print >> sys.stderr, (
                            'Failed to delete the run directory, thus failing the task.\n'
                            'This may be due to a subprocess outliving the main task\n'
                            'process, holding on to resources. Please fix the task so\n'
                            'that it releases resources and cleans up subprocesses.'
                        )
                        if result['exit_code'] == 0:
                            result['exit_code'] = 1
                if fs.isdir(tmp_dir):
                    try:
                        success = file_path.rmtree(tmp_dir)
                    except OSError as e:
                        logging.error('Failure with %s', e)
                        success = False
                    if not success:
                        print >> sys.stderr, (
                            'Failed to delete the temp directory, thus failing the task.\n'
                            'This may be due to a subprocess outliving the main task\n'
                            'process, holding on to resources. Please fix the task so\n'
                            'that it releases resources and cleans up subprocesses.'
                        )
                        if result['exit_code'] == 0:
                            result['exit_code'] = 1

            # This deletes out_dir if leak_temp_dir is not set.
            if out_dir:
                isolated_stats = result['stats'].setdefault('isolated', {})
                result['outputs_ref'], success, isolated_stats['upload'] = (
                    delete_and_upload(storage, out_dir, leak_temp_dir))
            if not success and result['exit_code'] == 0:
                result['exit_code'] = 1
        except Exception as e:
            # Swallow any exception in the main finally clause.
            if out_dir:
                logging.exception('Leaking out_dir %s: %s', out_dir, e)
            result['internal_failure'] = str(e)
    return result
Beispiel #5
0
def run_tha_test(isolated_hash, storage, cache, leak_temp_dir, extra_args):
  """Downloads the dependencies in the cache, hardlinks them into a temporary
  directory and runs the executable from there.

  A temporary directory is created to hold the output files. The content inside
  this directory will be uploaded back to |storage| packaged as a .isolated
  file.

  Arguments:
    isolated_hash: the SHA-1 of the .isolated file that must be retrieved to
                   recreate the tree of files to run the target executable.
    storage: an isolateserver.Storage object to retrieve remote objects. This
             object has a reference to an isolateserver.StorageApi, which does
             the actual I/O.
    cache: an isolateserver.LocalCache to keep from retrieving the same objects
           constantly by caching the objects retrieved. Can be on-disk or
           in-memory.
    leak_temp_dir: if true, the temporary directory will be deliberately leaked
                   for later examination.
    extra_args: optional arguments to add to the command stated in the .isolate
                file.
  """
  tmp_root = os.path.dirname(cache.cache_dir) if cache.cache_dir else None
  run_dir = make_temp_dir(u'run_tha_test', tmp_root)
  out_dir = unicode(make_temp_dir(u'isolated_out', tmp_root))
  result = 0
  try:
    try:
      bundle = isolateserver.fetch_isolated(
          isolated_hash=isolated_hash,
          storage=storage,
          cache=cache,
          outdir=run_dir,
          require_command=True)
    except isolated_format.IsolatedError:
      on_error.report(None)
      return 1

    change_tree_read_only(run_dir, bundle.read_only)
    cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
    command = bundle.command + extra_args

    file_path.ensure_command_has_abs_path(command, cwd)
    command = process_command(command, out_dir)
    logging.info('Running %s, cwd=%s' % (command, cwd))

    # TODO(csharp): This should be specified somewhere else.
    # TODO(vadimsh): Pass it via 'env_vars' in manifest.
    # Add a rotating log file if one doesn't already exist.
    env = os.environ.copy()
    if MAIN_DIR:
      env.setdefault('RUN_TEST_CASES_LOG_FILE',
          os.path.join(MAIN_DIR, RUN_TEST_CASES_LOG))
    sys.stdout.flush()
    with tools.Profiler('RunTest'):
      try:
        with subprocess42.Popen_with_handler(command, cwd=cwd, env=env) as p:
          p.communicate()
          result = p.returncode
      except OSError:
        on_error.report('Failed to run %s; cwd=%s' % (command, cwd))
        result = 1
    logging.info(
        'Command finished with exit code %d (%s)',
        result, hex(0xffffffff & result))
  finally:
    try:
      if leak_temp_dir:
        logging.warning('Deliberately leaking %s for later examination',
                        run_dir)
      else:
        try:
          if not file_path.rmtree(run_dir):
            print >> sys.stderr, (
                'Failed to delete the temporary directory, forcibly failing\n'
                'the task because of it. No zombie process can outlive a\n'
                'successful task run and still be marked as successful.\n'
                'Fix your stuff.')
            result = result or 1
        except OSError as exc:
          logging.error('Leaking run_dir %s: %s', run_dir, exc)
          result = 1

      # HACK(vadimsh): On Windows rmtree(run_dir) call above has
      # a synchronization effect: it finishes only when all task child processes
      # terminate (since a running process locks *.exe file). Examine out_dir
      # only after that call completes (since child processes may
      # write to out_dir too and we need to wait for them to finish).

      # Upload out_dir and generate a .isolated file out of this directory.
      # It is only done if files were written in the directory.
      if os.path.isdir(out_dir) and os.listdir(out_dir):
        with tools.Profiler('ArchiveOutput'):
          try:
            results = isolateserver.archive_files_to_storage(
                storage, [out_dir], None)
          except isolateserver.Aborted:
            # This happens when a signal SIGTERM was received while uploading
            # data. There is 2 causes:
            # - The task was too slow and was about to be killed anyway due to
            #   exceeding the hard timeout.
            # - The amount of data uploaded back is very large and took too much
            #   time to archive.
            #
            # There's 3 options to handle this:
            # - Ignore the upload failure as a silent failure. This can be
            #   detected client side by the fact no result file exists.
            # - Return as if the task failed. This is not factually correct.
            # - Return an internal failure. Sadly, it's impossible at this level
            #   at the moment.
            #
            # For now, silently drop the upload.
            #
            # In any case, the process only has a very short grace period so it
            # needs to exit right away.
            sys.stderr.write('Received SIGTERM while uploading')
            results = None

        if results:
          # TODO(maruel): Implement side-channel to publish this information.
          output_data = {
            'hash': results[0][0],
            'namespace': storage.namespace,
            'storage': storage.location,
          }
          sys.stdout.flush()
          print(
              '[run_isolated_out_hack]%s[/run_isolated_out_hack]' %
              tools.format_json(output_data, dense=True))

    finally:
      try:
        if os.path.isdir(out_dir) and not file_path.rmtree(out_dir):
          logging.error('Had difficulties removing out_dir %s', out_dir)
          result = result or 1
      except OSError as exc:
        # Only report on non-Windows or on Windows when the process had
        # succeeded. Due to the way file sharing works on Windows, it's sadly
        # expected that file deletion may fail when a test failed.
        logging.error('Failed to remove out_dir %s: %s', out_dir, exc)
        if sys.platform != 'win32' or not result:
          on_error.report(None)
        result = 1

  return result
Beispiel #6
0
def map_and_run(isolated_hash, storage, cache, leak_temp_dir, root_dir,
                hard_timeout, grace_period, extra_args):
    """Maps and run the command. Returns metadata about the result."""
    # TODO(maruel): Include performance statistics.
    result = {
        'exit_code': None,
        'had_hard_timeout': False,
        'internal_failure': None,
        'outputs_ref': None,
        'version': 2,
    }
    if root_dir:
        if not fs.isdir(root_dir):
            fs.makedirs(root_dir, 0700)
        prefix = u''
    else:
        root_dir = os.path.dirname(
            cache.cache_dir) if cache.cache_dir else None
        prefix = u'isolated_'
    run_dir = make_temp_dir(prefix + u'run', root_dir)
    out_dir = make_temp_dir(prefix + u'out', root_dir)
    tmp_dir = make_temp_dir(prefix + u'tmp', root_dir)
    try:
        try:
            bundle = isolateserver.fetch_isolated(isolated_hash=isolated_hash,
                                                  storage=storage,
                                                  cache=cache,
                                                  outdir=run_dir,
                                                  require_command=True)
        except isolateserver.IsolatedErrorNoCommand:
            # Handle this as a task failure, not an internal failure.
            sys.stderr.write(
                '<The .isolated doesn\'t declare any command to run!>\n'
                '<Check your .isolate for missing \'command\' variable>\n')
            if os.environ.get('SWARMING_TASK_ID'):
                # Give an additional hint when running as a swarming task.
                sys.stderr.write('<This occurs at the \'isolate\' step>\n')
            result['exit_code'] = 1
            return result

        change_tree_read_only(run_dir, bundle.read_only)
        cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
        command = bundle.command + extra_args
        file_path.ensure_command_has_abs_path(command, cwd)
        result['exit_code'], result['had_hard_timeout'] = run_command(
            process_command(command, out_dir), cwd, tmp_dir, hard_timeout,
            grace_period)
    except Exception as e:
        # An internal error occured. Report accordingly so the swarming task will be
        # retried automatically.
        logging.exception('internal failure: %s', e)
        result['internal_failure'] = str(e)
        on_error.report(None)
    finally:
        try:
            if leak_temp_dir:
                logging.warning(
                    'Deliberately leaking %s for later examination', run_dir)
            else:
                # On Windows rmtree(run_dir) call above has a synchronization effect: it
                # finishes only when all task child processes terminate (since a running
                # process locks *.exe file). Examine out_dir only after that call
                # completes (since child processes may write to out_dir too and we need
                # to wait for them to finish).
                if fs.isdir(run_dir):
                    try:
                        success = file_path.rmtree(run_dir)
                    except OSError as e:
                        logging.error('Failure with %s', e)
                        success = False
                    if not success:
                        print >> sys.stderr, (
                            'Failed to delete the run directory, forcibly failing\n'
                            'the task because of it. No zombie process can outlive a\n'
                            'successful task run and still be marked as successful.\n'
                            'Fix your stuff.')
                        if result['exit_code'] == 0:
                            result['exit_code'] = 1
                if fs.isdir(tmp_dir):
                    try:
                        success = file_path.rmtree(tmp_dir)
                    except OSError as e:
                        logging.error('Failure with %s', e)
                        success = False
                    if not success:
                        print >> sys.stderr, (
                            'Failed to delete the temporary directory, forcibly failing\n'
                            'the task because of it. No zombie process can outlive a\n'
                            'successful task run and still be marked as successful.\n'
                            'Fix your stuff.')
                        if result['exit_code'] == 0:
                            result['exit_code'] = 1

            # This deletes out_dir if leak_temp_dir is not set.
            result['outputs_ref'], success = delete_and_upload(
                storage, out_dir, leak_temp_dir)
            if not success and result['exit_code'] == 0:
                result['exit_code'] = 1
        except Exception as e:
            # Swallow any exception in the main finally clause.
            logging.exception('Leaking out_dir %s: %s', out_dir, e)
            result['internal_failure'] = str(e)
    return result
Beispiel #7
0
def run_tha_test(isolated_hash, storage, cache, leak_temp_dir, extra_args):
  """Downloads the dependencies in the cache, hardlinks them into a temporary
  directory and runs the executable from there.

  A temporary directory is created to hold the output files. The content inside
  this directory will be uploaded back to |storage| packaged as a .isolated
  file.

  Arguments:
    isolated_hash: the SHA-1 of the .isolated file that must be retrieved to
                   recreate the tree of files to run the target executable.
    storage: an isolateserver.Storage object to retrieve remote objects. This
             object has a reference to an isolateserver.StorageApi, which does
             the actual I/O.
    cache: an isolateserver.LocalCache to keep from retrieving the same objects
           constantly by caching the objects retrieved. Can be on-disk or
           in-memory.
    leak_temp_dir: if true, the temporary directory will be deliberately leaked
                   for later examination.
    extra_args: optional arguments to add to the command stated in the .isolate
                file.
  """
  run_dir = make_temp_dir(u'run_tha_test', cache.cache_dir)
  out_dir = unicode(make_temp_dir(u'isolated_out', cache.cache_dir))
  result = 0
  try:
    try:
      bundle = isolateserver.fetch_isolated(
          isolated_hash=isolated_hash,
          storage=storage,
          cache=cache,
          outdir=run_dir,
          require_command=True)
    except isolated_format.IsolatedError:
      on_error.report(None)
      return 1

    change_tree_read_only(run_dir, bundle.read_only)
    cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
    command = bundle.command + extra_args

    file_path.ensure_command_has_abs_path(command, cwd)
    command = process_command(command, out_dir)
    logging.info('Running %s, cwd=%s' % (command, cwd))

    # TODO(csharp): This should be specified somewhere else.
    # TODO(vadimsh): Pass it via 'env_vars' in manifest.
    # Add a rotating log file if one doesn't already exist.
    env = os.environ.copy()
    if MAIN_DIR:
      env.setdefault('RUN_TEST_CASES_LOG_FILE',
          os.path.join(MAIN_DIR, RUN_TEST_CASES_LOG))
    sys.stdout.flush()
    with tools.Profiler('RunTest'):
      try:
        with subprocess42.Popen_with_handler(command, cwd=cwd, env=env) as p:
          p.communicate()
          result = p.returncode
      except OSError:
        on_error.report('Failed to run %s; cwd=%s' % (command, cwd))
        result = 1
    logging.info(
        'Command finished with exit code %d (%s)',
        result, hex(0xffffffff & result))
  finally:
    try:
      if leak_temp_dir:
        logging.warning('Deliberately leaking %s for later examination',
                        run_dir)
      else:
        try:
          if not file_path.rmtree(run_dir):
            print >> sys.stderr, (
                'Failed to delete the temporary directory, forcibly failing\n'
                'the task because of it. No zombie process can outlive a\n'
                'successful task run and still be marked as successful.\n'
                'Fix your stuff.')
            result = result or 1
        except OSError:
          logging.warning('Leaking %s', run_dir)
          result = 1

      # HACK(vadimsh): On Windows rmtree(run_dir) call above has
      # a synchronization effect: it finishes only when all task child processes
      # terminate (since a running process locks *.exe file). Examine out_dir
      # only after that call completes (since child processes may
      # write to out_dir too and we need to wait for them to finish).

      # Upload out_dir and generate a .isolated file out of this directory.
      # It is only done if files were written in the directory.
      if os.path.isdir(out_dir) and os.listdir(out_dir):
        with tools.Profiler('ArchiveOutput'):
          results = isolateserver.archive_files_to_storage(
              storage, [out_dir], None)
        # TODO(maruel): Implement side-channel to publish this information.
        output_data = {
          'hash': results[0][0],
          'namespace': storage.namespace,
          'storage': storage.location,
        }
        sys.stdout.flush()
        print(
            '[run_isolated_out_hack]%s[/run_isolated_out_hack]' %
            tools.format_json(output_data, dense=True))

    finally:
      try:
        if os.path.isdir(out_dir) and not file_path.rmtree(out_dir):
          result = result or 1
      except OSError:
        # The error was already printed out. Report it but that's it. Only
        # report on non-Windows or on Windows when the process had succeeded.
        # Due to the way file sharing works on Windows, it's sadly expected that
        # file deletion may fail when a test failed.
        if sys.platform != 'win32' or not result:
          on_error.report(None)
        result = 1

  return result
Beispiel #8
0
def map_and_run(command, isolated_hash, storage, isolate_cache, outputs,
                init_name_caches, leak_temp_dir, root_dir, hard_timeout,
                grace_period, bot_file, extra_args, install_packages_fn,
                use_symlinks):
    """Runs a command with optional isolated input/output.

  See run_tha_test for argument documentation.

  Returns metadata about the result.
  """
    assert root_dir or root_dir is None
    assert bool(command) ^ bool(isolated_hash)
    result = {
        'duration': None,
        'exit_code': None,
        'had_hard_timeout': False,
        'internal_failure': None,
        'stats': {
            # 'isolated': {
            #    'cipd': {
            #      'duration': 0.,
            #      'get_client_duration': 0.,
            #    },
            #    'download': {
            #      'duration': 0.,
            #      'initial_number_items': 0,
            #      'initial_size': 0,
            #      'items_cold': '<large.pack()>',
            #      'items_hot': '<large.pack()>',
            #    },
            #    'upload': {
            #      'duration': 0.,
            #      'items_cold': '<large.pack()>',
            #      'items_hot': '<large.pack()>',
            #    },
            #  },
        },
        # 'cipd_pins': {
        #   'packages': [
        #     {'package_name': ..., 'version': ..., 'path': ...},
        #     ...
        #   ],
        #  'client_package': {'package_name': ..., 'version': ...},
        # },
        'outputs_ref': None,
        'version': 5,
    }

    if root_dir:
        file_path.ensure_tree(root_dir, 0700)
    elif isolate_cache.cache_dir:
        root_dir = os.path.dirname(isolate_cache.cache_dir)
    # See comment for these constants.
    run_dir = make_temp_dir(ISOLATED_RUN_DIR, root_dir)
    # storage should be normally set but don't crash if it is not. This can happen
    # as Swarming task can run without an isolate server.
    out_dir = make_temp_dir(ISOLATED_OUT_DIR, root_dir) if storage else None
    tmp_dir = make_temp_dir(ISOLATED_TMP_DIR, root_dir)
    cwd = run_dir

    try:
        cipd_info = install_packages_fn(run_dir)
        if cipd_info:
            result['stats']['cipd'] = cipd_info['stats']
            result['cipd_pins'] = cipd_info['cipd_pins']

        if isolated_hash:
            isolated_stats = result['stats'].setdefault('isolated', {})
            bundle, isolated_stats['download'] = fetch_and_map(
                isolated_hash=isolated_hash,
                storage=storage,
                cache=isolate_cache,
                outdir=run_dir,
                use_symlinks=use_symlinks)
            if not bundle.command:
                # Handle this as a task failure, not an internal failure.
                sys.stderr.write(
                    '<The .isolated doesn\'t declare any command to run!>\n'
                    '<Check your .isolate for missing \'command\' variable>\n')
                if os.environ.get('SWARMING_TASK_ID'):
                    # Give an additional hint when running as a swarming task.
                    sys.stderr.write('<This occurs at the \'isolate\' step>\n')
                result['exit_code'] = 1
                return result

            change_tree_read_only(run_dir, bundle.read_only)
            cwd = os.path.normpath(os.path.join(cwd, bundle.relative_cwd))
            command = bundle.command + extra_args

        # If we have an explicit list of files to return, make sure their
        # directories exist now.
        if storage and outputs:
            isolateserver.create_directories(run_dir, outputs)

        command = tools.fix_python_path(command)
        command = process_command(command, out_dir, bot_file)
        file_path.ensure_command_has_abs_path(command, cwd)

        init_name_caches(run_dir)

        sys.stdout.flush()
        start = time.time()
        try:
            result['exit_code'], result['had_hard_timeout'] = run_command(
                command, cwd, tmp_dir, hard_timeout, grace_period)
        finally:
            result['duration'] = max(time.time() - start, 0)
    except Exception as e:
        # An internal error occurred. Report accordingly so the swarming task will
        # be retried automatically.
        logging.exception('internal failure: %s', e)
        result['internal_failure'] = str(e)
        on_error.report(None)

    # Clean up
    finally:
        try:
            # Try to link files to the output directory, if specified.
            if out_dir:
                link_outputs_to_outdir(run_dir, out_dir, outputs)

            success = False
            if leak_temp_dir:
                success = True
                logging.warning(
                    'Deliberately leaking %s for later examination', run_dir)
            else:
                # On Windows rmtree(run_dir) call above has a synchronization effect: it
                # finishes only when all task child processes terminate (since a running
                # process locks *.exe file). Examine out_dir only after that call
                # completes (since child processes may write to out_dir too and we need
                # to wait for them to finish).
                if fs.isdir(run_dir):
                    try:
                        success = file_path.rmtree(run_dir)
                    except OSError as e:
                        logging.error('Failure with %s', e)
                        success = False
                    if not success:
                        print >> sys.stderr, (
                            'Failed to delete the run directory, forcibly failing\n'
                            'the task because of it. No zombie process can outlive a\n'
                            'successful task run and still be marked as successful.\n'
                            'Fix your stuff.')
                        if result['exit_code'] == 0:
                            result['exit_code'] = 1
                if fs.isdir(tmp_dir):
                    try:
                        success = file_path.rmtree(tmp_dir)
                    except OSError as e:
                        logging.error('Failure with %s', e)
                        success = False
                    if not success:
                        print >> sys.stderr, (
                            'Failed to delete the temporary directory, forcibly failing\n'
                            'the task because of it. No zombie process can outlive a\n'
                            'successful task run and still be marked as successful.\n'
                            'Fix your stuff.')
                        if result['exit_code'] == 0:
                            result['exit_code'] = 1

            # This deletes out_dir if leak_temp_dir is not set.
            if out_dir:
                isolated_stats = result['stats'].setdefault('isolated', {})
                result['outputs_ref'], success, isolated_stats['upload'] = (
                    delete_and_upload(storage, out_dir, leak_temp_dir))
            if not success and result['exit_code'] == 0:
                result['exit_code'] = 1
        except Exception as e:
            # Swallow any exception in the main finally clause.
            if out_dir:
                logging.exception('Leaking out_dir %s: %s', out_dir, e)
            result['internal_failure'] = str(e)
    return result
def map_and_run(isolated_hash, storage, cache, leak_temp_dir, root_dir, extra_args):
    """Maps and run the command. Returns metadata about the result."""
    # TODO(maruel): Include performance statistics.
    result = {"exit_code": None, "internal_failure": None, "outputs_ref": None, "version": 1}
    if root_dir:
        if not os.path.isdir(root_dir):
            os.makedirs(root_dir, 0700)
        prefix = u""
    else:
        root_dir = os.path.dirname(cache.cache_dir) if cache.cache_dir else None
        prefix = u"isolated_"
    run_dir = make_temp_dir(prefix + u"run", root_dir)
    out_dir = make_temp_dir(prefix + u"out", root_dir)
    tmp_dir = make_temp_dir(prefix + u"tmp", root_dir)
    try:
        bundle = isolateserver.fetch_isolated(
            isolated_hash=isolated_hash, storage=storage, cache=cache, outdir=run_dir, require_command=True
        )

        change_tree_read_only(run_dir, bundle.read_only)
        cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
        command = bundle.command + extra_args
        file_path.ensure_command_has_abs_path(command, cwd)
        result["exit_code"] = run_command(process_command(command, out_dir), cwd, tmp_dir)
    except Exception as e:
        # An internal error occured. Report accordingly so the swarming task will be
        # retried automatically.
        logging.error("internal failure: %s", e)
        result["internal_failure"] = str(e)
        on_error.report(None)
    finally:
        try:
            if leak_temp_dir:
                logging.warning("Deliberately leaking %s for later examination", run_dir)
            else:
                if os.path.isdir(run_dir) and not file_path.rmtree(run_dir):
                    # On Windows rmtree(run_dir) call above has a synchronization effect:
                    # it finishes only when all task child processes terminate (since a
                    # running process locks *.exe file). Examine out_dir only after that
                    # call completes (since child processes may write to out_dir too and
                    # we need to wait for them to finish).
                    print >>sys.stderr, (
                        "Failed to delete the run directory, forcibly failing\n"
                        "the task because of it. No zombie process can outlive a\n"
                        "successful task run and still be marked as successful.\n"
                        "Fix your stuff."
                    )
                    if result["exit_code"] == 0:
                        result["exit_code"] = 1
                if os.path.isdir(tmp_dir) and not file_path.rmtree(tmp_dir):
                    print >>sys.stderr, (
                        "Failed to delete the temporary directory, forcibly failing\n"
                        "the task because of it. No zombie process can outlive a\n"
                        "successful task run and still be marked as successful.\n"
                        "Fix your stuff."
                    )
                    if result["exit_code"] == 0:
                        result["exit_code"] = 1

            # This deletes out_dir if leak_temp_dir is not set.
            result["outputs_ref"], success = delete_and_upload(storage, out_dir, leak_temp_dir)
            if not success and result["exit_code"] == 0:
                result["exit_code"] = 1
        except Exception as e:
            # Swallow any exception in the main finally clause.
            logging.error("Leaking out_dir %s: %s", out_dir, e)
            result["internal_failure"] = str(e)
    return result
Beispiel #10
0
def map_and_run(data, constant_run_path):
  """Runs a command with optional isolated input/output.

  Arguments:
  - data: TaskData instance.
  - constant_run_path: TODO

  Returns metadata about the result.
  """
  result = {
    'duration': None,
    'exit_code': None,
    'had_hard_timeout': False,
    'internal_failure': 'run_isolated did not complete properly',
    'stats': {
    # 'isolated': {
    #    'cipd': {
    #      'duration': 0.,
    #      'get_client_duration': 0.,
    #    },
    #    'download': {
    #      'duration': 0.,
    #      'initial_number_items': 0,
    #      'initial_size': 0,
    #      'items_cold': '<large.pack()>',
    #      'items_hot': '<large.pack()>',
    #    },
    #    'upload': {
    #      'duration': 0.,
    #      'items_cold': '<large.pack()>',
    #      'items_hot': '<large.pack()>',
    #    },
    #  },
    },
    # 'cipd_pins': {
    #   'packages': [
    #     {'package_name': ..., 'version': ..., 'path': ...},
    #     ...
    #   ],
    #  'client_package': {'package_name': ..., 'version': ...},
    # },
    'outputs_ref': None,
    'version': 5,
  }

  if data.root_dir:
    file_path.ensure_tree(data.root_dir, 0700)
  elif data.isolate_cache.cache_dir:
    data = data._replace(
        root_dir=os.path.dirname(data.isolate_cache.cache_dir))
  # See comment for these constants.
  # If root_dir is not specified, it is not constant.
  # TODO(maruel): This is not obvious. Change this to become an error once we
  # make the constant_run_path an exposed flag.
  if constant_run_path and data.root_dir:
    run_dir = os.path.join(data.root_dir, ISOLATED_RUN_DIR)
    if os.path.isdir(run_dir):
      file_path.rmtree(run_dir)
    os.mkdir(run_dir, 0700)
  else:
    run_dir = make_temp_dir(ISOLATED_RUN_DIR, data.root_dir)
  # storage should be normally set but don't crash if it is not. This can happen
  # as Swarming task can run without an isolate server.
  out_dir = make_temp_dir(
      ISOLATED_OUT_DIR, data.root_dir) if data.storage else None
  tmp_dir = make_temp_dir(ISOLATED_TMP_DIR, data.root_dir)
  cwd = run_dir
  if data.relative_cwd:
    cwd = os.path.normpath(os.path.join(cwd, data.relative_cwd))
  command = data.command
  try:
    with data.install_packages_fn(run_dir) as cipd_info:
      if cipd_info:
        result['stats']['cipd'] = cipd_info.stats
        result['cipd_pins'] = cipd_info.pins

      if data.isolated_hash:
        isolated_stats = result['stats'].setdefault('isolated', {})
        bundle, isolated_stats['download'] = fetch_and_map(
            isolated_hash=data.isolated_hash,
            storage=data.storage,
            cache=data.isolate_cache,
            outdir=run_dir,
            use_symlinks=data.use_symlinks)
        change_tree_read_only(run_dir, bundle.read_only)
        # Inject the command
        if not command and bundle.command:
          command = bundle.command + data.extra_args
          # Only set the relative directory if the isolated file specified a
          # command, and no raw command was specified.
          if bundle.relative_cwd:
            cwd = os.path.normpath(os.path.join(cwd, bundle.relative_cwd))

      if not command:
        # Handle this as a task failure, not an internal failure.
        sys.stderr.write(
            '<No command was specified!>\n'
            '<Please secify a command when triggering your Swarming task>\n')
        result['exit_code'] = 1
        return result

      if not cwd.startswith(run_dir):
        # Handle this as a task failure, not an internal failure. This is a
        # 'last chance' way to gate against directory escape.
        sys.stderr.write('<Relative CWD is outside of run directory!>\n')
        result['exit_code'] = 1
        return result

      if not os.path.isdir(cwd):
        # Accepts relative_cwd that does not exist.
        os.makedirs(cwd, 0700)

      # If we have an explicit list of files to return, make sure their
      # directories exist now.
      if data.storage and data.outputs:
        isolateserver.create_directories(run_dir, data.outputs)

      command = tools.fix_python_path(command)
      command = process_command(command, out_dir, data.bot_file)
      file_path.ensure_command_has_abs_path(command, cwd)

      with data.install_named_caches(run_dir):
        sys.stdout.flush()
        start = time.time()
        try:
          # Need to switch the default account before 'get_command_env' call,
          # so it can grab correct value of LUCI_CONTEXT env var.
          with set_luci_context_account(data.switch_to_account, tmp_dir):
            env = get_command_env(
                tmp_dir, cipd_info, run_dir, data.env, data.env_prefix)
            result['exit_code'], result['had_hard_timeout'] = run_command(
                command, cwd, env, data.hard_timeout, data.grace_period)
        finally:
          result['duration'] = max(time.time() - start, 0)

    # We successfully ran the command, set internal_failure back to
    # None (even if the command failed, it's not an internal error).
    result['internal_failure'] = None
  except Exception as e:
    # An internal error occurred. Report accordingly so the swarming task will
    # be retried automatically.
    logging.exception('internal failure: %s', e)
    result['internal_failure'] = str(e)
    on_error.report(None)

  # Clean up
  finally:
    try:
      # Try to link files to the output directory, if specified.
      if out_dir:
        link_outputs_to_outdir(run_dir, out_dir, data.outputs)

      success = False
      if data.leak_temp_dir:
        success = True
        logging.warning(
            'Deliberately leaking %s for later examination', run_dir)
      else:
        # On Windows rmtree(run_dir) call above has a synchronization effect: it
        # finishes only when all task child processes terminate (since a running
        # process locks *.exe file). Examine out_dir only after that call
        # completes (since child processes may write to out_dir too and we need
        # to wait for them to finish).
        if fs.isdir(run_dir):
          try:
            success = file_path.rmtree(run_dir)
          except OSError as e:
            logging.error('Failure with %s', e)
            success = False
          if not success:
            sys.stderr.write(OUTLIVING_ZOMBIE_MSG % ('run', data.grace_period))
            if result['exit_code'] == 0:
              result['exit_code'] = 1
        if fs.isdir(tmp_dir):
          try:
            success = file_path.rmtree(tmp_dir)
          except OSError as e:
            logging.error('Failure with %s', e)
            success = False
          if not success:
            sys.stderr.write(OUTLIVING_ZOMBIE_MSG % ('temp', data.grace_period))
            if result['exit_code'] == 0:
              result['exit_code'] = 1

      # This deletes out_dir if leak_temp_dir is not set.
      if out_dir:
        isolated_stats = result['stats'].setdefault('isolated', {})
        result['outputs_ref'], success, isolated_stats['upload'] = (
            delete_and_upload(data.storage, out_dir, data.leak_temp_dir))
      if not success and result['exit_code'] == 0:
        result['exit_code'] = 1
    except Exception as e:
      # Swallow any exception in the main finally clause.
      if out_dir:
        logging.exception('Leaking out_dir %s: %s', out_dir, e)
      result['internal_failure'] = str(e)
  return result
Beispiel #11
0
def map_and_run(isolated_hash, storage, cache, leak_temp_dir, root_dir,
                extra_args):
    """Maps and run the command. Returns metadata about the result."""
    # TODO(maruel): Include performance statistics.
    result = {
        'exit_code': None,
        'internal_failure': None,
        'outputs_ref': None,
        'version': 1,
    }
    if root_dir:
        if not os.path.isdir(root_dir):
            os.makedirs(root_dir, 0700)
        prefix = u''
    else:
        root_dir = os.path.dirname(
            cache.cache_dir) if cache.cache_dir else None
        prefix = u'isolated_'
    run_dir = make_temp_dir(prefix + u'run', root_dir)
    out_dir = make_temp_dir(prefix + u'out', root_dir)
    tmp_dir = make_temp_dir(prefix + u'tmp', root_dir)
    try:
        bundle = isolateserver.fetch_isolated(isolated_hash=isolated_hash,
                                              storage=storage,
                                              cache=cache,
                                              outdir=run_dir,
                                              require_command=True)

        change_tree_read_only(run_dir, bundle.read_only)
        cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
        command = bundle.command + extra_args
        file_path.ensure_command_has_abs_path(command, cwd)
        result['exit_code'] = run_command(process_command(command, out_dir),
                                          cwd, tmp_dir)
    except Exception as e:
        # An internal error occured. Report accordingly so the swarming task will be
        # retried automatically.
        logging.error('internal failure: %s', e)
        result['internal_failure'] = str(e)
        on_error.report(None)
    finally:
        try:
            if leak_temp_dir:
                logging.warning(
                    'Deliberately leaking %s for later examination', run_dir)
            else:
                if os.path.isdir(run_dir) and not file_path.rmtree(run_dir):
                    # On Windows rmtree(run_dir) call above has a synchronization effect:
                    # it finishes only when all task child processes terminate (since a
                    # running process locks *.exe file). Examine out_dir only after that
                    # call completes (since child processes may write to out_dir too and
                    # we need to wait for them to finish).
                    print >> sys.stderr, (
                        'Failed to delete the run directory, forcibly failing\n'
                        'the task because of it. No zombie process can outlive a\n'
                        'successful task run and still be marked as successful.\n'
                        'Fix your stuff.')
                    if result['exit_code'] == 0:
                        result['exit_code'] = 1
                if os.path.isdir(tmp_dir) and not file_path.rmtree(tmp_dir):
                    print >> sys.stderr, (
                        'Failed to delete the temporary directory, forcibly failing\n'
                        'the task because of it. No zombie process can outlive a\n'
                        'successful task run and still be marked as successful.\n'
                        'Fix your stuff.')
                    if result['exit_code'] == 0:
                        result['exit_code'] = 1

            # This deletes out_dir if leak_temp_dir is not set.
            result['outputs_ref'], success = delete_and_upload(
                storage, out_dir, leak_temp_dir)
            if not success and result['exit_code'] == 0:
                result['exit_code'] = 1
        except Exception as e:
            # Swallow any exception in the main finally clause.
            logging.error('Leaking out_dir %s: %s', out_dir, e)
            result['internal_failure'] = str(e)
    return result
Beispiel #12
0
def map_and_run(
    isolated_hash, storage, cache, leak_temp_dir, root_dir, hard_timeout,
    grace_period, extra_args):
  """Maps and run the command. Returns metadata about the result."""
  result = {
    'duration': None,
    'exit_code': None,
    'had_hard_timeout': False,
    'internal_failure': None,
    'stats': {
    #  'download': {
    #    'duration': 0.,
    #    'initial_number_items': 0,
    #    'initial_size': 0,
    #    'items_cold': '<large.pack()>',
    #    'items_hot': '<large.pack()>',
    #  },
    #  'upload': {
    #    'duration': 0.,
    #    'items_cold': '<large.pack()>',
    #    'items_hot': '<large.pack()>',
    #  },
    },
    'outputs_ref': None,
    'version': 3,
  }
  if root_dir:
    if not fs.isdir(root_dir):
      fs.makedirs(root_dir, 0700)
    prefix = u''
  else:
    root_dir = os.path.dirname(cache.cache_dir) if cache.cache_dir else None
    prefix = u'isolated_'
  run_dir = make_temp_dir(prefix + u'run', root_dir)
  out_dir = make_temp_dir(prefix + u'out', root_dir)
  tmp_dir = make_temp_dir(prefix + u'tmp', root_dir)
  try:
    start = time.time()
    bundle = isolateserver.fetch_isolated(
        isolated_hash=isolated_hash,
        storage=storage,
        cache=cache,
        outdir=run_dir)
    if not bundle.command:
      # Handle this as a task failure, not an internal failure.
      sys.stderr.write(
          '<The .isolated doesn\'t declare any command to run!>\n'
          '<Check your .isolate for missing \'command\' variable>\n')
      if os.environ.get('SWARMING_TASK_ID'):
        # Give an additional hint when running as a swarming task.
        sys.stderr.write('<This occurs at the \'isolate\' step>\n')
      result['exit_code'] = 1
      return result
    result['stats']['download'] = {
      'duration': time.time() - start,
      'initial_number_items': cache.initial_number_items,
      'initial_size': cache.initial_size,
      'items_cold': base64.b64encode(large.pack(sorted(cache.added))),
      'items_hot': base64.b64encode(
          large.pack(sorted(set(cache.linked) - set(cache.added)))),
    }

    change_tree_read_only(run_dir, bundle.read_only)
    cwd = os.path.normpath(os.path.join(run_dir, bundle.relative_cwd))
    command = bundle.command + extra_args
    file_path.ensure_command_has_abs_path(command, cwd)
    sys.stdout.flush()
    start = time.time()
    try:
      result['exit_code'], result['had_hard_timeout'] = run_command(
          process_command(command, out_dir), cwd, tmp_dir, hard_timeout,
          grace_period)
    finally:
      result['duration'] = max(time.time() - start, 0)
  except Exception as e:
    # An internal error occured. Report accordingly so the swarming task will be
    # retried automatically.
    logging.exception('internal failure: %s', e)
    result['internal_failure'] = str(e)
    on_error.report(None)
  finally:
    try:
      if leak_temp_dir:
        logging.warning(
            'Deliberately leaking %s for later examination', run_dir)
      else:
        # On Windows rmtree(run_dir) call above has a synchronization effect: it
        # finishes only when all task child processes terminate (since a running
        # process locks *.exe file). Examine out_dir only after that call
        # completes (since child processes may write to out_dir too and we need
        # to wait for them to finish).
        if fs.isdir(run_dir):
          try:
            success = file_path.rmtree(run_dir)
          except OSError as e:
            logging.error('Failure with %s', e)
            success = False
          if not success:
            print >> sys.stderr, (
                'Failed to delete the run directory, forcibly failing\n'
                'the task because of it. No zombie process can outlive a\n'
                'successful task run and still be marked as successful.\n'
                'Fix your stuff.')
            if result['exit_code'] == 0:
              result['exit_code'] = 1
        if fs.isdir(tmp_dir):
          try:
            success = file_path.rmtree(tmp_dir)
          except OSError as e:
            logging.error('Failure with %s', e)
            success = False
          if not success:
            print >> sys.stderr, (
                'Failed to delete the temporary directory, forcibly failing\n'
                'the task because of it. No zombie process can outlive a\n'
                'successful task run and still be marked as successful.\n'
                'Fix your stuff.')
            if result['exit_code'] == 0:
              result['exit_code'] = 1

      # This deletes out_dir if leak_temp_dir is not set.
      start = time.time()
      result['outputs_ref'], success, cold, hot = delete_and_upload(
          storage, out_dir, leak_temp_dir)
      result['stats']['upload'] = {
        'duration': time.time() - start,
        'items_cold': base64.b64encode(large.pack(cold)),
        'items_hot': base64.b64encode(large.pack(hot)),
      }
      if not success and result['exit_code'] == 0:
        result['exit_code'] = 1
    except Exception as e:
      # Swallow any exception in the main finally clause.
      logging.exception('Leaking out_dir %s: %s', out_dir, e)
      result['internal_failure'] = str(e)
  return result