def update(self, **kwargs):
"""Update contents of this review.
Returns:
New revision of this review.
"""
license_id = kwargs.pop('license_id', None)
if license_id is not None:
if not self.is_draft: # If trying to convert published review into draft.
raise BadRequest(gettext("Changing license of a published review is not allowed."))
self.license_id = license_id
language = kwargs.pop('language', None)
if language is not None:
self.language = language
is_draft = kwargs.pop('is_draft', None)
if is_draft is not None: # This should be done after all changes that depend on review being a draft.
if not self.is_draft and is_draft: # If trying to convert published review into draft.
raise BadRequest(gettext("Converting published reviews back to drafts is not allowed."))
self.is_draft = is_draft
new_revision = Revision.create(self.id, kwargs.pop('text'))
cache.invalidate_namespace(Review.CACHE_NAMESPACE)
if kwargs:
# FIXME: Revision creation and other changes need to be rolled back
# there, but there's a `commit` in Revision.create.
raise TypeError('Unexpected **kwargs: %r' % kwargs)
return new_revision
def update(self, **kwargs):
"""Update contents of this review.
Returns:
New revision of this review.
"""
license_id = kwargs.pop('license_id', None)
if license_id is not None:
if not self.is_draft: # If trying to convert published review into draft.
raise BadRequest(
lazy_gettext(
"Changing license of a published review is not allowed."
))
self.license_id = license_id
language = kwargs.pop('language', None)
if language is not None:
self.language = language
is_draft = kwargs.pop('is_draft', None)
if is_draft is not None: # This should be done after all changes that depend on review being a draft.
if not self.is_draft and is_draft: # If trying to convert published review into draft.
raise BadRequest(
lazy_gettext(
"Converting published reviews back to drafts is not allowed."
))
self.is_draft = is_draft
new_revision = Revision.create(self.id, kwargs.pop('text'))
cache.invalidate_namespace(Review.CACHE_NAMESPACE)
if kwargs:
# FIXME: Revision creation and other changes need to be rolled back
# there, but there's a `commit` in Revision.create.
raise TypeError('Unexpected **kwargs: %r' % kwargs)
return new_revision
