def delete(self, context, network_id):
if network_id == -1:
raise exception.NetworkInUse(network_id=network_id)
for i, network in enumerate(self.networks):
if network['id'] == network_id:
del self.networks[0]
return True
raise exception.NetworkNotFoundForUUID(uuid=network_id)
class NetworksTest(test.NoDBTestCase):
def setUp(self):
super(NetworksTest, self).setUp()
self.controller = networks.NetworkController()
@mock.patch('nova.network.api.API.delete',
side_effect=exception.NetworkInUse(network_id=1))
def test_network_delete_in_use(self, mock_delete):
req = fakes.HTTPRequest.blank('/v2/1234/os-tenant-networks/1')
self.assertRaises(webob.exc.HTTPConflict, self.controller.delete, req,
1)
class TenantNetworksTestV21(test.NoDBTestCase):
ctrlr = networks_v21.TenantNetworkController
def setUp(self):
super(TenantNetworksTestV21, self).setUp()
self.controller = self.ctrlr()
self.flags(enable_network_quota=True)
@mock.patch('nova.network.api.API.delete',
side_effect=exception.NetworkInUse(network_id=1))
def test_network_delete_in_use(self, mock_delete):
req = fakes.HTTPRequest.blank('/v2/1234/os-tenant-networks/1')
self.assertRaises(webob.exc.HTTPConflict, self.controller.delete, req,
1)
@mock.patch('nova.quota.QUOTAS.reserve')
@mock.patch('nova.quota.QUOTAS.rollback')
@mock.patch('nova.network.api.API.delete')
def _test_network_delete_exception(self, ex, expex, delete_mock,
rollback_mock, reserve_mock):
req = fakes.HTTPRequest.blank('/v2/1234/os-tenant-networks')
ctxt = req.environ['nova.context']
reserve_mock.return_value = 'rv'
delete_mock.side_effect = ex
self.assertRaises(expex, self.controller.delete, req, 1)
delete_mock.assert_called_once_with(ctxt, 1)
rollback_mock.assert_called_once_with(ctxt, 'rv')
reserve_mock.assert_called_once_with(ctxt, networks=-1)
def test_network_delete_exception_network_not_found(self):
ex = exception.NetworkNotFound(network_id=1)
expex = webob.exc.HTTPNotFound
self._test_network_delete_exception(ex, expex)
def test_network_delete_exception_policy_failed(self):
ex = exception.PolicyNotAuthorized(action='dummy')
expex = webob.exc.HTTPForbidden
self._test_network_delete_exception(ex, expex)
def test_network_delete_exception_network_in_use(self):
ex = exception.NetworkInUse(network_id=1)
expex = webob.exc.HTTPConflict
self._test_network_delete_exception(ex, expex)
def test_network_delete_exception_network_in_use(self):
ex = exception.NetworkInUse(network_id=1)
expex = webob.exc.HTTPConflict
self._test_network_delete_exception(ex, None, expex)
def delete(self, context, network_uuid):
network = self.get(context, network_uuid)
if network.project_id is not None:
raise exception.NetworkInUse(network_id=network_uuid)
return self.network_rpcapi.delete_network(context, network_uuid, None)
class TenantNetworksTestV21(test.NoDBTestCase):
ctrlr = networks_v21.TenantNetworkController
validation_error = exception.ValidationError
def setUp(self):
super(TenantNetworksTestV21, self).setUp()
self.controller = self.ctrlr()
self.flags(enable_network_quota=True)
self.req = fakes.HTTPRequest.blank('')
self.original_value = CONF.use_neutron_default_nets
def tearDown(self):
super(TenantNetworksTestV21, self).tearDown()
CONF.set_override("use_neutron_default_nets", self.original_value)
@mock.patch('nova.network.api.API.delete',
side_effect=exception.NetworkInUse(network_id=1))
def test_network_delete_in_use(self, mock_delete):
self.assertRaises(webob.exc.HTTPConflict, self.controller.delete,
self.req, 1)
@mock.patch('nova.quota.QUOTAS.reserve')
@mock.patch('nova.quota.QUOTAS.rollback')
@mock.patch('nova.network.api.API.delete')
def _test_network_delete_exception(self, ex, expex, delete_mock,
rollback_mock, reserve_mock):
ctxt = self.req.environ['nova.context']
reserve_mock.return_value = 'rv'
delete_mock.side_effect = ex
self.assertRaises(expex, self.controller.delete, self.req, 1)
delete_mock.assert_called_once_with(ctxt, 1)
rollback_mock.assert_called_once_with(ctxt, 'rv')
reserve_mock.assert_called_once_with(ctxt, networks=-1)
def test_network_delete_exception_network_not_found(self):
ex = exception.NetworkNotFound(network_id=1)
expex = webob.exc.HTTPNotFound
self._test_network_delete_exception(ex, expex)
def test_network_delete_exception_policy_failed(self):
ex = exception.PolicyNotAuthorized(action='dummy')
expex = webob.exc.HTTPForbidden
self._test_network_delete_exception(ex, expex)
def test_network_delete_exception_network_in_use(self):
ex = exception.NetworkInUse(network_id=1)
expex = webob.exc.HTTPConflict
self._test_network_delete_exception(ex, expex)
@mock.patch('nova.quota.QUOTAS.reserve')
@mock.patch('nova.quota.QUOTAS.commit')
@mock.patch('nova.network.api.API.delete')
def test_network_delete(self, delete_mock, commit_mock, reserve_mock):
ctxt = self.req.environ['nova.context']
reserve_mock.return_value = 'rv'
res = self.controller.delete(self.req, 1)
# NOTE: on v2.1, http status code is set as wsgi_code of API
# method instead of status_int in a response object.
if isinstance(self.controller, networks_v21.TenantNetworkController):
status_int = self.controller.delete.wsgi_code
else:
status_int = res.status_int
self.assertEqual(202, status_int)
delete_mock.assert_called_once_with(ctxt, 1)
commit_mock.assert_called_once_with(ctxt, 'rv')
reserve_mock.assert_called_once_with(ctxt, networks=-1)
@mock.patch('nova.network.api.API.get')
def test_network_show(self, get_mock):
get_mock.return_value = NETWORKS[0]
res = self.controller.show(self.req, 1)
self.assertEqual(res['network'], NETWORKS[0])
@mock.patch('nova.network.api.API.get')
def test_network_show_not_found(self, get_mock):
ctxt = self.req.environ['nova.context']
get_mock.side_effect = exception.NetworkNotFound(network_id=1)
self.assertRaises(webob.exc.HTTPNotFound, self.controller.show,
self.req, 1)
get_mock.assert_called_once_with(ctxt, 1)
@mock.patch('nova.network.api.API.get_all')
def _test_network_index(self, get_all_mock, default_net=True):
CONF.set_override("use_neutron_default_nets", default_net)
get_all_mock.side_effect = fake_network_api_get_all
expected = NETWORKS
if default_net is True:
self.req.environ['nova.context'].project_id = DEFAULT_TENANT_ID
expected = NETWORKS_WITH_DEFAULT_NET
res = self.controller.index(self.req)
self.assertEqual(res['networks'], expected)
def test_network_index_with_default_net(self):
self._test_network_index()
def test_network_index_without_default_net(self):
self._test_network_index(default_net=False)
@mock.patch('nova.quota.QUOTAS.reserve')
@mock.patch('nova.quota.QUOTAS.commit')
@mock.patch('nova.network.api.API.create')
def test_network_create(self, create_mock, commit_mock, reserve_mock):
ctxt = self.req.environ['nova.context']
reserve_mock.return_value = 'rv'
create_mock.side_effect = fake_network_api_create
body = copy.deepcopy(NETWORKS[0])
del body['id']
body = {'network': body}
res = self.controller.create(self.req, body=body)
self.assertEqual(res['network'], NETWORKS[0])
commit_mock.assert_called_once_with(ctxt, 'rv')
reserve_mock.assert_called_once_with(ctxt, networks=1)
@mock.patch('nova.quota.QUOTAS.reserve')
def test_network_create_quota_error(self, reserve_mock):
ctxt = self.req.environ['nova.context']
reserve_mock.side_effect = exception.OverQuota(overs='fake')
body = {'network': {"cidr": "10.20.105.0/24", "label": "new net 1"}}
self.assertRaises(webob.exc.HTTPBadRequest,
self.controller.create,
self.req,
body=body)
reserve_mock.assert_called_once_with(ctxt, networks=1)
@mock.patch('nova.quota.QUOTAS.reserve')
@mock.patch('nova.quota.QUOTAS.rollback')
@mock.patch('nova.network.api.API.create')
def _test_network_create_exception(self, ex, expex, create_mock,
rollback_mock, reserve_mock):
ctxt = self.req.environ['nova.context']
reserve_mock.return_value = 'rv'
create_mock.side_effect = ex
body = {'network': {"cidr": "10.20.105.0/24", "label": "new net 1"}}
self.assertRaises(expex, self.controller.create, self.req, body=body)
reserve_mock.assert_called_once_with(ctxt, networks=1)
def test_network_create_exception_policy_failed(self):
ex = exception.PolicyNotAuthorized(action='dummy')
expex = webob.exc.HTTPForbidden
self._test_network_create_exception(ex, expex)
def test_network_create_exception_service_unavailable(self):
ex = Exception
expex = webob.exc.HTTPServiceUnavailable
self._test_network_create_exception(ex, expex)
def test_network_create_empty_body(self):
self.assertRaises(exception.ValidationError,
self.controller.create,
self.req,
body={})
def test_network_create_without_cidr(self):
body = {'network': {"label": "new net 1"}}
self.assertRaises(self.validation_error,
self.controller.create,
self.req,
body=body)
def test_network_create_bad_format_cidr(self):
body = {'network': {"cidr": "123", "label": "new net 1"}}
self.assertRaises(self.validation_error,
self.controller.create,
self.req,
body=body)
def test_network_create_empty_network(self):
body = {'network': {}}
self.assertRaises(self.validation_error,
self.controller.create,
self.req,
body=body)
def test_network_create_without_label(self):
body = {'network': {"cidr": "10.20.105.0/24"}}
self.assertRaises(self.validation_error,
self.controller.create,
self.req,
body=body)
