def test_review_scenario(mock_request, addon_with_files, review_action,
addon_status, file_status, review_class, review_type,
final_addon_status, final_file_status):
# Setup the addon and files.
addon = addon_with_files
addon.update(status=addon_status)
version = addon.versions.get()
version.files.filter(
status=amo.STATUS_AWAITING_REVIEW).update(status=file_status)
# Get the review helper.
helper = ReviewHelper(mock_request, addon, version)
assert isinstance(helper.handler, review_class)
helper.set_review_handler(mock_request)
assert helper.handler.review_type == review_type
helper.set_data({'comments': 'testing review scenarios'})
# Run the action (process_public, process_sandbox).
try:
getattr(helper.handler, review_action)()
except AssertionError:
# Some scenarios are expected to fail. We don't need to check it here,
# the scenario has the final statuses, and those are the ones we want
# to check.
pass
# Check the final statuses.
assert addon.reload().status == final_addon_status
assert list(version.files.values_list('status', flat=True)) == (
[amo.STATUS_DISABLED, final_file_status, final_file_status])
def get_form(self, data=None):
return ReviewForm(
data=data,
helper=ReviewHelper(
request=self.request, addon=self.addon, version=self.version
),
)
def notify_developers(self, version):
"""
Trigger task sending email notifying developer(s) of the add-on that
this version hasn't been auto-approved yet.
"""
helper = ReviewHelper(addon=version.addon, version=version)
helper.handler.data = {}
helper.handler.notify_about_auto_approval_delay(version)
def approve_files(files_with_review_type):
"""Approve the files waiting for review (and sign them)."""
for file_, review_type in files_with_review_type:
version = file_.version
addon = version.addon
helper = ReviewHelper(request=None, addon=addon, version=file_.version)
# Provide the file to review/sign to the helper.
helper.set_data({'addon_files': [file_], 'comments': u'bulk approval'})
if review_type == 'full':
# Already approved, or waiting for a full review.
helper.handler.process_public()
log.info(u'File %s (addon %s) approved', file_.pk, addon.pk)
else:
log.info(
u'File %s (addon %s) not approved: '
u'addon status: %s, file status: %s', file_.pk, addon.pk,
addon.status, file_.status)
def approve_files(files_with_review_type):
"""Approve the files waiting for review (and sign them)."""
for file_, review_type in files_with_review_type:
version = file_.version
addon = version.addon
helper = ReviewHelper(request=None, addon=addon,
version=file_.version)
# Provide the file to review/sign to the helper.
helper.set_data({'addon_files': [file_],
'comments': u'bulk approval'})
if review_type == 'full':
# Already approved, or waiting for a full review.
helper.handler.process_public()
log.info(u'File %s (addon %s) approved', file_.pk, addon.pk)
else:
log.info(u'File %s (addon %s) not approved: '
u'addon status: %s, file status: %s',
file_.pk, addon.pk, addon.status, file_.status)
def test_review_scenario(mock_request, addon_with_files, review_action,
addon_status, file_status, review_class, review_type,
final_addon_status, final_file_status):
# Setup the addon and files.
addon = addon_with_files
addon.update(status=addon_status)
version = addon.versions.get()
version.files.filter(status=amo.STATUS_AWAITING_REVIEW).update(
status=file_status)
# Get the review helper.
helper = ReviewHelper(mock_request, addon, version)
assert isinstance(helper.handler, review_class)
helper.set_review_handler(mock_request)
assert helper.handler.review_type == review_type
helper.set_data({'comments': 'testing review scenarios'})
# Run the action (process_public, process_sandbox).
try:
getattr(helper.handler, review_action)()
except AssertionError:
# Some scenarios are expected to fail. We don't need to check it here,
# the scenario has the final statuses, and those are the ones we want
# to check.
pass
# Check the final statuses.
assert addon.reload().status == final_addon_status
assert list(version.files.values_list('status', flat=True)) == ([
amo.STATUS_BETA, amo.STATUS_DISABLED, final_file_status,
final_file_status
])
def test_review_scenario(
mock_request,
review_action,
addon_status,
file_status,
review_class,
review_type,
final_addon_status,
final_file_status,
):
# Setup the addon and files.
addon = addon_factory(
name='My Addon',
slug='my-addon',
status=addon_status,
file_kw={'status': file_status},
)
version = addon.versions.get()
# Get the review helper.
helper = ReviewHelper(mock_request, addon, version)
assert isinstance(helper.handler, review_class)
helper.set_review_handler(mock_request)
assert helper.handler.review_type == review_type
helper.set_data({'comments': 'testing review scenarios'})
# Run the action (approve_latest_version, reject_latest_version).
try:
getattr(helper.handler, review_action)()
except AssertionError:
# Some scenarios are expected to fail. We don't need to check it here,
# the scenario has the final statuses, and those are the ones we want
# to check.
pass
# Check the final statuses.
assert addon.reload().status == final_addon_status
assert version.file.reload().status == final_file_status
def approve(self, version):
"""Do the approval itself, caling ReviewHelper to change the status,
sign the files, send the e-mail, etc."""
# Note: this should automatically use the TASK_USER_ID user.
helper = ReviewHelper(addon=version.addon, version=version)
helper.handler.data = {
# The comment is not translated on purpose, to behave like regular
# human approval does.
'comments':
u'This version has been approved for the public.'
u'\r\n\r\nThank you!'
}
helper.handler.process_public()
statsd.incr('reviewers.auto_approve.approve')
def reject_versions(self, *, addon, versions, latest_version):
"""Reject specific versions for an addon."""
if self.dry_run:
log.info(
'Would reject versions %s from add-on %s but this is a '
'dry run.', versions, addon)
return
helper = ReviewHelper(addon=addon, version=latest_version)
helper.handler.data = {
'comments': 'Automatic rejection after grace period ended.',
'versions': versions,
}
helper.handler.reject_multiple_versions()
VersionReviewerFlags.objects.filter(version__in=list(versions)).update(
pending_rejection=None)
def approve(self, version):
"""Do the approval itself, caling ReviewHelper to change the status,
sign the files, send the e-mail, etc."""
# Note: this should automatically use the TASK_USER_ID user.
helper = ReviewHelper(addon=version.addon, version=version)
helper.handler.data = {
# The comment is not translated on purpose, to behave like regular
# human approval does.
'comments': u'This version has been screened and approved for the '
u'public. Keep in mind that other reviewers may look '
u'into this version in the future and determine that '
u'it requires changes or should be taken down. In '
u'that case, you will be notified again with details '
u'and next steps.'
u'\r\n\r\nThank you!'
}
helper.handler.process_public()
statsd.incr('reviewers.auto_approve.approve')
def notify_developers(self, *, addon, versions, latest_version):
# Fetch the activity log to retrieve the comments to include in the
# email. There is no global one, so we just take the latest we can find
# for those versions with a delayed rejection action.
relevant_activity_log = (
ActivityLog.objects.for_versions(versions).filter(action__in=(
amo.LOG.REJECT_CONTENT_DELAYED.id,
amo.LOG.REJECT_VERSION_DELAYED.id,
)).last())
if (not relevant_activity_log or not relevant_activity_log.details
or not relevant_activity_log.details.get('comments')):
log.info(
'Skipping notification about versions pending rejections for '
'add-on %s since there is no activity log or comments.',
addon.pk,
)
return
log.info('Sending email for %s' % addon)
# Set up ReviewHelper with the data needed to send the notification.
helper = ReviewHelper(addon=addon)
helper.handler.data = {
'comments':
getattr(relevant_activity_log, 'details', {}).get('comments', ''),
'version_numbers':
', '.join(str(v.version) for v in versions),
'versions':
versions,
'delayed_rejection_days':
self.EXPIRING_PERIOD_DAYS,
}
template = 'reject_multiple_versions_with_delay'
subject = (
'Reminder - Mozilla Add-ons: %s%s will be disabled on addons.mozilla.org'
)
# This re-sends the notification sent when the versions were scheduled
# for rejection, but with the new delay in the body of the email now
# that the notification is about to expire.
helper.handler.notify_email(template, subject, version=latest_version)
# Note that we did this so that we don't notify developers of this
# add-on again until next rejection.
AddonReviewerFlags.objects.update_or_create(
addon=addon,
defaults={'notified_about_expiring_delayed_rejections': True},
)
def approve(self, version):
"""Do the approval itself, caling ReviewHelper to change the status,
sign the files, send the e-mail, etc."""
# Note: this should automatically use the TASK_USER_ID user.
helper = ReviewHelper(addon=version.addon, version=version)
if version.channel == amo.RELEASE_CHANNEL_LISTED:
helper.handler.data = {
# The comment is not translated on purpose, to behave like
# regular human approval does.
'comments': 'This version has been screened and approved for the '
'public. Keep in mind that other reviewers may look into '
'this version in the future and determine that it '
'requires changes or should be taken down.'
'\r\n\r\nThank you!'
}
else:
helper.handler.data = {'comments': 'automatic validation'}
helper.handler.approve_latest_version()
statsd.incr('reviewers.auto_approve.approve.success')
def review(request, addon, channel=None):
whiteboard_url = reverse('reviewers.whiteboard',
args=(channel or 'listed',
addon.slug if addon.slug else addon.pk))
channel, content_review_only = determine_channel(channel)
was_auto_approved = (channel == amo.RELEASE_CHANNEL_LISTED
and addon.current_version
and addon.current_version.was_auto_approved)
is_static_theme = addon.type == amo.ADDON_STATICTHEME
# If we're just looking (GET) we can bypass the specific permissions checks
# if we have ReviewerTools:View.
bypass_more_specific_permissions_because_read_only = (
request.method == 'GET'
and acl.action_allowed(request, amo.permissions.REVIEWER_TOOLS_VIEW))
if not bypass_more_specific_permissions_because_read_only:
perform_review_permission_checks(
request, addon, channel, content_review_only=content_review_only)
version = addon.find_latest_version(channel=channel,
exclude=(amo.STATUS_BETA, ))
if not settings.ALLOW_SELF_REVIEWS and addon.has_author(request.user):
amo.messages.warning(request,
ugettext('Self-reviews are not allowed.'))
return redirect(reverse('reviewers.queue'))
# Get the current info request state to set as the default.
form_initial = {'info_request': addon.pending_info_request}
form_helper = ReviewHelper(request=request,
addon=addon,
version=version,
content_review_only=content_review_only)
form = ReviewForm(request.POST if request.method == 'POST' else None,
helper=form_helper,
initial=form_initial)
is_admin = acl.action_allowed(request, amo.permissions.REVIEWS_ADMIN)
approvals_info = None
reports = None
user_ratings = None
if channel == amo.RELEASE_CHANNEL_LISTED:
if was_auto_approved:
try:
approvals_info = addon.addonapprovalscounter
except AddonApprovalsCounter.DoesNotExist:
pass
developers = addon.listed_authors
reports = Paginator((AbuseReport.objects.filter(
Q(addon=addon) | Q(user__in=developers)).order_by('-created')),
5).page(1)
user_ratings = Paginator((Rating.without_replies.filter(
addon=addon, rating__lte=3,
body__isnull=False).order_by('-created')), 5).page(1)
if content_review_only:
queue_type = 'content_review'
elif was_auto_approved:
queue_type = 'auto_approved'
else:
queue_type = form.helper.handler.review_type
redirect_url = reverse('reviewers.queue_%s' % queue_type)
else:
redirect_url = reverse('reviewers.unlisted_queue_all')
if request.method == 'POST' and form.is_valid():
form.helper.process()
amo.messages.success(request,
ugettext('Review successfully processed.'))
clear_reviewing_cache(addon.id)
return redirect(redirect_url)
# Kick off validation tasks for any files in this version which don't have
# cached validation, since reviewers will almost certainly need to access
# them. But only if we're not running in eager mode, since that could mean
# blocking page load for several minutes.
if version and not getattr(settings, 'CELERY_ALWAYS_EAGER', False):
for file_ in version.all_files:
if not file_.has_been_validated:
devhub_tasks.validate(file_)
actions = form.helper.actions.items()
try:
# Find the previously approved version to compare to.
show_diff = version and (addon.versions.exclude(id=version.id).filter(
# We're looking for a version that was either manually approved
# (either it has no auto approval summary, or it has one but
# with a negative verdict because it was locked by a reviewer
# who then approved it themselves), or auto-approved but then
# confirmed.
Q(autoapprovalsummary__isnull=True)
| Q(autoapprovalsummary__verdict=amo.NOT_AUTO_APPROVED)
| Q(autoapprovalsummary__verdict=amo.AUTO_APPROVED,
autoapprovalsummary__confirmed=True)).filter(
channel=channel,
files__isnull=False,
created__lt=version.created,
files__status=amo.STATUS_PUBLIC).latest())
except Version.DoesNotExist:
show_diff = None
# The actions we shouldn't show a minimal form for.
actions_full = [
k for (k, a) in actions if not (is_static_theme or a.get('minimal'))
]
# The actions we should show the comments form for (contrary to minimal
# form above, it defaults to True, because most actions do need to have
# the comments form).
actions_comments = [k for (k, a) in actions if a.get('comments', True)]
versions = (Version.unfiltered.filter(
addon=addon,
channel=channel).select_related('autoapprovalsummary').exclude(
files__status=amo.STATUS_BETA).order_by('-created').transform(
Version.transformer_activity).transform(Version.transformer))
# We assume comments on old deleted versions are for listed versions.
# See _get_comments_for_hard_deleted_versions above for more detail.
all_versions = (_get_comments_for_hard_deleted_versions(addon)
if channel == amo.RELEASE_CHANNEL_LISTED else [])
all_versions.extend(versions)
all_versions.sort(key=lambda v: v.created, reverse=True)
pager = amo.utils.paginate(request, all_versions, 10)
num_pages = pager.paginator.num_pages
count = pager.paginator.count
auto_approval_info = {}
# Now that we've paginated the versions queryset, iterate on them to
# generate auto approvals info. Note that the variable should not clash
# the already existing 'version'.
for a_version in pager.object_list:
if not a_version.is_ready_for_auto_approval:
continue
try:
summary = a_version.autoapprovalsummary
except AutoApprovalSummary.DoesNotExist:
auto_approval_info[a_version.pk] = None
continue
# Call calculate_verdict() again, it will use the data already stored.
verdict_info = summary.calculate_verdict(pretty=True)
auto_approval_info[a_version.pk] = verdict_info
flags = get_flags(addon, version) if version else []
if not is_static_theme:
try:
whiteboard = Whiteboard.objects.get(pk=addon.pk)
except Whiteboard.DoesNotExist:
whiteboard = Whiteboard(pk=addon.pk)
whiteboard_form = WhiteboardForm(instance=whiteboard,
prefix='whiteboard')
else:
whiteboard_form = None
backgrounds = version.get_background_image_urls() if version else []
user_changes_actions = [
amo.LOG.ADD_USER_WITH_ROLE.id, amo.LOG.CHANGE_USER_WITH_ROLE.id,
amo.LOG.REMOVE_USER_WITH_ROLE.id
]
user_changes_log = AddonLog.objects.filter(
activity_log__action__in=user_changes_actions,
addon=addon).order_by('id')
ctx = context(request,
actions=actions,
actions_comments=actions_comments,
actions_full=actions_full,
addon=addon,
api_token=request.COOKIES.get(API_TOKEN_COOKIE, None),
approvals_info=approvals_info,
auto_approval_info=auto_approval_info,
backgrounds=backgrounds,
content_review_only=content_review_only,
count=count,
flags=flags,
form=form,
is_admin=is_admin,
num_pages=num_pages,
pager=pager,
reports=reports,
show_diff=show_diff,
subscribed=ReviewerSubscription.objects.filter(
user=request.user, addon=addon).exists(),
unlisted=(channel == amo.RELEASE_CHANNEL_UNLISTED),
user_changes=user_changes_log,
user_ratings=user_ratings,
version=version,
was_auto_approved=was_auto_approved,
whiteboard_form=whiteboard_form,
whiteboard_url=whiteboard_url)
return render(request, 'reviewers/review.html', ctx)
def test_no_version(self):
helper = ReviewHelper(
request=self.request, addon=self.addon, version=None)
assert helper.handler.review_type == 'pending'
def get_helper(self, content_review_only=False):
return ReviewHelper(
request=self.request, addon=self.addon, version=self.version,
content_review_only=content_review_only)
def review(request, addon, channel=None):
if channel == 'content':
# 'content' is not a real channel, just a different review mode for
# listed add-ons.
content_review_only = True
channel = 'listed'
else:
content_review_only = False
# channel is passed in as text, but we want the constant.
channel = amo.CHANNEL_CHOICES_LOOKUP.get(channel,
amo.RELEASE_CHANNEL_LISTED)
if content_review_only and not acl.action_allowed(
request, amo.permissions.ADDONS_CONTENT_REVIEW):
raise PermissionDenied
unlisted_only = (channel == amo.RELEASE_CHANNEL_UNLISTED
or not addon.has_listed_versions())
if unlisted_only and not acl.check_unlisted_addons_reviewer(request):
raise PermissionDenied
version = addon.find_latest_version(channel=channel,
exclude=(amo.STATUS_BETA, ))
if not settings.ALLOW_SELF_REVIEWS and addon.has_author(request.user):
amo.messages.warning(request,
ugettext('Self-reviews are not allowed.'))
return redirect(reverse('reviewers.queue'))
# Get the current info request state to set as the default.
form_initial = {'info_request': version and version.has_info_request}
form_helper = ReviewHelper(request=request,
addon=addon,
version=version,
content_review_only=content_review_only)
form = forms.ReviewForm(request.POST if request.method == 'POST' else None,
helper=form_helper,
initial=form_initial)
is_admin = acl.action_allowed(request, amo.permissions.ADDONS_EDIT)
is_post_reviewer = acl.action_allowed(request,
amo.permissions.ADDONS_POST_REVIEW)
approvals_info = None
reports = None
user_reviews = None
was_auto_approved = False
if channel == amo.RELEASE_CHANNEL_LISTED:
if addon.current_version:
was_auto_approved = addon.current_version.was_auto_approved
if is_post_reviewer and version and version.is_webextension:
try:
approvals_info = addon.addonapprovalscounter
except AddonApprovalsCounter.DoesNotExist:
pass
developers = addon.listed_authors
reports = Paginator((AbuseReport.objects.filter(
Q(addon=addon) | Q(user__in=developers)).order_by('-created')),
5).page(1)
user_reviews = Paginator((Review.without_replies.filter(
addon=addon, rating__lte=3,
body__isnull=False).order_by('-created')), 5).page(1)
if content_review_only:
queue_type = 'content_review'
elif was_auto_approved and is_post_reviewer:
queue_type = 'auto_approved'
else:
queue_type = form.helper.handler.review_type
redirect_url = reverse('reviewers.queue_%s' % queue_type)
else:
redirect_url = reverse('reviewers.unlisted_queue_all')
if request.method == 'POST' and form.is_valid():
form.helper.process()
if form.cleaned_data.get('notify'):
ReviewerSubscription.objects.get_or_create(user=request.user,
addon=addon)
if form.cleaned_data.get('adminflag') and is_admin:
addon.update(admin_review=False)
amo.messages.success(request,
ugettext('Review successfully processed.'))
clear_reviewing_cache(addon.id)
return redirect(redirect_url)
# Kick off validation tasks for any files in this version which don't have
# cached validation, since reviewers will almost certainly need to access
# them. But only if we're not running in eager mode, since that could mean
# blocking page load for several minutes.
if version and not getattr(settings, 'CELERY_ALWAYS_EAGER', False):
for file_ in version.all_files:
if not file_.has_been_validated:
devhub_tasks.validate(file_)
canned = AddonCannedResponse.objects.all()
actions = form.helper.actions.items()
try:
# Find the previously approved version to compare to.
show_diff = version and (addon.versions.exclude(id=version.id).filter(
# We're looking for a version that was either manually approved
# or auto-approved but then confirmed.
Q(autoapprovalsummary__isnull=True)
| Q(autoapprovalsummary__verdict=amo.AUTO_APPROVED,
autoapprovalsummary__confirmed=True)).filter(
channel=channel,
files__isnull=False,
created__lt=version.created,
files__status=amo.STATUS_PUBLIC).latest())
except Version.DoesNotExist:
show_diff = None
# The actions we should show a minimal form for.
actions_minimal = [k for (k, a) in actions if not a.get('minimal')]
# The actions we should show the comments form for (contrary to minimal
# form above, it defaults to True, because most actions do need to have
# the comments form).
actions_comments = [k for (k, a) in actions if a.get('comments', True)]
# The actions we should show the 'info request' checkbox for.
actions_info_request = [
k for (k, a) in actions if a.get('info_request', False)
]
versions = (Version.unfiltered.filter(
addon=addon,
channel=channel).select_related('autoapprovalsummary').exclude(
files__status=amo.STATUS_BETA).order_by('-created').transform(
Version.transformer_activity).transform(Version.transformer))
# We assume comments on old deleted versions are for listed versions.
# See _get_comments_for_hard_deleted_versions above for more detail.
all_versions = (_get_comments_for_hard_deleted_versions(addon)
if channel == amo.RELEASE_CHANNEL_LISTED else [])
all_versions.extend(versions)
all_versions.sort(key=lambda v: v.created, reverse=True)
pager = amo.utils.paginate(request, all_versions, 10)
num_pages = pager.paginator.num_pages
count = pager.paginator.count
auto_approval_info = {}
# Now that we've paginated the versions queryset, iterate on them to
# generate auto approvals info. Note that the variable should not clash
# the already existing 'version'.
for a_version in pager.object_list:
if not is_post_reviewer or not a_version.is_ready_for_auto_approval:
continue
try:
summary = a_version.autoapprovalsummary
except AutoApprovalSummary.DoesNotExist:
auto_approval_info[a_version.pk] = None
continue
# Call calculate_verdict() again, it will use the data already stored.
verdict_info = summary.calculate_verdict(pretty=True)
auto_approval_info[a_version.pk] = verdict_info
if version:
flags = get_flags(version)
else:
flags = []
user_changes_actions = [
amo.LOG.ADD_USER_WITH_ROLE.id, amo.LOG.CHANGE_USER_WITH_ROLE.id,
amo.LOG.REMOVE_USER_WITH_ROLE.id
]
user_changes_log = AddonLog.objects.filter(
activity_log__action__in=user_changes_actions,
addon=addon).order_by('id')
ctx = context(request,
version=version,
addon=addon,
pager=pager,
num_pages=num_pages,
count=count,
flags=flags,
form=form,
canned=canned,
is_admin=is_admin,
show_diff=show_diff,
actions=actions,
actions_minimal=actions_minimal,
actions_comments=actions_comments,
actions_info_request=actions_info_request,
whiteboard_form=forms.WhiteboardForm(instance=addon),
user_changes=user_changes_log,
unlisted=(channel == amo.RELEASE_CHANNEL_UNLISTED),
approvals_info=approvals_info,
is_post_reviewer=is_post_reviewer,
auto_approval_info=auto_approval_info,
reports=reports,
user_reviews=user_reviews,
was_auto_approved=was_auto_approved,
content_review_only=content_review_only)
return render(request, 'reviewers/review.html', ctx)
