def testConvertApprovalAmendments(self):
"""Test convert_approval_comment."""
self.services.user.TestAddUser('*****@*****.**', 111)
self.services.user.TestAddUser('*****@*****.**', 222)
self.services.user.TestAddUser('*****@*****.**', 333)
mar = mock.Mock()
mar.cnxn = None
amendment_status = tracker_bizobj.MakeApprovalStatusAmendment(
tracker_pb2.ApprovalStatus.APPROVED)
amendment_approvers = tracker_bizobj.MakeApprovalApproversAmendment(
[111, 222], [333])
amendments = [amendment_status, amendment_approvers]
result = api_pb2_v1_helpers.convert_approval_amendments(
amendments, mar, self.services)
self.assertEquals(amendment_status.newvalue, result.status)
self.assertEquals(['*****@*****.**', '*****@*****.**',
'*****@*****.**'],
result.approvers)
def testNotifyApprovalChangeTask_GetApprovalEmailRecipients(self):
task = notify.NotifyApprovalChangeTask(request=None,
response=None,
services=self.services)
issue = fake.MakeTestIssue(789, 1, 'summary', 'New', 111)
approval_value = tracker_pb2.ApprovalValue(
approver_ids=[222, 333],
status=tracker_pb2.ApprovalStatus.APPROVED)
comment = tracker_pb2.IssueComment(project_id=789,
user_id=1,
issue_id=78901)
# Comment with not amendments notifies everyone.
rids = task._GetApprovalEmailRecipients(approval_value, comment, issue,
[777, 888])
self.assertItemsEqual(rids, [111, 222, 333, 777, 888])
# New APPROVED status notifies owners and any_comment users.
amendment = tracker_bizobj.MakeApprovalStatusAmendment(
tracker_pb2.ApprovalStatus.APPROVED)
comment.amendments = [amendment]
rids = task._GetApprovalEmailRecipients(approval_value, comment, issue,
[777, 888])
self.assertItemsEqual(rids, [111, 777, 888])
# New REVIEW_REQUESTED status notifies approvers.
approval_value.status = tracker_pb2.ApprovalStatus.REVIEW_REQUESTED
amendment = tracker_bizobj.MakeApprovalStatusAmendment(
tracker_pb2.ApprovalStatus.REVIEW_REQUESTED)
comment.amendments = [amendment]
rids = task._GetApprovalEmailRecipients(approval_value, comment, issue,
[777, 888])
self.assertItemsEqual(rids, [222, 333])
# Approvers change notifies everyone.
amendment = tracker_bizobj.MakeApprovalApproversAmendment([222], [555])
comment.amendments = [amendment]
approval_value.approver_ids = [222]
rids = task._GetApprovalEmailRecipients(approval_value,
comment,
issue, [777],
omit_ids=[444, 333])
self.assertItemsEqual(rids, [111, 222, 555, 777])
def testNotifyApprovalChangeTask_Normal(self):
config = self.services.config.GetProjectConfig('cnxn', 12345)
config.field_defs = [
# issue's User field with any_comment is notified.
tracker_bizobj.MakeFieldDef(
121, 12345, 'TL', tracker_pb2.FieldTypes.USER_TYPE, '', '',
False, False, False, None, None, None, False, '', None,
tracker_pb2.NotifyTriggers.ANY_COMMENT, 'no_action',
'TL, notified on everything', False),
# issue's User field with never is not notified.
tracker_bizobj.MakeFieldDef(
122, 12345, 'silentTL', tracker_pb2.FieldTypes.USER_TYPE, '',
'', False, False, False, None, None, None, False, '', None,
tracker_pb2.NotifyTriggers.NEVER, 'no_action',
'TL, notified on nothing', False),
# approval's User field with any_comment is notified.
tracker_bizobj.MakeFieldDef(123,
12345,
'otherapprovalTL',
tracker_pb2.FieldTypes.USER_TYPE,
'',
'',
False,
False,
False,
None,
None,
None,
False,
'',
None,
tracker_pb2.NotifyTriggers.ANY_COMMENT,
'no_action',
'TL on the approvers team',
False,
approval_id=3),
# another approval's User field with any_comment is not notified.
tracker_bizobj.MakeFieldDef(124,
12345,
'otherapprovalTL',
tracker_pb2.FieldTypes.USER_TYPE,
'',
'',
False,
False,
False,
None,
None,
None,
False,
'',
None,
tracker_pb2.NotifyTriggers.ANY_COMMENT,
'no_action',
'TL on another approvers team',
False,
approval_id=4),
tracker_bizobj.MakeFieldDef(3, 12345, 'Goat-Approval',
tracker_pb2.FieldTypes.APPROVAL_TYPE,
'', '', False, False, False, None,
None, None, False, '', None,
tracker_pb2.NotifyTriggers.NEVER,
'no_action', 'Get Approval from Goats',
False)
]
self.services.config.StoreConfig('cnxn', config)
# Custom user_type field TLs
self.services.user.TestAddUser('*****@*****.**', 111)
self.services.user.TestAddUser('*****@*****.**', 222)
self.services.user.TestAddUser('*****@*****.**', 333)
self.services.user.TestAddUser('*****@*****.**', 444)
# Approvers
self.services.user.TestAddUser('*****@*****.**', 777)
self.services.user.TestAddUser('*****@*****.**', 888)
self.services.user.TestAddUser('*****@*****.**', 999)
self.services.user.TestAddUser('*****@*****.**', 666)
self.services.user.TestAddUser('*****@*****.**', 661)
self.services.user.TestAddUser('*****@*****.**', 662)
self.services.user.TestAddUser('*****@*****.**', 663)
self.services.usergroup.TestAddGroupSettings(
666, '*****@*****.**')
self.services.usergroup.TestAddMembers(666, [661, 662, 663])
canary_phase = tracker_pb2.Phase(name='Canary', phase_id=1, rank=1)
approval_values = [
tracker_pb2.ApprovalValue(approval_id=3,
approver_ids=[888, 999, 666, 661])
]
approval_issue = MakeTestIssue(project_id=12345,
local_id=2,
owner_id=2,
reporter_id=1,
is_spam=True)
approval_issue.phases = [canary_phase]
approval_issue.approval_values = approval_values
approval_issue.field_values = [
tracker_bizobj.MakeFieldValue(121, None, None, 111, None, None,
False),
tracker_bizobj.MakeFieldValue(122, None, None, 222, None, None,
False),
tracker_bizobj.MakeFieldValue(123, None, None, 333, None, None,
False),
tracker_bizobj.MakeFieldValue(124, None, None, 444, None, None,
False),
]
self.services.issue.TestAddIssue(approval_issue)
amend = tracker_bizobj.MakeApprovalApproversAmendment([888], [777])
comment = tracker_pb2.IssueComment(project_id=12345,
user_id=999,
issue_id=approval_issue.issue_id,
amendments=[amend],
timestamp=1234567890,
content='just a comment.')
attach = tracker_pb2.Attachment(attachment_id=4567,
filename='sploot.jpg',
mimetype='image/png',
gcs_object_id='/pid/attachments/abcd',
filesize=(1024 * 1023))
comment.attachments.append(attach)
self.services.issue.TestAddComment(comment, approval_issue.local_id)
self.services.issue.TestAddAttachment(attach, comment.id,
approval_issue.issue_id)
task = notify.NotifyApprovalChangeTask(request=None,
response=None,
services=self.services)
params = {
'send_email': 1,
'issue_id': approval_issue.issue_id,
'approval_id': 3,
'comment_id': comment.id,
}
mr = testing_helpers.MakeMonorailRequest(user_info={'user_id': 1},
params=params,
method='POST',
services=self.services)
result = task.HandleRequest(mr)
self.assertTrue('just a comment' in result['tasks'][0]['body'])
self.assertTrue('Approvers: -approver' in result['tasks'][0]['body'])
self.assertTrue('sploot.jpg' in result['tasks'][0]['body'])
self.assertTrue(
'/issues/attachment?aid=4567' in result['tasks'][0]['body'])
self.assertItemsEqual([
'*****@*****.**', '*****@*****.**',
'*****@*****.**', '*****@*****.**',
'*****@*****.**', '*****@*****.**',
'*****@*****.**', '*****@*****.**'
], result['notified'])
# Test no approvers/groups notified
# Status change to NEED_INFO does not email approvers.
amend2 = tracker_bizobj.MakeApprovalStatusAmendment(
tracker_pb2.ApprovalStatus.NEED_INFO)
comment2 = tracker_pb2.IssueComment(project_id=12345,
user_id=999,
issue_id=approval_issue.issue_id,
amendments=[amend2],
timestamp=1234567891,
content='')
self.services.issue.TestAddComment(comment2, approval_issue.local_id)
task = notify.NotifyApprovalChangeTask(request=None,
response=None,
services=self.services)
params = {
'send_email': 1,
'issue_id': approval_issue.issue_id,
'approval_id': 3,
'comment_id': comment2.id,
}
mr = testing_helpers.MakeMonorailRequest(user_info={'user_id': 1},
params=params,
method='POST',
services=self.services)
result = task.HandleRequest(mr)
self.assertTrue('Status: need_info' in result['tasks'][0]['body'])
self.assertItemsEqual(
['*****@*****.**', '*****@*****.**', '*****@*****.**'],
result['notified'])