def _check_name(self, node: ast.AST, arg: str) -> None:
if is_wrong_variable_name(arg, BAD_VARIABLE_NAMES):
self.add_error(WrongVariableNameViolation(node, text=arg))
if is_too_short_variable_name(arg):
self.add_error(TooShortVariableNameViolation(node, text=arg))
if is_private_variable(arg):
self.add_error(PrivateNameViolation(node, text=arg))
def visit_FunctionDef(self, node: ast.FunctionDef):
"""Used to find wrong function and method parameters."""
if is_too_short_variable_name(node.name):
self.add_error(TooShortFunctionNameViolation(node, text=node.name))
if is_wrong_variable_name(node.name, BAD_VARIABLE_NAMES):
self.add_error(WrongFunctionNameViolation(node, text=node.name))
self._check_function_signature(node)
self.generic_visit(node)
def visit_ExceptHandler(self, node: ast.ExceptHandler):
"""Used to find wrong exception instances in `try/except`."""
name = getattr(node, 'name', '_')
if is_wrong_variable_name(name, BAD_VARIABLE_NAMES):
self.add_error(
WrongVariableNameViolation(node, text=name),
)
if is_too_short_variable_name(name):
self.add_error(
TooShortVariableNameViolation(node, text=name),
)
def visit_Name(self, node: ast.Name):
"""Used to find wrong regular variables."""
context = getattr(node, 'ctx', None)
if isinstance(context, ast.Store):
if is_wrong_variable_name(node.id, BAD_VARIABLE_NAMES):
self.add_error(
WrongVariableNameViolation(node, text=node.id),
)
if is_too_short_variable_name(node.id):
self.add_error(
TooShortVariableNameViolation(node, text=node.id),
)
self.generic_visit(node)
def visit_Attribute(self, node: ast.Attribute):
"""Used to find wrong attribute names inside classes."""
context = getattr(node, 'ctx', None)
if isinstance(context, ast.Store):
if is_wrong_variable_name(node.attr, BAD_VARIABLE_NAMES):
self.add_error(
WrongAttributeNameViolation(node, text=node.attr),
)
if is_too_short_variable_name(node.attr):
self.add_error(
TooShortAttributeNameViolation(node, text=node.attr),
)
self.generic_visit(node)
def _check_argument(self, node: ast.FunctionDef, arg: str) -> None:
if is_wrong_variable_name(arg, BAD_VARIABLE_NAMES):
self.add_error(WrongArgumentNameViolation(node, text=arg))
if is_too_short_variable_name(arg):
self.add_error(TooShortArgumentNameViolation(node, text=arg))