def test_migrate_scheduler(cephadm_module: CephadmOrchestrator):
with with_host(cephadm_module, 'host1'):
with with_host(cephadm_module, 'host2'):
# emulate the old scheduler:
c = cephadm_module.apply_rgw(
ServiceSpec('rgw',
'r.z',
placement=PlacementSpec(host_pattern='*',
count=2)))
assert wait(cephadm_module, c) == 'Scheduled rgw.r.z update...'
cephadm_module._apply_all_services()
out = {
o.hostname
for o in wait(cephadm_module, cephadm_module.list_daemons())
}
assert out == {'host1', 'host2'}
c = cephadm_module.apply_rgw(
ServiceSpec('rgw',
'r.z',
placement=PlacementSpec(host_pattern='host1',
count=2)))
assert wait(cephadm_module, c) == 'Scheduled rgw.r.z update...'
cephadm_module.migration_current = 0
cephadm_module.migration.migrate()
# assert we need all daemons.
assert cephadm_module.migration_current == 0
# Sorry, for this hack, but I need to make sure, Migration thinks,
# we have updated all daemons already.
cephadm_module.cache.last_daemon_update['host1'] = datetime.now()
cephadm_module.cache.last_daemon_update['host2'] = datetime.now()
cephadm_module.migration.migrate()
assert cephadm_module.migration_current == 2
out = [
o.spec.placement for o in wait(
cephadm_module, cephadm_module.describe_service())
]
assert out == [
PlacementSpec(count=2,
hosts=[
HostPlacementSpec(hostname='host1',
network='',
name=''),
HostPlacementSpec(hostname='host2',
network='',
name='')
])
]
def convert_to_explicit(spec: ServiceSpec) -> None:
placements = HostAssignment(spec=spec,
get_hosts_func=self.mgr._get_hosts,
get_daemons_func=self.mgr.cache.
get_daemons_by_service).place()
existing_daemons = self.mgr.cache.get_daemons_by_service(
spec.service_name())
# We have to migrate, only if the new scheduler would remove daemons
if len(placements) >= len(existing_daemons):
return
old_hosts = {h.hostname: h for h in spec.placement.hosts}
new_hosts = [
old_hosts[d.hostname] if d.hostname in old_hosts else
HostPlacementSpec(hostname=d.hostname, network='', name='')
for d in existing_daemons
]
new_placement = PlacementSpec(hosts=new_hosts,
count=spec.placement.count)
new_spec = ServiceSpec.from_json(spec.to_json())
new_spec.placement = new_placement
logger.info(
f"Migrating {spec.one_line_str()} to explicit placement")
self.mgr.spec_store.save(new_spec)
def get_host_placement(self) -> HostPlacementSpec:
return HostPlacementSpec(
hostname=self.hostname or '',
# FIXME: include the ip:port here?
network='',
name='',
)
def test_parse_host_placement_specs(test_input, expected, require_network):
ret = HostPlacementSpec.parse(test_input, require_network=require_network)
assert ret == expected
assert str(ret) == test_input
ps = PlacementSpec.from_string(test_input)
assert ps.pretty_str() == test_input
assert ps == PlacementSpec.from_string(ps.pretty_str())
# Testing the old verbose way of generating json. Don't remove:
assert ret == HostPlacementSpec.from_json({
'hostname': ret.hostname,
'network': ret.network,
'name': ret.name
})
assert ret == HostPlacementSpec.from_json(ret.to_json())
def test_migrate_scheduler(cephadm_module: CephadmOrchestrator):
with with_host(cephadm_module, 'host1', refresh_hosts=False):
with with_host(cephadm_module, 'host2', refresh_hosts=False):
# emulate the old scheduler:
c = cephadm_module.apply_rgw(
ServiceSpec('rgw', 'r.z', placement=PlacementSpec(host_pattern='*', count=2))
)
assert wait(cephadm_module, c) == 'Scheduled rgw.r.z update...'
# with pytest.raises(OrchestratorError, match="cephadm migration still ongoing. Please wait, until the migration is complete."):
CephadmServe(cephadm_module)._apply_all_services()
cephadm_module.migration_current = 0
cephadm_module.migration.migrate()
# assert we need all daemons.
assert cephadm_module.migration_current == 0
CephadmServe(cephadm_module)._refresh_hosts_and_daemons()
receive_agent_metadata_all_hosts(cephadm_module)
cephadm_module.migration.migrate()
CephadmServe(cephadm_module)._apply_all_services()
out = {o.hostname for o in wait(cephadm_module, cephadm_module.list_daemons())}
assert out == {'host1', 'host2'}
c = cephadm_module.apply_rgw(
ServiceSpec('rgw', 'r.z', placement=PlacementSpec(host_pattern='host1', count=2))
)
assert wait(cephadm_module, c) == 'Scheduled rgw.r.z update...'
# Sorry, for this hack, but I need to make sure, Migration thinks,
# we have updated all daemons already.
cephadm_module.cache.last_daemon_update['host1'] = datetime_now()
cephadm_module.cache.last_daemon_update['host2'] = datetime_now()
cephadm_module.migration_current = 0
cephadm_module.migration.migrate()
assert cephadm_module.migration_current >= 2
out = [o.spec.placement for o in wait(
cephadm_module, cephadm_module.describe_service())]
assert out == [PlacementSpec(count=2, hosts=[HostPlacementSpec(
hostname='host1', network='', name=''), HostPlacementSpec(hostname='host2', network='', name='')])]
def convert_to_old_style_json(j):
j_c = dict(j.copy())
j_c.pop('service_name', None)
if 'spec' in j_c:
spec = j_c.pop('spec')
j_c.update(spec)
if 'placement' in j_c:
if 'hosts' in j_c['placement']:
j_c['placement']['hosts'] = [
{
'hostname': HostPlacementSpec.parse(h).hostname,
'network': HostPlacementSpec.parse(h).network,
'name': HostPlacementSpec.parse(h).name
}
for h in j_c['placement']['hosts']
]
j_c.pop('objectstore', None)
j_c.pop('filter_logic', None)
return j_c
def get_candidates(self) -> List[HostPlacementSpec]:
if self.spec.placement.hosts:
return self.spec.placement.hosts
elif self.spec.placement.label:
return [
HostPlacementSpec(x, '', '')
for x in self.get_hosts_func(label=self.spec.placement.label)
]
elif self.spec.placement.host_pattern:
return [
HostPlacementSpec(x, '', '') for x in
self.spec.placement.filter_matching_hosts(self.get_hosts_func)
]
if self.spec.placement.count is None:
raise OrchestratorValidationError(
"placement spec is empty: no hosts, no label, no pattern, no count"
)
# backward compatibility: consider an empty placements to be the same pattern = *
return [HostPlacementSpec(x, '', '') for x in self.get_hosts_func()]
def get_candidates(self) -> List[HostPlacementSpec]:
if self.spec.placement.hosts:
return self.spec.placement.hosts
elif self.spec.placement.label:
return [
HostPlacementSpec(x.hostname, '', '')
for x in self.hosts_by_label(self.spec.placement.label)
]
elif self.spec.placement.host_pattern:
return [
HostPlacementSpec(x, '', '') for x in
self.spec.placement.filter_matching_hostspecs(self.hosts)
]
# If none of the above and also no <count>
if self.spec.placement.count is None:
raise OrchestratorValidationError(
"placement spec is empty: no hosts, no label, no pattern, no count"
)
# backward compatibility: consider an empty placements to be the same pattern = *
return [HostPlacementSpec(x.hostname, '', '') for x in self.hosts]
def test_daemon_add_fail(self, _run_cephadm, cephadm_module):
_run_cephadm.return_value = '{}', '', 0
with with_host(cephadm_module, 'test'):
spec = ServiceSpec(service_type='mgr',
placement=PlacementSpec(
hosts=[HostPlacementSpec('test', '', 'x')],
count=1))
_run_cephadm.side_effect = OrchestratorError('fail')
with pytest.raises(OrchestratorError):
wait(cephadm_module, cephadm_module.add_mgr(spec))
cephadm_module.assert_issued_mon_command({
'prefix': 'auth rm',
'entity': 'mgr.x',
})
def get_candidates(self) -> List[HostPlacementSpec]:
if self.spec.placement.hosts:
hosts = self.spec.placement.hosts
elif self.spec.placement.label:
hosts = [
HostPlacementSpec(x.hostname, '', '')
for x in self.hosts_by_label(self.spec.placement.label)
]
elif self.spec.placement.host_pattern:
hosts = [
HostPlacementSpec(x, '', '') for x in
self.spec.placement.filter_matching_hostspecs(self.hosts)
]
elif (self.spec.placement.count is not None
or self.spec.placement.count_per_host is not None):
hosts = [HostPlacementSpec(x.hostname, '', '') for x in self.hosts]
else:
raise OrchestratorValidationError(
"placement spec is empty: no hosts, no label, no pattern, no count"
)
if self.filter_new_host:
old = hosts.copy()
hosts = [h for h in hosts if self.filter_new_host(h.hostname)]
for h in list(set(old) - set(hosts)):
logger.info(
f"Filtered out host {h.hostname}: could not verify host allowed virtual ips"
)
logger.debug('Filtered %s down to %s' % (old, hosts))
# shuffle for pseudo random selection
# gen seed off of self.spec to make shuffling deterministic
seed = hash(self.spec.service_name())
random.Random(seed).shuffle(hosts)
return hosts
class TestCephadm(object):
def test_get_unique_name(self, cephadm_module):
# type: (CephadmOrchestrator) -> None
existing = [DaemonDescription(daemon_type='mon', daemon_id='a')]
new_mon = cephadm_module.get_unique_name('mon', 'myhost', existing)
match_glob(new_mon, 'myhost')
new_mgr = cephadm_module.get_unique_name('mgr', 'myhost', existing)
match_glob(new_mgr, 'myhost.*')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_host(self, cephadm_module):
assert wait(cephadm_module, cephadm_module.get_hosts()) == []
with with_host(cephadm_module, 'test'):
assert wait(cephadm_module, cephadm_module.get_hosts()) == [
HostSpec('test', 'test')
]
# Be careful with backward compatibility when changing things here:
assert json.loads(cephadm_module._store['inventory']) == \
{"test": {"hostname": "test", "addr": "test", "labels": [], "status": ""}}
with with_host(cephadm_module, 'second'):
assert wait(cephadm_module, cephadm_module.get_hosts()) == [
HostSpec('test', 'test'),
HostSpec('second', 'second')
]
assert wait(cephadm_module, cephadm_module.get_hosts()) == [
HostSpec('test', 'test')
]
assert wait(cephadm_module, cephadm_module.get_hosts()) == []
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_service_ls(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.list_daemons(refresh=True)
assert wait(cephadm_module, c) == []
ps = PlacementSpec(hosts=['test'], count=1)
c = cephadm_module.add_mds(ServiceSpec('mds', 'name',
placement=ps))
[out] = wait(cephadm_module, c)
match_glob(out, "Deployed mds.name.* on host 'test'")
c = cephadm_module.list_daemons()
def remove_id(dd):
out = dd.to_json()
del out['daemon_id']
return out
assert [remove_id(dd) for dd in wait(cephadm_module, c)] == [{
'daemon_type':
'mds',
'hostname':
'test',
'status':
1,
'status_desc':
'starting'
}]
ps = PlacementSpec(hosts=['test'], count=1)
spec = ServiceSpec('rgw', 'r.z', placement=ps)
c = cephadm_module.apply_rgw(spec)
assert wait(cephadm_module, c) == 'Scheduled rgw.r.z update...'
c = cephadm_module.describe_service()
out = [dict(o.to_json()) for o in wait(cephadm_module, c)]
expected = [{
'placement': {
'hosts': [{
'hostname': 'test',
'name': '',
'network': ''
}]
},
'service_id': 'name',
'service_name': 'mds.name',
'service_type': 'mds',
'status': {
'running': 1,
'size': 0
},
'unmanaged': True
}, {
'placement': {
'count': 1,
'hosts': [{
'hostname': 'test',
'name': '',
'network': ''
}]
},
'spec': {
'rgw_realm': 'r',
'rgw_zone': 'z',
},
'service_id': 'r.z',
'service_name': 'rgw.r.z',
'service_type': 'rgw',
'status': {
'running': 0,
'size': 1
}
}]
assert out == expected
assert [
ServiceDescription.from_json(o).to_json() for o in expected
] == expected
assert_rm_service(cephadm_module, 'rgw.r.z')
assert_rm_daemon(cephadm_module, 'mds.name', 'test')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_device_ls(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.get_inventory()
assert wait(cephadm_module, c) == [InventoryHost('test')]
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps([
dict(
name='rgw.myrgw.foobar',
style='cephadm',
fsid='fsid',
container_id='container_id',
version='version',
state='running',
)
])))
def test_daemon_action(self, cephadm_module):
cephadm_module.service_cache_timeout = 10
with with_host(cephadm_module, 'test'):
c = cephadm_module.list_daemons(refresh=True)
wait(cephadm_module, c)
c = cephadm_module.daemon_action('redeploy', 'rgw', 'myrgw.foobar')
assert wait(cephadm_module,
c) == ["Deployed rgw.myrgw.foobar on host 'test'"]
for what in ('start', 'stop', 'restart'):
c = cephadm_module.daemon_action(what, 'rgw', 'myrgw.foobar')
assert wait(cephadm_module, c) == [
what + " rgw.myrgw.foobar from host 'test'"
]
assert_rm_daemon(cephadm_module, 'rgw.myrgw.foobar', 'test')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_mon_add(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test:0.0.0.0=a'], count=1)
c = cephadm_module.add_mon(ServiceSpec('mon', placement=ps))
assert wait(cephadm_module, c) == ["Deployed mon.a on host 'test'"]
with pytest.raises(
OrchestratorError,
match=
"Must set public_network config option or specify a CIDR network,"
):
ps = PlacementSpec(hosts=['test'], count=1)
c = cephadm_module.add_mon(ServiceSpec('mon', placement=ps))
wait(cephadm_module, c)
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_mgr_update(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test:0.0.0.0=a'], count=1)
r = cephadm_module._apply_service(ServiceSpec('mgr', placement=ps))
assert r
assert_rm_daemon(cephadm_module, 'mgr.a', 'test')
@mock.patch("cephadm.module.CephadmOrchestrator.mon_command")
def test_find_destroyed_osds(self, _mon_cmd, cephadm_module):
dict_out = {
"nodes": [{
"id": -1,
"name": "default",
"type": "root",
"type_id": 11,
"children": [-3]
}, {
"id": -3,
"name": "host1",
"type": "host",
"type_id": 1,
"pool_weights": {},
"children": [0]
}, {
"id": 0,
"device_class": "hdd",
"name": "osd.0",
"type": "osd",
"type_id": 0,
"crush_weight": 0.0243988037109375,
"depth": 2,
"pool_weights": {},
"exists": 1,
"status": "destroyed",
"reweight": 1,
"primary_affinity": 1
}],
"stray": []
}
json_out = json.dumps(dict_out)
_mon_cmd.return_value = (0, json_out, '')
out = cephadm_module.osd_service.find_destroyed_osds()
assert out == {'host1': ['0']}
@mock.patch("cephadm.module.CephadmOrchestrator.mon_command")
def test_find_destroyed_osds_cmd_failure(self, _mon_cmd, cephadm_module):
_mon_cmd.return_value = (1, "", "fail_msg")
with pytest.raises(OrchestratorError):
out = cephadm_module.osd_service.find_destroyed_osds()
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_apply_osd_save(self, _run_cephadm,
cephadm_module: CephadmOrchestrator):
_run_cephadm.return_value = ('{}', '', 0)
with with_host(cephadm_module, 'test'):
spec = DriveGroupSpec(service_id='foo',
placement=PlacementSpec(host_pattern='*', ),
data_devices=DeviceSelection(all=True))
c = cephadm_module.apply_drivegroups([spec])
assert wait(cephadm_module, c) == ['Scheduled osd.foo update...']
inventory = Devices([
Device('/dev/sdb', available=True),
])
cephadm_module.cache.update_host_devices_networks(
'test', inventory.devices, {})
_run_cephadm.return_value = (['{}'], '', 0)
assert cephadm_module._apply_all_services() == False
_run_cephadm.assert_any_call(
'test',
'osd',
'ceph-volume', [
'--config-json', '-', '--', 'lvm', 'prepare',
'--bluestore', '--data', '/dev/sdb', '--no-systemd'
],
env_vars=[],
error_ok=True,
stdin='{"config": "", "keyring": ""}')
_run_cephadm.assert_called_with(
'test', 'osd', 'ceph-volume',
['--', 'lvm', 'list', '--format', 'json'])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.module.SpecStore.save")
def test_apply_osd_save_placement(self, _save_spec, cephadm_module):
with with_host(cephadm_module, 'test'):
json_spec = {
'service_type': 'osd',
'placement': {
'host_pattern': 'test'
},
'service_id': 'foo',
'data_devices': {
'all': True
}
}
spec = ServiceSpec.from_json(json_spec)
assert isinstance(spec, DriveGroupSpec)
c = cephadm_module.apply_drivegroups([spec])
assert wait(cephadm_module, c) == ['Scheduled osd.foo update...']
_save_spec.assert_called_with(spec)
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_create_osds(self, cephadm_module):
with with_host(cephadm_module, 'test'):
dg = DriveGroupSpec(placement=PlacementSpec(host_pattern='test'),
data_devices=DeviceSelection(paths=['']))
c = cephadm_module.create_osds(dg)
out = wait(cephadm_module, c)
assert out == "Created no osd(s) on host test; already created?"
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_prepare_drivegroup(self, cephadm_module):
with with_host(cephadm_module, 'test'):
dg = DriveGroupSpec(placement=PlacementSpec(host_pattern='test'),
data_devices=DeviceSelection(paths=['']))
out = cephadm_module.osd_service.prepare_drivegroup(dg)
assert len(out) == 1
f1 = out[0]
assert f1[0] == 'test'
assert isinstance(f1[1], DriveSelection)
@pytest.mark.parametrize(
"devices, preview, exp_command",
[
# no preview and only one disk, prepare is used due the hack that is in place.
(['/dev/sda'], False,
"lvm prepare --bluestore --data /dev/sda --no-systemd"),
# no preview and multiple disks, uses batch
(['/dev/sda', '/dev/sdb'], False,
"CEPH_VOLUME_OSDSPEC_AFFINITY=test.spec lvm batch --no-auto /dev/sda /dev/sdb --yes --no-systemd"
),
# preview and only one disk needs to use batch again to generate the preview
(['/dev/sda'
], True, "lvm batch --no-auto /dev/sda --report --format json"),
# preview and multiple disks work the same
(['/dev/sda', '/dev/sdb'], True,
"CEPH_VOLUME_OSDSPEC_AFFINITY=test.spec lvm batch --no-auto /dev/sda /dev/sdb --yes --no-systemd --report --format json"
),
])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_driveselection_to_ceph_volume(self, cephadm_module, devices,
preview, exp_command):
with with_host(cephadm_module, 'test'):
dg = DriveGroupSpec(service_id='test.spec',
placement=PlacementSpec(host_pattern='test'),
data_devices=DeviceSelection(paths=devices))
ds = DriveSelection(dg,
Devices([Device(path) for path in devices]))
preview = preview
out = cephadm_module.osd_service.driveselection_to_ceph_volume(
ds, [], preview)
assert out in exp_command
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps([
dict(
name='osd.0',
style='cephadm',
fsid='fsid',
container_id='container_id',
version='version',
state='running',
)
])))
@mock.patch("cephadm.services.osd.RemoveUtil.get_pg_count",
lambda _, __: 0)
def test_remove_osds(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.list_daemons(refresh=True)
wait(cephadm_module, c)
c = cephadm_module.remove_daemons(['osd.0'])
out = wait(cephadm_module, c)
assert out == ["Removed osd.0 from host 'test'"]
osd_removal_op = OSDRemoval(0, False, False, 'test', 'osd.0',
datetime.datetime.utcnow(), -1)
cephadm_module.rm_util.queue_osds_for_removal({osd_removal_op})
cephadm_module.rm_util._remove_osds_bg()
assert cephadm_module.rm_util.to_remove_osds == set()
c = cephadm_module.remove_osds_status()
out = wait(cephadm_module, c)
assert out == set()
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_rgw_update(self, cephadm_module):
with with_host(cephadm_module, 'host1'):
with with_host(cephadm_module, 'host2'):
ps = PlacementSpec(hosts=['host1'], count=1)
c = cephadm_module.add_rgw(
RGWSpec(rgw_realm='realm', rgw_zone='zone1', placement=ps))
[out] = wait(cephadm_module, c)
match_glob(out,
"Deployed rgw.realm.zone1.host1.* on host 'host1'")
ps = PlacementSpec(hosts=['host1', 'host2'], count=2)
r = cephadm_module._apply_service(
RGWSpec(rgw_realm='realm', rgw_zone='zone1', placement=ps))
assert r
assert_rm_daemon(cephadm_module, 'rgw.realm.zone1', 'host1')
assert_rm_daemon(cephadm_module, 'rgw.realm.zone1', 'host2')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps([
dict(
name='rgw.myrgw.myhost.myid',
style='cephadm',
fsid='fsid',
container_id='container_id',
version='version',
state='running',
)
])))
def test_remove_daemon(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.list_daemons(refresh=True)
wait(cephadm_module, c)
c = cephadm_module.remove_daemons(['rgw.myrgw.myhost.myid'])
out = wait(cephadm_module, c)
assert out == ["Removed rgw.myrgw.myhost.myid from host 'test'"]
@pytest.mark.parametrize("spec, meth", [
(ServiceSpec('crash'), CephadmOrchestrator.add_crash),
(ServiceSpec('prometheus'), CephadmOrchestrator.add_prometheus),
(ServiceSpec('grafana'), CephadmOrchestrator.add_grafana),
(ServiceSpec('node-exporter'), CephadmOrchestrator.add_node_exporter),
(ServiceSpec('alertmanager'), CephadmOrchestrator.add_alertmanager),
(ServiceSpec('rbd-mirror'), CephadmOrchestrator.add_rbd_mirror),
(ServiceSpec('mds', service_id='fsname'), CephadmOrchestrator.add_mds),
(RGWSpec(rgw_realm='realm',
rgw_zone='zone'), CephadmOrchestrator.add_rgw),
])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_daemon_add(self, spec: ServiceSpec, meth, cephadm_module):
with with_host(cephadm_module, 'test'):
spec.placement = PlacementSpec(hosts=['test'], count=1)
c = meth(cephadm_module, spec)
[out] = wait(cephadm_module, c)
match_glob(out, f"Deployed {spec.service_name()}.* on host 'test'")
assert_rm_daemon(cephadm_module, spec.service_name(), 'test')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.module.CephadmOrchestrator.rados", mock.MagicMock())
def test_nfs(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test'], count=1)
spec = NFSServiceSpec(service_id='name',
pool='pool',
namespace='namespace',
placement=ps)
c = cephadm_module.add_nfs(spec)
[out] = wait(cephadm_module, c)
match_glob(out, "Deployed nfs.name.* on host 'test'")
assert_rm_daemon(cephadm_module, 'nfs.name.test', 'test')
# Hack. We never created the service, but we now need to remove it.
# this is in contrast to the other services, which don't create this service
# automatically.
assert_rm_service(cephadm_module, 'nfs.name')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.module.CephadmOrchestrator.rados", mock.MagicMock())
def test_iscsi(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test'], count=1)
spec = IscsiServiceSpec(service_id='name',
pool='pool',
api_user='******',
api_password='******',
placement=ps)
c = cephadm_module.add_iscsi(spec)
[out] = wait(cephadm_module, c)
match_glob(out, "Deployed iscsi.name.* on host 'test'")
assert_rm_daemon(cephadm_module, 'iscsi.name.test', 'test')
# Hack. We never created the service, but we now need to remove it.
# this is in contrast to the other services, which don't create this service
# automatically.
assert_rm_service(cephadm_module, 'iscsi.name')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_blink_device_light(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.blink_device_light('ident', True,
[('test', '', '')])
assert wait(cephadm_module, c) == ['Set ident light for test: on']
@pytest.mark.parametrize("spec, meth", [
(ServiceSpec('mgr'), CephadmOrchestrator.apply_mgr),
(ServiceSpec('crash'), CephadmOrchestrator.apply_crash),
(ServiceSpec('prometheus'), CephadmOrchestrator.apply_prometheus),
(ServiceSpec('grafana'), CephadmOrchestrator.apply_grafana),
(ServiceSpec('node-exporter'),
CephadmOrchestrator.apply_node_exporter),
(ServiceSpec('alertmanager'), CephadmOrchestrator.apply_alertmanager),
(ServiceSpec('rbd-mirror'), CephadmOrchestrator.apply_rbd_mirror),
(ServiceSpec('mds',
service_id='fsname'), CephadmOrchestrator.apply_mds),
(ServiceSpec(
'mds',
service_id='fsname',
placement=PlacementSpec(hosts=[
HostPlacementSpec(hostname='test', name='fsname', network='')
])), CephadmOrchestrator.apply_mds),
(RGWSpec(rgw_realm='realm',
rgw_zone='zone'), CephadmOrchestrator.apply_rgw),
(RGWSpec(rgw_realm='realm',
rgw_zone='zone',
placement=PlacementSpec(hosts=[
HostPlacementSpec(
hostname='test', name='realm.zone.a', network='')
])), CephadmOrchestrator.apply_rgw),
(NFSServiceSpec(service_id='name', pool='pool',
namespace='namespace'), CephadmOrchestrator.apply_nfs),
(IscsiServiceSpec(
service_id='name',
pool='pool',
api_user='******',
api_password='******'), CephadmOrchestrator.apply_iscsi),
])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_apply_save(self, spec: ServiceSpec, meth,
cephadm_module: CephadmOrchestrator):
with with_host(cephadm_module, 'test'):
if not spec.placement:
spec.placement = PlacementSpec(hosts=['test'], count=1)
c = meth(cephadm_module, spec)
assert wait(cephadm_module,
c) == f'Scheduled {spec.service_name()} update...'
assert [
d.spec for d in wait(cephadm_module,
cephadm_module.describe_service())
] == [spec]
cephadm_module._apply_all_services()
dds = wait(cephadm_module, cephadm_module.list_daemons())
for dd in dds:
assert dd.service_name() == spec.service_name()
assert_rm_service(cephadm_module, spec.service_name())
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.services.cephadmservice.CephadmService.ok_to_stop")
def test_daemon_ok_to_stop(self, ok_to_stop,
cephadm_module: CephadmOrchestrator):
spec = ServiceSpec('mds',
service_id='fsname',
placement=PlacementSpec(hosts=['host1', 'host2']))
with with_host(cephadm_module,
'host1'), with_host(cephadm_module, 'host2'):
c = cephadm_module.apply_mds(spec)
out = wait(cephadm_module, c)
match_glob(out, "Scheduled mds.fsname update...")
cephadm_module._apply_all_services()
[daemon] = cephadm_module.cache.daemons['host1'].keys()
spec.placement.set_hosts(['host2'])
ok_to_stop.side_effect = False
c = cephadm_module.apply_mds(spec)
out = wait(cephadm_module, c)
match_glob(out, "Scheduled mds.fsname update...")
cephadm_module._apply_all_services()
ok_to_stop.assert_called_with([daemon[4:]])
assert_rm_daemon(cephadm_module, spec.service_name(),
'host1') # verifies ok-to-stop
assert_rm_daemon(cephadm_module, spec.service_name(), 'host2')
@mock.patch("cephadm.module.CephadmOrchestrator._get_connection")
@mock.patch("remoto.process.check")
def test_offline(self, _check, _get_connection, cephadm_module):
_check.return_value = '{}', '', 0
_get_connection.return_value = mock.Mock(), mock.Mock()
with with_host(cephadm_module, 'test'):
_get_connection.side_effect = HostNotFound
code, out, err = cephadm_module.check_host('test')
assert out == ''
assert 'Failed to connect to test (test)' in err
out = wait(cephadm_module, cephadm_module.get_hosts())[0].to_json()
assert out == HostSpec('test', 'test', status='Offline').to_json()
_get_connection.side_effect = None
assert cephadm_module._check_host('test') is None
out = wait(cephadm_module, cephadm_module.get_hosts())[0].to_json()
assert out == HostSpec('test', 'test').to_json()
def test_stale_connections(self, cephadm_module):
class Connection(object):
"""
A mocked connection class that only allows the use of the connection
once. If you attempt to use it again via a _check, it'll explode (go
boom!).
The old code triggers the boom. The new code checks the has_connection
and will recreate the connection.
"""
fuse = False
@staticmethod
def has_connection():
return False
def import_module(self, *args, **kargs):
return mock.Mock()
@staticmethod
def exit():
pass
def _check(conn, *args, **kargs):
if conn.fuse:
raise Exception("boom: connection is dead")
else:
conn.fuse = True
return '{}', None, 0
with mock.patch("remoto.Connection",
side_effect=[Connection(),
Connection(),
Connection()]):
with mock.patch("remoto.process.check", _check):
with with_host(cephadm_module, 'test'):
code, out, err = cephadm_module.check_host('test')
# First should succeed.
assert err is None
# On second it should attempt to reuse the connection, where the
# connection is "down" so will recreate the connection. The old
# code will blow up here triggering the BOOM!
code, out, err = cephadm_module.check_host('test')
assert err is None
def test_placement_target_size(p, hosts, size):
assert p.get_target_count([HostPlacementSpec(n, '', '')
for n in hosts]) == size
def test_parse_host_placement_specs_raises_wrong_format(test_input):
with pytest.raises(ValueError):
HostPlacementSpec.parse(test_input)
def test_parse_host_placement_specs_raises(test_input):
with pytest.raises(ValueError):
ret = HostPlacementSpec.parse(test_input)
def test_parse_host_placement_specs(test_input, expected, require_network):
ret = HostPlacementSpec.parse(test_input, require_network=require_network)
assert ret == expected
assert str(ret) == test_input
def to_hostname(d: DaemonDescription) -> HostPlacementSpec:
if d.hostname in old_hosts:
return old_hosts[d.hostname]
else:
assert d.hostname
return HostPlacementSpec(d.hostname, '', '')
class TestCephadm(object):
def test_get_unique_name(self, cephadm_module):
# type: (CephadmOrchestrator) -> None
existing = [DaemonDescription(daemon_type='mon', daemon_id='a')]
new_mon = cephadm_module.get_unique_name('mon', 'myhost', existing)
match_glob(new_mon, 'myhost')
new_mgr = cephadm_module.get_unique_name('mgr', 'myhost', existing)
match_glob(new_mgr, 'myhost.*')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_host(self, cephadm_module):
assert wait(cephadm_module, cephadm_module.get_hosts()) == []
with with_host(cephadm_module, 'test'):
assert wait(cephadm_module, cephadm_module.get_hosts()) == [
HostSpec('test', 'test')
]
# Be careful with backward compatibility when changing things here:
assert json.loads(cephadm_module.get_store('inventory')) == \
{"test": {"hostname": "test", "addr": "test", "labels": [], "status": ""}}
with with_host(cephadm_module, 'second'):
assert wait(cephadm_module, cephadm_module.get_hosts()) == [
HostSpec('test', 'test'),
HostSpec('second', 'second')
]
assert wait(cephadm_module, cephadm_module.get_hosts()) == [
HostSpec('test', 'test')
]
assert wait(cephadm_module, cephadm_module.get_hosts()) == []
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
@mock.patch(
"cephadm.services.cephadmservice.RgwService.create_realm_zonegroup_zone",
lambda _, __, ___: None)
def test_service_ls(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.list_daemons(refresh=True)
assert wait(cephadm_module, c) == []
with with_daemon(cephadm_module, ServiceSpec('mds', 'name'),
CephadmOrchestrator.add_mds, 'test'):
c = cephadm_module.list_daemons()
def remove_id_events(dd):
out = dd.to_json()
del out['daemon_id']
del out['events']
return out
assert [
remove_id_events(dd) for dd in wait(cephadm_module, c)
] == [{
'daemon_type': 'mds',
'hostname': 'test',
'status': 1,
'status_desc': 'starting',
'is_active': False
}]
with with_service(cephadm_module, ServiceSpec('rgw', 'r.z'),
CephadmOrchestrator.apply_rgw, 'test'):
c = cephadm_module.describe_service()
out = [dict(o.to_json()) for o in wait(cephadm_module, c)]
expected = [{
'placement': {
'hosts': ['test']
},
'service_id': 'name',
'service_name': 'mds.name',
'service_type': 'mds',
'status': {
'running': 1,
'size': 0
},
'unmanaged': True
}, {
'placement': {
'count': 1,
'hosts': ["test"]
},
'spec': {
'rgw_realm': 'r',
'rgw_zone': 'z',
},
'service_id': 'r.z',
'service_name': 'rgw.r.z',
'service_type': 'rgw',
'status': {
'created': mock.ANY,
'running': 1,
'size': 1
},
}]
for o in out:
if 'events' in o:
del o[
'events'] # delete it, as it contains a timestamp
assert out == expected
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_device_ls(self, cephadm_module):
with with_host(cephadm_module, 'test'):
c = cephadm_module.get_inventory()
assert wait(cephadm_module, c) == [InventoryHost('test')]
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps([
dict(
name='rgw.myrgw.foobar',
style='cephadm',
fsid='fsid',
container_id='container_id',
version='version',
state='running',
)
])))
def test_list_daemons(self, cephadm_module: CephadmOrchestrator):
cephadm_module.service_cache_timeout = 10
with with_host(cephadm_module, 'test'):
CephadmServe(cephadm_module)._refresh_host_daemons('test')
c = cephadm_module.list_daemons()
assert wait(cephadm_module, c)[0].name() == 'rgw.myrgw.foobar'
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
@mock.patch(
"cephadm.services.cephadmservice.RgwService.create_realm_zonegroup_zone",
lambda _, __, ___: None)
def test_daemon_action(self, cephadm_module: CephadmOrchestrator):
cephadm_module.service_cache_timeout = 10
with with_host(cephadm_module, 'test'):
with with_daemon(cephadm_module,
RGWSpec(service_id='myrgw.foobar'),
CephadmOrchestrator.add_rgw, 'test') as daemon_id:
c = cephadm_module.daemon_action('redeploy',
'rgw.' + daemon_id)
assert wait(
cephadm_module, c
) == f"Scheduled to redeploy rgw.{daemon_id} on host 'test'"
for what in ('start', 'stop', 'restart'):
c = cephadm_module.daemon_action(what, 'rgw.' + daemon_id)
assert wait(
cephadm_module, c
) == F"Scheduled to {what} rgw.{daemon_id} on host 'test'"
# Make sure, _check_daemons does a redeploy due to monmap change:
cephadm_module._store['_ceph_get/mon_map'] = {
'modified':
datetime.datetime.utcnow().strftime(CEPH_DATEFMT),
'fsid': 'foobar',
}
cephadm_module.notify('mon_map', None)
CephadmServe(cephadm_module)._check_daemons()
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
@mock.patch(
"cephadm.services.cephadmservice.RgwService.create_realm_zonegroup_zone",
lambda _, __, ___: None)
def test_daemon_action_fail(self, cephadm_module: CephadmOrchestrator):
cephadm_module.service_cache_timeout = 10
with with_host(cephadm_module, 'test'):
with with_daemon(cephadm_module,
RGWSpec(service_id='myrgw.foobar'),
CephadmOrchestrator.add_rgw, 'test') as daemon_id:
with mock.patch('ceph_module.BaseMgrModule._ceph_send_command'
) as _ceph_send_command:
_ceph_send_command.side_effect = Exception("myerror")
# Make sure, _check_daemons does a redeploy due to monmap change:
cephadm_module.mock_store_set(
'_ceph_get', 'mon_map', {
'modified':
datetime.datetime.utcnow().strftime(CEPH_DATEFMT),
'fsid':
'foobar',
})
cephadm_module.notify('mon_map', None)
CephadmServe(cephadm_module)._check_daemons()
evs = [
e.message
for e in cephadm_module.events.get_for_daemon(
f'rgw.{daemon_id}')
]
assert 'myerror' in ''.join(evs)
@pytest.mark.parametrize(
"action", ['start', 'stop', 'restart', 'reconfig', 'redeploy'])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_daemon_check(self, cephadm_module: CephadmOrchestrator, action):
with with_host(cephadm_module, 'test'):
with with_service(cephadm_module,
ServiceSpec(service_type='grafana'),
CephadmOrchestrator.apply_grafana,
'test') as d_names:
[daemon_name] = d_names
cephadm_module._schedule_daemon_action(daemon_name, action)
assert cephadm_module.cache.get_scheduled_daemon_action(
'test', daemon_name) == action
CephadmServe(cephadm_module)._check_daemons()
assert cephadm_module.cache.get_scheduled_daemon_action(
'test', daemon_name) is None
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_daemon_check_extra_config(self, _run_cephadm,
cephadm_module: CephadmOrchestrator):
_run_cephadm.return_value = ('{}', '', 0)
with with_host(cephadm_module, 'test'):
# Also testing deploying mons without explicit network placement
cephadm_module.check_mon_command({
'prefix': 'config set',
'who': 'mon',
'name': 'public_network',
'value': '127.0.0.0/8'
})
cephadm_module.cache.update_host_devices_networks(
'test', [], {
"127.0.0.0/8": ["127.0.0.1"],
})
with with_service(cephadm_module, ServiceSpec(service_type='mon'),
CephadmOrchestrator.apply_mon,
'test') as d_names:
[daemon_name] = d_names
cephadm_module._set_extra_ceph_conf('[mon]\nk=v')
CephadmServe(cephadm_module)._check_daemons()
_run_cephadm.assert_called_with(
'test',
'mon.test',
'deploy',
['--name', 'mon.test', '--reconfig', '--config-json', '-'],
stdin='{"config": "\\n\\n[mon]\\nk=v\\n", "keyring": ""}',
image='')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_daemon_check_post(self, cephadm_module: CephadmOrchestrator):
with with_host(cephadm_module, 'test'):
with with_service(cephadm_module,
ServiceSpec(service_type='grafana'),
CephadmOrchestrator.apply_grafana, 'test'):
# Make sure, _check_daemons does a redeploy due to monmap change:
cephadm_module.mock_store_set(
'_ceph_get', 'mon_map', {
'modified':
datetime.datetime.utcnow().strftime(CEPH_DATEFMT),
'fsid':
'foobar',
})
cephadm_module.notify('mon_map', None)
cephadm_module.mock_store_set('_ceph_get', 'mgr_map',
{'modules': ['dashboard']})
with mock.patch(
"cephadm.module.CephadmOrchestrator.mon_command"
) as _mon_cmd:
CephadmServe(cephadm_module)._check_daemons()
_mon_cmd.assert_any_call({
'prefix': 'dashboard set-grafana-api-url',
'value': 'https://*****:*****@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_mon_add(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test:0.0.0.0=a'], count=1)
c = cephadm_module.add_mon(ServiceSpec('mon', placement=ps))
assert wait(cephadm_module, c) == ["Deployed mon.a on host 'test'"]
with pytest.raises(
OrchestratorError,
match=
"Must set public_network config option or specify a CIDR network,"
):
ps = PlacementSpec(hosts=['test'], count=1)
c = cephadm_module.add_mon(ServiceSpec('mon', placement=ps))
wait(cephadm_module, c)
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('[]'))
def test_mgr_update(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test:0.0.0.0=a'], count=1)
r = CephadmServe(cephadm_module)._apply_service(
ServiceSpec('mgr', placement=ps))
assert r
assert_rm_daemon(cephadm_module, 'mgr.a', 'test')
@mock.patch("cephadm.module.CephadmOrchestrator.mon_command")
def test_find_destroyed_osds(self, _mon_cmd, cephadm_module):
dict_out = {
"nodes": [{
"id": -1,
"name": "default",
"type": "root",
"type_id": 11,
"children": [-3]
}, {
"id": -3,
"name": "host1",
"type": "host",
"type_id": 1,
"pool_weights": {},
"children": [0]
}, {
"id": 0,
"device_class": "hdd",
"name": "osd.0",
"type": "osd",
"type_id": 0,
"crush_weight": 0.0243988037109375,
"depth": 2,
"pool_weights": {},
"exists": 1,
"status": "destroyed",
"reweight": 1,
"primary_affinity": 1
}],
"stray": []
}
json_out = json.dumps(dict_out)
_mon_cmd.return_value = (0, json_out, '')
out = cephadm_module.osd_service.find_destroyed_osds()
assert out == {'host1': ['0']}
@mock.patch("cephadm.module.CephadmOrchestrator.mon_command")
def test_find_destroyed_osds_cmd_failure(self, _mon_cmd, cephadm_module):
_mon_cmd.return_value = (1, "", "fail_msg")
with pytest.raises(OrchestratorError):
out = cephadm_module.osd_service.find_destroyed_osds()
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_apply_osd_save(self, _run_cephadm,
cephadm_module: CephadmOrchestrator):
_run_cephadm.return_value = ('{}', '', 0)
with with_host(cephadm_module, 'test'):
spec = DriveGroupSpec(service_id='foo',
placement=PlacementSpec(host_pattern='*', ),
data_devices=DeviceSelection(all=True))
c = cephadm_module.apply([spec])
assert wait(cephadm_module, c) == ['Scheduled osd.foo update...']
inventory = Devices([
Device('/dev/sdb', available=True),
])
cephadm_module.cache.update_host_devices_networks(
'test', inventory.devices, {})
_run_cephadm.return_value = (['{}'], '', 0)
assert CephadmServe(cephadm_module)._apply_all_services() == False
_run_cephadm.assert_any_call(
'test',
'osd',
'ceph-volume', [
'--config-json', '-', '--', 'lvm', 'batch', '--no-auto',
'/dev/sdb', '--yes', '--no-systemd'
],
env_vars=['CEPH_VOLUME_OSDSPEC_AFFINITY=foo'],
error_ok=True,
stdin='{"config": "", "keyring": ""}')
_run_cephadm.assert_called_with(
'test', 'osd', 'ceph-volume',
['--', 'lvm', 'list', '--format', 'json'])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.module.SpecStore.save")
def test_apply_osd_save_placement(self, _save_spec, cephadm_module):
with with_host(cephadm_module, 'test'):
json_spec = {
'service_type': 'osd',
'placement': {
'host_pattern': 'test'
},
'service_id': 'foo',
'data_devices': {
'all': True
}
}
spec = ServiceSpec.from_json(json_spec)
assert isinstance(spec, DriveGroupSpec)
c = cephadm_module.apply([spec])
assert wait(cephadm_module, c) == ['Scheduled osd.foo update...']
_save_spec.assert_called_with(spec)
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_create_osds(self, cephadm_module):
with with_host(cephadm_module, 'test'):
dg = DriveGroupSpec(placement=PlacementSpec(host_pattern='test'),
data_devices=DeviceSelection(paths=['']))
c = cephadm_module.create_osds(dg)
out = wait(cephadm_module, c)
assert out == "Created no osd(s) on host test; already created?"
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_prepare_drivegroup(self, cephadm_module):
with with_host(cephadm_module, 'test'):
dg = DriveGroupSpec(placement=PlacementSpec(host_pattern='test'),
data_devices=DeviceSelection(paths=['']))
out = cephadm_module.osd_service.prepare_drivegroup(dg)
assert len(out) == 1
f1 = out[0]
assert f1[0] == 'test'
assert isinstance(f1[1], DriveSelection)
@pytest.mark.parametrize(
"devices, preview, exp_command",
[
# no preview and only one disk, prepare is used due the hack that is in place.
(['/dev/sda'
], False, "lvm batch --no-auto /dev/sda --yes --no-systemd"),
# no preview and multiple disks, uses batch
(['/dev/sda', '/dev/sdb'], False,
"CEPH_VOLUME_OSDSPEC_AFFINITY=test.spec lvm batch --no-auto /dev/sda /dev/sdb --yes --no-systemd"
),
# preview and only one disk needs to use batch again to generate the preview
(['/dev/sda'], True,
"lvm batch --no-auto /dev/sda --yes --no-systemd --report --format json"
),
# preview and multiple disks work the same
(['/dev/sda', '/dev/sdb'], True,
"CEPH_VOLUME_OSDSPEC_AFFINITY=test.spec lvm batch --no-auto /dev/sda /dev/sdb --yes --no-systemd --report --format json"
),
])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
def test_driveselection_to_ceph_volume(self, cephadm_module, devices,
preview, exp_command):
with with_host(cephadm_module, 'test'):
dg = DriveGroupSpec(service_id='test.spec',
placement=PlacementSpec(host_pattern='test'),
data_devices=DeviceSelection(paths=devices))
ds = DriveSelection(dg,
Devices([Device(path) for path in devices]))
preview = preview
out = cephadm_module.osd_service.driveselection_to_ceph_volume(
ds, [], preview)
assert out in exp_command
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps([
dict(
name='osd.0',
style='cephadm',
fsid='fsid',
container_id='container_id',
version='version',
state='running',
)
])))
@mock.patch("cephadm.services.osd.OSD.exists", True)
@mock.patch("cephadm.services.osd.RemoveUtil.get_pg_count",
lambda _, __: 0)
def test_remove_osds(self, cephadm_module):
with with_host(cephadm_module, 'test'):
CephadmServe(cephadm_module)._refresh_host_daemons('test')
c = cephadm_module.list_daemons()
wait(cephadm_module, c)
c = cephadm_module.remove_daemons(['osd.0'])
out = wait(cephadm_module, c)
assert out == ["Removed osd.0 from host 'test'"]
cephadm_module.to_remove_osds.enqueue(
OSD(osd_id=0,
replace=False,
force=False,
hostname='test',
fullname='osd.0',
process_started_at=datetime.datetime.utcnow(),
remove_util=cephadm_module.rm_util))
cephadm_module.rm_util.process_removal_queue()
assert cephadm_module.to_remove_osds == OSDQueue()
c = cephadm_module.remove_osds_status()
out = wait(cephadm_module, c)
assert out == []
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch(
"cephadm.services.cephadmservice.RgwService.create_realm_zonegroup_zone",
lambda _, __, ___: None)
def test_rgw_update(self, cephadm_module):
with with_host(cephadm_module, 'host1'):
with with_host(cephadm_module, 'host2'):
ps = PlacementSpec(hosts=['host1'], count=1)
c = cephadm_module.add_rgw(
RGWSpec(rgw_realm='realm', rgw_zone='zone1', placement=ps))
[out] = wait(cephadm_module, c)
match_glob(out,
"Deployed rgw.realm.zone1.host1.* on host 'host1'")
ps = PlacementSpec(hosts=['host1', 'host2'], count=2)
r = CephadmServe(cephadm_module)._apply_service(
RGWSpec(rgw_realm='realm', rgw_zone='zone1', placement=ps))
assert r
assert_rm_daemon(cephadm_module, 'rgw.realm.zone1', 'host1')
assert_rm_daemon(cephadm_module, 'rgw.realm.zone1', 'host2')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps([
dict(
name='rgw.myrgw.myhost.myid',
style='cephadm',
fsid='fsid',
container_id='container_id',
version='version',
state='running',
)
])))
def test_remove_daemon(self, cephadm_module):
with with_host(cephadm_module, 'test'):
CephadmServe(cephadm_module)._refresh_host_daemons('test')
c = cephadm_module.list_daemons()
wait(cephadm_module, c)
c = cephadm_module.remove_daemons(['rgw.myrgw.myhost.myid'])
out = wait(cephadm_module, c)
assert out == ["Removed rgw.myrgw.myhost.myid from host 'test'"]
@pytest.mark.parametrize("spec, meth", [
(ServiceSpec('crash'), CephadmOrchestrator.add_crash),
(ServiceSpec('prometheus'), CephadmOrchestrator.add_prometheus),
(ServiceSpec('grafana'), CephadmOrchestrator.add_grafana),
(ServiceSpec('node-exporter'), CephadmOrchestrator.add_node_exporter),
(ServiceSpec('alertmanager'), CephadmOrchestrator.add_alertmanager),
(ServiceSpec('rbd-mirror'), CephadmOrchestrator.add_rbd_mirror),
(ServiceSpec('mds', service_id='fsname'), CephadmOrchestrator.add_mds),
(RGWSpec(rgw_realm='realm',
rgw_zone='zone'), CephadmOrchestrator.add_rgw),
])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch(
"cephadm.services.cephadmservice.RgwService.create_realm_zonegroup_zone",
lambda _, __, ___: None)
def test_daemon_add(self, spec: ServiceSpec, meth, cephadm_module):
with with_host(cephadm_module, 'test'):
with with_daemon(cephadm_module, spec, meth, 'test'):
pass
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.module.CephadmOrchestrator.rados", mock.MagicMock())
def test_nfs(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test'], count=1)
spec = NFSServiceSpec(service_id='name',
pool='pool',
namespace='namespace',
placement=ps)
c = cephadm_module.add_nfs(spec)
[out] = wait(cephadm_module, c)
match_glob(out, "Deployed nfs.name.* on host 'test'")
assert_rm_daemon(cephadm_module, 'nfs.name.test', 'test')
# Hack. We never created the service, but we now need to remove it.
# this is in contrast to the other services, which don't create this service
# automatically.
assert_rm_service(cephadm_module, 'nfs.name')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.module.CephadmOrchestrator.rados", mock.MagicMock())
def test_iscsi(self, cephadm_module):
with with_host(cephadm_module, 'test'):
ps = PlacementSpec(hosts=['test'], count=1)
spec = IscsiServiceSpec(service_id='name',
pool='pool',
api_user='******',
api_password='******',
placement=ps)
c = cephadm_module.add_iscsi(spec)
[out] = wait(cephadm_module, c)
match_glob(out, "Deployed iscsi.name.* on host 'test'")
assert_rm_daemon(cephadm_module, 'iscsi.name.test', 'test')
# Hack. We never created the service, but we now need to remove it.
# this is in contrast to the other services, which don't create this service
# automatically.
assert_rm_service(cephadm_module, 'iscsi.name')
@pytest.mark.parametrize("on_bool", [True, False])
@pytest.mark.parametrize("fault_ident", ['fault', 'ident'])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_blink_device_light(self, _run_cephadm, on_bool, fault_ident,
cephadm_module):
_run_cephadm.return_value = '{}', '', 0
with with_host(cephadm_module, 'test'):
c = cephadm_module.blink_device_light(fault_ident, on_bool,
[('test', '', 'dev')])
on_off = 'on' if on_bool else 'off'
assert wait(cephadm_module,
c) == [f'Set {fault_ident} light for test: {on_off}']
_run_cephadm.assert_called_with(
'test',
'osd',
'shell', [
'--', 'lsmcli', f'local-disk-{fault_ident}-led-{on_off}',
'--path', 'dev'
],
error_ok=True)
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_blink_device_light_custom(self, _run_cephadm, cephadm_module):
_run_cephadm.return_value = '{}', '', 0
with with_host(cephadm_module, 'test'):
cephadm_module.set_store('blink_device_light_cmd', 'echo hello')
c = cephadm_module.blink_device_light('ident', True,
[('test', '', '/dev/sda')])
assert wait(cephadm_module, c) == ['Set ident light for test: on']
_run_cephadm.assert_called_with('test',
'osd',
'shell', ['--', 'echo', 'hello'],
error_ok=True)
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_blink_device_light_custom_per_host(self, _run_cephadm,
cephadm_module):
_run_cephadm.return_value = '{}', '', 0
with with_host(cephadm_module, 'mgr0'):
cephadm_module.set_store(
'mgr0/blink_device_light_cmd',
'xyz --foo --{{ ident_fault }}={{\'on\' if on else \'off\'}} \'{{ path or dev }}\''
)
c = cephadm_module.blink_device_light(
'fault', True,
[('mgr0', 'SanDisk_X400_M.2_2280_512GB_162924424784', '')])
assert wait(cephadm_module, c) == [
'Set fault light for mgr0:SanDisk_X400_M.2_2280_512GB_162924424784 on'
]
_run_cephadm.assert_called_with(
'mgr0',
'osd',
'shell', [
'--', 'xyz', '--foo', '--fault=on',
'SanDisk_X400_M.2_2280_512GB_162924424784'
],
error_ok=True)
@pytest.mark.parametrize("spec, meth", [
(ServiceSpec('mgr'), CephadmOrchestrator.apply_mgr),
(ServiceSpec('crash'), CephadmOrchestrator.apply_crash),
(ServiceSpec('prometheus'), CephadmOrchestrator.apply_prometheus),
(ServiceSpec('grafana'), CephadmOrchestrator.apply_grafana),
(ServiceSpec('node-exporter'),
CephadmOrchestrator.apply_node_exporter),
(ServiceSpec('alertmanager'), CephadmOrchestrator.apply_alertmanager),
(ServiceSpec('rbd-mirror'), CephadmOrchestrator.apply_rbd_mirror),
(ServiceSpec('mds',
service_id='fsname'), CephadmOrchestrator.apply_mds),
(ServiceSpec(
'mds',
service_id='fsname',
placement=PlacementSpec(hosts=[
HostPlacementSpec(hostname='test', name='fsname', network='')
])), CephadmOrchestrator.apply_mds),
(RGWSpec(rgw_realm='realm',
rgw_zone='zone'), CephadmOrchestrator.apply_rgw),
(RGWSpec(rgw_realm='realm',
rgw_zone='zone',
placement=PlacementSpec(hosts=[
HostPlacementSpec(
hostname='test', name='realm.zone.a', network='')
])), CephadmOrchestrator.apply_rgw),
(NFSServiceSpec(service_id='name', pool='pool',
namespace='namespace'), CephadmOrchestrator.apply_nfs),
(IscsiServiceSpec(
service_id='name',
pool='pool',
api_user='******',
api_password='******'), CephadmOrchestrator.apply_iscsi),
(CustomContainerSpec(service_id='hello-world',
image='docker.io/library/hello-world:latest',
uid=65534,
gid=65534,
dirs=['foo/bar'],
files={'foo/bar/xyz.conf': 'aaa\nbbb'},
bind_mounts=[[
'type=bind', 'source=lib/modules',
'destination=/lib/modules', 'ro=true'
]],
volume_mounts={'foo/bar': '/foo/bar:Z'},
args=['--no-healthcheck'],
envs=['SECRET=password'],
ports=[8080, 8443
]), CephadmOrchestrator.apply_container),
])
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch(
"cephadm.services.cephadmservice.RgwService.create_realm_zonegroup_zone",
lambda _, __, ___: None)
def test_apply_save(self, spec: ServiceSpec, meth,
cephadm_module: CephadmOrchestrator):
with with_host(cephadm_module, 'test'):
with with_service(cephadm_module, spec, meth, 'test'):
pass
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm('{}'))
@mock.patch("cephadm.services.cephadmservice.CephadmService.ok_to_stop")
def test_daemon_ok_to_stop(self, ok_to_stop,
cephadm_module: CephadmOrchestrator):
spec = ServiceSpec('mds',
service_id='fsname',
placement=PlacementSpec(hosts=['host1', 'host2']))
with with_host(cephadm_module,
'host1'), with_host(cephadm_module, 'host2'):
c = cephadm_module.apply_mds(spec)
out = wait(cephadm_module, c)
match_glob(out, "Scheduled mds.fsname update...")
CephadmServe(cephadm_module)._apply_all_services()
[daemon] = cephadm_module.cache.daemons['host1'].keys()
spec.placement.set_hosts(['host2'])
ok_to_stop.side_effect = False
c = cephadm_module.apply_mds(spec)
out = wait(cephadm_module, c)
match_glob(out, "Scheduled mds.fsname update...")
CephadmServe(cephadm_module)._apply_all_services()
ok_to_stop.assert_called_with([daemon[4:]])
assert_rm_daemon(cephadm_module, spec.service_name(),
'host1') # verifies ok-to-stop
assert_rm_daemon(cephadm_module, spec.service_name(), 'host2')
@mock.patch("cephadm.module.CephadmOrchestrator._get_connection")
@mock.patch("remoto.process.check")
def test_offline(self, _check, _get_connection, cephadm_module):
_check.return_value = '{}', '', 0
_get_connection.return_value = mock.Mock(), mock.Mock()
with with_host(cephadm_module, 'test'):
_get_connection.side_effect = HostNotFound
code, out, err = cephadm_module.check_host('test')
assert out == ''
assert "Host 'test' not found" in err
out = wait(cephadm_module, cephadm_module.get_hosts())[0].to_json()
assert out == HostSpec('test', 'test', status='Offline').to_json()
_get_connection.side_effect = None
assert CephadmServe(cephadm_module)._check_host('test') is None
out = wait(cephadm_module, cephadm_module.get_hosts())[0].to_json()
assert out == HostSpec('test', 'test').to_json()
def test_stale_connections(self, cephadm_module):
class Connection(object):
"""
A mocked connection class that only allows the use of the connection
once. If you attempt to use it again via a _check, it'll explode (go
boom!).
The old code triggers the boom. The new code checks the has_connection
and will recreate the connection.
"""
fuse = False
@staticmethod
def has_connection():
return False
def import_module(self, *args, **kargs):
return mock.Mock()
@staticmethod
def exit():
pass
def _check(conn, *args, **kargs):
if conn.fuse:
raise Exception("boom: connection is dead")
else:
conn.fuse = True
return '{}', None, 0
with mock.patch("remoto.Connection",
side_effect=[Connection(),
Connection(),
Connection()]):
with mock.patch("remoto.process.check", _check):
with with_host(cephadm_module, 'test', refresh_hosts=False):
code, out, err = cephadm_module.check_host('test')
# First should succeed.
assert err is None
# On second it should attempt to reuse the connection, where the
# connection is "down" so will recreate the connection. The old
# code will blow up here triggering the BOOM!
code, out, err = cephadm_module.check_host('test')
assert err is None
@mock.patch("cephadm.module.CephadmOrchestrator._get_connection")
@mock.patch("remoto.process.check")
def test_etc_ceph(self, _check, _get_connection, cephadm_module):
_get_connection.return_value = mock.Mock(), mock.Mock()
_check.return_value = '{}', '', 0
assert cephadm_module.manage_etc_ceph_ceph_conf is False
with with_host(cephadm_module, 'test'):
assert not cephadm_module.cache.host_needs_new_etc_ceph_ceph_conf(
'test')
with with_host(cephadm_module, 'test'):
cephadm_module.set_module_option('manage_etc_ceph_ceph_conf', True)
cephadm_module.config_notify()
assert cephadm_module.manage_etc_ceph_ceph_conf == True
CephadmServe(cephadm_module)._refresh_hosts_and_daemons()
_check.assert_called_with(ANY, ['dd', 'of=/etc/ceph/ceph.conf'],
stdin=b'')
assert not cephadm_module.cache.host_needs_new_etc_ceph_ceph_conf(
'test')
# set extra config and expect that we deploy another ceph.conf
cephadm_module._set_extra_ceph_conf('[mon]\nk=v')
CephadmServe(cephadm_module)._refresh_hosts_and_daemons()
_check.assert_called_with(ANY, ['dd', 'of=/etc/ceph/ceph.conf'],
stdin=b'\n\n[mon]\nk=v\n')
# reload
cephadm_module.cache.last_etc_ceph_ceph_conf = {}
cephadm_module.cache.load()
assert not cephadm_module.cache.host_needs_new_etc_ceph_ceph_conf(
'test')
# Make sure, _check_daemons does a redeploy due to monmap change:
cephadm_module.mock_store_set(
'_ceph_get', 'mon_map', {
'modified':
datetime.datetime.utcnow().strftime(CEPH_DATEFMT),
'fsid': 'foobar',
})
cephadm_module.notify('mon_map', mock.MagicMock())
assert cephadm_module.cache.host_needs_new_etc_ceph_ceph_conf(
'test')
cephadm_module.cache.last_etc_ceph_ceph_conf = {}
cephadm_module.cache.load()
assert cephadm_module.cache.host_needs_new_etc_ceph_ceph_conf(
'test')
def test_etc_ceph_init(self):
with with_cephadm_module({'manage_etc_ceph_ceph_conf': True}) as m:
assert m.manage_etc_ceph_ceph_conf is True
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm")
def test_registry_login(self, _run_cephadm,
cephadm_module: CephadmOrchestrator):
def check_registry_credentials(url, username, password):
assert cephadm_module.get_module_option('registry_url') == url
assert cephadm_module.get_module_option(
'registry_username') == username
assert cephadm_module.get_module_option(
'registry_password') == password
_run_cephadm.return_value = '{}', '', 0
with with_host(cephadm_module, 'test'):
# test successful login with valid args
code, out, err = cephadm_module.registry_login(
'test-url', 'test-user', 'test-password')
assert out == 'registry login scheduled'
assert err == ''
check_registry_credentials('test-url', 'test-user',
'test-password')
# test bad login attempt with invalid args
code, out, err = cephadm_module.registry_login('bad-args')
assert err == (
"Invalid arguments. Please provide arguments <url> <username> <password> "
"or -i <login credentials json file>")
check_registry_credentials('test-url', 'test-user',
'test-password')
# test bad login using invalid json file
code, out, err = cephadm_module.registry_login(
None, None, None, '{"bad-json": "bad-json"}')
assert err == (
"json provided for custom registry login did not include all necessary fields. "
"Please setup json file as\n"
"{\n"
" \"url\": \"REGISTRY_URL\",\n"
" \"username\": \"REGISTRY_USERNAME\",\n"
" \"password\": \"REGISTRY_PASSWORD\"\n"
"}\n")
check_registry_credentials('test-url', 'test-user',
'test-password')
# test good login using valid json file
good_json = ("{\"url\": \"" + "json-url" + "\", \"username\": \"" +
"json-user" + "\", "
" \"password\": \"" + "json-pass" + "\"}")
code, out, err = cephadm_module.registry_login(
None, None, None, good_json)
assert out == 'registry login scheduled'
assert err == ''
check_registry_credentials('json-url', 'json-user', 'json-pass')
# test bad login where args are valid but login command fails
_run_cephadm.return_value = '{}', 'error', 1
code, out, err = cephadm_module.registry_login(
'fail-url', 'fail-user', 'fail-password')
assert err == 'Host test failed to login to fail-url as fail-user with given password'
check_registry_credentials('json-url', 'json-user', 'json-pass')
@mock.patch("cephadm.module.CephadmOrchestrator._run_cephadm",
_run_cephadm(
json.dumps({
'image_id': 'image_id',
'repo_digest': 'image@repo_digest',
})))
@pytest.mark.parametrize("use_repo_digest", [False, True])
def test_upgrade_run(self, use_repo_digest,
cephadm_module: CephadmOrchestrator):
with with_host(cephadm_module, 'test', refresh_hosts=False):
cephadm_module.set_container_image('global', 'image')
if use_repo_digest:
cephadm_module.use_repo_digest = True
CephadmServe(cephadm_module).convert_tags_to_repo_digest()
_, image, _ = cephadm_module.check_mon_command({
'prefix':
'config get',
'who':
'global',
'key':
'container_image',
})
if use_repo_digest:
assert image == 'image@repo_digest'
else:
assert image == 'image'
def place(self):
# type: () -> List[HostPlacementSpec]
"""
Load hosts into the spec.placement.hosts container.
"""
self.validate()
# count == 0
if self.spec.placement.count == 0:
return []
# respect any explicit host list
if self.spec.placement.hosts and not self.spec.placement.count:
logger.debug('Provided hosts: %s' % self.spec.placement.hosts)
return self.spec.placement.hosts
# respect host_pattern
if self.spec.placement.host_pattern:
candidates = [
HostPlacementSpec(x, '', '') for x in
self.spec.placement.filter_matching_hosts(self.get_hosts_func)
]
logger.debug('All hosts: {}'.format(candidates))
return candidates
count = 0
if self.spec.placement.hosts and \
self.spec.placement.count and \
len(self.spec.placement.hosts) >= self.spec.placement.count:
hosts = self.spec.placement.hosts
logger.debug('place %d over provided host list: %s' %
(count, hosts))
count = self.spec.placement.count
elif self.spec.placement.label:
hosts = [
HostPlacementSpec(x, '', '')
for x in self.get_hosts_func(label=self.spec.placement.label)
]
if not self.spec.placement.count:
logger.debug('Labeled hosts: {}'.format(hosts))
return hosts
count = self.spec.placement.count
logger.debug('place %d over label %s: %s' %
(count, self.spec.placement.label, hosts))
else:
hosts = [
HostPlacementSpec(x, '', '') for x in self.get_hosts_func()
]
if self.spec.placement.count:
count = self.spec.placement.count
else:
# this should be a totally empty spec given all of the
# alternative paths above.
assert self.spec.placement.count is None
assert not self.spec.placement.hosts
assert not self.spec.placement.label
count = 1
logger.debug('place %d over all hosts: %s' % (count, hosts))
# we need to select a subset of the candidates
# if a partial host list is provided, always start with that
if len(self.spec.placement.hosts) < count:
chosen = self.spec.placement.hosts
else:
chosen = []
# prefer hosts that already have services
daemons = self.get_daemons_func(self.service_name)
hosts_with_daemons = {d.hostname for d in daemons}
# calc existing daemons (that aren't already in chosen)
chosen_hosts = [hs.hostname for hs in chosen]
existing = [hs for hs in hosts
if hs.hostname in hosts_with_daemons and \
hs.hostname not in chosen_hosts]
if len(chosen + existing) >= count:
chosen = chosen + self.scheduler.place(existing,
count - len(chosen))
logger.debug('Hosts with existing daemons: {}'.format(chosen))
return chosen
need = count - len(existing + chosen)
others = [hs for hs in hosts if hs.hostname not in hosts_with_daemons]
if self.filter_new_host:
old = others
others = [h for h in others if self.filter_new_host(h.hostname)]
logger.debug('filtered %s down to %s' % (old, hosts))
chosen = chosen + self.scheduler.place(others, need)
logger.debug('Combine hosts with existing daemons %s + new hosts %s' %
(existing, chosen))
return existing + chosen
