def editor_editgroups(ident):
try:
editor = api.get_editor(ident)
editgroups = api.get_editor_editgroups(ident, limit=50)
except ApiException as ae:
abort(ae.status)
return render_template('editor_editgroups.html',
editor=editor,
editgroups=editgroups)
def editor_editgroups(ident):
try:
editor = api.get_editor(ident)
editgroups = api.get_editor_editgroups(ident, limit=50)
# cheaper than API-side expand?
for eg in editgroups:
eg.editor = editor
except ApiException as ae:
abort(ae.status)
return render_template('editor_editgroups.html', editor=editor,
editgroups=editgroups)
def generic_entity_delete(editgroup_id: Optional[str], entity_type: str, existing_ident: str):
"""
Similar to generic_entity_edit(), but for deleting entities. This is a bit
simpler!
Handles both creation and update/edit paths.
"""
# fetch editgroup (if set) or 404
editgroup = None
if editgroup_id:
try:
editgroup = api.get_editgroup(editgroup_id)
except ApiException as ae:
raise ae
# check that editgroup is edit-able
if editgroup.changelog_index != None:
flash("Editgroup already merged")
abort(400)
# fetch entity (if set) or 404
existing = None
existing_edit = None
if editgroup and existing_ident:
existing, existing_edit = generic_get_editgroup_entity(editgroup, entity_type, existing_ident)
elif existing_ident:
existing = generic_get_entity(entity_type, existing_ident)
# parse form (if submitted)
status = 200
form = EntityEditForm()
if form.is_submitted():
if form.validate_on_submit():
# API on behalf of user
user_api = auth_api(session['api_token'])
if not editgroup:
editgroup = form_editgroup_get_or_create(user_api, form)
if editgroup:
# TODO: some danger of wiping database state here is
# "updated edit" causes, eg, a 4xx error. Better to allow
# this in the API itself. For now, form validation *should*
# catch most errors, and if not editor can hit back and try
# again. This means, need to allow failure of deletion.
if existing_edit:
# need to clear revision on object or this becomes just
# a "update pointer" edit
existing.revision = None
generic_entity_delete_edit(user_api, entity_type, editgroup.editgroup_id, existing_edit.edit_id)
try:
edit = generic_entity_delete_entity(user_api, entity_type, editgroup.editgroup_id, existing.ident)
except ApiException as ae:
app.log.warning(ae)
raise ae
if status == 200:
return redirect('/editgroup/{}/{}/{}'.format(editgroup.editgroup_id, entity_type, edit.ident))
else:
status = 400
elif form.errors:
status = 400
app.log.info("form errors (did not validate): {}".format(form.errors))
else: # form is not submitted
if existing:
form = EntityTomlForm.from_entity(existing)
editor_editgroups = api.get_editor_editgroups(session['editor']['editor_id'], limit=20)
potential_editgroups = [e for e in editor_editgroups if e.changelog_index == None and e.submitted == None]
if not form.is_submitted():
# default to most recent not submitted, fallback to "create new"
form.editgroup_id.data = ""
if potential_editgroups:
form.editgroup_id.data = potential_editgroups[0].editgroup_id
return render_template("entity_delete.html", form=form, entity_type=entity_type,
existing_ident=existing_ident, editgroup=editgroup,
potential_editgroups=potential_editgroups), status
def generic_entity_edit(editgroup_id, entity_type, existing_ident, edit_template):
"""
existing (entity)
Create: existing blank, ident blank, editgroup optional
Update: ident set
Need to handle:
- editgroup not set (need to create one)
- creating entity from form
- updating an existing ident
- updating an existing editgroup/ident
Views:
- /container/create
- /container/<ident>/edit
- /editgroup/<editgroup_id>/container/<ident>/edit
Helpers:
- get_editgroup_revision(editgroup, entity_type, ident) -> None or entity
TODO: prev_rev interlock
"""
# fetch editgroup (if set) or 404
editgroup = None
if editgroup_id:
try:
editgroup = api.get_editgroup(editgroup_id)
except ApiException as ae:
raise ae
# check that editgroup is edit-able
if editgroup.changelog_index != None:
abort(400, "Editgroup already merged")
# fetch entity (if set) or 404
existing = None
existing_edit = None
if editgroup and existing_ident:
existing, existing_edit = generic_get_editgroup_entity(editgroup, entity_type, existing_ident)
elif existing_ident:
existing = generic_get_entity(entity_type, existing_ident)
# parse form (if submitted)
status = 200
if entity_type == 'container':
form = ContainerEntityForm()
elif entity_type == 'file':
form = FileEntityForm()
elif entity_type == 'release':
form = ReleaseEntityForm()
else:
raise NotImplementedError
if form.is_submitted():
if form.validate_on_submit():
# API on behalf of user
user_api = auth_api(session['api_token'])
if not editgroup:
editgroup = form_editgroup_get_or_create(user_api, form)
if editgroup:
if not existing_ident: # it's a create
entity = form.to_entity()
try:
if entity_type == 'container':
edit = user_api.create_container(editgroup.editgroup_id, entity)
elif entity_type == 'file':
edit = user_api.create_file(editgroup.editgroup_id, entity)
elif entity_type == 'release':
edit = user_api.create_release(editgroup.editgroup_id, entity)
else:
raise NotImplementedError
except ApiException as ae:
app.log.warning(ae)
raise ae
return redirect('/editgroup/{}/{}/{}'.format(editgroup.editgroup_id, entity_type, edit.ident))
else: # it's an update
# all the tricky logic is in the update method
form.update_entity(existing)
# do we need to try to delete the current in-progress edit first?
# TODO: some danger of wiping database state here is
# "updated edit" causes, eg, a 4xx error. Better to allow
# this in the API itself. For now, form validation *should*
# catch most errors, and if not editor can hit back and try
# again. This means, need to allow failure of deletion.
if existing_edit:
# need to clear revision on object or this becomes just
# a "update pointer" edit
existing.revision = None
try:
generic_entity_delete_edit(user_api, entity_type, editgroup.editgroup_id, existing_edit.edit_id)
except ApiException as ae:
if ae.status == 404:
pass
else:
raise ae
try:
if entity_type == 'container':
edit = user_api.update_container(editgroup.editgroup_id, existing.ident, existing)
elif entity_type == 'file':
edit = user_api.update_file(editgroup.editgroup_id, existing.ident, existing)
elif entity_type == 'release':
edit = user_api.update_release(editgroup.editgroup_id, existing.ident, existing)
else:
raise NotImplementedError
except ApiException as ae:
app.log.warning(ae)
raise ae
return redirect('/editgroup/{}/{}/{}'.format(editgroup.editgroup_id, entity_type, edit.ident))
else:
status = 400
elif form.errors:
status = 400
app.log.info("form errors (did not validate): {}".format(form.errors))
else: # form is not submitted
if existing:
if entity_type == 'container':
form = ContainerEntityForm.from_entity(existing)
elif entity_type == 'file':
form = FileEntityForm.from_entity(existing)
elif entity_type == 'release':
form = ReleaseEntityForm.from_entity(existing)
else:
raise NotImplementedError
editor_editgroups = api.get_editor_editgroups(session['editor']['editor_id'], limit=20)
potential_editgroups = [e for e in editor_editgroups if e.changelog_index == None and e.submitted == None]
if not form.is_submitted():
# default to most recent not submitted, fallback to "create new"
form.editgroup_id.data = ""
if potential_editgroups:
form.editgroup_id.data = potential_editgroups[0].editgroup_id
return render_template(edit_template, form=form,
existing_ident=existing_ident, editgroup=editgroup,
potential_editgroups=potential_editgroups), status