def test_manual_merge_with_none_record(workflow_app):
json_head = fake_record('This is the HEAD', 1)
head = InspireRecord.create_or_update(json_head, skip_files=False)
head.commit()
non_existing_id = 123456789
with pytest.raises(RecordGetterError):
start_merger(
head_id=1,
update_id=non_existing_id,
current_user_id=1,
)
def test_manual_merge_with_none_record(workflow_app):
json_head = fake_record('This is the HEAD', 1)
head = InspireRecord.create_or_update(json_head, skip_files=False)
head.commit()
non_existing_id = 123456789
with pytest.raises(RecordGetterError):
start_merger(
head_id=1,
update_id=non_existing_id,
current_user_id=1,
)
def test_manual_merge_with_none_record(workflow_app):
# XXX: for some reason, this must be internal.
from inspirehep.modules.migrator.tasks import record_insert_or_replace
json_head = fake_record('This is the HEAD', 1)
record_insert_or_replace(json_head)
non_existing_id = 123456789
with pytest.raises(RecordGetterError):
start_merger(
head_id=1,
update_id=non_existing_id,
current_user_id=1,
)
def test_manual_merge_with_none_record(workflow_app):
# XXX: for some reason, this must be internal.
from inspirehep.modules.migrator.tasks import record_insert_or_replace
json_head = fake_record('This is the HEAD', 1)
record_insert_or_replace(json_head)
non_existing_id = 123456789
with pytest.raises(RecordGetterError):
start_merger(
head_id=1,
update_id=non_existing_id,
current_user_id=1,
)
def test_manual_merge_existing_records(workflow_app):
json_head = fake_record('This is the HEAD', 1)
json_update = fake_record('While this is the update', 2)
# this two fields will create a merging conflict
json_head['core'] = True
json_update['core'] = False
head = InspireRecord.create_or_update(json_head, skip_files=False)
head.commit()
update = InspireRecord.create_or_update(json_update, skip_files=False)
update.commit()
head_id = head.id
update_id = update.id
obj_id = start_merger(
head_id=1,
update_id=2,
current_user_id=1,
)
do_resolve_manual_merge_wf(workflow_app, obj_id)
# retrieve it again, otherwise Detached Instance Error
obj = workflow_object_class.get(obj_id)
assert obj.status == ObjectStatus.COMPLETED
assert obj.extra_data['approved'] is True
assert obj.extra_data['auto-approved'] is False
# no root present before
last_root = read_wf_record_source(head_id, 'arxiv')
assert last_root is None
update_source = LiteratureReader(update).source
root_update = read_wf_record_source(update_id, update_source)
assert root_update is None
# check that head's content has been replaced by merged
deleted_record = RecordMetadata.query.filter_by(id=update_id).one()
latest_record = get_db_record('lit', 1)
assert deleted_record.json['deleted'] is True
# check deleted record is linked in the latest one
deleted_rec_ref = {'$ref': 'http://localhost:5000/api/literature/2'}
assert [deleted_rec_ref] == latest_record['deleted_records']
# check the merged record is linked in the deleted one
new_record_metadata = {'$ref': 'http://localhost:5000/api/literature/1'}
assert new_record_metadata == deleted_record.json['new_record']
del latest_record['deleted_records']
assert latest_record == obj.data # -> resulted merged record
def test_manual_merge_existing_records(workflow_app):
json_head = fake_record('This is the HEAD', 1)
json_update = fake_record('While this is the update', 2)
# this two fields will create a merging conflict
json_head['core'] = True
json_update['core'] = False
head = InspireRecord.create_or_update(json_head, skip_files=False)
head.commit()
update = InspireRecord.create_or_update(json_update, skip_files=False)
update.commit()
head_id = head.id
update_id = update.id
obj_id = start_merger(
head_id=1,
update_id=2,
current_user_id=1,
)
do_resolve_manual_merge_wf(workflow_app, obj_id)
# retrieve it again, otherwise Detached Instance Error
obj = workflow_object_class.get(obj_id)
assert obj.status == ObjectStatus.COMPLETED
assert obj.extra_data['approved'] is True
assert obj.extra_data['auto-approved'] is False
# no root present before
last_root = read_wf_record_source(head_id, 'arxiv')
assert last_root is None
update_source = LiteratureReader(update).source
root_update = read_wf_record_source(update_id, update_source)
assert root_update is None
# check that head's content has been replaced by merged
deleted_record = RecordMetadata.query.filter_by(id=update_id).one()
latest_record = get_db_record('lit', 1)
assert deleted_record.json['deleted'] is True
# check deleted record is linked in the latest one
deleted_rec_ref = {'$ref': 'http://localhost:5000/api/literature/2'}
assert [deleted_rec_ref] == latest_record['deleted_records']
# check the merged record is linked in the deleted one
new_record_metadata = {'$ref': 'http://localhost:5000/api/literature/1'}
assert new_record_metadata == deleted_record.json['new_record']
del latest_record['deleted_records']
assert latest_record == obj.data # -> resulted merged record
def manual_merge():
"""Start a manual merge workflow on two records.
Todo:
The following two assertions must be replaced with proper access
control checks, as currently any curator who has access to the
editor API can merge any two records, even if they are not among
those who can see or edit them.
"""
assert request.json['head_recid']
assert request.json['update_recid']
workflow_object_id = start_merger(
request.json['head_recid'],
request.json['update_recid'],
current_user.get_id(),
)
return jsonify(workflow_object_id=workflow_object_id)
def manual_merge():
"""Start a manual merge workflow on two records.
Todo:
The following two assertions must be replaced with proper access
control checks, as currently any curator who has access to the
editor API can merge any two records, even if they are not among
those who can see or edit them.
"""
assert request.json['head_recid']
assert request.json['update_recid']
workflow_object_id = start_merger(
request.json['head_recid'],
request.json['update_recid'],
current_user.get_id(),
)
return jsonify(workflow_object_id=workflow_object_id)
def test_manual_merge_existing_records(mock_put_record_to_hep,
mock_store_records, workflow_app):
json_head = fake_record('This is the HEAD', 1)
json_update = fake_record('While this is the update', 2)
# this two fields will create a merging conflict
json_head['core'] = True
json_update['core'] = False
head = InspireRecord.create_or_update(json_head, skip_files=False)
head.commit()
update = InspireRecord.create_or_update(json_update, skip_files=False)
update.commit()
head_id = head.id
update_id = update.id
obj_id = start_merger(
head_id=1,
update_id=2,
current_user_id=1,
)
do_resolve_manual_merge_wf(workflow_app, obj_id)
mock_put_record_to_hep.assert_called()
# retrieve it again, otherwise Detached Instance Error
obj = workflow_object_class.get(obj_id)
assert obj.status == ObjectStatus.COMPLETED
assert obj.extra_data['approved'] is True
assert obj.extra_data['auto-approved'] is False
# no root present before
last_root = read_wf_record_source(head_id, 'arxiv')
assert last_root is None
update_source = LiteratureReader(update).source
root_update = read_wf_record_source(update_id, update_source)
assert root_update is None