def test_edit_wrong_format_tag(self):
tag_name_new = 'new-test-tag+'
tag_name = 'tag'
self.get_tag.return_value = {'id': 333,
'perm_id': 1,
'name': tag_name,
'arches': 'arch1 arch3',
'locked': False,
'maven_support': False,
'maven_include_all': False,
'extra': {'exA': 1,
'exC': 3,
'exD': 4}}
kwargs = {
'perm': None,
'name': tag_name_new,
'arches': 'arch1 arch2',
'locked': True,
'maven_support': False,
'maven_include_all': False,
'extra': {},
'remove_extra': []
}
# name is longer as expected
self.verify_name_internal.side_effect = koji.GenericError
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', **kwargs)
# not except regex rules
self.verify_name_internal.side_effect = koji.GenericError
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', **kwargs)
def editSideTag(sidetag,
debuginfo=None,
rpm_macros=None,
remove_rpm_macros=None):
"""Restricted ability to modify sidetags, parent tag must have:
sidetag_debuginfo_allowed: 1
sidetag_rpm_macros_allowed: 1
in extra, if modifying functions should work. For blocking/unblocking
further policy must be compatible with these operations.
:param sidetag: sidetag id or name
:type sidetag: int or str
:param debuginfo: set or disable debuginfo repo generation
:type debuginfo: bool
:param rpm_macros: add/update rpms macros in extra
:type rpm_macros: dict
:param remove_rpm_macros: remove rpm macros from extra
:type remove_rpm_macros: list of str
"""
context.session.assertLogin()
user = get_user(context.session.user_id, strict=True)
sidetag = get_tag(sidetag, strict=True)
# sanity/access
is_sidetag(sidetag, raise_error=True)
is_sidetag_owner(sidetag, user, raise_error=True)
parent_id = readInheritanceData(sidetag['id'])[0]['parent_id']
parent = get_tag(parent_id)
if debuginfo is not None and not parent['extra'].get(
'sidetag_debuginfo_allowed'):
raise koji.GenericError(
"Debuginfo setting is not allowed in parent tag.")
if (rpm_macros is not None or remove_rpm_macros is not None) \
and not parent['extra'].get('sidetag_rpm_macros_allowed'):
raise koji.GenericError(
"RPM macros change is not allowed in parent tag.")
kwargs = {'extra': {}}
if debuginfo is not None:
kwargs['extra']['with_debuginfo'] = bool(debuginfo)
if rpm_macros is not None:
for macro, value in rpm_macros.items():
kwargs['extra']['rpm.macro.%s' % macro] = value
if remove_rpm_macros is not None:
kwargs['remove_extra'] = [
'rpm.macro.%s' % m for m in remove_rpm_macros
]
_edit_tag(sidetag['id'], **kwargs)
def test_invalid_archs(self):
self.get_tag.return_value = {
'create_event': 42,
'creator_id': 23,
'arches': 'arch1 arch2',
'locked': True,
'maven_include_all': True,
'maven_support': True,
'perm_id': None,
'tag_id': 333,
'name': 'newtag',
'id': 345,
}
# valid
kwargs = {
'name': 'newtag',
'arches': 'valid_arch',
}
kojihub._edit_tag('tag', **kwargs)
# invalid 1
kwargs['arches'] = u'ěšč'
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', **kwargs)
# invalid 2
kwargs['arches'] = u'arch1;arch2'
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', **kwargs)
# invalid 2
kwargs['arches'] = u'arch1,arch2'
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', **kwargs)
def test_maven_disable(self):
self.context.opts.get.return_value = False
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', maven_support=True)
with self.assertRaises(koji.GenericError):
kojihub._edit_tag('tag', maven_include_all=False)
self.context.opts.get.return_value = True
kojihub._edit_tag('tag', maven_support=True)
self.get_tag.assert_called_once()
def test_edit(self):
self.get_tag.return_value = {
'id': 333,
'perm_id': 1,
'name': 'tag',
'arches': 'arch1 arch3',
'locked': False,
'maven_support': False,
'maven_include_all': False,
'extra': {
'exA': 1,
'exC': 3,
'exD': 4
}
}
self._singleValue.return_value = None
self.context.event_id = 42
self.context.session.user_id = 23
# no1 invoke
kwargs = {
'perm': None,
'name': 'newtag',
'arches': 'arch1 arch2',
'locked': True,
'maven_support': True,
'maven_include_all': True,
'extra': {
'exB': [None, 1, 'text', {
'dict': 'val'
}, (1, 2)]
},
'remove_extra': ['exC']
}
kojihub._edit_tag('tag', **kwargs)
self.get_perm_id.assert_not_called()
self._dml.assert_called_with(
"""UPDATE tag
SET name = %(name)s
WHERE id = %(tagID)i""", {
'name': 'newtag',
'tagID': 333
})
# check the insert/update
self.assertEqual(len(self.updates), 3)
self.assertEqual(len(self.inserts), 2)
values = {
'arches': 'arch1 arch2',
'locked': True,
'maven_include_all': True,
'maven_support': True,
'perm_id': None,
'id': 333,
'name': 'tag',
'extra': {
'exA': 1,
'exC': 3,
'exD': 4
}
}
revoke_data = {'revoke_event': 42, 'revoker_id': 23}
revoke_rawdata = {'active': 'NULL'}
update = self.updates[0]
self.assertEqual(update.table, 'tag_config')
self.assertEqual(update.values, values)
self.assertEqual(update.data, revoke_data)
self.assertEqual(update.rawdata, revoke_rawdata)
self.assertEqual(update.clauses, ['tag_id = %(id)i', 'active = TRUE'])
data = {
'create_event': 42,
'creator_id': 23,
'arches': 'arch1 arch2',
'locked': True,
'maven_include_all': True,
'maven_support': True,
'perm_id': None,
'tag_id': 333,
}
insert = self.inserts[0]
self.assertEqual(insert.table, 'tag_config')
self.assertEqual(insert.data, data)
self.assertEqual(insert.rawdata, {})
values = {
'key': 'exB',
'value': '[null, 1, "text", {"dict": "val"}, [1, 2]]',
'tag_id': 333,
}
update = self.updates[1]
self.assertEqual(update.table, 'tag_extra')
self.assertEqual(update.values, values)
self.assertEqual(update.data, revoke_data)
self.assertEqual(update.rawdata, revoke_rawdata)
self.assertEqual(
update.clauses,
['tag_id = %(tag_id)i', 'key=%(key)s', 'active = TRUE'])
data = {
'create_event': 42,
'creator_id': 23,
'key': 'exB',
'value': '[null, 1, "text", {"dict": "val"}, [1, 2]]',
'tag_id': 333,
}
insert = self.inserts[1]
self.assertEqual(insert.table, 'tag_extra')
self.assertEqual(insert.data, data)
self.assertEqual(insert.rawdata, {})
values = {
'key': 'exC',
'tag_id': 333,
}
update = self.updates[2]
self.assertEqual(update.table, 'tag_extra')
self.assertEqual(update.values, values)
self.assertEqual(update.data, revoke_data)
self.assertEqual(update.rawdata, revoke_rawdata)
self.assertEqual(
update.clauses,
['tag_id = %(tag_id)i', 'key=%(key)s', 'active = TRUE'])
# no2 invoke
kwargs = {'extra': {'exC': 'text'}, 'remove_extra': ['exC']}
with self.assertRaises(koji.GenericError) as cm:
kojihub._edit_tag('tag', **kwargs)
self.assertEqual(
cm.exception.args[0],
'Can not both add/update and remove tag-extra: \'exC\'')
# no3 invoke
kwargs = {'remove_extra': ['exE']}
with self.assertRaises(koji.GenericError) as cm:
kojihub._edit_tag('tag', **kwargs)
self.assertEqual(cm.exception.args[0],
"Tag: tag doesn't have extra: exE")
# no4 invoke
self.get_perm_id.reset_mock()
self.get_perm_id.return_value = 99
self._singleValue.reset_mock()
self._singleValue.return_value = 2
kwargs = {
'perm': 'admin',
'name': 'newtag',
}
with self.assertRaises(koji.GenericError) as cm:
kojihub._edit_tag('tag', **kwargs)
self.get_perm_id.assert_called_once()
self._singleValue.assert_called_once()
self.assertEqual(cm.exception.args[0],
'Name newtag already taken by tag 2')
