def test_get_results_with_good_blocked_versions(self):
# Result labelled as "good" because auto-approve has been confirmed.
version_1 = version_factory(addon=addon_factory())
result_1 = ScannerResult.objects.create(scanner=CUSTOMS, version=version_1)
ActivityLog.create(amo.LOG.APPROVE_VERSION, version_1, user=self.user)
# Oh noes! The version has been blocked.
block_1 = Block.objects.create(guid=version_1.addon.guid, updated_by=self.user)
block_activity_log_save(block_1, change=False)
response = self.client.get(self.url)
results = self.assert_json_results(response, expected_results=1)
assert results[0]['id'] == result_1.id
assert results[0]['label'] == LABEL_BAD
def test_get_results_with_blocked_versions(self):
self.create_switch('enable-scanner-results-api', active=True)
# result labelled as "bad" because its state is TRUE_POSITIVE
bad_version = version_factory(addon=addon_factory())
ScannerResult.objects.create(
scanner=YARA, version=bad_version, state=TRUE_POSITIVE
)
# result labelled as "bad" because the add-on is blocked.
blocked_addon_1 = addon_factory()
blocked_version_1 = version_factory(addon=blocked_addon_1)
ScannerResult.objects.create(scanner=YARA, version=blocked_version_1)
block_1 = Block.objects.create(
guid=blocked_addon_1.guid, updated_by=self.user
)
block_activity_log_save(block_1, change=False)
# result labelled as "bad" because the add-on is blocked and the block
# has been edited.
blocked_addon_2 = addon_factory()
blocked_version_2 = version_factory(addon=blocked_addon_2)
ScannerResult.objects.create(scanner=YARA, version=blocked_version_2)
block_2 = Block.objects.create(
guid=blocked_addon_2.guid, updated_by=self.user
)
block_activity_log_save(block_2, change=True)
# result labelled as "bad" because the add-on is blocked and the block
# has been added *and* edited. It should only return one result.
blocked_addon_3 = addon_factory()
blocked_version_3 = version_factory(addon=blocked_addon_3)
ScannerResult.objects.create(scanner=YARA, version=blocked_version_3)
block_3 = Block.objects.create(
guid=blocked_addon_3.guid, updated_by=self.user
)
block_activity_log_save(block_3, change=False)
block_activity_log_save(block_3, change=True)
# result labelled as "bad" because its state is TRUE_POSITIVE and the
# add-on is blocked. It should only return one result.
blocked_addon_4 = addon_factory()
blocked_version_4 = version_factory(addon=blocked_addon_4)
ScannerResult.objects.create(
scanner=YARA, version=blocked_version_4, state=TRUE_POSITIVE
)
block_4 = Block.objects.create(
guid=blocked_addon_4.guid, updated_by=self.user
)
block_activity_log_save(block_4, change=False)
response = self.client.get(self.url)
self.assert_json_results(response, expected_results=5)
def test_get_results_with_good_blocked_versions(self):
self.create_switch('enable-scanner-results-api', active=True)
# Result labelled as "good" because auto-approve has been confirmed.
version_1 = version_factory(addon=addon_factory())
result_1 = ScannerResult.objects.create(scanner=CUSTOMS,
version=version_1)
VersionLog.objects.create(
activity_log=ActivityLog.create(
action=amo.LOG.CONFIRM_AUTO_APPROVED,
version=version_1,
user=self.user,
),
version=version_1,
)
# Oh noes! The version has been blocked.
block_1 = Block.objects.create(guid=version_1.addon.guid,
updated_by=self.user)
block_activity_log_save(block_1, change=False)
response = self.client.get(self.url)
results = self.assert_json_results(response, expected_results=1)
assert results[0]['id'] == result_1.id
assert results[0]['label'] == LABEL_BAD