def test_diff_from_file(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
# this json file makes the same changes as _make_some_changes():
with open(
Path('forecast_app/tests/project_diff/docs-project-edited.json'
)) as fp:
edited_config_dict = json.load(fp)
changes = project_config_diff(out_config_dict, edited_config_dict)
# # print a little report
# print(f"* Analyzed {len(changes)} changes. Results:")
# for change, num_points, num_named, num_bins, num_samples, num_quantiles, num_truth in \
# database_changes_for_project_config_diff(project, changes):
# print(f"- {change.change_type.name} on {change.object_type.name} {change.object_pk!r} will delete:\n"
# f" = {num_points} point predictions\n"
# f" = {num_named} named predictions\n"
# f" = {num_bins} bin predictions\n"
# f" = {num_samples} samples\n"
# f" = {num_quantiles} quantiles\n"
# f" = {num_truth} truth rows")
# same tests as test_execute_project_config_diff():
execute_project_config_diff(project, changes)
self._do_make_some_changes_tests(project)
def post(self, request, *args, **kwargs):
"""
Edits a Project via "diffs" from a configuration file ala execute_project_config_diff(). Runs in the calling
thread and therefore blocks. POST form fields:
- request.data (required) must have a 'project_config' field containing a dict valid for
execute_project_config_diff(). NB: this is different from other API args in this file in that it takes all
required information as data, whereas others take their main data as a file in request.FILES, plus some
additional data in request.data.
"""
project = self.get_object()
if not is_user_ok_edit_project(request.user, project): # only the project owner can edit the project
return HttpResponseForbidden()
elif 'project_config' not in request.data:
return JsonResponse({'error': "No 'project_config' data."}, status=status.HTTP_400_BAD_REQUEST)
try:
current_config_dict = config_dict_from_project(project, request)
new_config_dict = request.data['project_config']
changes = project_config_diff(current_config_dict, new_config_dict)
# database_changes = database_changes_for_project_config_diff(project, changes)
logger.debug(f"ProjectDetail.post(): executing project config diff... changes={changes}")
execute_project_config_diff(project, changes)
logger.debug(f"ProjectDetail.post(): done")
project_serializer = ProjectSerializer(project, context={'request': request})
return JsonResponse(project_serializer.data)
except Exception as ex:
return JsonResponse({'error': str(ex)}, status=status.HTTP_400_BAD_REQUEST)
def test_execute_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
# make some changes
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
changes = project_config_diff(out_config_dict, edit_config_dict)
execute_project_config_diff(project, changes)
self._do_make_some_changes_tests(project)
def test_order_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
changes = project_config_diff(out_config_dict, edit_config_dict)
# removes one wasted activity ('pct next week', ChangeType.FIELD_EDITED) that is wasted b/c that target is being
# ChangeType.OBJ_REMOVED:
ordered_changes = order_project_config_diff(changes)
self.assertEqual(
13, len(changes)) # contains two duplicate and one wasted change
self.assertEqual(10, len(ordered_changes))
def test_diff_from_file_empty_data_version_date_string(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
# note: using APIRequestFactory was the only way I could find to pass a request object. o/w you get:
# AssertionError: `HyperlinkedIdentityField` requires the request in the serializer context.
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edited_config_dict = copy.deepcopy(out_config_dict)
# change '2011-10-02': None -> '' (incorrect, but we fix for users)
edited_config_dict['timezeros'][0]['data_version_date'] = ''
changes = project_config_diff(out_config_dict, edited_config_dict)
self.assertEqual(
0, len(changes)
) # is 1 without the fix "this test for `!= ''` matches this one below"
def test_execute_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
_update_scores_for_all_projects()
# make some changes
# note: using APIRequestFactory was the only way I could find to pass a request object. o/w you get:
# AssertionError: `HyperlinkedIdentityField` requires the request in the serializer context.
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
changes = project_config_diff(out_config_dict, edit_config_dict)
execute_project_config_diff(project, changes)
self._do_make_some_changes_tests(project)
def test_order_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
_update_scores_for_all_projects()
# note: using APIRequestFactory was the only way I could find to pass a request object. o/w you get:
# AssertionError: `HyperlinkedIdentityField` requires the request in the serializer context.
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
changes = project_config_diff(out_config_dict, edit_config_dict)
# removes one wasted activity ('pct next week', ChangeType.FIELD_EDITED) that is wasted b/c that target is being
# ChangeType.OBJ_REMOVED:
ordered_changes = order_project_config_diff(changes)
self.assertEqual(
13, len(changes)) # contains two duplicate and one wasted change
self.assertEqual(10, len(ordered_changes))
def test_database_changes_for_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
changes = project_config_diff(
out_config_dict,
edit_config_dict) # change, num_pred_eles, num_truth
exp_changes = [(Change(ObjectType.UNIT, 'location3',
ChangeType.OBJ_REMOVED, None, None), 8, 0),
(Change(ObjectType.TARGET, 'pct next week',
ChangeType.OBJ_REMOVED, None, None), 7, 3),
(Change(ObjectType.TIMEZERO, '2011-10-02',
ChangeType.OBJ_REMOVED, None, None), 29, 5)]
act_changes = database_changes_for_project_config_diff(
project, changes)
self.assertEqual(exp_changes, act_changes)
def test_database_changes_for_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
_update_scores_for_all_projects()
# note: using APIRequestFactory was the only way I could find to pass a request object. o/w you get:
# AssertionError: `HyperlinkedIdentityField` requires the request in the serializer context.
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
changes = project_config_diff(out_config_dict, edit_config_dict)
self.assertEqual( # change, num_points, num_named, num_bins, num_samples, num_truth
[(Change(ObjectType.UNIT, 'location3', ChangeType.OBJ_REMOVED,
None, None), 3, 0, 2, 10, 0),
(Change(ObjectType.TARGET, 'pct next week',
ChangeType.OBJ_REMOVED, None, None), 3, 1, 3, 5, 3),
(Change(ObjectType.TIMEZERO, '2011-10-02', ChangeType.OBJ_REMOVED,
None, None), 11, 2, 16, 23, 5)],
database_changes_for_project_config_diff(project, changes))
def test_serialize_change_list(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
# make some changes
out_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
edit_config_dict = copy.deepcopy(out_config_dict)
_make_some_changes(edit_config_dict)
# test round-trip for one Change
changes = sorted(project_config_diff(out_config_dict,
edit_config_dict),
key=lambda _:
(_.object_type, _.object_pk, _.change_type))
exp_dict = {
'object_type': ObjectType.PROJECT,
'object_pk': None,
'change_type': ChangeType.FIELD_EDITED,
'field_name': 'name',
'object_dict': edit_config_dict
}
act_dict = changes[0].serialize_to_dict()
self.assertEqual(exp_dict, act_dict)
self.assertEqual(changes[0], Change.deserialize_dict(exp_dict))
# test serialize_to_dict() for all changes
exp_dicts = [{
'object_type': ObjectType.PROJECT,
'object_pk': None,
'change_type': ChangeType.FIELD_EDITED,
'field_name': 'name',
'object_dict': edit_config_dict
}, {
'object_type': ObjectType.UNIT,
'object_pk': 'location3',
'change_type': ChangeType.OBJ_REMOVED,
'field_name': None,
'object_dict': None
}, {
'object_type': ObjectType.UNIT,
'object_pk': 'location4',
'change_type': ChangeType.OBJ_ADDED,
'field_name': None,
'object_dict': {
'name': 'location4'
}
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'cases next week',
'change_type': ChangeType.FIELD_EDITED,
'field_name': 'is_step_ahead',
'object_dict': {
'name': 'cases next week',
'type': 'discrete',
'description':
'A forecasted integer number of cases for a future week.',
'is_step_ahead': False,
'unit': 'cases',
'range': [0, 100000],
'cats': [0, 2, 50]
}
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'cases next week',
'change_type': ChangeType.FIELD_REMOVED,
'field_name': 'step_ahead_increment',
'object_dict': None
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'pct next week',
'change_type': ChangeType.OBJ_ADDED,
'field_name': None,
'object_dict': {
'name': 'pct next week',
'type': 'discrete',
'description': 'new descr',
'is_step_ahead': True,
'step_ahead_increment': 1,
'unit': 'percent',
'range': [0, 100],
'cats': [0, 1, 1, 2, 2, 3, 3, 5, 10, 50]
}
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'pct next week',
'change_type': ChangeType.OBJ_ADDED,
'field_name': None,
'object_dict': {
'type': 'discrete',
'name': 'pct next week',
'description': 'new descr',
'is_step_ahead': True,
'step_ahead_increment': 1,
'unit': 'percent',
'range': [0, 100],
'cats': [0, 1, 1, 2, 2, 3, 3, 5, 10, 50]
}
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'pct next week',
'change_type': ChangeType.OBJ_REMOVED,
'field_name': None,
'object_dict': None
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'pct next week',
'change_type': ChangeType.OBJ_REMOVED,
'field_name': None,
'object_dict': None
}, {
'object_type': ObjectType.TARGET,
'object_pk': 'pct next week',
'change_type': ChangeType.FIELD_EDITED,
'field_name': 'description',
'object_dict': {
'name': 'pct next week',
'type': 'discrete',
'description': 'new descr',
'is_step_ahead': True,
'step_ahead_increment': 1,
'unit': 'percent',
'range': [0, 100],
'cats': [0, 1, 1, 2, 2, 3, 3, 5, 10, 50]
}
}, {
'object_type': ObjectType.TIMEZERO,
'object_pk': '2011-10-02',
'change_type': ChangeType.OBJ_REMOVED,
'field_name': None,
'object_dict': None
}, {
'object_type': ObjectType.TIMEZERO,
'object_pk': '2011-10-09',
'change_type': ChangeType.FIELD_EDITED,
'field_name': 'data_version_date',
'object_dict': {
'timezero_date': '2011-10-09',
'data_version_date': '2011-10-19',
'is_season_start': False
}
}, {
'object_type': ObjectType.TIMEZERO,
'object_pk': '2011-10-22',
'change_type': ChangeType.OBJ_ADDED,
'field_name': None,
'object_dict': {
'timezero_date': '2011-10-22',
'data_version_date': None,
'is_season_start': True,
'season_name': '2011-2012'
}
}]
act_dicts = [change.serialize_to_dict() for change in changes]
for act_dict in act_dicts: # remove 'id' and 'url' fields from TargetSerializer to ease testing
if act_dict['object_dict']:
if 'id' in act_dict[
'object_dict']: # deleted in previous iteration?
del act_dict['object_dict']['id']
del act_dict['object_dict']['url']
self.assertEqual(exp_dicts, act_dicts)
# test round-trip for all changes
for change in changes:
serialized_change_dict = change.serialize_to_dict()
deserialized_change = Change.deserialize_dict(
serialized_change_dict)
self.assertEqual(change, deserialized_change)
def test_project_config_diff(self):
_, _, po_user, _, _, _, _, _ = get_or_create_super_po_mo_users(
is_create_super=True)
project, _, _, _ = _make_docs_project(po_user)
# first we remove 'id' and 'url' fields from serializers to ease testing
current_config_dict = config_dict_from_project(
project,
APIRequestFactory().request())
for the_dict_list in [
current_config_dict['units'], current_config_dict['targets'],
current_config_dict['timezeros']
]:
for the_dict in the_dict_list:
if 'id' in the_dict:
del the_dict['id']
del the_dict['url']
# project fields: edit
fields_new_values = [('name', 'new name'), ('is_public', False),
('description', 'new descr'),
('home_url', 'new home_url'),
('logo_url', 'new logo_url'),
('core_data', 'new core_data'),
('time_interval_type', 'Biweek'),
('visualization_y_label',
'new visualization_y_label')]
edit_config_dict = copy.deepcopy(current_config_dict)
for field_name, new_value in fields_new_values:
edit_config_dict[field_name] = new_value
exp_changes = [
Change(ObjectType.PROJECT, None, ChangeType.FIELD_EDITED,
field_name, edit_config_dict)
for field_name, new_value in fields_new_values
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))
# project units: remove 'location3', add 'location4'
edit_config_dict = copy.deepcopy(current_config_dict)
location_3_dict = [
target_dict for target_dict in edit_config_dict['units']
if target_dict['name'] == 'location3'
][0]
location_3_dict['name'] = 'location4' # 'location3'
exp_changes = [
Change(ObjectType.UNIT, 'location3', ChangeType.OBJ_REMOVED, None,
None),
Change(ObjectType.UNIT, 'location4', ChangeType.OBJ_ADDED, None,
location_3_dict)
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))
# project timezeros: remove '2011-10-02', add '2011-10-22', edit '2011-10-09' fields
edit_config_dict = copy.deepcopy(current_config_dict)
tz_2011_10_02_dict = [
target_dict for target_dict in edit_config_dict['timezeros']
if target_dict['timezero_date'] == '2011-10-02'
][0]
tz_2011_10_02_dict['timezero_date'] = '2011-10-22' # was '2011-10-02'
tz_2011_10_09_dict = [
target_dict for target_dict in edit_config_dict['timezeros']
if target_dict['timezero_date'] == '2011-10-09'
][0]
tz_2011_10_09_dict['data_version_date'] = '2011-10-19' # '2011-10-09'
tz_2011_10_09_dict['is_season_start'] = True # false
tz_2011_10_09_dict['season_name'] = 'season name' # null
exp_changes = [
Change(ObjectType.TIMEZERO, '2011-10-02', ChangeType.OBJ_REMOVED,
None, None),
Change(ObjectType.TIMEZERO, '2011-10-22', ChangeType.OBJ_ADDED,
None, tz_2011_10_02_dict),
Change(ObjectType.TIMEZERO, '2011-10-09', ChangeType.FIELD_EDITED,
'data_version_date', tz_2011_10_09_dict),
Change(ObjectType.TIMEZERO, '2011-10-09', ChangeType.FIELD_EDITED,
'is_season_start', tz_2011_10_09_dict),
Change(ObjectType.TIMEZERO, '2011-10-09', ChangeType.FIELD_ADDED,
'season_name', tz_2011_10_09_dict)
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))
# project targets: remove 'pct next week', add 'pct next week 2', edit 'cases next week' and 'Season peak week'
# fields
edit_config_dict = copy.deepcopy(current_config_dict)
pct_next_week_target_dict = [
target_dict for target_dict in edit_config_dict['targets']
if target_dict['name'] == 'pct next week'
][0]
pct_next_week_target_dict[
'name'] = 'pct next week 2' # was 'pct next week'
cases_next_week_target_dict = [
target_dict for target_dict in edit_config_dict['targets']
if target_dict['name'] == 'cases next week'
][0]
cases_next_week_target_dict[
'description'] = 'new descr' # 'cases next week'
cases_next_week_target_dict['is_step_ahead'] = False
del (cases_next_week_target_dict['step_ahead_increment'])
season_peak_week_target_dict = [
target_dict for target_dict in edit_config_dict['targets']
if target_dict['name'] == 'Season peak week'
][0]
season_peak_week_target_dict[
'description'] = 'new descr 2' # 'Season peak week'
season_peak_week_target_dict['is_step_ahead'] = True
season_peak_week_target_dict['step_ahead_increment'] = 2
season_peak_week_target_dict['unit'] = 'biweek'
exp_changes = [
Change(ObjectType.TARGET, 'pct next week', ChangeType.OBJ_REMOVED,
None, None),
Change(ObjectType.TARGET, 'pct next week 2', ChangeType.OBJ_ADDED,
None, pct_next_week_target_dict),
Change(ObjectType.TARGET, 'cases next week',
ChangeType.FIELD_REMOVED, 'step_ahead_increment', None),
Change(ObjectType.TARGET, 'cases next week',
ChangeType.FIELD_EDITED, 'description',
cases_next_week_target_dict),
Change(ObjectType.TARGET, 'cases next week',
ChangeType.FIELD_EDITED, 'is_step_ahead',
cases_next_week_target_dict),
Change(ObjectType.TARGET, 'Season peak week',
ChangeType.FIELD_ADDED, 'step_ahead_increment',
season_peak_week_target_dict),
Change(ObjectType.TARGET, 'Season peak week',
ChangeType.FIELD_EDITED, 'description',
season_peak_week_target_dict),
Change(ObjectType.TARGET, 'Season peak week',
ChangeType.FIELD_EDITED, 'is_step_ahead',
season_peak_week_target_dict),
Change(ObjectType.TARGET, 'Season peak week',
ChangeType.FIELD_EDITED, 'unit',
season_peak_week_target_dict)
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))
# project targets: edit 'pct next week' 'type' (non-editable) and 'description' (editable) fields
edit_config_dict = copy.deepcopy(current_config_dict)
pct_next_week_target_dict = [
target_dict for target_dict in edit_config_dict['targets']
if target_dict['name'] == 'pct next week'
][0]
pct_next_week_target_dict['type'] = 'discrete' # 'pct next week'
pct_next_week_target_dict['description'] = 'new descr'
exp_changes = [
Change(ObjectType.TARGET, 'pct next week', ChangeType.OBJ_REMOVED,
None, None),
Change(ObjectType.TARGET, 'pct next week', ChangeType.OBJ_ADDED,
None, pct_next_week_target_dict),
Change(ObjectType.TARGET, 'pct next week', ChangeType.FIELD_EDITED,
'description', pct_next_week_target_dict)
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))
# project targets: edit 'cases next week': remove 'range' (non-editable)
edit_config_dict = copy.deepcopy(current_config_dict)
cases_next_week_target_dict = [
target_dict for target_dict in edit_config_dict['targets']
if target_dict['name'] == 'cases next week'
][0]
del (cases_next_week_target_dict['range']) # 'cases next week
exp_changes = [
Change(ObjectType.TARGET, 'cases next week',
ChangeType.OBJ_REMOVED, None, None),
Change(ObjectType.TARGET, 'cases next week', ChangeType.OBJ_ADDED,
None, cases_next_week_target_dict)
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))
# project targets: edit 'season severity': edit 'cats' (non-editable)
edit_config_dict = copy.deepcopy(current_config_dict)
season_severity_target_dict = [
target_dict for target_dict in edit_config_dict['targets']
if target_dict['name'] == 'season severity'
][0]
season_severity_target_dict[
'cats'] = season_severity_target_dict['cats'] + ['cat 2']
exp_changes = [
Change(ObjectType.TARGET, 'season severity',
ChangeType.OBJ_REMOVED, None, None),
Change(ObjectType.TARGET, 'season severity', ChangeType.OBJ_ADDED,
None, season_severity_target_dict)
]
act_changes = project_config_diff(current_config_dict,
edit_config_dict)
self.assertEqual(
sorted(exp_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)),
sorted(act_changes,
key=lambda _: (_.object_type, _.object_pk, _.change_type)))