def test_remove_ambiguous_addresses_exactmatch(self):
in_list = [
{
"address": "Haringey Park, London",
"postcode": "N89JG",
"polling_station_id": "AA",
"council": "",
"slug": "haringey-park-london-n89jg-aa",
"uprn": "",
},
{
"address": "Haringey Park, London",
"postcode": "N89JG",
"polling_station_id": "AB",
"council": "",
"slug": "haringey-park-london-n89jg-ab",
"uprn": "",
},
{
"address": "Haringey Park, London",
"postcode": "N89JG",
"polling_station_id": "AC",
"council": "",
"slug": "haringey-park-london-n89jg-ac",
"uprn": "",
},
]
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
result = address_set.remove_ambiguous_addresses()
self.assertEqual(set(), result)
def test_remove_ambiguous_addresses_exactmatch(self):
in_list = [
{
'address': 'Haringey Park, London',
'postcode': 'N89JG',
'polling_station_id': 'AA',
'council': '',
'slug': 'haringey-park-london-n89jg-aa'
},
{
'address': 'Haringey Park, London',
'postcode': 'N89JG',
'polling_station_id': 'AB',
'council': '',
'slug': 'haringey-park-london-n89jg-ab'
},
{
'address': 'Haringey Park, London',
'postcode': 'N89JG',
'polling_station_id': 'AC',
'council': '',
'slug': 'haringey-park-london-n89jg-ac'
},
]
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
result = address_list.remove_ambiguous_addresses()
self.assertEqual(set(), result)
def test_remove_ambiguous_addresses_exactmatch(self):
in_list = [
{
'address': 'Haringey Park, London',
'postcode': 'N89JG',
'polling_station_id': 'AA',
'council': '',
'slug': 'haringey-park-london-n89jg-aa'
},
{
'address': 'Haringey Park, London',
'postcode': 'N89JG',
'polling_station_id': 'AB',
'council': '',
'slug': 'haringey-park-london-n89jg-ab'
},
{
'address': 'Haringey Park, London',
'postcode': 'N89JG',
'polling_station_id': 'AC',
'council': '',
'slug': 'haringey-park-london-n89jg-ac'
},
]
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
result = address_list.remove_ambiguous_addresses()
self.assertEqual(set(), result)
class BaseStationsAddressesImporter(BaseStationsImporter,
BaseAddressesImporter):
def import_data(self):
self.stations = StationSet()
self.addresses = AddressSet(self.logger)
self.import_residential_addresses()
self.import_polling_stations()
self.addresses.save(self.batch_size)
self.stations.save()
def test_add_with_duplicates(self):
in_list = [
{
"address": "foo",
"slug": "foo",
"postcode": "",
"council": "",
"polling_station_id": "",
"uprn": "",
},
{
"address": "bar",
"slug": "bar",
"postcode": "",
"council": "",
"polling_station_id": "",
"uprn": "",
},
{
"address": "foo",
"slug": "foo",
"postcode": "",
"council": "",
"polling_station_id": "",
"uprn": "",
},
]
expected = set([
Address(
address="foo",
slug="foo",
postcode="",
council="",
polling_station_id="",
uprn="",
location=None,
),
Address(
address="bar",
slug="bar",
postcode="",
council="",
polling_station_id="",
uprn="",
location=None,
),
])
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
self.assertEqual(expected, address_set.elements)
def import_data(self):
# Optional step for pre import tasks
try:
self.pre_import()
except NotImplementedError:
pass
self.stations = StationSet()
self.addresses = AddressSet(self.logger)
self.import_residential_addresses()
self.import_polling_stations()
self.addresses.save(self.batch_size)
self.stations.save()
def test_remove_ambiguous_addresses_no_issues(self):
# if there are no ambiguous addresses,
# we shouldn't do anything
in_list = [
{
"address": "1 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "a",
"uprn": "",
},
{
"address": "2 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "b",
"uprn": "",
},
{
"address": "3 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AB",
"council": "",
"slug": "c",
"uprn": "",
},
{
"address": "4 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "d",
"uprn": "",
},
]
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
expected = set(address_set.elements)
result = address_set.remove_ambiguous_addresses()
self.assertEqual(expected, result)
def test_remove_ambiguous_addresses_whole_postcode(self):
# if we've got one ambiguous address,
# we should remove all addresse with the same postcode
in_list = [
{
"address": "1 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "a",
"uprn": "",
},
{
"address": "2 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "b",
"uprn": "",
},
{
"address": "3 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AB",
"council": "",
"slug": "c",
"uprn": "",
},
{
"address": "3 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "d",
"uprn": "",
},
]
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
result = address_set.remove_ambiguous_addresses()
self.assertEqual(set(), result)
def test_add_with_duplicates(self):
in_list = [
{
'address': 'foo',
'slug': 'foo',
'postcode': '',
'council': '',
'polling_station_id': ''
},
{
'address': 'bar',
'slug': 'bar',
'postcode': '',
'council': '',
'polling_station_id': ''
},
{
'address': 'foo',
'slug': 'foo',
'postcode': '',
'council': '',
'polling_station_id': ''
},
]
expected = set([
Address(address='foo',
slug='foo',
postcode='',
council='',
polling_station_id=''),
Address(address='bar',
slug='bar',
postcode='',
council='',
polling_station_id=''),
])
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
self.assertEqual(expected, address_list.elements)
def test_add_with_duplicates(self):
in_list = [
{'address': 'foo', 'slug': 'foo', 'postcode': '', 'council': '', 'polling_station_id': ''},
{'address': 'bar', 'slug': 'bar', 'postcode': '', 'council': '', 'polling_station_id': ''},
{'address': 'foo', 'slug': 'foo', 'postcode': '', 'council': '', 'polling_station_id': ''},
]
expected = set([
Address(
address='foo', slug='foo', postcode='', council='', polling_station_id=''),
Address(
address='bar', slug='bar', postcode='', council='', polling_station_id=''),
])
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
self.assertEqual(expected, address_list.elements)
def test_remove_ambiguous_addresses_some_stations_match(self):
# if one polling station doesn't match, we should remove all of them
in_list = [
{
"address": "Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "a",
"uprn": "",
},
{
"address": "Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "b",
"uprn": "",
},
{
"address": "Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AB",
"council": "",
"slug": "c",
"uprn": "",
},
{
"address": "Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "d",
"uprn": "",
},
]
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
result = address_set.remove_ambiguous_addresses()
self.assertEqual(set(), result)
def test_remove_ambiguous_addresses_some_stations_match(self):
# if one polling station doesn't match, we should remove all of them
in_list = [
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AA',
'council': '',
'slug': 'a'
},
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AA',
'council': '',
'slug': 'b'
},
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AB',
'council': '',
'slug': 'c'
},
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AA',
'council': '',
'slug': 'd'
},
]
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
result = address_list.remove_ambiguous_addresses()
self.assertEqual(set(), result)
def test_remove_ambiguous_addresses_some_stations_match(self):
# if one polling station doesn't match, we should remove all of them
in_list = [
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AA',
'council': '',
'slug': 'a'
},
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AA',
'council': '',
'slug': 'b'
},
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AB',
'council': '',
'slug': 'c'
},
{
'address': 'Abbeyvale Dr, Liverpool',
'postcode': 'L252NW',
'polling_station_id': 'AA',
'council': '',
'slug': 'd'
},
]
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
result = address_list.remove_ambiguous_addresses()
self.assertEqual(set(), result)
def test_attach_doorstep_grid_refs(self):
in_list = [
{
"address": "1 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "a",
"uprn": "00001",
},
{
"address": "4 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "d",
"uprn": "00004",
},
]
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
addressbase = {
# 00001 is in here but 00004 isn't
"00001": {
"location": "SRID=4326;POINT(-0.9288492 53.3119342)"
}
}
address_set.elements = address_set.attach_doorstep_gridrefs(
addressbase)
self.assertEqual(2, len(address_set.elements))
for el in address_set.elements:
if el.uprn == "00001":
self.assertEqual("SRID=4326;POINT(-0.9288492 53.3119342)",
el.location)
if el.uprn == "00004":
self.assertEqual(None, el.location)
def test_remove_ambiguous_addresses_fuzzymatch(self):
"""
The addresses:
- 5-6 Mickleton Dr, Southport, PR82QX
- 5/6, Mickleton Dr. Southport, PR82QX
- 5-6 mickleton dr southport, PR82QX
should all be considered the same address.
The addresses:
- 56 Mickleton Dr, Southport, PR82QX
- 5-6 Mickleton Dr, Southport, BT281QZ
should be identified as different.
"""
in_list = [
{
'address': '5-6 Mickleton Dr, Southport',
'postcode': 'PR82QX',
'polling_station_id': 'A01',
'council': '',
'slug': 'a'
},
{
'address': '5/6, Mickleton Dr. Southport',
'postcode': 'PR82QX',
'polling_station_id': 'A02',
'council': '',
'slug': 'b'
},
{
'address': '5-6 mickleton dr southport',
'postcode': 'PR82QX',
'polling_station_id': 'A03',
'council': '',
'slug': 'c'
},
{
'address': '56 Mickleton Dr, Southport',
'postcode': 'PR82QX',
'polling_station_id': 'A04',
'council': '',
'slug': 'd'
},
{
'address': '5-6 Mickleton Dr, Southport',
'postcode': 'BT281QZ',
'polling_station_id': 'A05',
'council': '',
'slug': 'e'
},
]
expected = set([
Address(
address='56 Mickleton Dr, Southport',
postcode='PR82QX',
polling_station_id='A04',
council='',
slug='d'),
Address(
address='5-6 Mickleton Dr, Southport',
postcode='BT281QZ',
polling_station_id='A05',
council='',
slug='e'),
])
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
result = address_list.remove_ambiguous_addresses()
self.assertEqual(expected, result)
def test_remove_ambiguous_addresses_fuzzymatch(self):
"""
The addresses:
- 5-6 Mickleton Dr, Southport, PR82QX
- 5/6, Mickleton Dr. Southport, PR82QX
- 5-6 mickleton dr southport, PR82QX
should all be considered the same address.
The addresses:
- 56 Mickleton Dr, Southport, PR82QX
- 5-6 Mickleton Dr, Southport, BT281QZ
should be identified as different.
"""
in_list = [
{
'address': '5-6 Mickleton Dr, Southport',
'postcode': 'PR82QX',
'polling_station_id': 'A01',
'council': '',
'slug': 'a'
},
{
'address': '5/6, Mickleton Dr. Southport',
'postcode': 'PR82QX',
'polling_station_id': 'A02',
'council': '',
'slug': 'b'
},
{
'address': '5-6 mickleton dr southport',
'postcode': 'PR82QX',
'polling_station_id': 'A03',
'council': '',
'slug': 'c'
},
{
'address': '56 Mickleton Dr, Southport',
'postcode': 'PR82QX',
'polling_station_id': 'A04',
'council': '',
'slug': 'd'
},
{
'address': '5-6 Mickleton Dr, Southport',
'postcode': 'BT281QZ',
'polling_station_id': 'A05',
'council': '',
'slug': 'e'
},
]
expected = set([
Address(address='56 Mickleton Dr, Southport',
postcode='PR82QX',
polling_station_id='A04',
council='',
slug='d'),
Address(address='5-6 Mickleton Dr, Southport',
postcode='BT281QZ',
polling_station_id='A05',
council='',
slug='e'),
])
address_list = AddressSet(MockLogger())
for el in in_list:
address_list.add(el)
result = address_list.remove_ambiguous_addresses()
self.assertEqual(expected, result)
def test_remove_invalid_uprns(self):
in_list = [
{
"address": "1 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "a",
"uprn": "00001",
},
{
"address": "2 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "b",
"uprn": "00002",
},
{
"address": "3 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AB",
"council": "",
"slug": "c",
"uprn": "00003",
},
{
"address": "4 Abbeyvale Dr, Liverpool",
"postcode": "L252NW",
"polling_station_id": "AA",
"council": "",
"slug": "d",
"uprn": "00004",
},
]
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
addressbase = {
"00001": {
"postcode": "L252NW",
"address": "1 Abbeyvale Dr, Liverpool",
"location": "SRID=4326;POINT(-0.9288492 53.3119342)",
},
"00002": {
"postcode": "L252NW",
"address": "2 Abbeyvale Dr, Liverpool",
"location": "SRID=4326;POINT(-0.9288480 53.3119345)",
},
"00003": {
"postcode":
"L252XX", # this postcode doesn't match with the input record
"address": "2 Abbeyvale Dr, Liverpool",
"location": "SRID=4326;POINT(-0.9288400 53.3119332)",
}
# 00004 is not in here
}
address_set.elements = address_set.remove_invalid_uprns(addressbase)
# 00003 and 00004 should still be in the set
self.assertEqual(4, len(address_set.elements))
# but those records should now have a blank uprn
for el in address_set.elements:
assert el.uprn in ["00001", "00002", ""]
def test_remove_ambiguous_addresses_fuzzymatch(self):
"""
The addresses:
- 5-6 Mickleton Dr, Southport, PR82QX
- 5/6, Mickleton Dr. Southport, PR82QX
- 5-6 mickleton dr southport, PR82QX
should all be considered the same address.
The addresses:
- 56 Mickleton Dr, Southport, PR82QX
- 5-6 Mickleton Dr, Southport, BT281QZ
should be identified as different.
"""
in_list = [
{
"address": "5-6 Mickleton Dr, Southport",
"postcode": "PR82QX",
"polling_station_id": "A01",
"council": "",
"slug": "a",
"uprn": "",
},
{
"address": "5/6, Mickleton Dr. Southport",
"postcode": "PR82QX",
"polling_station_id": "A02",
"council": "",
"slug": "b",
"uprn": "",
},
{
"address": "5-6 mickleton dr southport",
"postcode": "PR82QX",
"polling_station_id": "A03",
"council": "",
"slug": "c",
"uprn": "",
},
{
"address": "56 Mickleton Dr, Southport",
"postcode": "PR82QX",
"polling_station_id": "A04",
"council": "",
"slug": "d",
"uprn": "",
},
{
"address": "5-6 Mickleton Dr, Southport",
"postcode": "BT281QZ",
"polling_station_id": "A05",
"council": "",
"slug": "e",
"uprn": "",
},
{
"address": "56 Mickleton Dr, Southport",
"postcode": "BT281QZ",
"polling_station_id": "A04",
"council": "",
"slug": "f",
"uprn": "",
},
]
expected = set([
Address(
address="5-6 Mickleton Dr, Southport",
postcode="BT281QZ",
polling_station_id="A05",
council="",
slug="e",
uprn="",
location=None,
),
Address(
address="56 Mickleton Dr, Southport",
postcode="BT281QZ",
polling_station_id="A04",
council="",
slug="f",
uprn="",
location=None,
),
])
address_set = AddressSet(MockLogger())
for el in in_list:
address_set.add(el)
result = address_set.remove_ambiguous_addresses()
self.assertEqual(expected, result)
