def test_regression_mishandling_multiple_reviews_okay_reviews(
pull_request: PullRequest,
config: V1,
branch_protection: BranchProtectionRule,
check_run: CheckRun,
context: StatusContext,
) -> None:
pull_request.mergeStateStatus = MergeStateStatus.BEHIND
branch_protection.requiresApprovingReviews = True
branch_protection.requiredApprovingReviewCount = 1
first_review_date = datetime(2010, 5, 15)
latest_review_date = first_review_date + timedelta(minutes=20)
reviews = [
PRReview(
state=PRReviewState.CHANGES_REQUESTED,
createdAt=first_review_date,
author=PRReviewAuthor(login="******"),
authorAssociation=CommentAuthorAssociation.CONTRIBUTOR,
),
PRReview(
state=PRReviewState.COMMENTED,
createdAt=latest_review_date,
author=PRReviewAuthor(login="******"),
authorAssociation=CommentAuthorAssociation.CONTRIBUTOR,
),
PRReview(
state=PRReviewState.APPROVED,
createdAt=latest_review_date,
author=PRReviewAuthor(login="******"),
authorAssociation=CommentAuthorAssociation.CONTRIBUTOR,
),
PRReview(
state=PRReviewState.APPROVED,
createdAt=latest_review_date,
author=PRReviewAuthor(login="******"),
authorAssociation=CommentAuthorAssociation.CONTRIBUTOR,
),
]
with pytest.raises(NeedsBranchUpdate):
mergeable(
config=config,
pull_request=pull_request,
branch_protection=branch_protection,
review_requests_count=1,
reviews=reviews,
check_runs=[check_run],
contexts=[context],
valid_signature=False,
valid_merge_methods=[MergeMethod.squash],
)
async def test_get_reviewers_and_permissions_empty_author(
mocker: Any, api_client: Client) -> None:
"""
We should ignore reviews with missing authors.
`author` becomes null if the GitHub user's account is deleted. This is shown
in the GitHub UI as the "ghost" user.
"""
async def get_permissions_for_username_patch(username: str) -> Permission:
if username == "jdoe":
return Permission.WRITE
raise Exception
mocker.patch.object(api_client, "get_permissions_for_username",
get_permissions_for_username_patch)
res = await api_client.get_reviewers_and_permissions(reviews=[
PRReviewSchema(
createdAt=datetime.fromisoformat("2019-05-22T15:29:34+00:00"),
state=PRReviewState.COMMENTED,
author=PRReviewAuthorSchema(login="******", type=Actor.User),
),
PRReviewSchema(
createdAt=datetime.fromisoformat("2019-05-22T15:29:52+00:00"),
state=PRReviewState.APPROVED,
author=None,
),
])
assert res == [
PRReview(
createdAt=datetime.fromisoformat("2019-05-22T15:29:34+00:00"),
state=PRReviewState.COMMENTED,
author=PRReviewAuthor(login="******", permission=Permission.WRITE),
)
]
def test_blocking_review(
pull_request: PullRequest,
config: V1,
branch_protection: BranchProtectionRule,
review: PRReview,
context: StatusContext,
) -> None:
pull_request.mergeStateStatus = MergeStateStatus.BLOCKED
review.state = PRReviewState.CHANGES_REQUESTED
with pytest.raises(NotQueueable, match="blocking review"):
mergeable(
config=config,
pull_request=pull_request,
branch_protection=branch_protection,
review_requests_count=0,
reviews=[review],
contexts=[context],
check_runs=[],
valid_signature=False,
valid_merge_methods=[MergeMethod.squash],
)
def block_event() -> EventInfoResponse:
config = V1(version=1,
merge=Merge(automerge_label="automerge",
method=MergeMethod.squash))
pr = PullRequest(
id="e14ff7599399478fb9dbc2dacb87da72",
number=100,
author=PullRequestAuthor(login="******", databaseId=49118, type="Bot"),
mergeStateStatus=MergeStateStatus.BEHIND,
state=PullRequestState.OPEN,
mergeable=MergeableState.MERGEABLE,
isCrossRepository=False,
labels=["automerge"],
latest_sha="8d728d017cac4f5ba37533debe65730abe65730a",
baseRefName="master",
headRefName="df825f90-9825-424c-a97e-733522027e4c",
title="Update README.md",
body="",
bodyText="",
bodyHTML="",
url="https://github.com/delos-corp/hive-mind/pull/324",
)
rep_info = RepoInfo(
merge_commit_allowed=False,
rebase_merge_allowed=False,
squash_merge_allowed=True,
delete_branch_on_merge=True,
is_private=True,
)
branch_protection = BranchProtectionRule(
requiresApprovingReviews=True,
requiredApprovingReviewCount=2,
requiresStatusChecks=True,
requiredStatusCheckContexts=[
"ci/circleci: backend_lint",
"ci/circleci: backend_test",
"ci/circleci: frontend_lint",
"ci/circleci: frontend_test",
"WIP (beta)",
],
requiresStrictStatusChecks=True,
requiresCommitSignatures=False,
restrictsPushes=True,
pushAllowances=NodeListPushAllowance(nodes=[
PushAllowance(actor=PushAllowanceActor(databaseId=None)),
PushAllowance(actor=PushAllowanceActor(databaseId=53453)),
]),
)
return EventInfoResponse(
config=config,
config_str="""\
version = 1
[merge]
method = "squash"
""",
config_file_expression="master:.kodiak.toml",
head_exists=True,
pull_request=pr,
repository=rep_info,
subscription=Subscription(
account_id="D1606A79-A1A1-4550-BA7B-C9ED0D792B1E",
subscription_blocker=None),
branch_protection=branch_protection,
review_requests=[
PRReviewRequest(name="ghost"),
PRReviewRequest(name="ghost-team"),
PRReviewRequest(name="ghost-mannequin"),
],
reviews=[
PRReview(
createdAt=arrow.get("2019-05-22T15:29:34Z").datetime,
state=PRReviewState.COMMENTED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-22T15:29:52Z").datetime,
state=PRReviewState.CHANGES_REQUESTED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-22T15:30:52Z").datetime,
state=PRReviewState.COMMENTED,
author=PRReviewAuthor(login="******",
permission=Permission.ADMIN),
),
PRReview(
createdAt=arrow.get("2019-05-22T15:43:17Z").datetime,
state=PRReviewState.APPROVED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-23T15:13:29Z").datetime,
state=PRReviewState.APPROVED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-24T10:21:32Z").datetime,
state=PRReviewState.APPROVED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
],
status_contexts=[
StatusContext(context="ci/circleci: backend_lint",
state=StatusState.SUCCESS),
StatusContext(context="ci/circleci: backend_test",
state=StatusState.SUCCESS),
StatusContext(context="ci/circleci: frontend_lint",
state=StatusState.SUCCESS),
StatusContext(context="ci/circleci: frontend_test",
state=StatusState.SUCCESS),
],
check_runs=[
CheckRun(name="WIP (beta)",
conclusion=CheckConclusionState.SUCCESS)
],
valid_signature=True,
valid_merge_methods=[MergeMethod.squash],
)
def block_event(config_file_expression: str,
config_str: str) -> EventInfoResponse:
config = V1(version=1,
merge=Merge(automerge_label="automerge",
method=MergeMethod.squash))
pr = PullRequest(
id="e14ff7599399478fb9dbc2dacb87da72",
number=100,
mergeStateStatus=MergeStateStatus.BEHIND,
state=PullRequestState.OPEN,
mergeable=MergeableState.MERGEABLE,
isCrossRepository=False,
labels=["automerge"],
latest_sha="8d728d017cac4f5ba37533debe65730abe65730a",
baseRefName="master",
headRefName="df825f90-9825-424c-a97e-733522027e4c",
title="Update README.md",
body="",
bodyText="",
bodyHTML="",
)
rep_info = RepoInfo(
merge_commit_allowed=False,
rebase_merge_allowed=False,
squash_merge_allowed=True,
)
branch_protection = BranchProtectionRule(
requiresApprovingReviews=True,
requiredApprovingReviewCount=2,
requiresStatusChecks=True,
requiredStatusCheckContexts=[
"ci/circleci: backend_lint",
"ci/circleci: backend_test",
"ci/circleci: frontend_lint",
"ci/circleci: frontend_test",
"WIP (beta)",
],
requiresStrictStatusChecks=True,
requiresCommitSignatures=False,
)
return EventInfoResponse(
config=config,
config_str=config_str,
config_file_expression=config_file_expression,
head_exists=True,
pull_request=pr,
repo=rep_info,
branch_protection=branch_protection,
review_requests=[
PRReviewRequest(name="ghost"),
PRReviewRequest(name="ghost-team"),
PRReviewRequest(name="ghost-mannequin"),
],
reviews=[
PRReview(
createdAt=arrow.get("2019-05-22T15:29:34Z").datetime,
state=PRReviewState.COMMENTED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-22T15:29:52Z").datetime,
state=PRReviewState.CHANGES_REQUESTED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-22T15:30:52Z").datetime,
state=PRReviewState.COMMENTED,
author=PRReviewAuthor(login="******",
permission=Permission.ADMIN),
),
PRReview(
createdAt=arrow.get("2019-05-22T15:43:17Z").datetime,
state=PRReviewState.APPROVED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
PRReview(
createdAt=arrow.get("2019-05-23T15:13:29Z").datetime,
state=PRReviewState.APPROVED,
author=PRReviewAuthor(login="******",
permission=Permission.WRITE),
),
],
status_contexts=[
StatusContext(context="ci/circleci: backend_lint",
state=StatusState.SUCCESS),
StatusContext(context="ci/circleci: backend_test",
state=StatusState.SUCCESS),
StatusContext(context="ci/circleci: frontend_lint",
state=StatusState.SUCCESS),
StatusContext(context="ci/circleci: frontend_test",
state=StatusState.SUCCESS),
],
check_runs=[
CheckRun(name="WIP (beta)",
conclusion=CheckConclusionState.SUCCESS)
],
valid_signature=True,
valid_merge_methods=[MergeMethod.squash],
)
