def _assess_transplant_request(phab, landing_path):
nodes, edges = _find_stack_from_landing_path(phab, landing_path)
stack_data = request_extended_revision_data(phab, [phid for phid in nodes])
landing_path = _convert_path_id_to_phid(landing_path, stack_data)
supported_repos = get_repos_for_env(current_app.config.get('ENVIRONMENT'))
landable_repos = get_landable_repos_for_revision_data(
stack_data, supported_repos)
landable, blocked = calculate_landable_subgraphs(
stack_data,
edges,
landable_repos,
other_checks=DEFAULT_OTHER_BLOCKER_CHECKS)
assessment = check_landing_blockers(
g.auth0_user,
landing_path,
stack_data,
landable,
landable_repos,
)
if assessment.blocker is not None:
return (assessment, None, None, None)
# We have now verified that landable_path is valid and is indeed
# landable (in the sense that it is a landable_subgraph, with no
# revisions being blocked). Make this clear by using a different
# value, and assume it going forward.
valid_path = landing_path
# Now that we know this is a valid path we can convert it into a list
# of (revision, diff) tuples.
to_land = [stack_data.revisions[r_phid] for r_phid, _ in valid_path]
to_land = [
(r, stack_data.diffs[PhabricatorClient.expect(r, 'fields',
'diffPHID')])
for r in to_land
]
# To be a landable path the entire path must have the same
# repository, so we can get away with checking only one.
repo = stack_data.repositories[to_land[0][0]['fields']['repositoryPHID']]
landing_repo = landable_repos[repo['phid']]
involved_phids = set()
for revision, _ in to_land:
involved_phids.update(gather_involved_phids(revision))
involved_phids = list(involved_phids)
users = lazy_user_search(phab, involved_phids)()
projects = lazy_project_search(phab, involved_phids)()
reviewers = {
revision['phid']: get_collated_reviewers(revision)
for revision, _ in to_land
}
assessment = check_landing_warnings(g.auth0_user, to_land, repo,
landing_repo, reviewers, users,
projects)
return (assessment, to_land, landing_repo, stack_data)
def get(revision_id, diff_id=None):
"""Gets revision from Phabricator.
Args:
revision_id: (string) ID of the revision in 'D{number}' format
diff_id: (integer) Id of the diff to return with the revision. By
default the active diff will be returned.
"""
revision_id = revision_id_to_int(revision_id)
phab = g.phabricator
revision = phab.call_conduit('differential.revision.search',
constraints={'ids': [revision_id]},
attachments={
'reviewers': True,
'reviewers-extra': True,
})
revision = phab.single(revision, 'data', none_when_empty=True)
if revision is None:
return problem(
404,
'Revision not found',
'The requested revision does not exist',
type='https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404'
)
latest_diff = phab.single(
phab.call_conduit(
'differential.diff.search',
constraints={
'phids': [phab.expect(revision, 'fields', 'diffPHID')]
},
attachments={'commits': True},
), 'data')
latest_diff_id = phab.expect(latest_diff, 'id')
if diff_id is not None and diff_id != latest_diff_id:
diff = phab.single(phab.call_conduit(
'differential.diff.search',
constraints={'ids': [diff_id]},
attachments={'commits': True},
),
'data',
none_when_empty=True)
else:
diff = latest_diff
if diff is None:
return problem(
404,
'Diff not found',
'The requested diff does not exist',
type='https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404'
)
revision_phid = phab.expect(revision, 'phid')
if phab.expect(diff, 'fields', 'revisionPHID') != revision_phid:
return problem(
400,
'Diff not related to the revision',
'The requested diff is not related to the requested revision.',
type='https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400'
)
author_phid = phab.expect(revision, 'fields', 'authorPHID')
reviewers = get_collated_reviewers(revision)
# Immediately execute the lazy functions.
users = lazy_user_search(phab, list(reviewers.keys()) + [author_phid])()
projects = lazy_project_search(phab, list(reviewers.keys()))()
accepted_reviewers = [
reviewer_identity(phid, users, projects).identifier
for phid, r in reviewers.items()
if r['status'] is ReviewerStatus.ACCEPTED
]
title = phab.expect(revision, 'fields', 'title')
summary = phab.expect(revision, 'fields', 'summary')
bug_id = get_bugzilla_bug(revision)
human_revision_id = 'D{}'.format(revision_id)
revision_url = urllib.parse.urljoin(current_app.config['PHABRICATOR_URL'],
human_revision_id)
commit_message_title, commit_message = format_commit_message(
title, bug_id, accepted_reviewers, summary, revision_url)
reviewers_response = serialize_reviewers(reviewers, users, projects,
phab.expect(diff, 'phid'))
author_response = serialize_author(author_phid, users)
diff_response = serialize_diff(diff)
return {
'id': human_revision_id,
'phid': phab.expect(revision, 'phid'),
'bug_id': bug_id,
'title': title,
'url': revision_url,
'date_created': PhabricatorClient.to_datetime(
phab.expect(revision, 'fields', 'dateCreated')
).isoformat(),
'date_modified': PhabricatorClient.to_datetime(
phab.expect(revision, 'fields', 'dateModified')
).isoformat(),
'summary': summary,
'commit_message_title': commit_message_title,
'commit_message': commit_message,
'diff': diff_response,
'latest_diff_id': latest_diff_id,
'author': author_response,
'reviewers': reviewers_response,
}, 200 # yapf: disable
def post(data):
phab = g.phabricator
landing_path, confirmation_token = _unmarshal_transplant_request(data)
logger.info('transplant requested by user',
extra={
'has_confirmation_token': confirmation_token is not None,
'landing_path': landing_path,
})
assessment, to_land, landing_repo, stack_data = _assess_transplant_request(
phab, landing_path)
assessment.raise_if_blocked_or_unacknowledged(confirmation_token)
assert to_land is not None
assert landing_repo is not None
assert stack_data is not None
if assessment.warnings:
# Log any warnings that were acknowledged, for auditing.
logger.info(
'Transplant with acknowledged warnings is being requested',
extra={
'landing_path': landing_path,
'warnings': [
{
'i': w.i,
'revision_id': w.revision_id,
'details': w.details,
}
for w in assessment.warnings
],
}
) # yapf: disable
involved_phids = set()
for revision, _ in to_land:
involved_phids.update(gather_involved_phids(revision))
involved_phids = list(involved_phids)
users = lazy_user_search(phab, involved_phids)()
projects = lazy_project_search(phab, involved_phids)()
# Build the patches to land.
patch_urls = []
for revision, diff in to_land:
reviewers = get_collated_reviewers(revision)
accepted_reviewers = [
reviewer_identity(phid, users, projects).identifier
for phid, r in reviewers.items()
if r['status'] is ReviewerStatus.ACCEPTED
]
_, commit_message = format_commit_message(
phab.expect(revision, 'fields', 'title'),
get_bugzilla_bug(revision), accepted_reviewers,
phab.expect(revision, 'fields', 'summary'),
urllib.parse.urljoin(current_app.config['PHABRICATOR_URL'],
'D{}'.format(revision['id'])))
author_name, author_email = select_diff_author(diff)
date_modified = phab.expect(revision, 'fields', 'dateModified')
# Construct the patch that will be sent to transplant.
raw_diff = phab.call_conduit('differential.getrawdiff',
diffID=diff['id'])
patch = build_patch_for_revision(raw_diff, author_name, author_email,
commit_message, date_modified)
# Upload the patch to S3
patch_url = upload(
revision['id'],
diff['id'],
patch,
current_app.config['PATCH_BUCKET_NAME'],
aws_access_key=current_app.config['AWS_ACCESS_KEY'],
aws_secret_key=current_app.config['AWS_SECRET_KEY'],
)
patch_urls.append(patch_url)
trans = TransplantClient(
current_app.config['TRANSPLANT_URL'],
current_app.config['TRANSPLANT_USERNAME'],
current_app.config['TRANSPLANT_PASSWORD'],
)
submitted_assessment = TransplantAssessment(
blocker=('This stack was submitted for landing by another user '
'at the same time.'))
ldap_username = g.auth0_user.email
revision_to_diff_id = {str(r['id']): d['id'] for r, d in to_land}
revision_order = [str(r['id']) for r, _ in to_land]
stack_ids = [r['id'] for r in stack_data.revisions.values()]
# We pass the revision id of the base of our landing path to
# transplant in rev as it must be unique until the request
# has been serviced. While this doesn't use Autoland Transplant
# to enforce not requesting from the same stack again, Lando
# ensures this itself.
root_revision_id = to_land[0][0]['id']
try:
# WARNING: Entering critical section, do not add additional
# code unless absolutely necessary. Acquires a lock on the
# transplants table which gives exclusive write access and
# prevents readers who are entering this critical section.
# See https://www.postgresql.org/docs/9.3/static/explicit-locking.html
# for more details on the specifics of the lock mode.
with db.session.begin_nested():
db.session.execute(
'LOCK TABLE transplants IN SHARE ROW EXCLUSIVE MODE;')
if Transplant.revisions_query(stack_ids).filter_by(
status=TransplantStatus.submitted).first() is not None:
submitted_assessment.raise_if_blocked_or_unacknowledged(None)
transplant_request_id = trans.land(
revision_id=root_revision_id,
ldap_username=ldap_username,
patch_urls=patch_urls,
tree=landing_repo.tree,
pingback=current_app.config['PINGBACK_URL'],
push_bookmark=landing_repo.push_bookmark)
transplant = Transplant(request_id=transplant_request_id,
revision_to_diff_id=revision_to_diff_id,
revision_order=revision_order,
requester_email=ldap_username,
tree=landing_repo.tree,
repository_url=landing_repo.url,
status=TransplantStatus.submitted)
db.session.add(transplant)
except TransplantError as exc:
logger.exception(
'error creating transplant',
extra={'landing_path': landing_path},
)
return problem(
502,
'Transplant not created',
'The requested landing_path is valid, but transplant failed.'
'Please retry your request at a later time.',
type='https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/502'
)
# Transaction succeeded, commit the session.
db.session.commit()
logger.info('transplant created',
extra={
'landing_path': landing_path,
'transplant_id': transplant.id,
})
return {'id': transplant.id}, 202
def get(revision_id):
"""Get the stack a revision is part of.
Args:
revision_id: (string) ID of the revision in 'D{number}' format
"""
revision_id = revision_id_to_int(revision_id)
phab = g.phabricator
revision = phab.call_conduit(
'differential.revision.search',
constraints={'ids': [revision_id]},
)
revision = phab.single(revision, 'data', none_when_empty=True)
if revision is None:
return problem(
404,
'Revision not found',
'The requested revision does not exist',
type='https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404'
)
# TODO: This assumes that all revisions and related objects in the stack
# have uniform view permissions for the requesting user. Some revisions
# being restricted could cause this to fail.
nodes, edges = build_stack_graph(phab, phab.expect(revision, 'phid'))
stack_data = request_extended_revision_data(phab, [phid for phid in nodes])
supported_repos = get_repos_for_env(current_app.config.get('ENVIRONMENT'))
landable_repos = get_landable_repos_for_revision_data(
stack_data, supported_repos
)
landable, blocked = calculate_landable_subgraphs(
stack_data,
edges,
landable_repos,
other_checks=DEFAULT_OTHER_BLOCKER_CHECKS
)
involved_phids = set()
for revision in stack_data.revisions.values():
involved_phids.update(gather_involved_phids(revision))
involved_phids = list(involved_phids)
users = lazy_user_search(phab, involved_phids)()
projects = lazy_project_search(phab, involved_phids)()
revisions_response = []
for phid, revision in stack_data.revisions.items():
revision_phid = PhabricatorClient.expect(revision, 'phid')
fields = PhabricatorClient.expect(revision, 'fields')
diff_phid = PhabricatorClient.expect(fields, 'diffPHID')
diff = stack_data.diffs[diff_phid]
human_revision_id = 'D{}'.format(
PhabricatorClient.expect(revision, 'id')
)
revision_url = urllib.parse.urljoin(
current_app.config['PHABRICATOR_URL'], human_revision_id
)
title = PhabricatorClient.expect(fields, 'title')
summary = PhabricatorClient.expect(fields, 'summary')
bug_id = get_bugzilla_bug(revision)
reviewers = get_collated_reviewers(revision)
accepted_reviewers = [
reviewer_identity(phid, users, projects).identifier
for phid, r in reviewers.items()
if r['status'] is ReviewerStatus.ACCEPTED
]
commit_message_title, commit_message = format_commit_message(
title, bug_id, accepted_reviewers, summary, revision_url
)
author_response = serialize_author(
phab.expect(fields, 'authorPHID'), users
)
revisions_response.append({
'id': human_revision_id,
'phid': revision_phid,
'status': serialize_status(revision),
'blocked_reason': blocked.get(revision_phid, ''),
'bug_id': bug_id,
'title': title,
'url': revision_url,
'date_created': PhabricatorClient.to_datetime(
PhabricatorClient.expect(revision, 'fields', 'dateCreated')
).isoformat(),
'date_modified': PhabricatorClient.to_datetime(
PhabricatorClient.expect(revision, 'fields', 'dateModified')
).isoformat(),
'summary': summary,
'commit_message_title': commit_message_title,
'commit_message': commit_message,
'diff': serialize_diff(diff),
'author': author_response,
'reviewers': serialize_reviewers(
reviewers, users, projects, diff_phid
),
}) # yapf: disable
return {
'revisions': revisions_response,
'edges': [e for e in edges],
'landable_paths': landable,
}