def test_configs(self): """All yaml files in metrics are valid.""" config_metrics = set() for path in bigquery.all_configs(search='**'): name = os.path.basename(path) if name in ['BUILD', 'README.md']: continue if not path.endswith('.yaml'): self.fail('Only .yaml files allowed: %s' % path) with open(path) as config_file: try: config = yaml.safe_load(config_file) except yaml.YAMLError: self.fail(path) self.assertIn('metric', config) self.assertIn('query', config) self.assertIn('jqfilter', config) self.assertIn('description', config) metric = config['metric'].strip() bigquery.validate_metric_name(metric) config_metrics.add(metric) configs = bigquery.all_configs() self.assertTrue(all(p.endswith('.yaml') for p in configs), configs) # Check that the '**' search finds the same number of yaml # files as the default search. self.assertEqual(len(configs), len(config_metrics)) # Check that config files correlate with metrics listed in # test-infra/metrics/README.md. with open('metrics/README.md') as readme_file: readme = readme_file.read() readme_metrics = set(re.findall( r'\(http://storage\.googleapis\.com/k8s-metrics/([\w-]+)-latest\.json\)', readme, )) missing = config_metrics - readme_metrics if missing: self.fail( 'test-infra/metrics/README.md is missing entries for metrics: %s.' % missing, ) extra = readme_metrics - config_metrics if extra: self.fail( 'test-infra/metrics/README.md includes metrics that are missing config files: %s.' % extra, ) # Check that all configs are linked in readme. self.assertTrue(all(os.path.basename(p) in readme for p in configs))
def test_configs(self): """All yaml files in metrics are valid.""" config_metrics = set() for path in bigquery.all_configs(search='**'): name = os.path.basename(path) if name in ['BUILD', 'BUILD.bazel', 'README.md']: continue if not path.endswith('.yaml'): self.fail('Only .yaml files allowed: %s' % path) with open(path) as config_file: try: config = yaml.safe_load(config_file) except yaml.YAMLError: self.fail(path) self.assertIn('metric', config) self.assertIn('query', config) self.assertIn('jqfilter', config) self.assertIn('description', config) metric = config['metric'].strip() bigquery.validate_metric_name(metric) config_metrics.add(metric) configs = bigquery.all_configs() self.assertTrue(all(p.endswith('.yaml') for p in configs), configs) # Check that the '**' search finds the same number of yaml # files as the default search. self.assertEqual(len(configs), len(config_metrics), "verify the `metric` feild is unique") # Check that config files correlate with metrics listed in # test-infra/metrics/README.md. with open(os.path.join(os.path.dirname(__file__), 'README.md')) as readme_file: readme = readme_file.read() readme_metrics = set(re.findall( r'\(http://storage\.googleapis\.com/k8s-metrics/([\w-]+)-latest\.json\)', readme, )) missing = config_metrics - readme_metrics if missing: self.fail( 'test-infra/metrics/README.md is missing entries for metrics: %s.' % ', '.join(sorted(missing)), ) extra = readme_metrics - config_metrics if extra: self.fail( 'test-infra/metrics/README.md includes metrics that are missing config files: %s.' % ', '.join(sorted(extra)), ) # Check that all configs are linked in readme. self.assertTrue(all(os.path.basename(p) in readme for p in configs))
def test_validate_metric_name(self): """validate_metric_name rejects invalid metric names.""" bigquery.validate_metric_name('normal') def check(test): """Check invalid names.""" self.assertRaises(ValueError, bigquery.validate_metric_name, test) check('invalid#metric') check('invalid/metric') check('in\\valid') check('invalid?yes') check('*invalid') check('[metric]') check('metric\n') check('met\ric') check('metric& invalid')
def test_validate_metric_name(self): """validate_metric_name rejects invalid metric names.""" bigquery.validate_metric_name('normal') def check(test): """Check invalid names.""" self.assertRaises(ValueError, bigquery.validate_metric_name, test) check('invalid#metric') check('invalid/metric') check('in\\valid') check('invalid?yes') check('*invalid') check('[metric]') check('metric\n') check('met\ric') check('metric& invalid')
def test_configs(self): """All yaml files in metrics are valid.""" for path in bigquery.all_configs(search='**'): name = os.path.basename(path) if name in ['BUILD', 'README.md']: continue if not path.endswith('.yaml'): self.fail('Only .yaml files allowed: %s' % path) with open(path) as config_file: config = yaml.safe_load(config_file) if not config: self.fail(path) self.assertIn('metric', config) self.assertIn('query', config) self.assertIn('jqfilter', config) bigquery.validate_metric_name(config['metric'].strip()) configs = bigquery.all_configs() self.assertTrue(all(p.endswith('.yaml') for p in configs), configs)