def test_full_file(mock_config, mock_phabricator, mock_try_task):
"""
Test Phabricator reporter supports an issue on a full file
"""
from code_review_bot.report.phabricator import PhabricatorReporter
from code_review_bot.revisions import Revision
from code_review_bot.tasks.default import DefaultIssue
def _check_comment(request):
# Check the Phabricator main comment is well formed
payload = urllib.parse.parse_qs(request.body)
assert payload["output"] == ["json"]
assert len(payload["params"]) == 1
details = json.loads(payload["params"][0])
assert details["message"] == VALID_DEFAULT_MESSAGE.format(
results=mock_config.taskcluster.results_dir)
# Outputs dummy empty response
resp = {"error_code": None, "result": None}
return (
201,
{
"Content-Type": "application/json",
"unittest": "full-file-comment"
},
json.dumps(resp),
)
def _check_inline(request):
# Check the inline does not have a null value for line
payload = urllib.parse.parse_qs(request.body)
assert payload["output"] == ["json"]
assert len(payload["params"]) == 1
details = json.loads(payload["params"][0])
assert details == {
"__conduit__": {
"token": "deadbeef"
},
"content":
"Error: Something bad happened on the whole file ! [a-huge-issue]",
"diffID": 42,
"filePath": "xx.cpp",
"isNewFile": 1,
"lineLength": -1,
# Cannot be null for a full file as it's not supported by phabricator
"lineNumber": 1,
}
# Outputs dummy empty response
resp = {"error_code": None, "result": {"id": "PHID-XXXX-YYYYY"}}
return (
201,
{
"Content-Type": "application/json",
"unittest": "full-file-inline"
},
json.dumps(resp),
)
responses.add_callback(
responses.POST,
"http://phabricator.test/api/differential.createinline",
callback=_check_inline,
)
responses.add_callback(
responses.POST,
"http://phabricator.test/api/differential.createcomment",
callback=_check_comment,
)
with mock_phabricator as api:
revision = Revision(api, mock_try_task)
revision.lines = {
# Add dummy lines diff
"xx.cpp": [123, 124, 125]
}
revision.files = list(revision.lines.keys())
reporter = PhabricatorReporter(api=api)
issue = DefaultIssue(
analyzer="full-file-analyzer",
revision=revision,
path="xx.cpp",
line=-1,
nb_lines=0,
check="a-huge-issue",
message="Something bad happened on the whole file !",
)
assert issue.line is None # check auto conversion
assert str(
issue
) == "full-file-analyzer issue a-huge-issue@error xx.cpp full file"
assert issue.is_publishable()
assert revision.has_file(issue.path)
assert revision.contains(issue)
issues, patches = reporter.publish([issue], revision, [])
assert len(issues) == 1
assert len(patches) == 0
# Check the comment callback has been used
assert len(responses.calls) > 0
call = responses.calls[-1]
assert call.request.url == "http://phabricator.test/api/differential.createcomment"
assert call.response.headers.get("unittest") == "full-file-comment"
# Check the inline callback has been used
call = responses.calls[-2]
assert call.request.url == "http://phabricator.test/api/differential.createinline"
assert call.response.headers.get("unittest") == "full-file-inline"
def test_phabricator_clang_tidy(mock_phabricator, mock_try_task):
"""
Test Phabricator reporter publication on a mock clang-tidy issue
"""
from code_review_bot.report.phabricator import PhabricatorReporter
from code_review_bot.revisions import Revision
from code_review_bot.tasks.clang_tidy import ClangTidyIssue
def _check_comment(request):
# Check the Phabricator main comment is well formed
payload = urllib.parse.parse_qs(request.body)
assert payload["output"] == ["json"]
assert len(payload["params"]) == 1
details = json.loads(payload["params"][0])
assert details == {
"revision_id": 51,
"message": VALID_CLANG_TIDY_MESSAGE,
"attach_inlines": 1,
"__conduit__": {
"token": "deadbeef"
},
}
# Outputs dummy empty response
resp = {"error_code": None, "result": None}
return (
201,
{
"Content-Type": "application/json",
"unittest": "clang-tidy"
},
json.dumps(resp),
)
responses.add_callback(
responses.POST,
"http://phabricator.test/api/differential.createcomment",
callback=_check_comment,
)
with mock_phabricator as api:
revision = Revision(api, mock_try_task)
revision.lines = {
# Add dummy lines diff
"another_test.cpp": [41, 42, 43]
}
revision.files = ["another_test.cpp"]
reporter = PhabricatorReporter(
{
"analyzers": ["clang-tidy"],
"modes": ("comment")
}, api=api)
issue = ClangTidyIssue(
"mock-clang-tidy",
revision,
"another_test.cpp",
"42",
"51",
"modernize-use-nullptr",
"dummy message",
"error",
)
assert issue.is_publishable()
issues, patches = reporter.publish([issue], revision, [])
assert len(issues) == 1
assert len(patches) == 0
# Check the callback has been used
assert len(responses.calls) > 0
call = responses.calls[-1]
assert call.request.url == "http://phabricator.test/api/differential.createcomment"
assert call.response.headers.get("unittest") == "clang-tidy"
