class ImportCommandTest(unittest.TestCase):
@patch("hummingbot.core.utils.trading_pair_fetcher.TradingPairFetcher")
def setUp(self, _: MagicMock) -> None:
super().setUp()
self.ev_loop = asyncio.get_event_loop()
self.app = HummingbotApplication()
self.cli_mock_assistant = CLIMockingAssistant(self.app.app)
self.cli_mock_assistant.start()
def tearDown(self) -> None:
self.cli_mock_assistant.stop()
super().tearDown()
@staticmethod
async def raise_timeout(*args, **kwargs):
raise asyncio.TimeoutError
def async_run_with_timeout(self, coroutine: Awaitable, timeout: float = 1):
ret = self.ev_loop.run_until_complete(asyncio.wait_for(coroutine, timeout))
return ret
def async_run_with_timeout_coroutine_must_raise_timeout(self, coroutine: Awaitable, timeout: float = 1):
class DesiredError(Exception):
pass
async def run_coro_that_raises(coro: Awaitable):
try:
await coro
except asyncio.TimeoutError:
raise DesiredError
try:
self.async_run_with_timeout(run_coro_that_raises(coroutine), timeout)
except DesiredError: # the coroutine raised an asyncio.TimeoutError as expected
raise asyncio.TimeoutError
except asyncio.TimeoutError: # the coroutine did not finish on time
raise RuntimeError
@patch("hummingbot.client.command.import_command.update_strategy_config_map_from_file")
@patch("hummingbot.client.command.status_command.StatusCommand.status_check_all")
def test_import_config_file_success(
self, status_check_all_mock: AsyncMock, update_strategy_config_map_from_file: AsyncMock
):
strategy_name = "some-strategy"
strategy_file_name = f"{strategy_name}.yml"
status_check_all_mock.return_value = True
update_strategy_config_map_from_file.return_value = strategy_name
self.async_run_with_timeout(self.app.import_config_file(strategy_file_name))
self.assertEqual(strategy_file_name, self.app.strategy_file_name)
self.assertEqual(strategy_name, self.app.strategy_name)
self.assertTrue(
self.cli_mock_assistant.check_log_called_with("\nEnter \"start\" to start market making.")
)
@patch("hummingbot.client.command.import_command.update_strategy_config_map_from_file")
@patch("hummingbot.client.command.status_command.StatusCommand.status_check_all")
def test_import_config_file_handles_network_timeouts(
self, status_check_all_mock: AsyncMock, update_strategy_config_map_from_file: AsyncMock
):
strategy_name = "some-strategy"
strategy_file_name = f"{strategy_name}.yml"
status_check_all_mock.side_effect = self.raise_timeout
update_strategy_config_map_from_file.return_value = strategy_name
with self.assertRaises(asyncio.TimeoutError):
self.async_run_with_timeout_coroutine_must_raise_timeout(
self.app.import_config_file(strategy_file_name)
)
self.assertEqual(None, self.app.strategy_file_name)
self.assertEqual(None, self.app.strategy_name)
class ImportCommandTest(unittest.TestCase):
@patch("hummingbot.core.utils.trading_pair_fetcher.TradingPairFetcher")
def setUp(self, _: MagicMock) -> None:
super().setUp()
self.ev_loop = asyncio.get_event_loop()
self.async_run_with_timeout(read_system_configs_from_yml())
self.app = HummingbotApplication()
self.cli_mock_assistant = CLIMockingAssistant(self.app.app)
self.cli_mock_assistant.start()
def tearDown(self) -> None:
self.cli_mock_assistant.stop()
super().tearDown()
@staticmethod
async def raise_timeout(*args, **kwargs):
raise asyncio.TimeoutError
def async_run_with_timeout(self, coroutine: Awaitable, timeout: float = 1):
ret = self.ev_loop.run_until_complete(
asyncio.wait_for(coroutine, timeout))
return ret
def async_run_with_timeout_coroutine_must_raise_timeout(
self, coroutine: Awaitable, timeout: float = 1):
class DesiredError(Exception):
pass
async def run_coro_that_raises(coro: Awaitable):
try:
await coro
except asyncio.TimeoutError:
raise DesiredError
try:
self.async_run_with_timeout(run_coro_that_raises(coroutine),
timeout)
except DesiredError: # the coroutine raised an asyncio.TimeoutError as expected
raise asyncio.TimeoutError
except asyncio.TimeoutError: # the coroutine did not finish on time
raise RuntimeError
@staticmethod
def build_dummy_strategy_config_cls(
strategy_name: str) -> Type[BaseClientModel]:
class SomeEnum(ClientConfigEnum):
ONE = "one"
class DoubleNestedModel(BaseClientModel):
double_nested_attr: datetime = Field(
default=datetime(2022, 1, 1, 10, 30),
description="Double nested attr description")
class NestedModel(BaseClientModel):
nested_attr: str = Field(
default="some value",
description="Nested attr\nmultiline description",
)
double_nested_model: DoubleNestedModel = Field(
default=DoubleNestedModel(), )
class DummyModel(BaseTradingStrategyConfigMap):
strategy: str = strategy_name
exchange: str = "binance"
market: str = "BTC-USDT"
some_attr: SomeEnum = Field(
default=SomeEnum.ONE,
description="Some description",
)
nested_model: NestedModel = Field(
default=NestedModel(),
description="Nested model description",
)
another_attr: Decimal = Field(
default=Decimal("1.0"),
description="Some other\nmultiline description",
)
non_nested_no_description: time = Field(default=time(10, 30), )
date_attr: date = Field(default=date(2022, 1, 2))
no_default: str = Field(default=...)
class Config:
title = "dummy_model"
return DummyModel
@patch(
"hummingbot.client.command.import_command.load_strategy_config_map_from_file"
)
@patch(
"hummingbot.client.command.status_command.StatusCommand.status_check_all"
)
def test_import_config_file_success_legacy(
self, status_check_all_mock: AsyncMock,
load_strategy_config_map_from_file: AsyncMock):
strategy_name = "some_strategy"
strategy_file_name = f"{strategy_name}.yml"
status_check_all_mock.return_value = True
strategy_conf_var = ConfigVar("strategy", None)
strategy_conf_var.value = strategy_name
load_strategy_config_map_from_file.return_value = {
"strategy": strategy_conf_var
}
self.async_run_with_timeout(
self.app.import_config_file(strategy_file_name))
self.assertEqual(strategy_file_name, self.app.strategy_file_name)
self.assertEqual(strategy_name, self.app.strategy_name)
self.assertTrue(
self.cli_mock_assistant.check_log_called_with(
"\nEnter \"start\" to start market making."))
@patch(
"hummingbot.client.command.import_command.load_strategy_config_map_from_file"
)
@patch(
"hummingbot.client.command.status_command.StatusCommand.status_check_all"
)
def test_import_config_file_handles_network_timeouts_legacy(
self, status_check_all_mock: AsyncMock,
load_strategy_config_map_from_file: AsyncMock):
strategy_name = "some_strategy"
strategy_file_name = f"{strategy_name}.yml"
status_check_all_mock.side_effect = self.raise_timeout
strategy_conf_var = ConfigVar("strategy", None)
strategy_conf_var.value = strategy_name
load_strategy_config_map_from_file.return_value = {
"strategy": strategy_conf_var
}
with self.assertRaises(asyncio.TimeoutError):
self.async_run_with_timeout_coroutine_must_raise_timeout(
self.app.import_config_file(strategy_file_name))
self.assertEqual(None, self.app.strategy_file_name)
self.assertEqual(None, self.app.strategy_name)
@patch(
"hummingbot.client.config.config_helpers.get_strategy_pydantic_config_cls"
)
@patch(
"hummingbot.client.command.status_command.StatusCommand.status_check_all"
)
def test_import_config_file_success(
self, status_check_all_mock: AsyncMock,
get_strategy_pydantic_config_cls: MagicMock):
strategy_name = "perpetual_market_making"
strategy_file_name = f"{strategy_name}.yml"
status_check_all_mock.return_value = True
dummy_strategy_config_cls = self.build_dummy_strategy_config_cls(
strategy_name)
get_strategy_pydantic_config_cls.return_value = dummy_strategy_config_cls
cm = ClientConfigAdapter(
dummy_strategy_config_cls(no_default="some value"))
with TemporaryDirectory() as d:
d = Path(d)
import_command.STRATEGIES_CONF_DIR_PATH = d
temp_file_name = d / strategy_file_name
save_to_yml(temp_file_name, cm)
self.async_run_with_timeout(
self.app.import_config_file(strategy_file_name))
self.assertEqual(strategy_file_name, self.app.strategy_file_name)
self.assertEqual(strategy_name, self.app.strategy_name)
self.assertTrue(
self.cli_mock_assistant.check_log_called_with(
"\nEnter \"start\" to start market making."))
self.assertEqual(cm, self.app.strategy_config_map)
@patch(
"hummingbot.client.config.config_helpers.get_strategy_pydantic_config_cls"
)
@patch(
"hummingbot.client.command.status_command.StatusCommand.status_check_all"
)
def test_import_incomplete_config_file_success(
self, status_check_all_mock: AsyncMock,
get_strategy_pydantic_config_cls: MagicMock):
strategy_name = "perpetual_market_making"
strategy_file_name = f"{strategy_name}.yml"
status_check_all_mock.return_value = True
dummy_strategy_config_cls = self.build_dummy_strategy_config_cls(
strategy_name)
get_strategy_pydantic_config_cls.return_value = dummy_strategy_config_cls
cm = ClientConfigAdapter(
dummy_strategy_config_cls(no_default="some value"))
with TemporaryDirectory() as d:
d = Path(d)
import_command.STRATEGIES_CONF_DIR_PATH = d
temp_file_name = d / strategy_file_name
cm_yml_str = cm.generate_yml_output_str_with_comments()
cm_yml_str = cm_yml_str.replace("\nno_default: some value\n", "")
with open(temp_file_name, "w+") as outfile:
outfile.write(cm_yml_str)
self.async_run_with_timeout(
self.app.import_config_file(strategy_file_name))
self.assertEqual(strategy_file_name, self.app.strategy_file_name)
self.assertEqual(strategy_name, self.app.strategy_name)
self.assertTrue(
self.cli_mock_assistant.check_log_called_with(
"\nEnter \"start\" to start market making."))
self.assertNotEqual(cm, self.app.strategy_config_map)
validation_errors = self.app.strategy_config_map.validate_model()
self.assertEqual(1, len(validation_errors))
self.assertEqual("no_default - field required", validation_errors[0])
