class Testshellcheck(TestCase):
fixtures = [
'tests/fixtures/shellcheck/no_errors.sh',
'tests/fixtures/shellcheck/has_errors.sh',
]
def setUp(self):
self.problems = Problems()
self.tool = Shellcheck(self.problems, {}, root_dir)
def test_version(self):
assert self.tool.version != ''
def test_match_file(self):
self.assertTrue(self.tool.match_file('test.bash'))
self.assertTrue(self.tool.match_file('test.zsh'))
self.assertTrue(self.tool.match_file('test.ksh'))
self.assertTrue(self.tool.match_file('test.sh'))
self.assertTrue(self.tool.match_file('dir/name/test.sh'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('test.js'))
def test_match_file__executable(self):
res = self.tool.match_file('tests/fixtures/shellcheck/tool')
self.assertTrue(res)
@requires_image('shellcheck')
def test_check_dependencies(self):
self.assertTrue(self.tool.check_dependencies())
@requires_image('shellcheck')
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
self.assertEqual(3, len(problems))
fname = self.fixtures[1]
expected = Comment(
fname, 3, 3,
'a is referenced but not assigned.\nDouble quote to prevent '
'globbing and word splitting.')
self.assertEqual(expected, problems[0])
expected = Comment(
fname, 4, 4,
'BASE appears unused. Verify use (or export if used externally).\n'
'Use $(...) notation instead of legacy backticked \\`...\\`.')
self.assertEqual(expected, problems[1])
expected = Comment(fname, 6, 6, (
"To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' "
"to clarify)."))
self.assertEqual(expected, problems[2])
@requires_image('shellcheck')
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
self.assertEqual(1, len(self.problems.all(self.fixtures[0])))
problems = self.problems.all(self.fixtures[1])
self.assertEqual(3, len(problems))
@requires_image('shellcheck')
def test_process_files_with_config(self):
config = {'shell': 'bash', 'exclude': 'SC2154,SC2069'}
tool = Shellcheck(self.problems, config, root_dir)
tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
self.assertEqual(2, len(problems),
'Changing standards changes error counts')
class Testshellcheck(TestCase):
needs_shellcheck = skipIf(shellcheck_missing, 'Needs shellcheck')
fixtures = [
'tests/fixtures/shellcheck/no_errors.sh',
'tests/fixtures/shellcheck/has_errors.sh',
]
def setUp(self):
self.problems = Problems()
self.tool = Shellcheck(self.problems)
def test_match_file(self):
self.assertTrue(self.tool.match_file('test.bash'))
self.assertTrue(self.tool.match_file('test.zsh'))
self.assertTrue(self.tool.match_file('test.ksh'))
self.assertTrue(self.tool.match_file('test.sh'))
self.assertTrue(self.tool.match_file('dir/name/test.sh'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('test.js'))
def test_match_file__executable(self):
res = self.tool.match_file('tests/fixtures/shellcheck/tool')
self.assertTrue(res)
@needs_shellcheck
def test_check_dependencies(self):
self.assertTrue(self.tool.check_dependencies())
@needs_shellcheck
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
eq_([], self.problems.all(self.fixtures[0]))
@needs_shellcheck
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
eq_(3, len(problems))
fname = self.fixtures[1]
expected = Comment(
fname,
5,
3,
'a is referenced but not assigned.\nDouble quote to prevent '
'globbing and word splitting.')
eq_(expected, problems[0])
expected = Comment(
fname,
4,
4,
'BASE appears unused. Verify it or export it.\n'
'Use $(..) instead of legacy \`..\`.')
eq_(expected, problems[1])
expected = Comment(
fname,
6,
6,
'The order of the 2>&1 and the redirect matters. The 2>&1 has to '
'be last.')
eq_(expected, problems[2])
@needs_shellcheck
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
eq_([], self.problems.all(self.fixtures[0]))
problems = self.problems.all(self.fixtures[1])
eq_(3, len(problems))
@needs_shellcheck
def test_process_files_with_config(self):
config = {
'shell': 'bash',
'exclude': 'SC2154,SC2069'
}
tool = Shellcheck(self.problems, config)
tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
eq_(2, len(problems), 'Changing standards changes error counts')
class Testshellcheck(TestCase):
needs_shellcheck = skipIf(shellcheck_missing, 'Needs shellcheck')
fixtures = [
'tests/fixtures/shellcheck/no_errors.sh',
'tests/fixtures/shellcheck/has_errors.sh',
]
def setUp(self):
self.problems = Problems()
self.tool = Shellcheck(self.problems)
def test_match_file(self):
self.assertTrue(self.tool.match_file('test.sh'))
self.assertTrue(self.tool.match_file('dir/name/test.sh'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('test.js'))
@needs_shellcheck
def test_check_dependencies(self):
self.assertTrue(self.tool.check_dependencies())
@needs_shellcheck
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
eq_([], self.problems.all(self.fixtures[0]))
@needs_shellcheck
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
eq_(3, len(problems))
fname = self.fixtures[1]
expected = Comment(
fname, 5, 3,
'a is referenced but not assigned.\nDouble quote to prevent '
'globbing and word splitting.')
eq_(expected, problems[0])
expected = Comment(
fname, 4, 4, 'BASE appears unused. Verify it or export it.\n'
'Use $(..) instead of legacy \`..\`.')
eq_(expected, problems[1])
expected = Comment(
fname, 6, 6,
'The order of the 2>&1 and the redirect matters. The 2>&1 has to '
'be last.')
eq_(expected, problems[2])
@needs_shellcheck
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
eq_([], self.problems.all(self.fixtures[0]))
problems = self.problems.all(self.fixtures[1])
eq_(3, len(problems))
@needs_shellcheck
def test_process_files_with_config(self):
config = {'shell': 'bash', 'exclude': 'SC2154,SC2069'}
tool = Shellcheck(self.problems, config)
tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
eq_(2, len(problems), 'Changing standards changes error counts')
class Testshellcheck(TestCase):
fixtures = [
'tests/fixtures/shellcheck/no_errors.sh',
'tests/fixtures/shellcheck/has_errors.sh',
]
def setUp(self):
self.problems = Problems()
self.tool = Shellcheck(self.problems, {}, root_dir)
def test_match_file(self):
self.assertTrue(self.tool.match_file('test.bash'))
self.assertTrue(self.tool.match_file('test.zsh'))
self.assertTrue(self.tool.match_file('test.ksh'))
self.assertTrue(self.tool.match_file('test.sh'))
self.assertTrue(self.tool.match_file('dir/name/test.sh'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('test.js'))
def test_match_file__executable(self):
res = self.tool.match_file('tests/fixtures/shellcheck/tool')
self.assertTrue(res)
@requires_image('shellcheck')
def test_check_dependencies(self):
self.assertTrue(self.tool.check_dependencies())
@requires_image('shellcheck')
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
self.assertEqual([], self.problems.all(self.fixtures[0]))
@requires_image('shellcheck')
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
self.assertEqual(3, len(problems))
fname = self.fixtures[1]
expected = Comment(
fname,
3,
3,
'a is referenced but not assigned.\nDouble quote to prevent '
'globbing and word splitting.')
self.assertEqual(expected, problems[0])
expected = Comment(
fname,
4,
4,
'BASE appears unused. Verify it or export it.\n'
'Use $(..) instead of legacy \`..\`.')
self.assertEqual(expected, problems[1])
expected = Comment(
fname,
6,
6,
("The order of the 2>&1 and the redirect matters. "
"The 2>&1 has to be last."))
self.assertEqual(expected, problems[2])
@requires_image('shellcheck')
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
self.assertEqual([], self.problems.all(self.fixtures[0]))
problems = self.problems.all(self.fixtures[1])
self.assertEqual(3, len(problems))
@requires_image('shellcheck')
def test_process_files_with_config(self):
config = {
'shell': 'bash',
'exclude': 'SC2154,SC2069'
}
tool = Shellcheck(self.problems, config, root_dir)
tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
self.assertEqual(2, len(problems),
'Changing standards changes error counts')