def test_csv_file_output(capsys, tmpdir):
target_dir = tmpdir.mkdir('reports')
cfg = get_default_config()
cfg['requested_reports'] = [{'type': 'csv'}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
test_file = str(target_dir) + 'test1'
with open(test_file, 'w') as fp:
execute_reports(cfg, 'someproject', collector, output_file=fp)
out, err = capsys.readouterr()
assert out == ''
assert err == ''
assert EXPECTED_CSV == open(test_file, 'r').read()
test_file = str(target_dir) + 'test2'
cfg['requested_reports'] = [{'type': 'csv', 'file': test_file}]
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert out == ''
assert err == ''
assert EXPECTED_CSV == open(test_file, 'r').read()
def test_sort_issues_default():
collector = Collector(get_default_config())
expected = [
BarIssue('test', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 2),
FooIssue('test', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 2),
BarIssue('test', 'test message', 'test/file.ext', 2, 5),
BarIssue('test2', 'test message', 'test/file.ext', 2, 5),
FooIssue('test', 'test message', 'test/file.ext', 2, 5),
FooIssue('test2', 'test message', 'test/file.ext', 2, 5),
BarIssue('test', 'test message', 'test/file.ext', 5, 3),
BarIssue('test2', 'test message', 'test/file.ext', 5, 3),
FooIssue('test', 'test message', 'test/file.ext', 5, 3),
FooIssue('test2', 'test message', 'test/file.ext', 5, 3),
BarIssue('test', 'test message', 'test/file2.ext', 2),
BarIssue('test2', 'test message', 'test/file2.ext', 2),
FooIssue('test', 'test message', 'test/file2.ext', 2),
FooIssue('test2', 'test message', 'test/file2.ext', 2),
BarIssue('test', 'test message', 'test/file2.ext', 2, 5),
BarIssue('test2', 'test message', 'test/file2.ext', 2, 5),
FooIssue('test', 'test message', 'test/file2.ext', 2, 5),
FooIssue('test2', 'test message', 'test/file2.ext', 2, 5),
BarIssue('test', 'test message', 'test/file2.ext', 5, 3),
BarIssue('test2', 'test message', 'test/file2.ext', 5, 3),
FooIssue('test', 'test message', 'test/file2.ext', 5, 3),
FooIssue('test2', 'test message', 'test/file2.ext', 5, 3),
]
shuffled = [] + expected
random.shuffle(shuffled)
assert collector._sort_issues(shuffled) == expected
def test_console_execute(capsys):
cfg = get_default_config()
cfg['reports'] = [{'type': 'console'}]
collector = Collector(cfg)
execute_reports(cfg, 'someproject', collector)
expected = u'No issues found!'
if sys.platform != 'win32':
expected = u'\u2714 ' + expected
out, err = capsys.readouterr()
assert out.rstrip() == expected
assert err == ''
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
expected = EXPECTED_CONSOLE.rstrip()
if sys.platform == 'win32':
expected = expected.replace(u'\u2717 ', '')
if PY2:
expected = expected.replace('\n', '\r\n')
out, err = capsys.readouterr()
assert out.rstrip() == expected
assert err == ''
def test_noqa_disabled(tmpdir):
project_dir = tmpdir.mkdir('noqa')
py_file = project_dir.join('file.py')
py_file.write(
'\nsomething # noqa: test1\n\n# NoQA\n\n\n\n# NOqa: tidypy:test6,foobar,@bar'
)
yaml_file = project_dir.join('file.yaml')
cfg = get_default_config()
cfg['merge-issues'] = False
cfg['noqa'] = False
collector = Collector(cfg)
good_issues = [
TidyPyIssue('test', 'test message', str(py_file), 2),
TidyPyIssue('test4', 'test message', str(py_file), 6),
TidyPyIssue('test5', 'test message', str(yaml_file), 2),
TidyPyIssue('test7', 'test message', str(py_file), 8),
BarIssue('test8', 'test message', str(py_file), 7),
]
filtered_issues = [
TidyPyIssue('test1', 'test message', str(py_file), 2),
TidyPyIssue('test2', 'test message', str(py_file), 4),
TidyPyIssue('test3', 'test message', str(py_file), 4),
TidyPyIssue('test6', 'test message', str(py_file), 8),
BarIssue('test9', 'test message', str(py_file), 8),
]
collector.add_issues(good_issues)
collector.add_issues(filtered_issues)
assert good_issues + filtered_issues == collector.get_issues(
sortby=collector.NO_SORT)
assert collector.issue_count() == len(good_issues + filtered_issues)
assert collector.issue_count(include_unclean=True) == len(good_issues +
filtered_issues)
def test_sort_issues_empty():
collector = Collector(get_default_config())
expected = [
BarIssue('test', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 5),
FooIssue('test', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 5),
]
assert collector._sort_issues(expected, collector.NO_SORT) == expected
def test_json_execute(capsys):
cfg = get_default_config()
cfg['requested_reports'] = [{'type': 'json'}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert EXPECTED_JSON == out.replace('\r\n', '\n')
assert err == ''
def test_execute_parseable(capsys):
cfg = get_default_config()
cfg['requested_reports'] = [{'type': 'pylint-parseable'}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert out.replace('\r\n', '\n') == EXPECTED_PARSEABLE
assert err == ''
def test_execute(capsys):
cfg = get_default_config()
cfg['reports'] = [{'type': 'pycodestyle'}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert out.replace('\r\n', '\n') == EXPECTED_PYCODESTYLE
assert err == ''
def test_execute_bad_format(capsys):
cfg = get_default_config()
cfg['requested_reports'] = [{
'type': 'custom',
'format': '{filename:,}/{line}'
}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert out == ''
assert err.strip().startswith('Invalid format for custom report')
def test_sort_issues_custom():
collector = Collector(get_default_config())
expected = [
BarIssue('test', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 5),
FooIssue('test', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 5),
]
shuffled = [] + expected
random.shuffle(shuffled)
assert collector._sort_issues(shuffled,
('tool', 'code', 'line')) == expected
def test_execute_bad_token(capsys):
cfg = get_default_config()
cfg['requested_reports'] = [{
'type': 'custom',
'format': '{filename}/{foo}'
}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert out == ''
assert err.strip(
) == "Invalid format for custom report: Unknown token 'foo'"
def test_execute(capsys):
cfg = get_default_config()
cfg['requested_reports'] = [{
'type':
'custom',
'format':
'{filename}/{line}/{character}/{tool}/{code}/{message}'
}]
collector = Collector(cfg)
collector.add_issues(ISSUES)
execute_reports(cfg, 'someproject', collector)
out, err = capsys.readouterr()
assert out.replace('\r\n', '\n') == EXPECTED
assert err == ''
def test_get_grouped_issues_custom():
collector = Collector(get_default_config())
expected = {
'test': [
BarIssue('test', 'test message', 'test/file.ext', 2),
FooIssue('test', 'test message', 'test/file.ext', 2),
],
'test2': [
BarIssue('test2', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 5),
FooIssue('test2', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 5),
],
}
shuffled = []
for issues in expected.values():
shuffled += issues
random.shuffle(shuffled)
collector.add_issues(shuffled)
assert collector.get_grouped_issues(lambda x: x.code,
('tool', 'line')) == expected
assert collector.issue_count() == len(shuffled)
assert collector.issue_count(include_unclean=True) == len(shuffled)
def test_disabled():
cfg = get_default_config()
cfg['disabled'] = ['foo']
collector = Collector(cfg)
collector.add_issues([
TidyPyIssue('code1', 'message 1', 'test1.py', 2),
TidyPyIssue('foo', 'message 2', 'test2.py', 3),
])
assert collector.issue_count() == 1
assert collector.issue_count(include_unclean=True) == 2
assert collector.get_issues()[0].code == 'code1'
def test_disabled():
cfg = get_default_config()
cfg['disabled'] = ['test']
collector = Collector(cfg)
issues = [
TidyPyIssue('test', 'test message', 'test/file.ext', 2),
TidyPyIssue('test2', 'test message', 'test/file.ext', 2),
TidyPyIssue('test3', 'test message', 'test/file.ext', 2),
]
collector.add_issues(issues)
assert collector.get_issues() == issues[1:]
assert collector.issue_count() == 2
assert collector.issue_count(include_unclean=True) == 3
def test_merging_dupes():
collector = Collector(get_default_config())
issues = [
TidyPyIssue('test', 'test message', 'test/file.ext', 2),
TidyPyIssue('test', 'test message', 'test/file.ext', 2),
TidyPyIssue('test2', 'test message', 'test/file.ext', 2),
TidyPyIssue('test', 'test message', 'test/file.ext', 3),
TidyPyIssue('test2', 'test message', 'test/file2.ext', 2),
]
collector.add_issues(issues)
assert collector.get_issues() == [issues[0]] + issues[2:]
assert collector.issue_count() == 4
assert collector.issue_count(include_unclean=True) == 5
def test_get_grouped_issues_default():
cfg = get_default_config()
cfg['merge-issues'] = False
collector = Collector(cfg)
expected = {
'test/file.ext': [
BarIssue('test', 'test message', 'test/file.ext', 2),
BarIssue('test2', 'test message', 'test/file.ext', 2),
FooIssue('test', 'test message', 'test/file.ext', 2),
FooIssue('test2', 'test message', 'test/file.ext', 2),
BarIssue('test', 'test message', 'test/file.ext', 2, 5),
BarIssue('test2', 'test message', 'test/file.ext', 2, 5),
FooIssue('test', 'test message', 'test/file.ext', 2, 5),
FooIssue('test2', 'test message', 'test/file.ext', 2, 5),
BarIssue('test', 'test message', 'test/file.ext', 5, 3),
BarIssue('test2', 'test message', 'test/file.ext', 5, 3),
FooIssue('test', 'test message', 'test/file.ext', 5, 3),
FooIssue('test2', 'test message', 'test/file.ext', 5, 3),
],
'test/file2.ext': [
BarIssue('test', 'test message', 'test/file2.ext', 2),
BarIssue('test2', 'test message', 'test/file2.ext', 2),
FooIssue('test', 'test message', 'test/file2.ext', 2),
FooIssue('test2', 'test message', 'test/file2.ext', 2),
BarIssue('test', 'test message', 'test/file2.ext', 2, 5),
BarIssue('test2', 'test message', 'test/file2.ext', 2, 5),
FooIssue('test', 'test message', 'test/file2.ext', 2, 5),
FooIssue('test2', 'test message', 'test/file2.ext', 2, 5),
BarIssue('test', 'test message', 'test/file2.ext', 5, 3),
BarIssue('test2', 'test message', 'test/file2.ext', 5, 3),
FooIssue('test', 'test message', 'test/file2.ext', 5, 3),
FooIssue('test2', 'test message', 'test/file2.ext', 5, 3),
],
}
shuffled = []
for issues in expected.values():
shuffled += issues
random.shuffle(shuffled)
collector.add_issues(shuffled)
assert collector.get_grouped_issues() == expected
assert collector.issue_count() == len(shuffled)
assert collector.issue_count(include_unclean=True) == len(shuffled)
def test_basics():
collector = Collector(get_default_config())
assert collector.get_issues() == []
assert collector.issue_count() == 0
assert collector.issue_count(include_unclean=True) == 0
collector.add_issues(FooIssue('test', 'test message', 'test/file.ext',
1), )
collector.add_issues([
FooIssue('test2', 'test message 2', 'test/file.ext', 2),
BarIssue('test3', 'test message 3', 'test/file.ext', 3),
])
assert collector.issue_count() == 3
assert collector.issue_count(include_unclean=True) == 3
