def _validate(self, watch_list): cc_definitions_set = self._rule_definitions_as_set(watch_list.cc_rules) messages_definitions_set = self._rule_definitions_as_set(watch_list.message_rules) self._verify_all_definitions_are_used(watch_list, cc_definitions_set.union(messages_definitions_set)) self._validate_definitions(cc_definitions_set, self._CC_RULES, watch_list) self._validate_definitions(messages_definitions_set, self._MESSAGE_RULES, watch_list) accounts = CommitterList() for cc_rule in watch_list.cc_rules: # Copy the instructions since we'll be remove items from the original list and # modifying a list while iterating through it leads to undefined behavior. intructions_copy = cc_rule.instructions()[:] for email in intructions_copy: if not accounts.account_by_email(email): cc_rule.remove_instruction(email) self._log_error( "The email alias %s which is in the watchlist is not listed as a contributor in committers.py" % email ) continue
def _validate(self, watch_list): cc_definitions_set = self._rule_definitions_as_set(watch_list.cc_rules) messages_definitions_set = self._rule_definitions_as_set( watch_list.message_rules) self._verify_all_definitions_are_used( watch_list, cc_definitions_set.union(messages_definitions_set)) self._validate_definitions(cc_definitions_set, self._CC_RULES, watch_list) self._validate_definitions(messages_definitions_set, self._MESSAGE_RULES, watch_list) accounts = CommitterList() for cc_rule in watch_list.cc_rules: # Copy the instructions since we'll be remove items from the original list and # modifying a list while iterating through it leads to undefined behavior. intructions_copy = cc_rule.instructions()[:] for email in intructions_copy: if not accounts.account_by_email(email): cc_rule.remove_instruction(email) self._log_error( "The email alias %s which is in the watchlist is not listed as a contributor in committers.py" % email) continue
def test_committer_lookup(self): account = Account('Test Zero', ['*****@*****.**', '*****@*****.**'], 'zero') committer = Committer('Test One', '*****@*****.**', 'one') reviewer = Reviewer('Test Two', ['*****@*****.**', '*****@*****.**', '*****@*****.**']) contributor = Contributor('Test Three', ['*****@*****.**'], 'three') contributor_with_two_nicknames = Contributor('Other Four', ['*****@*****.**', '*****@*****.**'], ['four', 'otherfour']) contributor_with_same_email_username = Contributor('Yet Another Four', ['*****@*****.**'], ['yetanotherfour']) committer_list = CommitterList(watchers=[account], committers=[committer], reviewers=[reviewer], contributors=[contributor, contributor_with_two_nicknames, contributor_with_same_email_username]) # Test valid committer, reviewer and contributor lookup self.assertEqual(committer_list.account_by_email('*****@*****.**'), account) self.assertEqual(committer_list.committer_by_email('*****@*****.**'), committer) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.committer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.committer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.contributor_by_email('*****@*****.**'), contributor) # Test valid committer, reviewer and contributor lookup self.assertEqual(committer_list.committer_by_name("Test One"), committer) self.assertEqual(committer_list.committer_by_name("Test Two"), reviewer) self.assertEqual(committer_list.committer_by_name("Test Three"), None) self.assertEqual(committer_list.contributor_by_name("Test Three"), contributor) self.assertEqual(committer_list.contributor_by_name("test one"), committer) self.assertEqual(committer_list.contributor_by_name("test two"), reviewer) self.assertEqual(committer_list.contributor_by_name("test three"), contributor) # Test that the first email is assumed to be the Bugzilla email address (for now) self.assertEqual(committer_list.committer_by_email('*****@*****.**').bugzilla_email(), '*****@*****.**') # Test lookup by login email address self.assertEqual(committer_list.account_by_login('*****@*****.**'), account) self.assertEqual(committer_list.account_by_login('*****@*****.**'), None) self.assertEqual(committer_list.account_by_login('*****@*****.**'), committer) self.assertEqual(committer_list.account_by_login('*****@*****.**'), reviewer) self.assertEqual(committer_list.account_by_login('*****@*****.**'), None) self.assertEqual(committer_list.account_by_login('*****@*****.**'), None) # Test that a known committer is not returned during reviewer lookup self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), None) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), None) # and likewise that a known contributor is not returned for committer lookup. self.assertEqual(committer_list.committer_by_email('*****@*****.**'), None) # Test that unknown email address fail both committer and reviewer lookup self.assertEqual(committer_list.committer_by_email('*****@*****.**'), None) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), None) # Test that emails returns a list. self.assertEqual(committer.emails, ['*****@*****.**']) self.assertEqual(committer.irc_nicknames, ['one']) self.assertEqual(committer_list.contributor_by_irc_nickname('one'), committer) self.assertEqual(committer_list.contributor_by_irc_nickname('three'), contributor) self.assertEqual(committer_list.contributor_by_irc_nickname('four'), contributor_with_two_nicknames) self.assertEqual(committer_list.contributor_by_irc_nickname('otherfour'), contributor_with_two_nicknames) # Test that the lists returned are are we expect them. self.assertEqual(committer_list.contributors(), [contributor, contributor_with_two_nicknames, contributor_with_same_email_username, committer, reviewer]) self.assertEqual(committer_list.committers(), [committer, reviewer]) self.assertEqual(committer_list.reviewers(), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string('test'), [contributor, committer, reviewer]) self.assertEqual(committer_list.contributors_by_search_string('rad'), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string('Two'), [reviewer]) self.assertEqual(committer_list.contributors_by_email_username("one"), [committer]) self.assertEqual(committer_list.contributors_by_email_username("four"), []) self.assertEqual(committer_list.contributors_by_email_username("otherfour"), [contributor_with_two_nicknames, contributor_with_same_email_username])
def test_committer_lookup(self): account = Account("Test Zero", ["*****@*****.**", "*****@*****.**"], "zero") committer = Committer("Test One", "*****@*****.**", "one") reviewer = Reviewer("Test Two", ["*****@*****.**", "*****@*****.**", "*****@*****.**"]) contributor = Contributor("Test Three", ["*****@*****.**"], "three") contributor_with_two_nicknames = Contributor( "Other Four", ["*****@*****.**", "*****@*****.**"], ["four", "otherfour"] ) contributor_with_same_email_username = Contributor( "Yet Another Four", ["*****@*****.**"], ["yetanotherfour"] ) committer_list = CommitterList( watchers=[account], committers=[committer], reviewers=[reviewer], contributors=[contributor, contributor_with_two_nicknames, contributor_with_same_email_username], ) # Test valid committer, reviewer and contributor lookup self.assertEqual(committer_list.account_by_email("*****@*****.**"), account) self.assertEqual(committer_list.committer_by_email("*****@*****.**"), committer) self.assertEqual(committer_list.reviewer_by_email("*****@*****.**"), reviewer) self.assertEqual(committer_list.committer_by_email("*****@*****.**"), reviewer) self.assertEqual(committer_list.committer_by_email("*****@*****.**"), reviewer) self.assertEqual(committer_list.reviewer_by_email("*****@*****.**"), reviewer) self.assertEqual(committer_list.contributor_by_email("*****@*****.**"), contributor) # Test valid committer, reviewer and contributor lookup self.assertEqual(committer_list.committer_by_name("Test One"), committer) self.assertEqual(committer_list.committer_by_name("Test Two"), reviewer) self.assertEqual(committer_list.committer_by_name("Test Three"), None) self.assertEqual(committer_list.contributor_by_name("Test Three"), contributor) self.assertEqual(committer_list.contributor_by_name("test one"), committer) self.assertEqual(committer_list.contributor_by_name("test two"), reviewer) self.assertEqual(committer_list.contributor_by_name("test three"), contributor) # Test that the first email is assumed to be the Bugzilla email address (for now) self.assertEqual(committer_list.committer_by_email("*****@*****.**").bugzilla_email(), "*****@*****.**") # Test lookup by login email address self.assertEqual(committer_list.account_by_login("*****@*****.**"), account) self.assertEqual(committer_list.account_by_login("*****@*****.**"), None) self.assertEqual(committer_list.account_by_login("*****@*****.**"), committer) self.assertEqual(committer_list.account_by_login("*****@*****.**"), reviewer) self.assertEqual(committer_list.account_by_login("*****@*****.**"), None) self.assertEqual(committer_list.account_by_login("*****@*****.**"), None) # Test that a known committer is not returned during reviewer lookup self.assertEqual(committer_list.reviewer_by_email("*****@*****.**"), None) self.assertEqual(committer_list.reviewer_by_email("*****@*****.**"), None) # and likewise that a known contributor is not returned for committer lookup. self.assertEqual(committer_list.committer_by_email("*****@*****.**"), None) # Test that unknown email address fail both committer and reviewer lookup self.assertEqual(committer_list.committer_by_email("*****@*****.**"), None) self.assertEqual(committer_list.reviewer_by_email("*****@*****.**"), None) # Test that emails returns a list. self.assertEqual(committer.emails, ["*****@*****.**"]) self.assertEqual(committer.irc_nicknames, ["one"]) self.assertEqual(committer_list.contributor_by_irc_nickname("one"), committer) self.assertEqual(committer_list.contributor_by_irc_nickname("three"), contributor) self.assertEqual(committer_list.contributor_by_irc_nickname("four"), contributor_with_two_nicknames) self.assertEqual(committer_list.contributor_by_irc_nickname("otherfour"), contributor_with_two_nicknames) # Test that the lists returned are are we expect them. self.assertEqual( committer_list.contributors(), [contributor, contributor_with_two_nicknames, contributor_with_same_email_username, committer, reviewer], ) self.assertEqual(committer_list.committers(), [committer, reviewer]) self.assertEqual(committer_list.reviewers(), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string("test"), [contributor, committer, reviewer]) self.assertEqual(committer_list.contributors_by_search_string("rad"), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string("Two"), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string("otherfour"), [contributor_with_two_nicknames]) self.assertEqual( committer_list.contributors_by_search_string("*otherfour*"), [contributor_with_two_nicknames, contributor_with_same_email_username], ) self.assertEqual(committer_list.contributors_by_email_username("one"), [committer]) self.assertEqual(committer_list.contributors_by_email_username("four"), []) self.assertEqual( committer_list.contributors_by_email_username("otherfour"), [contributor_with_two_nicknames, contributor_with_same_email_username], )
def test_committer_lookup(self): account = Account('Test Zero', ['*****@*****.**', '*****@*****.**'], 'zero') committer = Committer('Test One', '*****@*****.**', 'one') reviewer = Reviewer( 'Test Two', ['*****@*****.**', '*****@*****.**', '*****@*****.**']) contributor = Contributor('Test Three', ['*****@*****.**'], 'three') contributor_with_two_nicknames = Contributor( 'Other Four', ['*****@*****.**', '*****@*****.**'], ['four', 'otherfour']) contributor_with_same_email_username = Contributor( 'Yet Another Four', ['*****@*****.**'], ['yetanotherfour']) committer_list = CommitterList(watchers=[account], committers=[committer], reviewers=[reviewer], contributors=[ contributor, contributor_with_two_nicknames, contributor_with_same_email_username ]) # Test valid committer, reviewer and contributor lookup self.assertEqual(committer_list.account_by_email('*****@*****.**'), account) self.assertEqual(committer_list.committer_by_email('*****@*****.**'), committer) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.committer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.committer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), reviewer) self.assertEqual(committer_list.contributor_by_email('*****@*****.**'), contributor) # Test valid committer, reviewer and contributor lookup self.assertEqual(committer_list.committer_by_name("Test One"), committer) self.assertEqual(committer_list.committer_by_name("Test Two"), reviewer) self.assertEqual(committer_list.committer_by_name("Test Three"), None) self.assertEqual(committer_list.contributor_by_name("Test Three"), contributor) self.assertEqual(committer_list.contributor_by_name("test one"), committer) self.assertEqual(committer_list.contributor_by_name("test two"), reviewer) self.assertEqual(committer_list.contributor_by_name("test three"), contributor) # Test that the first email is assumed to be the Bugzilla email address (for now) self.assertEqual( committer_list.committer_by_email('*****@*****.**').bugzilla_email(), '*****@*****.**') # Test lookup by login email address self.assertEqual(committer_list.account_by_login('*****@*****.**'), account) self.assertEqual(committer_list.account_by_login('*****@*****.**'), None) self.assertEqual(committer_list.account_by_login('*****@*****.**'), committer) self.assertEqual(committer_list.account_by_login('*****@*****.**'), reviewer) self.assertEqual(committer_list.account_by_login('*****@*****.**'), None) self.assertEqual(committer_list.account_by_login('*****@*****.**'), None) # Test that a known committer is not returned during reviewer lookup self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), None) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), None) # and likewise that a known contributor is not returned for committer lookup. self.assertEqual(committer_list.committer_by_email('*****@*****.**'), None) # Test that unknown email address fail both committer and reviewer lookup self.assertEqual(committer_list.committer_by_email('*****@*****.**'), None) self.assertEqual(committer_list.reviewer_by_email('*****@*****.**'), None) # Test that emails returns a list. self.assertEqual(committer.emails, ['*****@*****.**']) self.assertEqual(committer.irc_nicknames, ['one']) self.assertEqual(committer_list.contributor_by_irc_nickname('one'), committer) self.assertEqual(committer_list.contributor_by_irc_nickname('three'), contributor) self.assertEqual(committer_list.contributor_by_irc_nickname('four'), contributor_with_two_nicknames) self.assertEqual( committer_list.contributor_by_irc_nickname('otherfour'), contributor_with_two_nicknames) # Test that the lists returned are are we expect them. self.assertEqual(committer_list.contributors(), [ contributor, contributor_with_two_nicknames, contributor_with_same_email_username, committer, reviewer ]) self.assertEqual(committer_list.committers(), [committer, reviewer]) self.assertEqual(committer_list.reviewers(), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string('test'), [contributor, committer, reviewer]) self.assertEqual(committer_list.contributors_by_search_string('rad'), [reviewer]) self.assertEqual(committer_list.contributors_by_search_string('Two'), [reviewer]) self.assertEqual(committer_list.contributors_by_email_username("one"), [committer]) self.assertEqual(committer_list.contributors_by_email_username("four"), []) self.assertEqual( committer_list.contributors_by_email_username("otherfour"), [ contributor_with_two_nicknames, contributor_with_same_email_username ])