def test_check_setup_not_quiet_not_applied(package, speccheck):
"""Test if specfile does not have a setup macro."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: setup-not-quiet' not in out
def test_check_lib_package_without_mklibname(package, speccheck):
"""Test if specfile has lib pacakge without %mklibname."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: lib-package-without-%mklibname' in out
def test_check_non_utf8_spec_file_not_applied(package, speccheck):
"""Test if specfile has UTF-8 character encoding."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: non-utf8-spec-file' not in out
def test_check_macro_in_comment_not_found(package, speccheck):
"""Test if specfile has comment in macro."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: macro-in-comment' not in out
def test_check_no_build_root_tag_not_applied(package, speccheck):
"""Test if specfile has BuildRoot tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: no-buildroot-tag' not in out
def test_check_macro_in_changelog(package, speccheck):
"""Test if specfile has macro in %changelog."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: macro-in-%changelog' in out
def test_check_deprecated_grep(package, speccheck):
"""Test if specfile has direct use of grep or egrep or fgrep."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: deprecated-grep' in out
def test_check_hardcoded_library_path(package, speccheck):
"""Test if specfile has hardcoded library path."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: hardcoded-library-path' in out
def test_check_obsolete_tag_not_applied(package, speccheck):
"""Test if specfile does not have obsolete-tag as Copyright or Serial."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: obsolete-tag' not in out
def test_check_use_of_rpm_source_dir(package, speccheck):
"""Test if specfile consist of $RPM_SOURCE_DIR or %{_sourcedir}."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: use-of-RPM_SOURCE_DIR' in out
def test_check_configure_without_libdir_spec(package, speccheck):
"""Test if specfile does not have options augmented with --libdir."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: configure-without-libdir-spec' in out
def test_check_autosetup_not_in_prep_not_applied(package, speccheck):
"""Test if specfile has no %autosetup."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: %autosetup-not-in-prep' not in out
def test_check_autosetup_not_in_prep(package, speccheck):
"""Test if specfile does not have %autosetup inside %prep."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: %autosetup-not-in-prep' in out
def test_check_autopatch_in_prep(package, speccheck):
"""Test if specfile has %autopatch inside %prep."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: %autopatch-not-in-prep' not in out
def test_check_unversioned_explicit_version_not_found(package, speccheck):
"""Test if specfile has Provides: /something tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: unversioned-explicit-provides /something' not in out
def test_check_hardcoded_path_in_buildroot_tag(package, speccheck):
"""Test if specfile has hardoded path in buildroot tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: hardcoded-path-in-buildroot-tag /usr/bin/bash' in out
def test_check_unversioned_explicit_obsoletes(package, speccheck):
"""Test if specfile has Obsoletes: tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: unversioned-explicit-obsoletes Something' in out
def test_check_hardcoded_packager_tag(package, speccheck):
"""Test if specfile has hardcoded packager tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: hardcoded-packager-tag Someone' in out
def test_check_libdir_macro_in_noarch_package(package, speccheck):
"""Test if specfile has _libdir macro in noarch package."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: libdir-macro-in-noarch-package' in out
def test_check_hardcoded_prefix_tag_not_applied(package, speccheck):
"""Test if specfile does not have hardcoded prefix tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: hardcoded-prefix-tag' not in out
def test_check_deprecated_grep_not_applied(package, speccheck):
"""Test if specfile has no use of egrep/fgrep or egrep/fgrep with -E or -F."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: deprecated-grep' not in out
def test_check_prereq_use_not_applied(package, speccheck):
"""Test if specfile has no PreReq tag value."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: prereq-use' not in out
def test_check_macro_in_comment_not_applied(package, speccheck):
"""Test if specfile does not have macro inside a comment."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: macro-in-comment' not in out
def test_check_buildprereq_use(package, speccheck):
"""Test if specfile has buildprereq tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: buildprereq-use Something' in out
def test_check_more_than_one_changelog_section(package, speccheck):
"""Test if specfile has more than one changelog section."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: more-than-one-%changelog-section' in out
def test_check_buildprereq_use_not_applied(package, speccheck):
"""Test if specfile does not have buildprereq tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'E: buildprereq-use' not in out
def test_check_depscript_without_disabling_depgen(package, speccheck):
"""Test if specfile has define __find_provides/requires."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: depscript-without-disabling-depgen' in out
def test_check_unversioned_explicit_version(package, speccheck):
"""Test if specfile has Provides: tag."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: unversioned-explicit-provides someones-something=%{version}' in out
def test_check_mixed_use_of_spaces_and_tabs_not_applied(package, speccheck):
"""Test if specfile does not have mix use of space and tabs."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: mixed-use-of-spaces-and-tabs' not in out
def test_check_setup_is_quiet(package, speccheck):
"""Test if specfile has a %setup -q macro."""
output, test = speccheck
pkg = get_tested_spec_package(package)
test.check_spec(pkg)
out = output.print_results(output.results)
assert 'W: setup-not-quiet' not in out
