def test_version_rest_publish_zarr(
api_client,
user: User,
draft_version: Version,
draft_asset_factory,
zarr_archive_factory,
):
assign_perm('owner', user, draft_version.dandiset)
api_client.force_authenticate(user=user)
zarr_archive = zarr_archive_factory(dandiset=draft_version.dandiset)
zarr_asset: Asset = draft_asset_factory(zarr=zarr_archive, blob=None)
normal_asset: Asset = draft_asset_factory()
draft_version.assets.add(zarr_asset)
draft_version.assets.add(normal_asset)
# Validate the metadata to mark the assets and version as `VALID`
tasks.validate_asset_metadata(zarr_asset.id)
tasks.validate_asset_metadata(normal_asset.id)
tasks.validate_version_metadata(draft_version.id)
draft_version.refresh_from_db()
assert draft_version.valid
resp = api_client.post(
f'/api/dandisets/{draft_version.dandiset.identifier}'
f'/versions/{draft_version.version}/publish/'
)
assert resp.status_code == 400
assert resp.json() == ['Cannot publish dandisets which contain zarrs']
def test_validate_version_metadata(version: Version, asset: Asset):
version.assets.add(asset)
tasks.validate_version_metadata(version.id)
version.refresh_from_db()
assert version.status == Version.Status.VALID
assert version.validation_errors == []
def test_validate_version_metadata_malformed_schema_version(
version: Version, asset: Asset):
version.assets.add(asset)
version.metadata['schemaVersion'] = 'xxx'
version.save()
tasks.validate_version_metadata(version.id)
version.refresh_from_db()
assert version.status == Version.Status.INVALID
assert len(version.validation_errors) == 1
assert version.validation_errors[0]['message'].startswith(
'Metadata version xxx is not allowed.')
def test_validate_version_metadata_malformed_license(version: Version,
asset: Asset):
version.assets.add(asset)
version.metadata['license'] = 'foo'
version.save()
tasks.validate_version_metadata(version.id)
version.refresh_from_db()
assert version.status == Version.Status.INVALID
assert version.validation_errors == [{
'field':
'license',
'message':
"'foo' is not of type 'array'"
}]
def test_validate_version_metadata_no_description(version: Version,
asset: Asset):
version.assets.add(asset)
del version.metadata['description']
version.save()
tasks.validate_version_metadata(version.id)
version.refresh_from_db()
assert version.status == Version.Status.INVALID
assert version.validation_errors == [{
'field':
'',
'message':
"'description' is a required property"
}]
def test_version_rest_publish_assets(
api_client,
user: User,
draft_version: Version,
draft_asset_factory,
published_asset_factory,
):
assign_perm('owner', user, draft_version.dandiset)
api_client.force_authenticate(user=user)
old_draft_asset: Asset = draft_asset_factory()
old_published_asset: Asset = published_asset_factory()
old_published_asset.publish()
old_published_asset.save()
assert not old_draft_asset.published
assert old_published_asset.published
draft_version.assets.add(old_draft_asset)
draft_version.assets.add(old_published_asset)
# Validate the metadata to mark the assets and version as `VALID`
tasks.validate_asset_metadata(old_draft_asset.id)
tasks.validate_asset_metadata(old_published_asset.id)
tasks.validate_version_metadata(draft_version.id)
draft_version.refresh_from_db()
assert draft_version.valid
resp = api_client.post(
f'/api/dandisets/{draft_version.dandiset.identifier}'
f'/versions/{draft_version.version}/publish/'
)
assert resp.status_code == 200
published_version = Version.objects.get(version=resp.data['version'])
assert published_version.assets.count() == 2
new_draft_asset: Asset = published_version.assets.get(asset_id=old_draft_asset.asset_id)
new_published_asset: Asset = published_version.assets.get(asset_id=old_published_asset.asset_id)
# The former draft asset should have been modified into a published asset
assert new_draft_asset.published
assert new_draft_asset.asset_id == old_draft_asset.asset_id
assert new_draft_asset.path == old_draft_asset.path
assert new_draft_asset.blob == old_draft_asset.blob
assert new_draft_asset.metadata == {
**old_draft_asset.metadata,
'datePublished': UTC_ISO_TIMESTAMP_RE,
'publishedBy': {
'id': URN_RE,
'name': 'DANDI publish',
'startDate': UTC_ISO_TIMESTAMP_RE,
# TODO endDate needs to be defined before publish is complete
'endDate': UTC_ISO_TIMESTAMP_RE,
'wasAssociatedWith': [
{
'id': URN_RE,
'identifier': 'RRID:SCR_017571',
'name': 'DANDI API',
'version': '0.1.0',
'schemaKey': 'Software',
}
],
'schemaKey': 'PublishActivity',
},
}
# The published_asset should be completely unchanged
assert new_published_asset.published
assert new_published_asset.asset_id == old_published_asset.asset_id
assert new_published_asset.path == old_published_asset.path
assert new_published_asset.blob == old_published_asset.blob
assert new_published_asset.metadata == old_published_asset.metadata
def test_version_rest_publish(api_client, user: User, draft_version: Version, asset: Asset):
assign_perm('owner', user, draft_version.dandiset)
api_client.force_authenticate(user=user)
draft_version.assets.add(asset)
# Validate the metadata to mark the version and asset as `VALID`
tasks.validate_version_metadata(draft_version.id)
tasks.validate_asset_metadata(asset.id)
draft_version.refresh_from_db()
assert draft_version.valid
resp = api_client.post(
f'/api/dandisets/{draft_version.dandiset.identifier}'
f'/versions/{draft_version.version}/publish/'
)
assert resp.data == {
'dandiset': {
'identifier': draft_version.dandiset.identifier,
'created': TIMESTAMP_RE,
'modified': TIMESTAMP_RE,
'contact_person': draft_version.metadata['contributor'][0]['name'],
'embargo_status': 'OPEN',
},
'version': VERSION_ID_RE,
'name': draft_version.name,
'created': TIMESTAMP_RE,
'modified': TIMESTAMP_RE,
'asset_count': 1,
'size': draft_version.size,
'status': 'Valid',
}
published_version = Version.objects.get(version=resp.data['version'])
assert published_version
assert draft_version.dandiset.versions.count() == 2
published_asset: Asset = published_version.assets.get()
assert published_asset.published
# The asset should be the same after publishing
assert asset.asset_id == published_asset.asset_id
assert published_version.metadata == {
**draft_version.metadata,
'publishedBy': {
'id': URN_RE,
'name': 'DANDI publish',
'startDate': UTC_ISO_TIMESTAMP_RE,
'endDate': UTC_ISO_TIMESTAMP_RE,
'wasAssociatedWith': [
{
'id': URN_RE,
'identifier': 'RRID:SCR_017571',
'name': 'DANDI API',
# TODO version the API
'version': '0.1.0',
'schemaKey': 'Software',
}
],
'schemaKey': 'PublishActivity',
},
'datePublished': UTC_ISO_TIMESTAMP_RE,
'manifestLocation': [
f'http://{settings.MINIO_STORAGE_ENDPOINT}/test-dandiapi-dandisets/test-prefix/dandisets/{draft_version.dandiset.identifier}/{published_version.version}/assets.yaml', # noqa: E501
],
'identifier': f'DANDI:{draft_version.dandiset.identifier}',
'version': published_version.version,
'id': f'DANDI:{draft_version.dandiset.identifier}/{published_version.version}',
'url': (
f'{settings.DANDI_WEB_APP_URL}/dandiset/{draft_version.dandiset.identifier}'
f'/{published_version.version}'
),
'citation': published_version.citation(published_version.metadata),
'doi': f'10.80507/dandi.{draft_version.dandiset.identifier}/{published_version.version}',
# Once the assets are linked, assetsSummary should be computed properly
'assetsSummary': {
'schemaKey': 'AssetsSummary',
'numberOfBytes': 100,
'numberOfFiles': 1,
'dataStandard': [
{
'schemaKey': 'StandardsType',
'identifier': 'RRID:SCR_015242',
'name': 'Neurodata Without Borders (NWB)',
}
],
'approach': [],
'measurementTechnique': [],
'variableMeasured': [],
'species': [],
},
}
draft_version.refresh_from_db()
assert draft_version.status == Version.Status.PUBLISHED
assert not draft_version.valid