def testUpdate_GroupTriaged_AlertsPartRecovered(self):
anomalies = [self._AddAnomaly(recovered=True), self._AddAnomaly()]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff', auto_triage_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertEqual('open', self._issue_tracker.issue.get('state'))
def testBisect_GroupTriaged_PinpointFailed(self):
anomalies = [self._AddAnomaly(), self._AddAnomaly()]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._pinpoint.SetFailure()
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
)
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertEqual(alert_group.AlertGroup.Status.bisected,
group.get().status)
self.assertEqual([], group.get().bisection_ids)
self.assertEqual(['Chromeperf-Auto-NeedsAttention'],
self._issue_tracker.add_comment_kwargs['labels'])
def testArchive_GroupTriaged(self):
anomalies = [self._AddAnomaly(), self._AddAnomaly()]
group = self._AddAlertGroup(
anomalies[0],
anomalies=anomalies,
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff', auto_triage_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
config=alert_group_workflow.AlertGroupWorkflow.Config(
active_window=datetime.timedelta(days=0),
triage_delay=datetime.timedelta(hours=0),
),
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertEqual(True, group.get().active)
def testTriage_GroupTriaged_InfAnomaly(self):
anomalies = [
self._AddAnomaly(median_before_anomaly=0),
self._AddAnomaly()
]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff',
auto_triage_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
)
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertIn('inf', self._issue_tracker.add_comment_args[1])
def testBisect_GroupBisected(self):
anomalies = [self._AddAnomaly(), self._AddAnomaly()]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.bisected,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(
name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertIsNone(self._pinpoint.new_job_request)
def testTriage_GroupUntriaged_MultipleRange(self):
anomalies = [
self._AddAnomaly(median_before_anomaly=0.2, start_revision=10),
self._AddAnomaly(median_before_anomaly=0.1)
]
group = self._AddAlertGroup(
anomalies[0],
status=alert_group.AlertGroup.Status.untriaged,
)
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff',
auto_triage_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
revision_info=self._revision_info,
config=alert_group_workflow.AlertGroupWorkflow.Config(
active_window=datetime.timedelta(days=7),
triage_delay=datetime.timedelta(hours=0),
),
)
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=None,
))
self.assertIn('2 regressions', self._issue_tracker.new_bug_args[0])
self.assertIn(
'Chromium Commit Position: http://test-results.appspot.com/revision_range?start=0&end=100',
self._issue_tracker.new_bug_args[1])
def testTriage_GroupUntriaged_InfAnomaly(self):
anomalies = [self._AddAnomaly(median_before_anomaly=0), self._AddAnomaly()]
group = self._AddAlertGroup(
anomalies[0],
status=alert_group.AlertGroup.Status.untriaged,
)
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff', auto_triage_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
config=alert_group_workflow.AlertGroupWorkflow.Config(
active_window=datetime.timedelta(days=7),
triage_delay=datetime.timedelta(hours=0),
),
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=None,
))
self.assertIn('inf', self._issue_tracker.new_bug_args[1])
def testBisect_GroupTriaged_MultiBot_AllInf(self):
anomalies = [
self._AddAnomaly(
test='master/bot1/test_suite/measurement/test_case1',
median_before_anomaly=0.0,
median_after_anomaly=1.0,
),
self._AddAnomaly(
test='master/bot1/test_suite/measurement/test_case2',
median_before_anomaly=0.0,
median_after_anomaly=2.0,
),
self._AddAnomaly(
test='master/bot2/test_suite/measurement/test_case2',
median_before_anomaly=0.1,
),
]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(
name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertEqual(
anomalies[1].urlsafe(),
json.loads(self._pinpoint.new_job_request['tags'])['alert'])
self.assertEqual(['123456'], group.get().bisection_ids)
def testBisect_GroupTriaged_NoIgnored(self):
anomalies = [
# This anomaly is manually ignored.
self._AddAnomaly(
median_before_anomaly=0.1, median_after_anomaly=1.0, bug_id=-2),
self._AddAnomaly(
median_before_anomaly=0.2,
median_after_anomaly=1.0,
start_revision=20),
]
group = self._AddAlertGroup(
anomalies[1],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
anomalies=anomalies,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(
name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertIsNotNone(self._pinpoint.new_job_request)
self.assertEqual(self._pinpoint.new_job_request['bug_id'], 12345)
self.assertEqual(group.get().status, alert_group.AlertGroup.Status.bisected)
# Check that we bisected the anomaly that is not ignored.
ignored_anomaly = anomalies[0].get()
bisected_anomaly = anomalies[1].get()
self.assertNotEqual(ignored_anomaly.pinpoint_bisects, ['123456'])
self.assertEqual(bisected_anomaly.pinpoint_bisects, ['123456'])
def testBisect_GroupTriaged(self):
anomalies = [
self._AddAnomaly(median_before_anomaly=0.2),
self._AddAnomaly(median_before_anomaly=0.1),
]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(
name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
tags = json.loads(self._pinpoint.new_job_request['tags'])
self.assertEqual(anomalies[1].urlsafe(), tags['alert'])
# Tags must be a dict of key/value string pairs.
for k, v in tags.items():
self.assertIsInstance(k, basestring)
self.assertIsInstance(v, basestring)
self.assertEqual(['123456'], group.get().bisection_ids)
self.assertEqual(['Chromeperf-Auto-Bisected'],
self._issue_tracker.add_comment_kwargs['labels'])
def testAddAnomalies_GroupTriaged_IssueOpen(self):
anomalies = [self._AddAnomaly(), self._AddAnomaly()]
added = [self._AddAnomaly(), self._AddAnomaly()]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
anomalies=anomalies,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff',
auto_triage_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
)
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies + added),
issue=self._issue_tracker.issue,
))
self.assertEqual(len(group.get().anomalies), 4)
self.assertEqual(group.get().status,
alert_group.AlertGroup.Status.triaged)
for a in added:
self.assertIn(a, group.get().anomalies)
self.assertEqual(group.get().bug.bug_id,
self._issue_tracker.add_comment_args[0])
self.assertIn('Added 2 regressions to the group',
self._issue_tracker.add_comment_args[1])
self.assertIn('4 regressions in test_suite',
self._issue_tracker.add_comment_kwargs['summary'])
self.assertIn('sheriff',
self._issue_tracker.add_comment_kwargs['summary'])
def testBisect_GroupTriaged_AlertWithBug(self):
anomalies = [
self._AddAnomaly(median_before_anomaly=0.2),
self._AddAnomaly(
median_before_anomaly=0.1,
bug_id=12340,
project_id='v8',
),
]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(
name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue,
))
self.assertEqual(self._issue_tracker.bug_id,
self._pinpoint.new_job_request['bug_id'])
self.assertEqual('chromium', self._pinpoint.new_job_request['project'])
self.assertEqual(['123456'], group.get().bisection_ids)
def testAddAnomalies_GroupUntriaged(self):
anomalies = [self._AddAnomaly(), self._AddAnomaly()]
added = [self._AddAnomaly(), self._AddAnomaly()]
group = self._AddAlertGroup(anomalies[0], anomalies=anomalies)
self._sheriff_config.patterns = {
'*': [subscription.Subscription(name='sheriff')],
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
)
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies + added),
issue={},
))
self.assertEqual(len(group.get().anomalies), 4)
for a in added:
self.assertIn(a, group.get().anomalies)
def testTriage_GroupUntriaged_NonChromiumProject(self):
anomalies = [self._AddAnomaly()]
# TODO(dberris): Figure out a way to not have to hack the fake service to
# seed it with the correct issue in the correct project.
self._issue_tracker.issues[(
'v8', self._issue_tracker.bug_id)] = self._issue_tracker.issues[(
'chromium', self._issue_tracker.bug_id)]
del self._issue_tracker.issues[('chromium',
self._issue_tracker.bug_id)]
self._issue_tracker.issues[('v8', self._issue_tracker.bug_id)].update({
'projectId':
'v8',
})
group = self._AddAlertGroup(
anomalies[0],
status=alert_group.AlertGroup.Status.untriaged,
project_id='v8')
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff',
auto_triage_enable=True,
monorail_project_id='v8')
],
}
self.assertEqual(group.get().project_id, 'v8')
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
revision_info=self._revision_info,
config=alert_group_workflow.AlertGroupWorkflow.Config(
active_window=datetime.timedelta(days=7),
triage_delay=datetime.timedelta(hours=0),
))
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=None))
self.assertEqual(group.get().bug.project, 'v8')
self.assertEqual(anomalies[0].get().project_id, 'v8')
def testBisect_UnsupportedTarget(self):
anomalies = [
self._AddAnomaly(
test='master/bot/performance_browser_tests/some_case')
]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged,
)
self._issue_tracker.issue.update({
'state': 'open',
})
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
]
}
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev)
w.Process(update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue))
self.assertEqual(alert_group.AlertGroup.Status.bisected,
group.get().status)
self.assertEqual([], group.get().bisection_ids)
self.assertEqual(['Chromeperf-Auto-NeedsAttention'],
self._issue_tracker.add_comment_kwargs['labels'])
self.assertIn('Only telemetry is supported at the moment.',
self._issue_tracker.add_comment_args[1])
def testBisect_SingleCL(self):
anomalies = [
self._AddAnomaly(
# Current implementation requires that a revision string is between
# 5 and 7 digits long.
start_revision=11111,
end_revision=11111,
test='ChromiumPerf/some-bot/some-benchmark/some-metric/some-story')
]
group = self._AddAlertGroup(
anomalies[0],
issue=self._issue_tracker.issue,
status=alert_group.AlertGroup.Status.triaged)
self._sheriff_config.patterns = {
'*': [
subscription.Subscription(
name='sheriff',
auto_triage_enable=True,
auto_bisect_enable=True)
]
}
# Here we are simulating that a gitiles service will respond to a specific
# repository URL (the format is not important) and can map a commit (40
# hexadecimal characters) to some commit information.
self._gitiles._repo_commit_list.update({
'git://chromium': {
'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa': {
'author': {
'email': '*****@*****.**',
},
'message': 'This is some commit.\n\nWith some details.',
}
}
})
# We are also seeding some repository information to let us set which
# repository URL is being used to look up data from a gitiles service.
namespaced_stored_object.Set('repositories', {
'chromium': {
'repository_url': 'git://chromium'
},
})
# Current implementation requires that a git hash is 40 characters of
# hexadecimal digits.
self._crrev.SetSuccess('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
w = alert_group_workflow.AlertGroupWorkflow(
group.get(),
sheriff_config=self._sheriff_config,
issue_tracker=self._issue_tracker,
pinpoint=self._pinpoint,
crrev=self._crrev,
gitiles=self._gitiles)
w.Process(
update=alert_group_workflow.AlertGroupWorkflow.GroupUpdate(
now=datetime.datetime.utcnow(),
anomalies=ndb.get_multi(anomalies),
issue=self._issue_tracker.issue))
self.assertEqual(alert_group.AlertGroup.Status.bisected, group.get().status)
self.assertEqual([], group.get().bisection_ids)
self.assertEqual(['Chromeperf-Auto-Assigned'],
self._issue_tracker.add_comment_kwargs['labels'])
self.assertIn(('Assigning to [email protected] because this is the '
'only CL in range:'),
self._issue_tracker.add_comment_args[1])
def _ProcessAlertGroup(group_key):
workflow = alert_group_workflow.AlertGroupWorkflow(group_key.get())
logging.info('Processing group: %s', group_key.string_id())
workflow.Process()
