def whiteboard(request, addon, channel): channel_as_text = channel channel, content_review_only = determine_channel(channel) perform_review_permission_checks( request, addon, channel, content_review_only=content_review_only) whiteboard, _ = Whiteboard.objects.get_or_create(pk=addon.pk) form = WhiteboardForm(request.POST or None, instance=whiteboard, prefix='whiteboard') if form.is_valid(): if whiteboard.private or whiteboard.public: form.save() else: whiteboard.delete() return redirect('reviewers.review', channel_as_text, addon.slug if addon.slug else addon.pk) raise PermissionDenied
def whiteboard(request, addon, channel): channel_as_text = channel channel, content_review_only = determine_channel(channel) perform_review_permission_checks( request, addon, channel, content_review_only=content_review_only) whiteboard, _ = Whiteboard.objects.get_or_create(pk=addon.pk) form = WhiteboardForm(request.POST or None, instance=whiteboard, prefix='whiteboard') if form.is_valid(): if whiteboard.private or whiteboard.public: form.save() else: whiteboard.delete() return redirect('reviewers.review', channel_as_text, addon.slug if addon.slug else addon.pk) raise PermissionDenied
def review(request, addon, channel=None): whiteboard_url = reverse('reviewers.whiteboard', args=(channel or 'listed', addon.slug if addon.slug else addon.pk)) channel, content_review_only = determine_channel(channel) was_auto_approved = (channel == amo.RELEASE_CHANNEL_LISTED and addon.current_version and addon.current_version.was_auto_approved) is_static_theme = addon.type == amo.ADDON_STATICTHEME # If we're just looking (GET) we can bypass the specific permissions checks # if we have ReviewerTools:View. bypass_more_specific_permissions_because_read_only = ( request.method == 'GET' and acl.action_allowed(request, amo.permissions.REVIEWER_TOOLS_VIEW)) if not bypass_more_specific_permissions_because_read_only: perform_review_permission_checks( request, addon, channel, content_review_only=content_review_only) version = addon.find_latest_version(channel=channel, exclude=(amo.STATUS_BETA, )) if not settings.ALLOW_SELF_REVIEWS and addon.has_author(request.user): amo.messages.warning(request, ugettext('Self-reviews are not allowed.')) return redirect(reverse('reviewers.queue')) # Get the current info request state to set as the default. form_initial = {'info_request': addon.pending_info_request} form_helper = ReviewHelper(request=request, addon=addon, version=version, content_review_only=content_review_only) form = ReviewForm(request.POST if request.method == 'POST' else None, helper=form_helper, initial=form_initial) is_admin = acl.action_allowed(request, amo.permissions.REVIEWS_ADMIN) approvals_info = None reports = None user_ratings = None if channel == amo.RELEASE_CHANNEL_LISTED: if was_auto_approved: try: approvals_info = addon.addonapprovalscounter except AddonApprovalsCounter.DoesNotExist: pass developers = addon.listed_authors reports = Paginator((AbuseReport.objects.filter( Q(addon=addon) | Q(user__in=developers)).order_by('-created')), 5).page(1) user_ratings = Paginator((Rating.without_replies.filter( addon=addon, rating__lte=3, body__isnull=False).order_by('-created')), 5).page(1) if content_review_only: queue_type = 'content_review' elif was_auto_approved: queue_type = 'auto_approved' else: queue_type = form.helper.handler.review_type redirect_url = reverse('reviewers.queue_%s' % queue_type) else: redirect_url = reverse('reviewers.unlisted_queue_all') if request.method == 'POST' and form.is_valid(): form.helper.process() amo.messages.success(request, ugettext('Review successfully processed.')) clear_reviewing_cache(addon.id) return redirect(redirect_url) # Kick off validation tasks for any files in this version which don't have # cached validation, since reviewers will almost certainly need to access # them. But only if we're not running in eager mode, since that could mean # blocking page load for several minutes. if version and not getattr(settings, 'CELERY_ALWAYS_EAGER', False): for file_ in version.all_files: if not file_.has_been_validated: devhub_tasks.validate(file_) actions = form.helper.actions.items() try: # Find the previously approved version to compare to. show_diff = version and (addon.versions.exclude(id=version.id).filter( # We're looking for a version that was either manually approved # (either it has no auto approval summary, or it has one but # with a negative verdict because it was locked by a reviewer # who then approved it themselves), or auto-approved but then # confirmed. Q(autoapprovalsummary__isnull=True) | Q(autoapprovalsummary__verdict=amo.NOT_AUTO_APPROVED) | Q(autoapprovalsummary__verdict=amo.AUTO_APPROVED, autoapprovalsummary__confirmed=True)).filter( channel=channel, files__isnull=False, created__lt=version.created, files__status=amo.STATUS_PUBLIC).latest()) except Version.DoesNotExist: show_diff = None # The actions we shouldn't show a minimal form for. actions_full = [ k for (k, a) in actions if not (is_static_theme or a.get('minimal')) ] # The actions we should show the comments form for (contrary to minimal # form above, it defaults to True, because most actions do need to have # the comments form). actions_comments = [k for (k, a) in actions if a.get('comments', True)] versions = (Version.unfiltered.filter( addon=addon, channel=channel).select_related('autoapprovalsummary').exclude( files__status=amo.STATUS_BETA).order_by('-created').transform( Version.transformer_activity).transform(Version.transformer)) # We assume comments on old deleted versions are for listed versions. # See _get_comments_for_hard_deleted_versions above for more detail. all_versions = (_get_comments_for_hard_deleted_versions(addon) if channel == amo.RELEASE_CHANNEL_LISTED else []) all_versions.extend(versions) all_versions.sort(key=lambda v: v.created, reverse=True) pager = amo.utils.paginate(request, all_versions, 10) num_pages = pager.paginator.num_pages count = pager.paginator.count auto_approval_info = {} # Now that we've paginated the versions queryset, iterate on them to # generate auto approvals info. Note that the variable should not clash # the already existing 'version'. for a_version in pager.object_list: if not a_version.is_ready_for_auto_approval: continue try: summary = a_version.autoapprovalsummary except AutoApprovalSummary.DoesNotExist: auto_approval_info[a_version.pk] = None continue # Call calculate_verdict() again, it will use the data already stored. verdict_info = summary.calculate_verdict(pretty=True) auto_approval_info[a_version.pk] = verdict_info flags = get_flags(addon, version) if version else [] if not is_static_theme: try: whiteboard = Whiteboard.objects.get(pk=addon.pk) except Whiteboard.DoesNotExist: whiteboard = Whiteboard(pk=addon.pk) whiteboard_form = WhiteboardForm(instance=whiteboard, prefix='whiteboard') else: whiteboard_form = None backgrounds = version.get_background_image_urls() if version else [] user_changes_actions = [ amo.LOG.ADD_USER_WITH_ROLE.id, amo.LOG.CHANGE_USER_WITH_ROLE.id, amo.LOG.REMOVE_USER_WITH_ROLE.id ] user_changes_log = AddonLog.objects.filter( activity_log__action__in=user_changes_actions, addon=addon).order_by('id') ctx = context(request, actions=actions, actions_comments=actions_comments, actions_full=actions_full, addon=addon, api_token=request.COOKIES.get(API_TOKEN_COOKIE, None), approvals_info=approvals_info, auto_approval_info=auto_approval_info, backgrounds=backgrounds, content_review_only=content_review_only, count=count, flags=flags, form=form, is_admin=is_admin, num_pages=num_pages, pager=pager, reports=reports, show_diff=show_diff, subscribed=ReviewerSubscription.objects.filter( user=request.user, addon=addon).exists(), unlisted=(channel == amo.RELEASE_CHANNEL_UNLISTED), user_changes=user_changes_log, user_ratings=user_ratings, version=version, was_auto_approved=was_auto_approved, whiteboard_form=whiteboard_form, whiteboard_url=whiteboard_url) return render(request, 'reviewers/review.html', ctx)