def test_deduplication_identical_object(): create_jurisdiction() p1 = ScrapeBill("HB 1", "2020", "Title").as_dict() p2 = ScrapeBill("HB 1", "2020", "Title").as_dict() BillImporter("jid").import_data([p1, p2]) assert Bill.objects.count() == 1
def test_locked_field(): create_jurisdiction() bill = ScrapeBill("HB 1", "2020", "Title").as_dict() bi = BillImporter("jid") bi.import_data([bill]) # set classification and lock field b = Bill.objects.get() b.classification = ["locked"] b.locked_fields = ["classification"] b.save() # reimport bill = ScrapeBill("HB 1", "2020", "Title").as_dict() bi = BillImporter("jid") bi.import_data([bill]) b = Bill.objects.get() assert b.classification == ["locked"] assert b.locked_fields == ["classification"] # do it a third time to check for the locked_fields reversion issue bill = ScrapeBill("HB 1", "2020", "Title").as_dict() bi = BillImporter("jid") bi.import_data([bill]) b = Bill.objects.get() assert b.classification == ["locked"] assert b.locked_fields == ["classification"]
def test_bill_sponsor_limit_lookup_within_session(): j = create_jurisdiction() org = create_org() j.legislative_sessions.create(identifier="2021", name="2021", start_date="2021", end_date="2022") old_bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower") old_bill.add_sponsorship( name="Springfield", classification="sponsor", entity_type="person", primary=True, ) new_bill = ScrapeBill( "HB 9000", "2021", "Laser Regulations", classification="tax bill", chamber="lower", ) new_bill.add_sponsorship( name="Springfield", classification="sponsor", entity_type="person", primary=True, ) jeb = Person.objects.create(name="Jebediah Springfield", birth_date="1850-01-01", family_name="Springfield") Membership.objects.create(person_id=jeb.id, organization_id=org.id, end_date="1910-01-01") futuro = Person.objects.create(name="Futuro Springfield", birth_date="2000-01-01", family_name="Springfield") Membership.objects.create(person_id=futuro.id, organization_id=org.id, start_date="2020-04-01") BillImporter("jid").import_data([old_bill.as_dict(), new_bill.as_dict()]) # get old bill and ensure Jeb is sponsor old_bill_obj = Bill.objects.get(identifier="HB 1") (entry, ) = old_bill_obj.sponsorships.all() assert entry.person.name == jeb.name # get new bill and ensure Futuro is sponsor new_bill_obj = Bill.objects.get(identifier="HB 9000") (entry, ) = new_bill_obj.sponsorships.all() assert entry.person.name == futuro.name
def test_exception_on_identical_objects_in_import_stream(): create_jurisdiction() # these two objects aren't identical, but refer to the same thing # at the moment we consider this an error (but there may be a better way to handle this?) b1 = ScrapeBill("HB 1", "2020", "Title", chamber="upper").as_dict() b2 = ScrapeBill("HB 1", "2020", "Title", chamber="lower").as_dict() with pytest.raises(Exception): BillImporter("jid").import_data([b1, b2])
def test_exception_on_identical_objects_in_import_stream(): create_jurisdiction() # the first two objects aren't identical, but refer to the same thing # at the moment we drop both objects (because we can't know which one is correct) b1 = ScrapeBill("HB 1", "2020", "Title", chamber="upper").as_dict() b2 = ScrapeBill("HB 1", "2020", "Title", chamber="lower").as_dict() b3 = ScrapeBill("HB 2", "2020", "Bill Title").as_dict() BillImporter("jid").import_data([b1, b2, b3]) assert Bill.objects.count() == 1
def test_duplicate_bill_different_chamber(): create_jurisdiction() create_org() Organization.objects.create(id="upper-id", name="Senate", classification="upper", jurisdiction_id="jid") b1 = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", chamber="lower") b2 = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", chamber="upper") with pytest.raises(DuplicateItemError): BillImporter("jid").import_data([b1.as_dict(), b2.as_dict()])
def test_bill_sponsor_by_identifier(): create_jurisdiction() org = create_org() bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower") bill.add_sponsorship_by_identifier( name="SNODGRASS", classification="sponsor", entity_type="person", primary=True, identifier="TOTALLY_REAL_ID", scheme="TOTALLY_REAL_SCHEME", ) za_db = Person.objects.create(name="Zadock Snodgrass") za_db.identifiers.create(identifier="TOTALLY_REAL_ID", scheme="TOTALLY_REAL_SCHEME") Membership.objects.create(person_id=za_db.id, organization_id=org.id) BillImporter("jid").import_data([bill.as_dict()]) obj = Bill.objects.get() (entry, ) = obj.sponsorships.all() assert entry.person.name == "Zadock Snodgrass"
def test_invalid_fields(): create_jurisdiction() p1 = ScrapeBill("HB 1", "2020", "Title").as_dict() p1["newfield"] = "shouldn't happen" with pytest.raises(DataImportError): BillImporter("jid").import_data([p1])
def test_invalid_fields_related_item(): create_jurisdiction() p1 = ScrapeBill("HB 1", "2020", "Title") p1.add_source("http://example.com") p1 = p1.as_dict() p1["sources"][0]["test"] = 3 with pytest.raises(DataImportError): BillImporter("jid").import_data([p1])
def test_bill_update(): create_jurisdiction() create_org() bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") _, what = BillImporter("jid").import_item(bill.as_dict()) assert what == "insert" _, what = BillImporter("jid").import_item(bill.as_dict()) assert what == "noop" # ensure no new object was created assert Bill.objects.count() == 1 # test basic update bill = ScrapeBill("HB 1", "1900", "1st Bill", chamber="lower") _, what = BillImporter("jid").import_item(bill.as_dict()) assert what == "update" assert Bill.objects.get().title == "1st Bill"
def test_full_vote_event(): j = create_jurisdiction() j.legislative_sessions.create(name="1900", identifier="1900") sp1 = ScrapePerson("John Smith", primary_org="lower") sp2 = ScrapePerson("Adam Smith", primary_org="lower") org = ScrapeOrganization(name="House", classification="lower") bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", from_organization=org._id) vote_event = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-01", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", organization=org._id, ) vote_event.set_count("yes", 20) vote_event.yes("John Smith") vote_event.no("Adam Smith") oi = OrganizationImporter("jid") oi.import_data([org.as_dict()]) pi = PersonImporter("jid") pi.import_data([sp1.as_dict(), sp2.as_dict()]) mi = MembershipImporter("jid", pi, oi, DumbMockImporter()) mi.import_data([sp1._related[0].as_dict(), sp2._related[0].as_dict()]) bi = BillImporter("jid", oi, pi) bi.import_data([bill.as_dict()]) VoteEventImporter("jid", pi, oi, bi).import_data([vote_event.as_dict()]) assert VoteEvent.objects.count() == 1 ve = VoteEvent.objects.get() assert ve.legislative_session == LegislativeSession.objects.get() assert ve.motion_classification == ["passage:bill"] assert ve.bill == Bill.objects.get() count = ve.counts.get() assert count.option == "yes" assert count.value == 20 votes = list(ve.votes.all()) assert len(votes) == 2 for v in ve.votes.all(): if v.voter_name == "John Smith": assert v.option == "yes" assert v.voter == Person.objects.get(name="John Smith") else: assert v.option == "no" assert v.voter == Person.objects.get(name="Adam Smith")
def test_locked_field_subitem(): create_jurisdiction() bill = ScrapeBill("HB 1", "2020", "Title") bill.add_source("https://example.com") bi = BillImporter("jid") bi.import_data([bill.as_dict()]) # lock the field b = Bill.objects.get() b.locked_fields = ["sources"] b.save() # reimport (without source) bill = ScrapeBill("HB 1", "2020", "Title") bi = BillImporter("jid") bi.import_data([bill.as_dict()]) b = Bill.objects.get() assert b.sources.count() == 1 assert b.locked_fields == ["sources"]
def test_resolve_json_id(): create_jurisdiction() p1 = ScrapeBill("HB 1", "2020", "Title").as_dict() p2 = ScrapeBill("HB 1", "2020", "Title").as_dict() bi = BillImporter("jid") # do import and get database id p1_id = p1["_id"] p2_id = p2["_id"] bi.import_data([p1, p2]) db_id = Bill.objects.get().id # simplest case assert bi.resolve_json_id(p1_id) == db_id # duplicate should resolve to same id assert bi.resolve_json_id(p2_id) == db_id # a null id should map to None assert bi.resolve_json_id(None) is None # no such id with pytest.raises(UnresolvedIdError): bi.resolve_json_id("this-is-invalid")
def test_vote_event_bill_actions_two_stage(): # this test is very similar to what we're testing in test_vote_event_bill_actions w/ # ve3 and ve4, that two bills that reference the same action won't conflict w/ the # OneToOneField, but in this case we do it in two stages so that the conflict is found # even if the votes weren't in the same scrape create_jurisdiction() bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", chamber="lower") bill.add_action(description="passage", date="1900-04-02", chamber="lower") ve1 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", bill_action="passage", chamber="lower", ) ve2 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", bill_action="passage", chamber="lower", ) # disambiguate them ve1.pupa_id = "one" ve2.pupa_id = "two" bi = BillImporter("jid") bi.import_data([bill.as_dict()]) # first imports just fine VoteEventImporter("jid", bi).import_data([ve1.as_dict()]) votes = list(VoteEvent.objects.all()) assert len(votes) == 1 assert votes[0].bill_action is not None # when second is imported, ensure that action stays pinned to first just as it would # have if they were both in same import VoteEventImporter("jid", bi).import_data([ve1.as_dict(), ve2.as_dict()]) votes = list(VoteEvent.objects.all()) assert len(votes) == 2 assert votes[0].bill_action is not None assert votes[1].bill_action is None
def _problem_bill(): bill = ScrapeBill( "HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower", ) # two identical actions, and one differs bill.add_action("identical action", "1900-04-01", chamber="lower") bill.add_action("different action", "1900-04-01", chamber="lower") bill.add_action("identical action", "1900-04-01", chamber="lower") return bill
def test_bill_chamber_param(): create_jurisdiction() org = create_org() bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower") BillImporter("jid").import_data([bill.as_dict()]) assert Bill.objects.get().from_organization_id == org.id
def test_bill_action_extras(): create_jurisdiction() create_org() bill = ScrapeBill( "HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower" ) bill.add_action("sample", "1900-01-01", chamber="lower", extras={"test": 3}) oi = OrganizationImporter("jid") pi = PersonImporter("jid") BillImporter("jid", oi, pi).import_data([bill.as_dict()]) b = Bill.objects.get() assert b.actions.all()[0].extras == {"test": 3}
def test_full_vote_event(): create_jurisdiction() bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", chamber="lower") vote_event = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-01", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", chamber="lower", ) vote_event.set_count("yes", 20) vote_event.yes("John Smith") vote_event.no("Adam Smith") Person.objects.create(name="John Smith") Person.objects.create(name="Adam Smith") for person in Person.objects.all(): person.memberships.create(organization=Organization.objects.get( classification="lower")) bi = BillImporter("jid") bi.import_data([bill.as_dict()]) VoteEventImporter("jid", bi).import_data([vote_event.as_dict()]) assert VoteEvent.objects.count() == 1 ve = VoteEvent.objects.get() assert ve.legislative_session == LegislativeSession.objects.get() assert ve.motion_classification == ["passage:bill"] assert ve.bill == Bill.objects.get() count = ve.counts.get() assert count.option == "yes" assert count.value == 20 votes = list(ve.votes.all()) assert len(votes) == 2 for v in ve.votes.all(): if v.voter_name == "John Smith": assert v.option == "yes" assert v.voter == Person.objects.get(name="John Smith") else: assert v.option == "no" assert v.voter == Person.objects.get(name="Adam Smith")
def test_fix_bill_id(): j = create_jurisdiction() j.legislative_sessions.create(name="1900", identifier="1900") org1 = ScrapeOrganization(name="House", classification="lower") bill = ScrapeBill("HB 1", "1900", "Test Bill ID", classification="bill", chamber="lower") oi = OrganizationImporter("jid") oi.import_data([org1.as_dict()]) from openstates.settings import IMPORT_TRANSFORMERS IMPORT_TRANSFORMERS["bill"] = { "identifier": lambda x: re.sub(r"([A-Z]*)\s*0*([-\d]+)", r"\1 \2", x, 1) } bi = BillImporter("jid", oi, DumbMockImporter()) bi.import_data([bill.as_dict()]) ve = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="fail", bill_chamber="lower", bill="HB1", identifier="4", bill_action="passage", organization=org1._id, ) VoteEventImporter("jid", DumbMockImporter(), oi, bi).import_data([ve.as_dict()]) IMPORT_TRANSFORMERS["bill"] = {} ve = VoteEvent.objects.get() ve.bill.identifier == "HB 1"
def test_fix_bill_id(): create_jurisdiction() create_org() bill = ScrapeBill("hb1", "1900", "Test Bill ID", classification="bill", chamber="lower") from openstates.settings import IMPORT_TRANSFORMERS IMPORT_TRANSFORMERS["bill"] = { "identifier": fix_bill_id, } bi = BillImporter("jid") bi.import_data([bill.as_dict()]) IMPORT_TRANSFORMERS["bill"] = {} b = Bill.objects.get() assert b.identifier == "HB 1"
def test_fix_bill_id(): create_jurisdiction() create_org() bill = ScrapeBill("HB1", "1900", "Test Bill ID", classification="bill", chamber="lower") from openstates.settings import IMPORT_TRANSFORMERS IMPORT_TRANSFORMERS["bill"] = { "identifier": lambda x: re.sub(r"([A-Z]*)\s*0*([-\d]+)", r"\1 \2", x, 1) } bi = BillImporter("jid") bi.import_data([bill.as_dict()]) IMPORT_TRANSFORMERS["bill"] = {} b = Bill.objects.get() assert b.identifier == "HB 1"
def test_bill_sponsor_limit_lookup(): create_jurisdiction() org = create_org() bill = ScrapeBill( "HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower" ) bill.add_sponsorship_by_identifier( name="SNODGRASS", classification="sponsor", entity_type="person", primary=True, identifier="TOTALLY_REAL_ID", scheme="TOTALLY_REAL_SCHEME", ) oi = OrganizationImporter("jid") pi = PersonImporter("jid") zs = ScrapePerson(name="Zadock Snodgrass", birth_date="1800-01-01") zs.add_identifier(identifier="TOTALLY_REAL_ID", scheme="TOTALLY_REAL_SCHEME") pi.import_data([zs.as_dict()]) za_db = Person.objects.get() Membership.objects.create(person_id=za_db.id, organization_id=org.id) zs2 = ScrapePerson(name="Zadock Snodgrass", birth_date="1900-01-01") zs2.add_identifier(identifier="TOTALLY_REAL_ID", scheme="TOTALLY_REAL_SCHEME") # This is contrived and perhaps broken, but we're going to check this. # We *really* don't want to *ever* cross jurisdiction bounds. PersonImporter("another-jurisdiction").import_data([zs.as_dict()]) BillImporter("jid", oi, pi).import_data([bill.as_dict()]) obj = Bill.objects.get() (entry,) = obj.sponsorships.all() assert entry.person.name == "Zadock Snodgrass" assert entry.person.birth_date == "1800-01-01"
def test_fix_bill_id(): create_jurisdiction() bill = ScrapeBill("HB 1", "1900", "Test Bill ID", classification="bill", chamber="lower") from openstates.settings import IMPORT_TRANSFORMERS IMPORT_TRANSFORMERS["bill"] = { "identifier": fix_bill_id, } bi = BillImporter("jid") bi.import_data([bill.as_dict()]) ve = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="fail", bill_chamber="lower", bill="HB1", identifier="4", bill_action="passage", chamber="lower", ) VoteEventImporter("jid", bi).import_data([ve.as_dict()]) IMPORT_TRANSFORMERS["bill"] = {} ve = VoteEvent.objects.get() ve.bill.identifier == "HB 1"
def test_bill_update_because_of_subitem(): create_jurisdiction() create_org() # initial bill bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is an action", chamber="lower", date="1900-01-01") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["insert"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 1 last_updated = obj.updated_at # now let's make sure we get updated when there are second actions bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is an action", chamber="lower", date="1900-01-01") bill.add_action("this is a second action", chamber="lower", date="1900-01-02") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 2 assert obj.updated_at > last_updated # same 2 actions, noop bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is an action", chamber="lower", date="1900-01-01") bill.add_action("this is a second action", chamber="lower", date="1900-01-02") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["noop"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 2 # same 2 actions, different order, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is a second action", chamber="lower", date="1900-01-02") bill.add_action("this is an action", chamber="lower", date="1900-01-01") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 2 # different 2 actions, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is an action", chamber="lower", date="1900-01-01") bill.add_action("this is a different second action", chamber="lower", date="1900-01-02") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 2 # delete an action, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is a second action", chamber="lower", date="1900-01-02") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 1 # delete all actions, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 0 # and back to initial status, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_action("this is an action", chamber="lower", date="1900-01-01") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.actions.count() == 1
def test_bill_update_subsubitem(): create_jurisdiction() create_org() # initial sub-subitem bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_version_link("printing", "http://example.com/test.pdf", media_type="application/pdf") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["insert"] == 1 obj = Bill.objects.get() assert obj.versions.count() == 1 assert obj.versions.get().links.count() == 1 # a second subsubitem, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_version_link("printing", "http://example.com/test.pdf", media_type="application/pdf") bill.add_version_link("printing", "http://example.com/test.text", media_type="text/plain") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.versions.count() == 1 assert obj.versions.get().links.count() == 2 # same thing, noop bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_version_link("printing", "http://example.com/test.pdf", media_type="application/pdf") bill.add_version_link("printing", "http://example.com/test.text", media_type="text/plain") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["noop"] == 1 obj = Bill.objects.get() assert obj.versions.count() == 1 assert obj.versions.get().links.count() == 2 # different link for second one, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_version_link("printing", "http://example.com/test.pdf", media_type="application/pdf") bill.add_version_link("printing", "http://example.com/diff-link.txt", media_type="text/plain") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.versions.count() == 1 assert obj.versions.get().links.count() == 2 # delete one, update bill = ScrapeBill("HB 1", "1900", "First Bill", chamber="lower") bill.add_version_link("printing", "http://example.com/test.pdf", media_type="application/pdf") result = BillImporter("jid").import_data([bill.as_dict()]) assert result["bill"]["update"] == 1 obj = Bill.objects.get() assert obj.versions.count() == 1 assert obj.versions.get().links.count() == 1
def test_full_bill(): create_jurisdiction() person = Person.objects.create(name="Adam Smith") lower = Organization.objects.create(jurisdiction_id="jid", name="House", classification="lower") Membership.objects.create(person_id=person.id, organization_id=lower.id) Organization.objects.create( jurisdiction_id="jid", name="Arbitrary Committee", classification="committee", parent=lower, ) oldbill = ScrapeBill( "HB 99", "1899", "Axe & Tack Tax Act", classification="tax bill", chamber="lower", ) bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", classification="tax bill", chamber="lower") bill.subject = ["taxes", "axes"] bill.add_identifier("SB 9") bill.add_title("Tack & Axe Tax Act") bill.add_action("introduced in house", "1900-04-01", chamber="lower") act = bill.add_action("sent to arbitrary committee", "1900-04-04", chamber="lower") act.add_related_entity( "arbitrary committee", "organization", _make_pseudo_id(name="Arbitrary Committee"), ) bill.add_related_bill("HB 99", legislative_session="1899", relation_type="prior-session") bill.add_sponsorship( "Adam Smith", classification="extra sponsor", entity_type="person", primary=False, entity_id=_make_pseudo_id(name="Adam Smith"), ) bill.add_sponsorship("Jane Smith", classification="lead sponsor", entity_type="person", primary=True) bill.add_abstract( "This is an act about axes and taxes and tacks.", note="official", date="1969-10-20", ) bill.add_document_link("Fiscal Note", "http://example.com/fn.pdf", media_type="application/pdf") bill.add_document_link("Fiscal Note", "http://example.com/fn.html", media_type="text/html") bill.add_version_link("Fiscal Note", "http://example.com/v/1", media_type="text/html") bill.add_source("http://example.com/source") # import bill BillImporter("jid").import_data([oldbill.as_dict(), bill.as_dict()]) # get bill from db and assert it imported correctly b = Bill.objects.get(identifier="HB 1") assert b.from_organization.classification == "lower" assert b.identifier == bill.identifier assert b.title == bill.title assert b.classification == bill.classification assert b.subject == ["taxes", "axes"] assert b.abstracts.get().note == "official" assert b.abstracts.get().date == "1969-10-20" # other_title, other_identifier added assert b.other_titles.get().title == "Tack & Axe Tax Act" assert b.other_identifiers.get().identifier == "SB 9" # actions actions = list(b.actions.all()) assert len(actions) == 2 # ensure order was preserved (if this breaks it'll be intermittent) assert actions[0].organization == Organization.objects.get( classification="lower") assert actions[0].description == "introduced in house" assert actions[1].description == "sent to arbitrary committee" assert actions[1].related_entities.get( ).organization == Organization.objects.get(classification="committee") # action computed fields assert b.first_action_date == "1900-04-01" assert b.latest_action_date == "1900-04-04" assert b.latest_action_description == "sent to arbitrary committee" # related_bills were added rb = b.related_bills.get() assert rb.identifier == "HB 99" # and bill got resolved assert rb.related_bill.identifier == "HB 99" # sponsors added, linked & unlinked sponsorships = b.sponsorships.all() assert len(sponsorships) == 2 person = Person.objects.get(name="Adam Smith") for ss in sponsorships: if ss.primary: assert ss.person is None assert ss.organization is None else: assert ss.person == person # versions & documents with their links versions = b.versions.all() assert len(versions) == 1 assert versions[0].links.count() == 1 documents = b.documents.all() assert len(documents) == 1 assert documents[0].links.count() == 2 # sources assert b.sources.count() == 1
def test_vote_event_bill_actions(): j = create_jurisdiction() j.legislative_sessions.create(name="1900", identifier="1900") org1 = ScrapeOrganization(name="House", classification="lower") org2 = ScrapeOrganization(name="Senate", classification="upper") bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", from_organization=org1._id) # add actions, passage of upper & lower on same day, something else, # then passage in upper again on a different day bill.add_action(description="passage", date="1900-04-01", chamber="upper") bill.add_action(description="passage", date="1900-04-01", chamber="lower") bill.add_action(description="other event", date="1900-04-01", chamber="lower") bill.add_action(description="passage", date="1900-04-02", chamber="upper") # four passage votes, one per chamber, one on 04-01, and one on 04-02 ve1 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-01", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", bill_action="passage", organization=org1._id, ) ve2 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-01", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", bill_action="passage", organization=org2._id, ) ve3 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", bill_action="passage", organization=org1._id, ) ve4 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", bill_action="passage", organization=org2._id, ) oi = OrganizationImporter("jid") oi.import_data([org1.as_dict(), org2.as_dict()]) bi = BillImporter("jid", oi, DumbMockImporter()) bi.import_data([bill.as_dict()]) VoteEventImporter("jid", DumbMockImporter(), oi, bi).import_data( [ve1.as_dict(), ve2.as_dict(), ve3.as_dict(), ve4.as_dict()]) bill = Bill.objects.get() votes = list(VoteEvent.objects.all()) actions = list(bill.actions.all()) assert len(actions) == 4 assert len(votes) == 4 votes = {(v.organization.classification, v.start_date): v.bill_action for v in votes} # ensure that votes are matched using action, chamber, and date assert votes[("upper", "1900-04-01")] == actions[0] assert votes[("lower", "1900-04-01")] == actions[1] assert votes[("upper", "1900-04-02")] == actions[3] assert votes[("lower", "1900-04-02")] is None
def test_vote_event_bill_actions_errors(): j = create_jurisdiction() j.legislative_sessions.create(name="1900", identifier="1900") org1 = ScrapeOrganization(name="House", classification="lower") org2 = ScrapeOrganization(name="Senate", classification="upper") bill = ScrapeBill("HB 1", "1900", "Axe & Tack Tax Act", from_organization=org1._id) # for this bill, two identical actions, so vote matching will fail bill.add_action(description="passage", date="1900-04-01", chamber="lower") bill.add_action(description="passage", date="1900-04-01", chamber="lower") # this action is good, but two votes will try to match it bill.add_action(description="passage", date="1900-04-02", chamber="lower") # will match two actions ve1 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-01", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", identifier="1", bill_action="passage", organization=org1._id, ) # will match no actions ve2 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-01", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", identifier="2", bill_action="committee result", organization=org1._id, ) # these two votes will both match the same action ve3 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage", start_date="1900-04-02", classification="passage:bill", result="pass", bill_chamber="lower", bill="HB 1", identifier="3", bill_action="passage", organization=org1._id, ) ve4 = ScrapeVoteEvent( legislative_session="1900", motion_text="passage-syz", start_date="1900-04-02", classification="passage:bill", result="fail", bill_chamber="lower", bill="HB 1", identifier="4", bill_action="passage", organization=org1._id, ) oi = OrganizationImporter("jid") oi.import_data([org1.as_dict(), org2.as_dict()]) bi = BillImporter("jid", oi, DumbMockImporter()) bi.import_data([bill.as_dict()]) VoteEventImporter("jid", DumbMockImporter(), oi, bi).import_data( [ve1.as_dict(), ve2.as_dict(), ve3.as_dict(), ve4.as_dict()]) bill = Bill.objects.get() votes = list(VoteEvent.objects.all().order_by("identifier")) # isn't matched, was ambiguous across two actions assert votes[0].bill_action is None # isn't matched, no match in actions assert votes[1].bill_action is None # these both try to match the same action, only first will succeed assert votes[2].bill_action is not None assert votes[3].bill_action is None