def testCountViolationsWithRelativePath(self):
self.deps_checker.results_formatter = results.CountViolationsFormatter(
)
self.deps_checker.CheckDirectory(
os.path.join('checkdeps', 'testdata', 'allowed'))
self.failUnlessEqual('4',
self.deps_checker.results_formatter.GetResults())
def CountViolations(self, skip_tests):
deps_checker = checkdeps.DepsChecker(self.checkout_root,
ignore_temp_rules=True,
skip_tests=skip_tests)
deps_checker.results_formatter = results.CountViolationsFormatter()
deps_checker.CheckDirectory(os.path.join('chrome', 'browser'))
return int(deps_checker.results_formatter.GetResults())
def CountViolations(self, ignore_temp_rules):
self.deps_checker._ignore_temp_rules = ignore_temp_rules
self.deps_checker.results_formatter = results.CountViolationsFormatter()
self.deps_checker.CheckDirectory(
os.path.join(self.deps_checker.base_directory,
'tools/checkdeps/testdata'))
return self.deps_checker.results_formatter.GetResults()
def main():
option_parser = optparse.OptionParser()
option_parser.add_option(
'', '--root',
default='', dest='base_directory',
help='Specifies the repository root. This defaults '
'to "../../.." relative to the script file, which '
'will normally be the repository root.')
option_parser.add_option(
'', '--ignore-temp-rules',
action='store_true', dest='ignore_temp_rules', default=False,
help='Ignore !-prefixed (temporary) rules.')
option_parser.add_option(
'', '--generate-temp-rules',
action='store_true', dest='generate_temp_rules', default=False,
help='Print rules to temporarily allow files that fail '
'dependency checking.')
option_parser.add_option(
'', '--count-violations',
action='store_true', dest='count_violations', default=False,
help='Count #includes in violation of intended rules.')
option_parser.add_option(
'', '--skip-tests',
action='store_true', dest='skip_tests', default=False,
help='Skip checking test files (best effort).')
option_parser.add_option(
'-v', '--verbose',
action='store_true', default=False,
help='Print debug logging')
options, args = option_parser.parse_args()
deps_checker = DepsChecker(options.base_directory,
verbose=options.verbose,
ignore_temp_rules=options.ignore_temp_rules,
skip_tests=options.skip_tests)
# Figure out which directory we have to check.
start_dir = deps_checker.base_directory
if len(args) == 1:
# Directory specified. Start here. It's supposed to be relative to the
# base directory.
start_dir = os.path.abspath(
os.path.join(deps_checker.base_directory, args[0]))
elif len(args) >= 2 or (options.generate_temp_rules and
options.count_violations):
# More than one argument, or incompatible flags, we don't handle this.
PrintUsage()
return 1
print 'Using base directory:', deps_checker.base_directory
print 'Checking:', start_dir
if options.generate_temp_rules:
deps_checker.results_formatter = results.TemporaryRulesFormatter()
elif options.count_violations:
deps_checker.results_formatter = results.CountViolationsFormatter()
deps_checker.CheckDirectory(start_dir)
return deps_checker.Report()
def main():
option_parser = optparse.OptionParser()
option_parser.add_option(
'',
'--root',
default='',
dest='base_directory',
help='Specifies the repository root. This defaults '
'to "../../.." relative to the script file, which '
'will normally be the repository root.')
option_parser.add_option(
'',
'--extra-repos',
action='append',
dest='extra_repos',
default=[],
help='Specifies extra repositories relative to root repository.')
option_parser.add_option('',
'--ignore-temp-rules',
action='store_true',
dest='ignore_temp_rules',
default=False,
help='Ignore !-prefixed (temporary) rules.')
option_parser.add_option(
'',
'--generate-temp-rules',
action='store_true',
dest='generate_temp_rules',
default=False,
help='Print rules to temporarily allow files that fail '
'dependency checking.')
option_parser.add_option(
'',
'--count-violations',
action='store_true',
dest='count_violations',
default=False,
help='Count #includes in violation of intended rules.')
option_parser.add_option('',
'--skip-tests',
action='store_true',
dest='skip_tests',
default=False,
help='Skip checking test files (best effort).')
option_parser.add_option('-v',
'--verbose',
action='store_true',
default=False,
help='Print debug logging')
option_parser.add_option('', '--json', help='Path to JSON output file')
option_parser.add_option(
'',
'--no-resolve-dotdot',
action='store_false',
dest='resolve_dotdot',
default=True,
help='resolve leading ../ in include directive paths relative '
'to the file perfoming the inclusion.')
options, args = option_parser.parse_args()
deps_checker = DepsChecker(options.base_directory,
extra_repos=options.extra_repos,
verbose=options.verbose,
ignore_temp_rules=options.ignore_temp_rules,
skip_tests=options.skip_tests,
resolve_dotdot=options.resolve_dotdot)
base_directory = deps_checker.base_directory # Default if needed, normalized
# Figure out which directory we have to check.
start_dir = base_directory
if len(args) == 1:
# Directory specified. Start here. It's supposed to be relative to the
# base directory.
start_dir = os.path.abspath(os.path.join(base_directory, args[0]))
elif len(args) >= 2 or (options.generate_temp_rules
and options.count_violations):
# More than one argument, or incompatible flags, we don't handle this.
PrintUsage()
return 1
if not start_dir.startswith(deps_checker.base_directory):
print 'Directory to check must be a subdirectory of the base directory,'
print 'but %s is not a subdirectory of %s' % (start_dir,
base_directory)
return 1
print 'Using base directory:', base_directory
print 'Checking:', start_dir
if options.generate_temp_rules:
deps_checker.results_formatter = results.TemporaryRulesFormatter()
elif options.count_violations:
deps_checker.results_formatter = results.CountViolationsFormatter()
if options.json:
deps_checker.results_formatter = results.JSONResultsFormatter(
options.json, deps_checker.results_formatter)
deps_checker.CheckDirectory(start_dir)
return deps_checker.Report()
