def test_can_get_violation_definitions(self):
reviewer = Mock()
validator = HeadingHierarchyValidator(reviewer)
definitions = validator.get_violation_definitions()
expect(definitions).to_length(1)
expect('page.heading_hierarchy.size' in definitions).to_be_true()
definitions_value = definitions['page.heading_hierarchy.size']
expect('title' in definitions_value).to_be_true()
expect('description' in definitions_value).to_be_true()
expect('category' in definitions_value).to_be_true()
value = {
'hh_list': [
('h1', 'Loren ipsum dolor sit amet'),
],
'max_size': 150
}
hh_size_def = definitions['page.heading_hierarchy.size']
hh_size_desc = hh_size_def['description']
expect(
hh_size_desc % validator.get_violation_parsed_value(value)
).to_equal(
'Heading hierarchy values bigger than 150 characters aren\'t good '
'for Search Engines. This elements were found: '
'<ul class="violation-hh-list"><li>'
'<span class="hh-type">h1</span>: '
'Loren ipsum dolor sit amet</li></ul>')
def test_can_get_default_violations_values(self):
config = Config()
config.MAX_HEADING_HIEARARCHY_SIZE = 150
page = PageFactory.create()
reviewer = Reviewer(api_url='http://localhost:2368',
page_uuid=page.uuid,
page_url=page.url,
page_score=0.0,
config=config,
validators=[])
validator = HeadingHierarchyValidator(reviewer)
violations_values = validator.get_default_violations_values(config)
expect(violations_values).to_include('page.heading_hierarchy.size')
expect(violations_values['page.heading_hierarchy.size']).to_length(2)
expect(violations_values['page.heading_hierarchy.size']).to_equal({
'value':
config.MAX_HEADING_HIEARARCHY_SIZE,
'description':
config.get_description('MAX_HEADING_HIEARARCHY_SIZE')
})
def test_can_validate_heading_hierarchy(self):
page = PageFactory.create()
reviewer = Reviewer(api_url='http://localhost:2368',
page_uuid=page.uuid,
page_url=page.url,
page_score=0.0,
config=Config(),
validators=[],
cache=self.sync_cache)
reviewer.violation_definitions = {
'page.heading_hierarchy.size': {
'default_value': 150
},
}
content = self.get_file('globo.html')
result = {
'url': page.url,
'status': 200,
'content': content,
'html': lxml.html.fromstring(content)
}
reviewer.responses[page.url] = result
reviewer.get_response = Mock(return_value=result)
validator = HeadingHierarchyValidator(reviewer)
# expecting no call of add_violation method
validator.add_violation = Mock()
validator.review.data = {
'page.heading_hierarchy': [
('h1', 'Loren ipsum dolor sit amet'),
]
}
validator.validate()
expect(validator.add_violation.called).to_be_false()
# expecting calling add_violation for `page.heading_hierarchy.size`
validator.add_violation = Mock()
hh_list = [
('h1', 'Loren ipsum dolor sit amet' * 10),
('h1', 'Loren ipsum dolor sit amet' * 10),
]
validator.review.data = {'page.heading_hierarchy': hh_list}
validator.validate()
expect(validator.add_violation.called).to_be_true()
validator.add_violation.assert_called_once_with(
key='page.heading_hierarchy.size',
value={
'max_size': 150,
'hh_list': hh_list,
},
points=40)