def test_regression_mishandling_multiple_reviews_okay_reviews( pull_request: PullRequest, config: V1, branch_protection: BranchProtectionRule, check_run: CheckRun, context: StatusContext, ) -> None: pull_request.mergeStateStatus = MergeStateStatus.BEHIND branch_protection.requiresApprovingReviews = True branch_protection.requiredApprovingReviewCount = 1 first_review_date = datetime(2010, 5, 15) latest_review_date = first_review_date + timedelta(minutes=20) reviews = [ PRReview( state=PRReviewState.CHANGES_REQUESTED, createdAt=first_review_date, author=PRReviewAuthor(login="******"), authorAssociation=CommentAuthorAssociation.CONTRIBUTOR, ), PRReview( state=PRReviewState.COMMENTED, createdAt=latest_review_date, author=PRReviewAuthor(login="******"), authorAssociation=CommentAuthorAssociation.CONTRIBUTOR, ), PRReview( state=PRReviewState.APPROVED, createdAt=latest_review_date, author=PRReviewAuthor(login="******"), authorAssociation=CommentAuthorAssociation.CONTRIBUTOR, ), PRReview( state=PRReviewState.APPROVED, createdAt=latest_review_date, author=PRReviewAuthor(login="******"), authorAssociation=CommentAuthorAssociation.CONTRIBUTOR, ), ] with pytest.raises(NeedsBranchUpdate): mergeable( config=config, pull_request=pull_request, branch_protection=branch_protection, review_requests_count=1, reviews=reviews, check_runs=[check_run], contexts=[context], valid_signature=False, valid_merge_methods=[MergeMethod.squash], )
def test_config_merge_optimistic_updates( pull_request: PullRequest, config: V1, branch_protection: BranchProtectionRule ) -> None: """ If optimisitc_updates are enabled, branch updates should be prioritized over waiting for running status checks to complete. Otherwise, status checks should be checked before updating. """ branch_protection.requiredApprovingReviewCount = 0 branch_protection.requiresStrictStatusChecks = True pull_request.mergeStateStatus = MergeStateStatus.BEHIND branch_protection.requiresStatusChecks = True branch_protection.requiredStatusCheckContexts = ["ci/lint", "ci/test"] contexts: List[StatusContext] = [] config.merge.optimistic_updates = True with pytest.raises(NeedsBranchUpdate): mergeable( app_id="1234", config=config, pull_request=pull_request, branch_protection=branch_protection, review_requests_count=0, reviews=[], contexts=contexts, check_runs=[], valid_signature=False, valid_merge_methods=[MergeMethod.squash], ) config.merge.optimistic_updates = False with pytest.raises(WaitingForChecks): mergeable( app_id="1234", config=config, pull_request=pull_request, branch_protection=branch_protection, review_requests_count=0, reviews=[], contexts=contexts, check_runs=[], valid_signature=False, valid_merge_methods=[MergeMethod.squash], )
def test_unknown_blockage( pull_request: PullRequest, config: V1, branch_protection: BranchProtectionRule ) -> None: branch_protection.requiredApprovingReviewCount = 0 branch_protection.requiresStatusChecks = False pull_request.mergeStateStatus = MergeStateStatus.BLOCKED with pytest.raises(NotQueueable, match="determine why PR is blocked"): mergeable( config=config, pull_request=pull_request, branch_protection=branch_protection, review_requests_count=0, reviews=[], contexts=[], check_runs=[], valid_signature=False, valid_merge_methods=[MergeMethod.squash], )
def test_missing_review_count( pull_request: PullRequest, config: V1, branch_protection: BranchProtectionRule, review: PRReview, context: StatusContext, ) -> None: pull_request.mergeStateStatus = MergeStateStatus.BLOCKED branch_protection.requiredApprovingReviewCount = 2 with pytest.raises(NotQueueable, match="missing required review count"): mergeable( config=config, pull_request=pull_request, branch_protection=branch_protection, review_requests_count=0, reviews=[review], contexts=[context], check_runs=[], valid_signature=False, valid_merge_methods=[MergeMethod.squash], )