def test_book_adder_duplicate_isbn10(self):
"""
Switch ISBNs of test_book_adder_duplicate_isbn13.
"""
self.make_current_user()
isbn13 = "1596914696"
self.verify_does_not_exist(Book, isbn=isbn13)
self.verify_does_not_exist(Genre, name="Academic Nonfiction")
self.verify_does_not_exist(Contributor,
lastname="Bayard",
firstname="Pierre")
self.verify_does_not_exist(Contributor,
lastname="Mehlman",
firstname="Jeffrey")
self.verify_does_not_exist(BookCompany, name="Bloomsbury")
self.verify_does_not_exist(BookCompany,
name="Quebecor World Fairfield")
author = [Person(lastname="Bayard", firstname="Pierre")]
translator = [Person(lastname="Mehlman", firstname="Jeffrey")]
books_you_havent_read = BookRecord(
isbn=isbn13,
title="How to Talk About Books You Haven't Read",
author=author,
translator=translator,
genre="Academic Nonfiction",
publisher="Bloomsbury",
printer="Quebecor World Fairfield",
publish_year=2007)
havent_read_rv = self.client.post(
"/api/add/books", data=books_you_havent_read.request_data())
self.verify_inserted(Book, isbn=isbn13)
self.verify_inserted(Genre, name="Academic Nonfiction")
self.verify_inserted(Contributor,
lastname="Bayard",
firstname="Pierre")
self.verify_inserted(Contributor,
lastname="Mehlman",
firstname="Jeffrey")
self.verify_inserted(BookCompany, name="Bloomsbury")
self.verify_inserted(BookCompany, name="Quebecor World Fairfield")
books_you_havent_read.isbn = "9781596914698"
duplicate = self.client.post("/api/add/books",
data=books_you_havent_read.request_data())
self.assertEquals(duplicate._status_code, 409)
def test_book_adder_blank_person(self):
self.make_current_user()
isbn = fake.isbn()
# Check that the relevant records do not exist yet
self.verify_does_not_exist(Book, isbn=isbn)
self.verify_does_not_exist(Genre, name="io9")
self.verify_does_not_exist(BookCompany, name="Scholastic")
self.verify_does_not_exist(BookCompany, name="UP Press")
author = [Person(lastname="", firstname="")]
single_author = BookRecord(isbn=isbn,
title="The Carpet Makers",
genre="io9",
author=author,
publisher="Scholastic",
printer="UP Press",
publish_year=2013)
single_rv = self.client.post("/api/add/books",
data=single_author.request_data())
self.assertEquals(single_rv._status_code, 400)
self.verify_does_not_exist(Book, isbn=isbn)
self.verify_does_not_exist(Genre, name="io9")
self.verify_does_not_exist(BookCompany, name="Scholastic")
self.verify_does_not_exist(BookCompany, name="UP Press")
def test_title_edit_book(self):
self.make_current_user()
authors = [ContributorFactory().make_plain_person() for _ in range(3)]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
author=authors,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
librarian.db.session.commit()
existing = (librarian.db.session.query(Book).filter(
Book.isbn == book.isbn).first())
self.assertEquals(book.title, existing.title)
edit_data = BookRecord(isbn=book.isbn,
title="This is a Ret Con",
publisher=book.publisher,
author=book.authors,
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
edited = (librarian.db.session.query(Book).filter(
Book.isbn == book.isbn).first())
self.assertEquals(edit_data.title, edited.title)
def test_repeat_people(self):
"""
Test that API call should still succeed even if the people have been
added before.
"""
def insert_bookpersons(persons):
for p in persons:
bp = Contributor(firstname=p.firstname,
lastname=p.lastname,
creator=self.admin_user)
librarian.db.session.add(bp)
librarian.db.session.flush()
def verify_bookperson(p):
self.verify_inserted(Contributor,
firstname=p.firstname,
lastname=p.lastname)
self.make_current_user()
isbn = fake.isbn()
title = fake.title()
authors = [make_person_object() for _ in range(4)]
insert_bookpersons(authors)
map(verify_bookperson, authors)
illustrators = [make_person_object() for _ in range(4)]
insert_bookpersons(illustrators)
map(verify_bookperson, illustrators)
editors = [make_person_object() for _ in range(4)]
insert_bookpersons(editors)
map(verify_bookperson, editors)
translators = [make_person_object() for _ in range(4)]
insert_bookpersons(translators)
map(verify_bookperson, translators)
req_data = BookRecord(isbn=isbn,
title=title,
genre="Multinational",
author=authors,
illustrator=illustrators,
editor=editors,
translator=translators,
publisher="Scholastic",
printer="UP Press",
publish_year=2013)
req_val = self.client.post("/api/add/books",
data=req_data.request_data())
self.assertEqual(200, req_val.status_code)
def test_edit_book_contrib_add(self):
self.make_current_user()
authors = [ContributorFactory().make_plain_person() for _ in range(3)]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
author=authors,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
librarian.db.session.commit()
author_role = Role.get_preset_role("Author")
book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_authors
])
self.assertEquals(set(authors), author_persons)
additional_author = ContributorFactory().make_plain_person()
_book_authors = copy.deepcopy(list(book.authors))
_book_authors.append(additional_author)
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
author=_book_authors,
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
librarian.db.session.commit()
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_authors
])
self.assertEqual(set(_book_authors), author_persons)
def test_no_printer(self):
self.make_current_user()
single_author = BookRecord(
isbn="9780062330260",
title="Trigger Warning",
genre="Short Story Collection",
author=[Person(lastname="Gaiman", firstname="Neil")],
publisher="William Morrow",
publish_year=2015)
single_rv = self.client.post("/api/add/books",
data=single_author.request_data())
self.assertEquals(single_rv._status_code, 200)
def test_genre_adding(self):
g1 = GenreFactory(name="B Genre")
g2 = GenreFactory(name="A Genre")
librarian.db.session.add(g1)
librarian.db.session.add(g2)
librarian.db.session.flush()
self.set_current_user(self.admin_user)
bgenre_book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
genre=g1.name,
author=[make_person_object()],
publisher="random",
publish_year=2017)
bgenre_rv = self.client.post("/api/add/books",
data=bgenre_book.request_data())
self.assertEquals(200, bgenre_rv.status_code)
agenre_book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
genre=g2.name,
author=[make_person_object()],
publisher="random",
publish_year=2017)
agenre_rv = self.client.post("/api/add/books",
data=agenre_book.request_data())
self.assertEquals(200, agenre_rv.status_code)
bgenre_orm = (librarian.db.session.query(Book).filter(
Book.isbn == bgenre_book.isbn).first())
agenre_orm = (librarian.db.session.query(Book).filter(
Book.isbn == agenre_book.isbn).first())
self.assertNotEquals(bgenre_orm.genre, agenre_orm.genre)
self.assertEquals(bgenre_orm.genre.name, g1.name)
self.assertEquals(agenre_orm.genre.name, g2.name)
def __basic_edit_test(self, book_id):
author_role = Role.get_preset_role("Author")
book = (librarian.db.session.query(Book).filter(
Book.id == book_id).first())
book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
authors = [co.make_plain_person() for co in book_authors]
the_deleted = book_authors[-1]
author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_authors
])
edited_book_authors = authors[0:-1]
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
author=edited_book_authors,
publish_year=book.publish_year,
genre=book.genre.name,
id=book_id)
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
updated_book_authors = (
librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active)
# Just for thoroughness, but in an ideal world BookContribution.active is sufficient
.filter(Contributor.active).all())
updated_author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in updated_book_authors
])
self.assertEqual(set(edited_book_authors), updated_author_persons)
# Verify that the BookRecord for the "deleted" contribution remains
# but inactive.
self.verify_inserted(BookContribution,
book_id=book_id,
contributor_id=the_deleted.id,
role_id=author_role.id,
active=False)
self.verify_inserted(Contributor, id=the_deleted.id, active=False)
def test_multiple_same_names(self):
self.make_current_user()
Neil_Gaiman = Person(lastname="Gaiman", firstname="Neil")
single_author = BookRecord(isbn="9780062330260",
title="Trigger Warning",
genre="Short Story Collection",
author=[Neil_Gaiman, Neil_Gaiman],
publisher="William Morrow",
publish_year=2015)
single_rv = self.client.post("/api/add/books",
data=single_author.request_data())
self.assertEquals(200, single_rv.status_code)
gaimen = (librarian.db.session.query(Contributor).filter(
Contributor.firstname == 'Neil').filter(
Contributor.lastname == 'Gaiman').all())
self.assertEquals(1, len(gaimen))
def test_extra_whitespace(self):
self.make_current_user()
self.verify_does_not_exist(Contributor,
lastname="de Cervantes",
firstname="Miguel")
spaced = BookRecord(
isbn="0812972104",
title="Don Quixote",
genre="Fiction",
author=[Person(lastname=" de Cervantes ", firstname="Miguel")],
publisher="Modern Library",
publish_year=2006)
spaced_rv = self.client.post("/api/add/books",
data=spaced.request_data())
self.assertEquals(200, spaced_rv.status_code)
self.verify_inserted(Contributor,
lastname="de Cervantes",
firstname="Miguel")
def test_book_adder_utf8(self):
self.make_current_user()
isbn = fake.isbn()
# Check that the relevant records do not exist yet
self.verify_does_not_exist(Book, isbn=isbn)
self.verify_does_not_exist(Genre, name="English 12")
self.verify_does_not_exist(Contributor,
lastname="Pérez-Reverte",
firstname="Arturo")
self.verify_does_not_exist(Contributor,
lastname="de Onís",
firstname="Harriet")
self.verify_does_not_exist(BookCompany, name="Scholastic")
self.verify_does_not_exist(BookCompany, name="UP Press")
author = [Person(lastname="Pérez-Reverte", firstname="Arturo")]
translator = [Person(lastname="de Onís", firstname="Harriet")]
single_author = BookRecord(isbn=isbn,
title="The Club Dumas",
genre="English 12",
author=author,
translator=translator,
publisher="Scholastic",
printer="UP Press",
publish_year=2013)
single_rv = self.client.post("/api/add/books",
data=single_author.request_data())
self.assertEquals(single_rv._status_code, 200)
self.verify_inserted(Book, isbn=isbn)
self.verify_inserted(Genre, name="English 12")
self.verify_inserted(Contributor,
lastname="Pérez-Reverte",
firstname="Arturo")
self.verify_inserted(BookCompany, name="Scholastic")
self.verify_inserted(BookCompany, name="UP Press")
def test_multiple_book_people(self):
"""
Test adding multiple people for the fields where person names are
expected. We can assume that records are "fresh".
"""
self.make_current_user()
isbn = fake.isbn()
title = fake.title()
authors = [make_person_object() for _ in range(4)]
illustrators = [make_person_object() for _ in range(4)]
editors = [make_person_object() for _ in range(4)]
translators = [make_person_object() for _ in range(4)]
req_data = BookRecord(isbn=isbn,
title=title,
genre="Multinational",
author=authors,
illustrator=illustrators,
editor=editors,
translator=translators,
publisher="Scholastic",
printer="UP Press",
publish_year=2013)
req_val = self.client.post("/api/add/books",
data=req_data.request_data())
self.assertEqual(200, req_val.status_code)
created_book = (librarian.db.session.query(Book).filter(
Book.isbn == isbn).first())
self.verify_persons_inserted(authors, "Author", created_book.id)
self.verify_persons_inserted(illustrators, "Illustrator",
created_book.id)
self.verify_persons_inserted(editors, "Editor", created_book.id)
self.verify_persons_inserted(translators, "Translator",
created_book.id)
def test_book_adder_reactivation(self):
self.set_current_user(self.admin_user)
inactive_contributor = ContributorFactory(lastname="Duffer",
firstname="Matt",
active=False)
librarian.db.session.add(inactive_contributor)
librarian.db.session.flush()
isbn = fake.isbn()
# Check that the relevant records do not exist yet
self.verify_does_not_exist(Book, isbn=isbn)
self.verify_does_not_exist(Genre, name="Horror")
self.verify_does_not_exist(BookCompany, name="Netflix")
self.verify_does_not_exist(BookCompany, name="WWW")
author = [Person(lastname="Duffer", firstname="Matt")]
single_author = BookRecord(isbn=isbn,
title="Stranger Things",
genre="Horror",
author=author,
publisher="Netflix",
printer="WWW",
publish_year=2016)
reactivate = self.client.post("/api/add/books",
data=single_author.request_data())
self.assertEquals(reactivate._status_code, 200)
self.verify_inserted(Book, isbn=isbn)
self.verify_inserted(Genre, name="Horror")
self.verify_inserted(BookCompany, name="Netflix")
self.verify_inserted(BookCompany, name="WWW")
self.verify_inserted(Contributor,
lastname="Duffer",
firstname="Matt",
active=True)
def test_same_person_diff_roles(self):
self.make_current_user()
jtamaki_exists = (librarian.db.session.query(Contributor).filter(
Contributor.firstname == "Jillian").filter(
Contributor.lastname == "Tamaki").first())
self.assertFalse(jtamaki_exists)
jtamaki = Person(lastname="Tamaki", firstname="Jillian")
author_illus = BookRecord(isbn="9781596437746",
title="This One Summer",
genre="Graphic Novel",
author=[jtamaki],
illustrator=[jtamaki],
publisher="First Second",
publish_year=2016)
rv = self.client.post("/api/add/books",
data=author_illus.request_data())
self.assertEquals(200, rv.status_code)
jtamakis = (librarian.db.session.query(Contributor).filter(
Contributor.firstname == "Jillian").filter(
Contributor.lastname == "Tamaki").all())
self.assertEqual(1, len(jtamakis))
def test_edit_book_contrib_correction(self):
"""
Another actual error encountered in testing. We are modifying
"MIlo Manara" to "Milo Manara" but it would seem that get_or_create
fetches "MIlo Manara" when given "Milo Manara".
"""
self.set_current_user(self.admin_user)
# These two are always parallel arrays.
contributor_objs = [
ContributorFactory(lastname="Manara", firstname="MIlo")
]
illustrators = [co.make_plain_person() for co in contributor_objs]
the_deleted = contributor_objs[-1]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
illustrator=illustrators,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
librarian.db.session.commit()
illustrator_role = Role.get_preset_role("Illustrator")
book_illustrators = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == illustrator_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
illustrator_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_illustrators
])
self.assertEquals(set(illustrators), illustrator_persons)
edited_book_illustrators = [
Person(lastname="McKean", firstname="Dave"),
Person(lastname="Manara", firstname="Milo")
]
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
illustrator=edited_book_illustrators,
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
librarian.db.session.commit()
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
updated_book_illustrators = (librarian.db.session.query(
Contributor).filter(BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == illustrator_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
updated_illustrator_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in updated_book_illustrators
])
self.assertEqual(set(edited_book_illustrators),
updated_illustrator_persons)
# Verify that the BookRecord for the "deleted" contribution remains
# but inactive.
self.verify_inserted(BookContribution,
book_id=book_id,
contributor_id=the_deleted.id,
role_id=illustrator_role.id,
active=False)
self.verify_inserted(Contributor, id=the_deleted.id, active=False)
def test_edit_book_contrib_delete_keepactive(self):
"""
Test deleting a contribution from a book where the contributor stays
active from other books
"""
self.make_current_user()
# These two are always parallel arrays.
contributor_objs = [ContributorFactory() for _ in range(3)]
authors = [co.make_plain_person() for co in contributor_objs]
the_deleted = contributor_objs[-1]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
author=authors,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
# This will keep `the_deleted` alive. Get it?
horcrux = BookRecord(isbn=fake.isbn(),
title="Secrets of the Darkest Art",
publisher="Scholastic",
author=[the_deleted.make_plain_person()],
publish_year=1967,
genre="Black Magic")
librarian.db.session.commit()
create_book(librarian.db.session, horcrux, self.admin_user)
librarian.db.session.commit()
author_role = Role.get_preset_role("Author")
book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_authors
])
self.assertEquals(set(authors), author_persons)
# The last author is the one we delete
edited_book_authors = authors[0:-1]
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
author=edited_book_authors,
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
updated_book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
updated_author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in updated_book_authors
])
self.assertEqual(set(edited_book_authors), updated_author_persons)
# Verify that the BookRecord for the "deleted" contribution remains
# but inactive.
self.verify_inserted(BookContribution,
book_id=book_id,
contributor_id=the_deleted.id,
role_id=author_role.id,
active=False)
# But the contributor remains active thanks to the horcrux!
self.verify_inserted(Contributor, id=the_deleted.id, active=True)
def test_remove_duplicate_contributor_team(self):
"""
Yet another actual test case encountered live.
For some reason, Preludes and Nocturnes was saved with the same
Contributors for both Translators and Editors (note that Preludes and
Nocturnes is not supposed to have Translators). Deleting all
Translators does not seem to work.
UPDATE: Looks like it was, indeed, a side-effect of the update code.
When editing the Translators role, the Editors field is passed, creating
the discrepancy.
"""
self.make_current_user()
# These two are always parallel arrays.
contributor_objs = [ContributorFactory() for _ in range(3)]
editors = [co.make_plain_person() for co in contributor_objs]
the_deleted = contributor_objs[-1]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
editor=editors,
translator=editors,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
librarian.db.session.commit()
editor_role = Role.get_preset_role("Editor")
translator_role = Role.get_preset_role("Translator")
book_editors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == editor_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
book_translators = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == translator_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
editor_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_editors
])
self.assertEquals(set(editors), editor_persons)
self.assertEquals(set(book_editors), set(book_translators))
# Delete all translators
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
editor=editors,
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
updated_book_editors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == editor_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
updated_editor_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in updated_book_editors
])
self.assertEqual(set(editor_persons), updated_editor_persons)
updated_book_translators = (
librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == translator_role.id).filter(
BookContribution.active).all())
self.assertEqual(0, len(updated_book_translators))
# Verify that the BookRecord for the "deleted" contribution remains
# but inactive.
for translator in book_translators:
self.verify_inserted(BookContribution,
book_id=book_id,
contributor_id=translator.id,
role_id=translator_role.id,
active=False)
self.verify_inserted(Contributor, id=translator.id, active=True)
def test_edit_book_contrib_correction(self):
"""
Actual (unexpected) error encountered while live testing. It would seem
that the database might have race conditions where a pending book is
uncommitted resulting to errors when pairing a Contributor with a role.
"""
self.set_current_user(self.admin_user)
# These two are always parallel arrays.
contributor_objs = [
ContributorFactory(lastname="Jill", firstname="Jack"),
ContributorFactory(lastname="Stewart", firstname="John")
]
authors = [co.make_plain_person() for co in contributor_objs]
the_deleted = contributor_objs[-1]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
author=authors,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
librarian.db.session.commit()
js_autobio = BookRecord(
isbn=fake.isbn(),
title="JS Autobio",
publisher="Green Cross",
author=[Person(lastname="Stewart", firstname="Jon")],
publish_year=2016,
genre="Fiction")
create_book(librarian.db.session, js_autobio, self.admin_user)
# This is what makes this pass.
librarian.db.session.commit()
author_role = Role.get_preset_role("Author")
book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_authors
])
self.assertEquals(set(authors), author_persons)
edited_book_authors = [
Person(lastname="Jill", firstname="Jack"),
Person(lastname="Stewart", firstname="Jon")
]
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
author=edited_book_authors,
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
updated_book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
updated_author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in updated_book_authors
])
self.assertEqual(set(edited_book_authors), updated_author_persons)
# Verify that the BookRecord for the "deleted" contribution remains
# but inactive.
self.verify_inserted(BookContribution,
book_id=book_id,
contributor_id=the_deleted.id,
role_id=author_role.id,
active=False)
self.verify_inserted(Contributor, id=the_deleted.id, active=False)
def test_edit_book_contrib_move(self):
"""
Test that moving contributors between roles produce the desired effect.
"""
self.make_current_user()
# These two are always parallel arrays.
contributor_objs = [ContributorFactory() for _ in range(3)]
authors = [co.make_plain_person() for co in contributor_objs]
the_deleted = contributor_objs[-1]
book = BookRecord(isbn=fake.isbn(),
title=fake.title(),
publisher="Mumford and Sons",
author=authors,
publish_year=2016,
genre="Fiction")
book_id = create_book(librarian.db.session, book, self.admin_user)
librarian.db.session.commit()
author_role = Role.get_preset_role("Author")
book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in book_authors
])
self.assertEquals(set(authors), author_persons)
# The last author is the one we delete
edited_book_authors = authors[0:-1]
edit_data = BookRecord(isbn=book.isbn,
title=book.title,
publisher=book.publisher,
author=edited_book_authors,
editor=[the_deleted.make_plain_person()],
publish_year=book.publish_year,
genre=book.genre,
id=book_id)
edit_book = self.client.post("/api/edit/books",
data=edit_data.request_data())
self.assertEqual(200, edit_book.status_code)
updated_book_authors = (librarian.db.session.query(Contributor).filter(
BookContribution.book_id == book_id).filter(
BookContribution.contributor_id == Contributor.id).filter(
BookContribution.role_id == author_role.id).filter(
BookContribution.active).filter(
Contributor.active).all())
updated_author_persons = set([
Person(firstname=a.firstname, lastname=a.lastname)
for a in updated_book_authors
])
self.assertEqual(set(edited_book_authors), updated_author_persons)
# Verify that the BookRecord for the "deleted" contribution remains
# but inactive.
self.verify_inserted(BookContribution,
book_id=book_id,
contributor_id=the_deleted.id,
role_id=author_role.id,
active=False)
the_deleted = librarian.db.session.query(Contributor).filter(
Contributor.id == the_deleted.id).first()
self.verify_inserted(Contributor, id=the_deleted.id, active=True)