class TestRubocop(TestCase):
needs_rubocop = skipIf(rubocop_missing, 'Missing rubocop, cannot run')
fixtures = [
'tests/fixtures/rubocop/no_errors.rb',
'tests/fixtures/rubocop/has_errors.rb',
]
def setUp(self):
self.problems = Problems()
self.tool = Rubocop(self.problems)
def test_match_file(self):
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertTrue(self.tool.match_file('test.rb'))
self.assertTrue(self.tool.match_file('dir/name/test.rb'))
@needs_rubocop
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
eq_([], self.problems.all(self.fixtures[0]))
@needs_rubocop
def test_process_files__one_file_fail(self):
linty_filename = abspath(self.fixtures[1])
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(linty_filename, 4, 4,
'C: Trailing whitespace detected.')
eq_(expected, problems[1])
@needs_rubocop
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
linty_filename = abspath(self.fixtures[1])
eq_(2, len(self.problems.all(linty_filename)))
freshly_laundered_filename = abspath(self.fixtures[0])
eq_([], self.problems.all(freshly_laundered_filename))
@needs_rubocop
def test_process_files_one_file_fail_display_cop_names(self):
options = {
'display_cop_names': 'True',
}
self.tool = Rubocop(self.problems, options)
linty_filename = abspath(self.fixtures[1])
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(
linty_filename, 4, 4,
'C: Style/TrailingWhitespace: Trailing whitespace detected.')
eq_(expected, problems[1])
class TestRubocop(TestCase):
needs_rubocop = skipIf(rubocop_missing, 'Missing rubocop, cannot run')
fixtures = [
'tests/fixtures/rubocop/no_errors.rb',
'tests/fixtures/rubocop/has_errors.rb',
]
def setUp(self):
self.problems = Problems()
self.tool = Rubocop(self.problems)
def test_match_file(self):
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertTrue(self.tool.match_file('test.rb'))
self.assertTrue(self.tool.match_file('dir/name/test.rb'))
@needs_rubocop
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
eq_([], self.problems.all(self.fixtures[0]))
@needs_rubocop
def test_process_files__one_file_fail(self):
linty_filename = abspath(self.fixtures[1])
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(linty_filename, 4, 4,
'C: Trailing whitespace detected.')
eq_(expected, problems[5])
@needs_rubocop
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
linty_filename = abspath(self.fixtures[1])
eq_(6, len(self.problems.all(linty_filename)))
freshly_laundered_filename = abspath(self.fixtures[0])
eq_([], self.problems.all(freshly_laundered_filename))
@needs_rubocop
def test_process_files_one_file_fail_display_cop_names(self):
options = {
'display_cop_names': 'True',
}
self.tool = Rubocop(self.problems, options)
linty_filename = abspath(self.fixtures[1])
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(linty_filename, 3, 3,
'C: Metrics/LineLength: Line is too long. [82/80]')
eq_(expected, problems[4])
class TestRubocop(TestCase):
needs_rubocop = skipIf(rubocop_missing, "Missing rubocop, cannot run")
fixtures = ["tests/fixtures/rubocop/no_errors.rb", "tests/fixtures/rubocop/has_errors.rb"]
def setUp(self):
self.problems = Problems()
self.tool = Rubocop(self.problems)
def test_match_file(self):
self.assertFalse(self.tool.match_file("test.py"))
self.assertFalse(self.tool.match_file("dir/name/test.py"))
self.assertTrue(self.tool.match_file("test.rb"))
self.assertTrue(self.tool.match_file("dir/name/test.rb"))
@needs_rubocop
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
eq_([], self.problems.all(self.fixtures[0]))
@needs_rubocop
def test_process_files__one_file_fail(self):
linty_filename = abspath(self.fixtures[1])
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(linty_filename, 4, 4, "C: Trailing whitespace detected.")
eq_(expected, problems[1])
@needs_rubocop
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
linty_filename = abspath(self.fixtures[1])
eq_(2, len(self.problems.all(linty_filename)))
freshly_laundered_filename = abspath(self.fixtures[0])
eq_([], self.problems.all(freshly_laundered_filename))
@needs_rubocop
def test_process_files_one_file_fail_display_cop_names(self):
options = {"display_cop_names": "True"}
self.tool = Rubocop(self.problems, options)
linty_filename = abspath(self.fixtures[1])
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(linty_filename, 4, 4, "C: Style/TrailingWhitespace: Trailing whitespace detected.")
eq_(expected, problems[1])
class TestRubocop(TestCase):
fixtures = [
'tests/fixtures/rubocop/no_errors.rb',
'tests/fixtures/rubocop/has_errors.rb',
]
def setUp(self):
self.problems = Problems()
self.tool = Rubocop(self.problems, {}, root_dir)
def test_match_file(self):
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertTrue(self.tool.match_file('test.rb'))
self.assertTrue(self.tool.match_file('dir/name/test.rb'))
@requires_image('ruby2')
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
eq_([], self.problems.all(self.fixtures[0]))
@requires_image('ruby2')
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
expected = Comment(self.fixtures[1], 4, 4,
'C: Trailing whitespace detected.')
eq_(expected, problems[1])
@requires_image('ruby2')
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
linty_filename = self.fixtures[1]
eq_(2, len(self.problems.all(linty_filename)))
freshly_laundered_filename = self.fixtures[0]
eq_([], self.problems.all(freshly_laundered_filename))
@requires_image('ruby2')
def test_process_files_one_file_fail_display_cop_names(self):
options = {
'display_cop_names': 'True',
}
self.tool = Rubocop(self.problems, options, root_dir)
linty_filename = self.fixtures[1]
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
expected = Comment(
linty_filename, 4, 4,
'C: Layout/TrailingWhitespace: Trailing whitespace detected.')
eq_(expected, problems[1])
def test_has_fixer__not_enabled(self):
tool = Rubocop(self.problems, {}, root_dir)
eq_(False, tool.has_fixer())
def test_has_fixer__enabled(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
eq_(True, tool.has_fixer())
@requires_image('ruby2')
def test_execute_fixer(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
original = read_file(self.fixtures[1])
tool.execute_fixer(self.fixtures)
updated = read_and_restore_file(self.fixtures[1], original)
assert original != updated, 'File content should change.'
eq_(0, len(self.problems.all()), 'No errors should be recorded')
@requires_image('ruby2')
def test_execute_fixer__fewer_problems_remain(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
# The fixture file can have all problems fixed by rubocop
original = read_file(self.fixtures[1])
tool.execute_fixer(self.fixtures)
tool.process_files(self.fixtures)
read_and_restore_file(self.fixtures[1], original)
eq_(1, len(self.problems.all()), 'Most errors should be fixed')
assert_in('too long', self.problems.all()[0].body)
class TestRubocop(TestCase):
fixtures = [
'tests/fixtures/rubocop/no_errors.rb',
'tests/fixtures/rubocop/has_errors.rb',
]
def setUp(self):
self.problems = Problems()
self.tool = Rubocop(self.problems, {}, root_dir)
def test_version(self):
assert self.tool.version != ''
def test_match_file(self):
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertTrue(self.tool.match_file('test.rb'))
self.assertTrue(self.tool.match_file('dir/name/test.rb'))
@requires_image('ruby2')
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
self.assertEqual([], self.problems.all(self.fixtures[0]))
@requires_image('ruby2')
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
long_line = problems[1]
assert long_line.filename == self.fixtures[1]
assert long_line.line == 3
assert long_line.position == 3
assert 'W: Unused method argument' in long_line.body
@requires_image('ruby2')
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
linty_filename = self.fixtures[1]
self.assertEqual(3, len(self.problems.all(linty_filename)))
freshly_laundered_filename = self.fixtures[0]
self.assertEqual([], self.problems.all(freshly_laundered_filename))
@requires_image('ruby2')
def test_process_files_one_file_fail_display_cop_names(self):
options = {
'display_cop_names': 'True',
}
self.tool = Rubocop(self.problems, options, root_dir)
linty_filename = self.fixtures[1]
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
long_line = problems[1]
assert long_line.filename == linty_filename
assert long_line.line == 3
assert long_line.position == 3
assert 'Lint/UnusedMethodArgument' in long_line.body
@requires_image('ruby2')
def test_process_files_one_file_fail_display_cop_names__bool(self):
options = {
'display_cop_names': True,
}
self.tool = Rubocop(self.problems, options, root_dir)
linty_filename = self.fixtures[1]
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
long_line = problems[1]
assert long_line.filename == linty_filename
assert long_line.line == 3
assert long_line.position == 3
assert 'Lint/UnusedMethodArgument' in long_line.body
@requires_image('ruby2')
def test_process_files__invalid_rubocop_yml(self):
self.tool.process_files(
['tests/fixtures/rubocop/badconfig/has_errors.rb'])
problems = self.problems.all()
assert 1 == len(problems)
assert 'Your rubocop configuration' in problems[0].body
assert 'expected key while parsing' in problems[0].body
@requires_image('ruby2')
def test_process_files__incomplete_rubocop_yml(self):
self.tool.process_files(
['tests/fixtures/rubocop/incompleteconfig/has_errors.rb'])
problems = self.problems.all()
assert 4 == len(problems)
# Check config warning.
assert 'Your rubocop configuration' in problems[0].body
assert 'The following cops were added' in problems[0].body
assert '- Style/HashEachMethods' in problems[0].body
# Has other errors too.
assert 'C: Missing frozen string literal comment.' in problems[1].body
def test_has_fixer__not_enabled(self):
tool = Rubocop(self.problems, {}, root_dir)
self.assertEqual(False, tool.has_fixer())
def test_has_fixer__enabled(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
self.assertEqual(True, tool.has_fixer())
@requires_image('ruby2')
def test_execute_fixer(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
original = read_file(self.fixtures[1])
tool.execute_fixer(self.fixtures)
updated = read_and_restore_file(self.fixtures[1], original)
assert original != updated, 'File content should change.'
self.assertEqual(0, len(self.problems.all()),
'No errors should be recorded')
@requires_image('ruby2')
def test_execute_fixer__fewer_problems_remain(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
# The fixture file can have all problems fixed by rubocop
original = read_file(self.fixtures[1])
tool.execute_fixer(self.fixtures)
tool.process_files(self.fixtures)
read_and_restore_file(self.fixtures[1], original)
self.assertEqual(1, len(self.problems.all()),
'Most errors should be fixed')
class TestRubocop(TestCase):
fixtures = [
'tests/fixtures/rubocop/no_errors.rb',
'tests/fixtures/rubocop/has_errors.rb',
]
def setUp(self):
self.problems = Problems()
self.tool = Rubocop(self.problems, {}, root_dir)
def test_match_file(self):
self.assertFalse(self.tool.match_file('test.py'))
self.assertFalse(self.tool.match_file('dir/name/test.py'))
self.assertTrue(self.tool.match_file('test.rb'))
self.assertTrue(self.tool.match_file('dir/name/test.rb'))
@requires_image('ruby2')
def test_process_files__one_file_pass(self):
self.tool.process_files([self.fixtures[0]])
self.assertEqual([], self.problems.all(self.fixtures[0]))
@requires_image('ruby2')
def test_process_files__one_file_fail(self):
self.tool.process_files([self.fixtures[1]])
problems = self.problems.all(self.fixtures[1])
long_line = problems[1]
assert long_line.filename == self.fixtures[1]
assert long_line.line == 3
assert long_line.position == 3
assert 'C: Line is too long. [82/80]' in long_line.body
@requires_image('ruby2')
def test_process_files_two_files(self):
self.tool.process_files(self.fixtures)
linty_filename = self.fixtures[1]
self.assertEqual(3, len(self.problems.all(linty_filename)))
freshly_laundered_filename = self.fixtures[0]
self.assertEqual([], self.problems.all(freshly_laundered_filename))
@requires_image('ruby2')
def test_process_files_one_file_fail_display_cop_names(self):
options = {
'display_cop_names': 'True',
}
self.tool = Rubocop(self.problems, options, root_dir)
linty_filename = self.fixtures[1]
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
long_line = problems[1]
assert long_line.filename == linty_filename
assert long_line.line == 3
assert long_line.position == 3
assert 'C: Metrics/LineLength: Line is too long. [82/80]' in long_line.body
@requires_image('ruby2')
def test_process_files_one_file_fail_display_cop_names__bool(self):
options = {
'display_cop_names': True,
}
self.tool = Rubocop(self.problems, options, root_dir)
linty_filename = self.fixtures[1]
self.tool.process_files([linty_filename])
problems = self.problems.all(linty_filename)
long_line = problems[1]
assert long_line.filename == linty_filename
assert long_line.line == 3
assert long_line.position == 3
assert 'C: Metrics/LineLength: Line is too long. [82/80]' in long_line.body
def test_has_fixer__not_enabled(self):
tool = Rubocop(self.problems, {}, root_dir)
self.assertEqual(False, tool.has_fixer())
def test_has_fixer__enabled(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
self.assertEqual(True, tool.has_fixer())
@requires_image('ruby2')
def test_execute_fixer(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
original = read_file(self.fixtures[1])
tool.execute_fixer(self.fixtures)
updated = read_and_restore_file(self.fixtures[1], original)
assert original != updated, 'File content should change.'
self.assertEqual(0, len(self.problems.all()),
'No errors should be recorded')
@requires_image('ruby2')
def test_execute_fixer__fewer_problems_remain(self):
tool = Rubocop(self.problems, {'fixer': True}, root_dir)
# The fixture file can have all problems fixed by rubocop
original = read_file(self.fixtures[1])
tool.execute_fixer(self.fixtures)
tool.process_files(self.fixtures)
read_and_restore_file(self.fixtures[1], original)
self.assertEqual(1, len(self.problems.all()),
'Most errors should be fixed')
self.assertIn('too long', self.problems.all()[0].body)