def post(self):
"""
Creates a money transaction.
"""
json_data = request.get_json(force=True)
session = DbSessionHolder().get_session()
try:
# Check that we are not giving the resource a transfer type
if "TRANSFER" in json_data["type"]:
raise ValueError("A single transaction cannot be of 'TRANSFER' type")
# Create the resource
transaction_uri = create_transaction(session,
json_data["user"],
json_data["amount"],
json_data["type"])
response = make_response(jsonify(json_data),
status.HTTP_201_CREATED)
response.headers["location"] = transaction_uri
response.autocorrect_location_header = False
return response
except (KeyError, ValueError, NotEnoughMoneyException), e:
return make_response(jsonify({"error": str(e)}),
status.HTTP_400_BAD_REQUEST)
def post(self):
"""
Creates a money transaction.
"""
json_data = request.get_json(force=True)
session = DbSessionHolder().get_session()
try:
withdrawal_uri = create_transaction(
session,
json_data["sender"],
-int(json_data["amount"]),
TransactionType.TRANSFER_WITHDRAWAL,
commit=False
)
deposit_uri = create_transaction(
session,
json_data["receiver"],
int(json_data["amount"]),
TransactionType.TRANSFER_DEPOSIT,
commit=False
)
transfer_uri = create_transfer(
session,
withdrawal_uri,
deposit_uri,
json_data["comment"],
json_data["type"]
)
response = make_response(jsonify(json_data),
status.HTTP_201_CREATED)
response.headers["location"] = transfer_uri
response.autocorrect_location_header = False
return response
except (KeyError, ValueError, NotEnoughMoneyException), e:
return make_response(jsonify({"error": str(e)}),
status.HTTP_400_BAD_REQUEST)
def test_get_user_transactions(self):
session = DbSessionHolder(TestV1API.REST_TEST_DB).get_session()
finn_uri = create_user(session,
"0000",
"Finn",
"1413434",
233.05)
create_transaction(session, amount=10, user_uri=finn_uri, transaction_type=TransactionType.FUNDS_DEPOSIT)
create_transaction(session, amount=3, user_uri=finn_uri, transaction_type=TransactionType.FUNDS_DEPOSIT)
create_transaction(session, amount=-4.05, user_uri=finn_uri, transaction_type=TransactionType.FUNDS_WITHDRAWAL)
endpoint = gen_resource_url(API_PREFIX, v1, USER_GET_TRANSACTIONS_URI.format(user_id="0000"))
response = self.client().get(endpoint)
self.assertItemsEqual(["/transaction/1", "/transaction/2", "/transaction/3"], json.loads(response.data))
endpoint = gen_resource_url(API_PREFIX, v1, USER_GET_EXPANDED_TRANSACTIONS_URI.format(user_id="0000"))
response = self.client().get(endpoint)
expected = [
{"amount": 10.0, "id": 1, "type": "FUNDS_DEPOSIT", "user": "******"},
{"amount": 3.0, "id": 2, "type": "FUNDS_DEPOSIT", "user": "******"},
{"amount": -4.05, "id": 3, "type": "FUNDS_WITHDRAWAL", "user": "******"}
]
parsed_response = json.loads(response.data)
for mov in parsed_response:
del mov["created"]
self.assertItemsEqual(expected, parsed_response)
def test_check_transfer_is_symetric(self):
# REPEATED CODE AHEAD. TODO: REFACTOR
# Create the users
susan_uri = create_user(self.session, "0000", "susan",
"0123456789ABCDEF", 100.0)
susan_id = susan_uri.split("/")[-1]
pep_uri = create_user(self.session, "0001", "pep", "0123456789ABCDEF",
50.0)
pep_id = pep_uri.split("/")[-1]
# Create the transactions
# ID: 1
create_transaction(
self.session,
susan_uri,
-25,
transaction_type=TransactionType.TRANSFER_WITHDRAWAL,
commit=False)
# ID: 2
create_transaction(self.session,
pep_uri,
25,
transaction_type=TransactionType.TRANSFER_DEPOSIT,
commit=False)
# ID: 3
create_transaction(self.session,
pep_uri,
30,
transaction_type=TransactionType.TRANSFER_DEPOSIT,
commit=False)
# ID: 4
# A 0 money transaction is not allowed
with self.assertRaises(ValueError):
create_transaction(
self.session,
pep_uri,
0,
transaction_type=TransactionType.TRANSFER_DEPOSIT,
commit=False)
check_transfer_is_symmetric(self.session, 1, 2)
with self.assertRaises(AsymmetricTransferException):
check_transfer_is_symmetric(self.session, 1, 3)
with self.assertRaises(ValueError):
check_transfer_is_symmetric(self.session, 3, 1)
def test_transaction_creation_retrieval(self):
# Resource creation
dean_uri = create_user(self.session, "0000", "dean",
"0123456789ABCDEF", 100.0)
transaction_uri = create_transaction(
self.session,
dean_uri,
-10,
transaction_type=TransactionType.FUNDS_WITHDRAWAL)
self.assertEqual('/transaction/1', transaction_uri)
# Resource retrieval
transaction_id = int(transaction_uri.split("/")[-1])
transaction_json = get_transaction(self.session, transaction_id)
del transaction_json["created"]
expected_json = {
'amount': -10.0,
'type': 'FUNDS_WITHDRAWAL',
'user': '******',
'id': 1
}
self.assertDictEqual(expected_json, transaction_json)
# Retrieval with expansion
transaction_json = get_transaction(self.session,
transaction_id,
expand=True)
del transaction_json["created"]
del transaction_json["user"]["created"]
expected_json = {
'amount': -10.0,
'type': 'FUNDS_WITHDRAWAL',
'user': {
'funds': 90.0,
'pass_hash': '0123456789ABCDEF',
'picture_path': None,
'name': 'dean',
'phone_number': "0000"
},
'id': 1
}
self.assertDictEqual(expected_json, transaction_json)
def test_get_transactions_for_user(self):
susan_uri = create_user(self.session, "0000", "susan",
"0123456789ABCDEF", 100.0)
susan_id = susan_uri.split("/")[-1]
pep_uri = create_user(self.session, "0001", "pep", "0123456789ABCDEF",
50.0)
create_transaction(self.session,
susan_uri,
-25,
transaction_type=TransactionType.FUNDS_WITHDRAWAL,
commit=False)
create_transaction(self.session,
pep_uri,
-25,
transaction_type=TransactionType.FUNDS_WITHDRAWAL,
commit=False)
create_transaction(self.session,
susan_uri,
10,
transaction_type=TransactionType.FUNDS_DEPOSIT,
commit=False)
create_transaction(self.session,
pep_uri,
10,
transaction_type=TransactionType.FUNDS_DEPOSIT,
commit=False)
create_transaction(self.session,
susan_uri,
3,
transaction_type=TransactionType.FUNDS_DEPOSIT,
commit=False)
expand_expected = [{
'amount': -25.0,
'type': 'FUNDS_WITHDRAWAL',
'user': '******',
'id': 1
}, {
'amount': 10.0,
'type': 'FUNDS_DEPOSIT',
'user': '******',
'id': 3
}, {
'amount': 3.0,
'type': 'FUNDS_DEPOSIT',
'user': '******',
'id': 5
}]
transactions = get_user_transactions(self.session,
susan_id,
expand=True)
for mov in transactions:
del mov["created"]
self.assertItemsEqual(expand_expected, transactions)
expected = ['/transaction/1', '/transaction/3', '/transaction/5']
transactions = get_user_transactions(self.session,
susan_id,
expand=False)
self.assertItemsEqual(expected, transactions)
def test_create_retrieve_transfer(self):
# susan -> 25 -> pep, Susan gives 25 to Pep
# Create the users
susan_uri = create_user(self.session, "0000", "susan",
"0123456789ABCDEF", 100.0)
susan_id = susan_uri.split("/")[-1]
pep_uri = create_user(self.session, "0001", "pep", "0123456789ABCDEF",
50.0)
pep_id = pep_uri.split("/")[-1]
# Create the transactions
susan_transaction_uri = create_transaction(
self.session,
susan_uri,
-25,
transaction_type=TransactionType.TRANSFER_WITHDRAWAL,
commit=False)
pep_transaction_uri = create_transaction(
self.session,
pep_uri,
25,
transaction_type=TransactionType.TRANSFER_DEPOSIT,
commit=False)
transfer_uri = create_transfer(self.session, susan_transaction_uri,
pep_transaction_uri, "Great lunch!!",
TransferType.PUBLIC)
self.assertEqual("/transfer/1", transfer_uri)
# Retrieve the transfer
transfer_json = get_transfer(self.session, 1)
del transfer_json["created"]
expected = {
'comment': 'Great lunch!!',
'deposit': '/transaction/2',
'withdrawal': '/transaction/1',
'type': 'PUBLIC',
'id': 1
}
self.assertDictEqual(expected, transfer_json)
# Try expanding the transactions
transfer_json = get_transfer(self.session, 1, expand=True)
expected = {
'comment': 'Great lunch!!',
'deposit': {
'amount': 25.0,
'type': 'TRANSFER_DEPOSIT',
'user': '******',
'id': 2
},
'withdrawal': {
'amount': -25.0,
'type': 'TRANSFER_WITHDRAWAL',
'user': '******',
'id': 1
},
'type': 'PUBLIC',
'id': 1
}
del transfer_json["created"]
del transfer_json["withdrawal"]["created"]
del transfer_json["deposit"]["created"]
self.assertDictEqual(expected, transfer_json)
# Also, after the transfer susan and pep have the same amount of money
self.assertEqual(get_user_balance(self.session, susan_id),
get_user_balance(self.session, pep_id))
self.assertEqual(75., get_user_balance(self.session, susan_id))