def test_group_update_gid_not_found(self):
# test
values_before = {
"gid": "12345678-1234-5678-9123-123456789012",
"user_id": "user",
"project_id": "user",
"display_name": "My_group",
"display_description": "This is my group.",
"status": "active"
}
group_before = db.group_create(self.user_ctxt, values_before)
values = {
"gid": group_before["gid"] + "not-found",
"display_name": "My_group_updated",
"display_description": "This is my group updated."
}
try:
db.group_update(self.user_ctxt, values)
except Exception as e:
status_code = e.code
self.assertEqual(status_code, 404)
def update(self, req, body, gid):
def _validate(body, gid):
if not self.is_valid_body(body, 'group'):
msg = _("Invalid request body")
raise exception.InvalidInput(reason=msg)
values = body["group"]
name = values.get("name")
description = values.get("description")
if not uuidutils.is_uuid_like(gid):
raise exception.GroupNotFound(gid=gid)
if name is None and description is None:
msg = _("Group name or description is required")
raise exception.InvalidInput(reason=msg)
if name is not None:
if isinstance(name, six.string_types):
name = name.strip()
utils.check_string_length(name,
'name',
min_length=1,
max_length=255)
if description is not None:
utils.check_string_length(description,
'description',
min_length=0,
max_length=255)
valid_values = {}
if name:
valid_values["display_name"] = name
# allow blank string to clear description
if description is not None:
valid_values["display_description"] = description
valid_values["gid"] = gid
return valid_values
context = req.environ['rack.context']
try:
values = _validate(body, gid)
group = db.group_update(context, values)
except exception.InvalidInput as exc:
raise webob.exc.HTTPBadRequest(explanation=exc.format_message())
except exception.GroupNotFound:
msg = _("Group could not be found")
raise webob.exc.HTTPNotFound(explanation=msg)
return self._view_builder.update(group)
def update(self, req, body, gid):
def _validate(body, gid):
if not self.is_valid_body(body, 'group'):
msg = _("Invalid request body")
raise exception.InvalidInput(reason=msg)
values = body["group"]
name = values.get("name")
description = values.get("description")
if not uuidutils.is_uuid_like(gid):
raise exception.GroupNotFound(gid=gid)
if name is None and description is None:
msg = _("Group name or description is required")
raise exception.InvalidInput(reason=msg)
if name is not None:
if isinstance(name, six.string_types):
name = name.strip()
utils.check_string_length(name, 'name', min_length=1,
max_length=255)
if description is not None:
utils.check_string_length(description, 'description',
min_length=0, max_length=255)
valid_values = {}
if name:
valid_values["display_name"] = name
# allow blank string to clear description
if description is not None:
valid_values["display_description"] = description
valid_values["gid"] = gid
return valid_values
context = req.environ['rack.context']
try:
values = _validate(body, gid)
group = db.group_update(context, values)
except exception.InvalidInput as exc:
raise webob.exc.HTTPBadRequest(explanation=exc.format_message())
except exception.GroupNotFound:
msg = _("Group could not be found")
raise webob.exc.HTTPNotFound(explanation=msg)
return self._view_builder.update(group)
def test_group_update(self):
values_before = {
"gid": "12345678-1234-5678-9123-123456789012",
"user_id": "user",
"project_id": "user",
"display_name": "My_group",
"display_description": "This is my group.",
"status": "active"
}
group_before = db.group_create(self.user_ctxt, values_before)
values = {
"gid": group_before["gid"],
"display_name": "My_group_updated",
"display_description": "This is my group updated."
}
group = db.group_update(self.user_ctxt, values)
ignored_keys = ['deleted', 'deleted_at', 'updated_at',
'created_at', "user_id", "project_id", "status"]
self._assertEqualObjects(group, values, ignored_keys)
