def test_only_valid_uploads(self):
f = FileUpload.objects.create(valid=False)
form = forms.NewAddonForm({'upload': f.pk})
assert 'upload' in form.errors
f.validation = '{"errors": 0}'
f.save()
form = forms.NewAddonForm({'upload': f.pk})
assert 'upload' not in form.errors
def test_only_valid_uploads(self):
f = FileUpload.objects.create(valid=False)
form = forms.NewAddonForm({'upload': f.pk}, request=mock.Mock())
assert ('There was an error with your upload. Please try again.'
in form.errors.get('__all__')), form.errors
f.validation = '{"errors": 0}'
f.save()
form = forms.NewAddonForm({'upload': f.pk}, request=mock.Mock())
assert ('There was an error with your upload. Please try again.'
not in form.errors.get('__all__')), form.errors
def test_check_xpi_called(self, mock_check_xpi_info, mock_parse):
"""Make sure the check_xpi_info helper is called.
There's some important checks made in check_xpi_info, if we ever
refactor the form to not call it anymore, we need to make sure those
checks are run at some point.
"""
mock_parse.return_value = None
mock_check_xpi_info.return_value = {'name': 'foo', 'type': 2}
f = FileUpload.objects.create(valid=True)
form = forms.NewAddonForm(
{'upload': f.pk, 'supported_platforms': [1]},
request=mock.Mock())
form.clean()
assert mock_check_xpi_info.called
