def test_deduplication_parties():
create_jurisdictions()
party = ScrapeOrganization("Wild", classification="party")
OrganizationImporter("jid1").import_data([party.as_dict()])
assert Organization.objects.count() == 1
# parties shouldn't get jurisdiction id attached, so don't differ on import
party = ScrapeOrganization("Wild", classification="party")
OrganizationImporter("jid2").import_data([party.as_dict()])
assert Organization.objects.count() == 1
def test_parent_id_resolution():
create_jurisdictions()
parent = ScrapeOrganization("UN", classification="international")
child = ScrapeOrganization("UNESCO",
classification="unknown",
parent_id=parent._id)
OrganizationImporter("jid1").import_data(
[parent.as_dict(), child.as_dict()])
assert Organization.objects.count() == 2
assert Organization.objects.get(name="UN").children.count() == 1
assert Organization.objects.get(name="UNESCO").parent.name == "UN"
def test_deduplication_prevents_identical():
create_jurisdictions()
org1 = ScrapeOrganization("United Nations", classification="international")
org2 = ScrapeOrganization("United Nations",
classification="international",
founding_date="1945")
OrganizationImporter("jid1").import_data([org1.as_dict()])
assert Organization.objects.count() == 1
OrganizationImporter("jid1").import_data([org2.as_dict()])
assert Organization.objects.count() == 1
def test_full_organization():
create_jurisdictions()
org = ScrapeOrganization("United Nations", classification="international")
org.add_identifier("un")
org.add_name("UN", start_date="1945")
org.add_contact_detail(type="phone",
value="555-555-1234",
note="this is fake")
org.add_link("http://example.com/link")
org.add_source("http://example.com/source")
# import org
od = org.as_dict()
OrganizationImporter("jid1").import_data([od])
# get person from db and assert it imported correctly
o = Organization.objects.get()
assert "ocd-organization" in o.id
assert o.name == org.name
assert o.identifiers.all()[0].identifier == "un"
assert o.identifiers.all()[0].scheme == ""
assert o.other_names.all()[0].name == "UN"
assert o.other_names.all()[0].start_date == "1945"
assert o.contact_details.all()[0].type == "phone"
assert o.contact_details.all()[0].value == "555-555-1234"
assert o.contact_details.all()[0].note == "this is fake"
assert o.links.all()[0].url == "http://example.com/link"
assert o.sources.all()[0].url == "http://example.com/source"
def test_deduplication_other_name_exists():
create_jurisdictions()
create_org()
org = ScrapeOrganization("UN", classification="international")
od = org.as_dict()
OrganizationImporter("jid1").import_data([od])
assert Organization.objects.all().count() == 1
def test_extras_organization():
create_jurisdictions()
org = ScrapeOrganization("United Nations", classification="international")
org.extras = {"hello": "world", "foo": {"bar": "baz"}}
od = org.as_dict()
OrganizationImporter("jid1").import_data([od])
o = Organization.objects.get()
assert o.extras["foo"]["bar"] == "baz"
def test_full_vote_event():
j = create_jurisdiction()
j.legislative_sessions.create(name="1900", identifier="1900")
sp1 = ScrapePerson("John Smith", primary_org="lower")
sp2 = ScrapePerson("Adam Smith", primary_org="lower")
org = ScrapeOrganization(name="House", classification="lower")
bill = ScrapeBill("HB 1",
"1900",
"Axe & Tack Tax Act",
from_organization=org._id)
vote_event = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-01",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
organization=org._id,
)
vote_event.set_count("yes", 20)
vote_event.yes("John Smith")
vote_event.no("Adam Smith")
oi = OrganizationImporter("jid")
oi.import_data([org.as_dict()])
pi = PersonImporter("jid")
pi.import_data([sp1.as_dict(), sp2.as_dict()])
mi = MembershipImporter("jid", pi, oi, DumbMockImporter())
mi.import_data([sp1._related[0].as_dict(), sp2._related[0].as_dict()])
bi = BillImporter("jid", oi, pi)
bi.import_data([bill.as_dict()])
VoteEventImporter("jid", pi, oi, bi).import_data([vote_event.as_dict()])
assert VoteEvent.objects.count() == 1
ve = VoteEvent.objects.get()
assert ve.legislative_session == LegislativeSession.objects.get()
assert ve.motion_classification == ["passage:bill"]
assert ve.bill == Bill.objects.get()
count = ve.counts.get()
assert count.option == "yes"
assert count.value == 20
votes = list(ve.votes.all())
assert len(votes) == 2
for v in ve.votes.all():
if v.voter_name == "John Smith":
assert v.option == "yes"
assert v.voter == Person.objects.get(name="John Smith")
else:
assert v.option == "no"
assert v.voter == Person.objects.get(name="Adam Smith")
def test_deduplication_overlap_name_distinct_juris():
create_jurisdictions()
org_jid_1 = Organization.objects.create(
name="World Wrestling Federation",
classification="international",
jurisdiction_id="jid1",
)
org_jid_1.other_names.create(name="WWF")
org = ScrapeOrganization(name="WWF", classification="international")
org.add_name("WWF")
oi1 = OrganizationImporter("jid1")
oi1.import_item(org.as_dict())
assert Organization.objects.count() == 1
oi2 = OrganizationImporter("jid2")
oi2.import_item(org.as_dict())
assert Organization.objects.count() == 2
def test_deduplication_similar_but_different():
create_jurisdictions()
o1 = ScrapeOrganization("United Nations", classification="international")
# different classification
o2 = ScrapeOrganization("United Nations", classification="global")
# different name
o3 = ScrapeOrganization("United Nations of Earth",
classification="international")
# has a parent
o4 = ScrapeOrganization("United Nations",
classification="international",
parent_id=o1._id)
# similar, but no duplicates
orgs = [o1.as_dict(), o2.as_dict(), o3.as_dict(), o4.as_dict()]
OrganizationImporter("jid1").import_data(orgs)
assert Organization.objects.count() == 4
# should get a new one when jurisdiction_id changes
o5 = ScrapeOrganization("United Nations", classification="international")
OrganizationImporter("jid2").import_data([o5.as_dict()])
assert Organization.objects.count() == 5
def test_save_related():
s = Scraper(juris, "/tmp/")
p = Person("Michael Jordan")
p.add_source("http://example.com")
o = Organization("Chicago Bulls", classification="committee")
o.add_source("http://example.com")
p._related.append(o)
with mock.patch("json.dump") as json_dump:
s.save_object(p)
assert json_dump.mock_calls == [
mock.call(p.as_dict(), mock.ANY, cls=mock.ANY),
mock.call(o.as_dict(), mock.ANY, cls=mock.ANY),
]
def test_fix_bill_id():
j = create_jurisdiction()
j.legislative_sessions.create(name="1900", identifier="1900")
org1 = ScrapeOrganization(name="House", classification="lower")
bill = ScrapeBill("HB 1",
"1900",
"Test Bill ID",
classification="bill",
chamber="lower")
oi = OrganizationImporter("jid")
oi.import_data([org1.as_dict()])
from openstates.settings import IMPORT_TRANSFORMERS
IMPORT_TRANSFORMERS["bill"] = {
"identifier":
lambda x: re.sub(r"([A-Z]*)\s*0*([-\d]+)", r"\1 \2", x, 1)
}
bi = BillImporter("jid", oi, DumbMockImporter())
bi.import_data([bill.as_dict()])
ve = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-02",
classification="passage:bill",
result="fail",
bill_chamber="lower",
bill="HB1",
identifier="4",
bill_action="passage",
organization=org1._id,
)
VoteEventImporter("jid", DumbMockImporter(), oi,
bi).import_data([ve.as_dict()])
IMPORT_TRANSFORMERS["bill"] = {}
ve = VoteEvent.objects.get()
ve.bill.identifier == "HB 1"
def test_locked_field_subitem():
create_jurisdiction()
org = ScrapeOrganization("SHIELD")
org.add_name("S.H.I.E.L.D.")
oi = OrganizationImporter("jid")
oi.import_data([org.as_dict()])
# lock the field
o = Organization.objects.get()
o.locked_fields = ["other_names"]
o.save()
# reimport
org = ScrapeOrganization("SHIELD").as_dict()
oi = OrganizationImporter("jid")
oi.import_data([org])
o = Organization.objects.get()
assert o.other_names.get().name == "S.H.I.E.L.D."
def test_deduplication_error_overlaps():
create_jurisdictions()
Organization.objects.create(
name="World Wrestling Federation",
classification="international",
jurisdiction_id="jid1",
)
wildlife = Organization.objects.create(
name="World Wildlife Fund",
classification="international",
jurisdiction_id="jid1",
)
wildlife.other_names.create(name="WWF")
org = ScrapeOrganization("World Wrestling Federation",
classification="international")
org.add_name("WWF")
od = org.as_dict()
with pytest.raises(SameOrgNameError):
OrganizationImporter("jid1").import_data([od])
def test_vote_event_bill_actions_errors():
j = create_jurisdiction()
j.legislative_sessions.create(name="1900", identifier="1900")
org1 = ScrapeOrganization(name="House", classification="lower")
org2 = ScrapeOrganization(name="Senate", classification="upper")
bill = ScrapeBill("HB 1",
"1900",
"Axe & Tack Tax Act",
from_organization=org1._id)
# for this bill, two identical actions, so vote matching will fail
bill.add_action(description="passage", date="1900-04-01", chamber="lower")
bill.add_action(description="passage", date="1900-04-01", chamber="lower")
# this action is good, but two votes will try to match it
bill.add_action(description="passage", date="1900-04-02", chamber="lower")
# will match two actions
ve1 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-01",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
identifier="1",
bill_action="passage",
organization=org1._id,
)
# will match no actions
ve2 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-01",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
identifier="2",
bill_action="committee result",
organization=org1._id,
)
# these two votes will both match the same action
ve3 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-02",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
identifier="3",
bill_action="passage",
organization=org1._id,
)
ve4 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage-syz",
start_date="1900-04-02",
classification="passage:bill",
result="fail",
bill_chamber="lower",
bill="HB 1",
identifier="4",
bill_action="passage",
organization=org1._id,
)
oi = OrganizationImporter("jid")
oi.import_data([org1.as_dict(), org2.as_dict()])
bi = BillImporter("jid", oi, DumbMockImporter())
bi.import_data([bill.as_dict()])
VoteEventImporter("jid", DumbMockImporter(), oi, bi).import_data(
[ve1.as_dict(),
ve2.as_dict(),
ve3.as_dict(),
ve4.as_dict()])
bill = Bill.objects.get()
votes = list(VoteEvent.objects.all().order_by("identifier"))
# isn't matched, was ambiguous across two actions
assert votes[0].bill_action is None
# isn't matched, no match in actions
assert votes[1].bill_action is None
# these both try to match the same action, only first will succeed
assert votes[2].bill_action is not None
assert votes[3].bill_action is None
def test_vote_event_bill_actions_two_stage():
# this test is very similar to what we're testing in test_vote_event_bill_actions w/
# ve3 and ve4, that two bills that reference the same action won't conflict w/ the
# OneToOneField, but in this case we do it in two stages so that the conflict is found
# even if the votes weren't in the same scrape
j = create_jurisdiction()
j.legislative_sessions.create(name="1900", identifier="1900")
org1 = ScrapeOrganization(name="House", classification="lower")
bill = ScrapeBill("HB 1",
"1900",
"Axe & Tack Tax Act",
from_organization=org1._id)
bill.add_action(description="passage", date="1900-04-02", chamber="lower")
ve1 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-02",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
bill_action="passage",
organization=org1._id,
)
ve2 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-02",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
bill_action="passage",
organization=org1._id,
)
# disambiguate them
ve1.pupa_id = "one"
ve2.pupa_id = "two"
oi = OrganizationImporter("jid")
oi.import_data([org1.as_dict()])
bi = BillImporter("jid", oi, DumbMockImporter())
bi.import_data([bill.as_dict()])
# first imports just fine
VoteEventImporter("jid", DumbMockImporter(), oi,
bi).import_data([ve1.as_dict()])
votes = list(VoteEvent.objects.all())
assert len(votes) == 1
assert votes[0].bill_action is not None
# when second is imported, ensure that action stays pinned to first just as it would
# have if they were both in same import
VoteEventImporter("jid", DumbMockImporter(), oi,
bi).import_data([ve1.as_dict(),
ve2.as_dict()])
votes = list(VoteEvent.objects.all())
assert len(votes) == 2
assert votes[0].bill_action is not None
assert votes[1].bill_action is None
def test_vote_event_bill_actions():
j = create_jurisdiction()
j.legislative_sessions.create(name="1900", identifier="1900")
org1 = ScrapeOrganization(name="House", classification="lower")
org2 = ScrapeOrganization(name="Senate", classification="upper")
bill = ScrapeBill("HB 1",
"1900",
"Axe & Tack Tax Act",
from_organization=org1._id)
# add actions, passage of upper & lower on same day, something else,
# then passage in upper again on a different day
bill.add_action(description="passage", date="1900-04-01", chamber="upper")
bill.add_action(description="passage", date="1900-04-01", chamber="lower")
bill.add_action(description="other event",
date="1900-04-01",
chamber="lower")
bill.add_action(description="passage", date="1900-04-02", chamber="upper")
# four passage votes, one per chamber, one on 04-01, and one on 04-02
ve1 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-01",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
bill_action="passage",
organization=org1._id,
)
ve2 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-01",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
bill_action="passage",
organization=org2._id,
)
ve3 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-02",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
bill_action="passage",
organization=org1._id,
)
ve4 = ScrapeVoteEvent(
legislative_session="1900",
motion_text="passage",
start_date="1900-04-02",
classification="passage:bill",
result="pass",
bill_chamber="lower",
bill="HB 1",
bill_action="passage",
organization=org2._id,
)
oi = OrganizationImporter("jid")
oi.import_data([org1.as_dict(), org2.as_dict()])
bi = BillImporter("jid", oi, DumbMockImporter())
bi.import_data([bill.as_dict()])
VoteEventImporter("jid", DumbMockImporter(), oi, bi).import_data(
[ve1.as_dict(),
ve2.as_dict(),
ve3.as_dict(),
ve4.as_dict()])
bill = Bill.objects.get()
votes = list(VoteEvent.objects.all())
actions = list(bill.actions.all())
assert len(actions) == 4
assert len(votes) == 4
votes = {(v.organization.classification, v.start_date): v.bill_action
for v in votes}
# ensure that votes are matched using action, chamber, and date
assert votes[("upper", "1900-04-01")] == actions[0]
assert votes[("lower", "1900-04-01")] == actions[1]
assert votes[("upper", "1900-04-02")] == actions[3]
assert votes[("lower", "1900-04-02")] is None
def test_full_bill():
create_jurisdiction()
sp = ScrapePerson("Adam Smith")
org = ScrapeOrganization(name="House", classification="lower")
com = ScrapeOrganization(
name="Arbitrary Committee", classification="committee", parent_id=org._id
)
oldbill = ScrapeBill(
"HB 99",
"1899",
"Axe & Tack Tax Act",
classification="tax bill",
from_organization=org._id,
)
bill = ScrapeBill(
"HB 1",
"1900",
"Axe & Tack Tax Act",
classification="tax bill",
from_organization=org._id,
)
bill.subject = ["taxes", "axes"]
bill.add_identifier("SB 9")
bill.add_title("Tack & Axe Tax Act")
bill.add_action("introduced in house", "1900-04-01", chamber="lower")
act = bill.add_action("sent to arbitrary committee", "1900-04-04", chamber="lower")
act.add_related_entity("arbitrary committee", "organization", com._id)
bill.add_related_bill(
"HB 99", legislative_session="1899", relation_type="prior-session"
)
bill.add_sponsorship(
"Adam Smith",
classification="extra sponsor",
entity_type="person",
primary=False,
entity_id=sp._id,
)
bill.add_sponsorship(
"Jane Smith", classification="lead sponsor", entity_type="person", primary=True
)
bill.add_abstract(
"This is an act about axes and taxes and tacks.",
note="official",
date="1969-10-20",
)
bill.add_document_link(
"Fiscal Note", "http://example.com/fn.pdf", media_type="application/pdf"
)
bill.add_document_link(
"Fiscal Note", "http://example.com/fn.html", media_type="text/html"
)
bill.add_version_link(
"Fiscal Note", "http://example.com/v/1", media_type="text/html"
)
bill.add_source("http://example.com/source")
# import bill
oi = OrganizationImporter("jid")
oi.import_data([org.as_dict(), com.as_dict()])
pi = PersonImporter("jid")
pi.import_data([sp.as_dict()])
BillImporter("jid", oi, pi).import_data([oldbill.as_dict(), bill.as_dict()])
# get bill from db and assert it imported correctly
b = Bill.objects.get(identifier="HB 1")
assert b.from_organization.classification == "lower"
assert b.identifier == bill.identifier
assert b.title == bill.title
assert b.classification == bill.classification
assert b.subject == ["taxes", "axes"]
assert b.abstracts.get().note == "official"
assert b.abstracts.get().date == "1969-10-20"
# other_title, other_identifier added
assert b.other_titles.get().title == "Tack & Axe Tax Act"
assert b.other_identifiers.get().identifier == "SB 9"
# actions
actions = list(b.actions.all())
assert len(actions) == 2
# ensure order was preserved (if this breaks it'll be intermittent)
assert actions[0].organization == Organization.objects.get(classification="lower")
assert actions[0].description == "introduced in house"
assert actions[1].description == "sent to arbitrary committee"
assert actions[1].related_entities.get().organization == Organization.objects.get(
classification="committee"
)
# related_bills were added
rb = b.related_bills.get()
assert rb.identifier == "HB 99"
# and bill got resolved
assert rb.related_bill.identifier == "HB 99"
# sponsors added, linked & unlinked
sponsorships = b.sponsorships.all()
assert len(sponsorships) == 2
person = Person.objects.get(name="Adam Smith")
for ss in sponsorships:
if ss.primary:
assert ss.person is None
assert ss.organization is None
else:
assert ss.person == person
# versions & documents with their links
versions = b.versions.all()
assert len(versions) == 1
assert versions[0].links.count() == 1
documents = b.documents.all()
assert len(documents) == 1
assert documents[0].links.count() == 2
# sources
assert b.sources.count() == 1
