def test_time_log_creation_that_violates_dependency_condition_WIP_CMPL_onstart(self):
"""testing if a ValueError will be raised when the entered TimeLog will
violate the dependency relation of the task
+--------+
+-| Task 1 |
| | CMPL |
| +--------+ +--------+
+-------------------->| Task 2 |
| WIP |
+--------+
"""
task = self.kwargs['task']
task.status = self.status_cmpl
task.start = datetime.datetime(2014, 3, 16, 10, 0)
task.end = datetime.datetime(2014, 3, 25, 19, 0)
dep_task = Task(
name="test task 2",
project=self.test_project,
status_list=self.test_task_status_list,
schedule_timing=10,
schedule_unit='d',
depends=[task],
resources=[self.test_resource2]
)
# set the dependency target to onstart
dep_task.task_depends_to[0].dependency_target = 'onstart'
# entering a time log to the dates before 2014-03-16-10-0 should raise
# a ValueError
with self.assertRaises(DependencyViolationError) as cm:
dep_task.create_time_log(
self.test_resource2,
datetime.datetime(2014, 3, 16, 9, 0),
datetime.datetime(2014, 3, 16, 10, 0)
)
self.assertEqual(
'\'It is not possible to create a TimeLog before %s, which '
'violates the dependency relation of "%s" to "%s"\'' % (
datetime.datetime(2014, 3, 16, 10, 0),
dep_task.name,
task.name
),
str(cm.exception)
)
# and creating a TimeLog after that is possible
dep_task.create_time_log(
self.test_resource2,
datetime.datetime(2014, 3, 16, 10, 0),
datetime.datetime(2014, 3, 16, 10, 0)
)
def test_time_log_creation_that_violates_dependency_condition_WIP_CMPL_onend(self):
"""testing if a DependencyViolationError will be raised when the entered
TimeLog will violate the dependency relation of the task
+--------+
| Task 1 | ----+
| CMPL | |
+--------+ | +--------+
+--->| Task 2 |
| WIP |
+--------+
"""
kwargs = copy.copy(self.kwargs)
task = kwargs['task']
task.status = self.status_cmpl
task.start = datetime.datetime(2014, 3, 16, 10, 0, tzinfo=pytz.utc)
task.end = datetime.datetime(2014, 3, 25, 19, 0, tzinfo=pytz.utc)
from stalker import Task
dep_task = Task(
name="test task 2",
project=self.test_project,
schedule_timing=10,
schedule_unit='d',
depends=[task],
resources=[self.test_resource2]
)
# set the dependency target to onend
dep_task.task_depends_to[0].dependency_target = 'onend'
# entering a time log to the dates before 2014-03-25-19-0 should raise
# a ValueError
from stalker.exceptions import DependencyViolationError
with pytest.raises(DependencyViolationError) as cm:
dep_task.create_time_log(
self.test_resource2,
datetime.datetime(2014, 3, 25, 18, 0, tzinfo=pytz.utc),
datetime.datetime(2014, 3, 25, 19, 0, tzinfo=pytz.utc)
)
assert 'It is not possible to create a TimeLog before %s, which ' \
'violates the dependency relation of "%s" to "%s"' % (
datetime.datetime(2014, 3, 25, 19, 0, tzinfo=pytz.utc),
dep_task.name,
task.name
) == str(cm.value)
# and creating a TimeLog after that is possible
dep_task.create_time_log(
self.test_resource2,
datetime.datetime(2014, 3, 25, 19, 0, tzinfo=pytz.utc),
datetime.datetime(2014, 3, 25, 20, 0, tzinfo=pytz.utc)
)
class ReviewTestCase(unittest2.TestCase):
"""tests the stalker.models.review.Review class
"""
def setUp(self):
"""set up the test
"""
db.setup()
db.init()
self.user1 = User(
name='Test User 1',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user1)
self.user2 = User(
name='Test User 2',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user2)
self.user3 = User(
name='Test User 2',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user3)
# Review Statuses
self.status_new = Status.query.filter_by(code='NEW').first()
self.status_rrev = Status.query.filter_by(code='RREV').first()
self.status_app = Status.query.filter_by(code='APP').first()
# Task Statuses
self.status_wfd = Status.query.filter_by(code='WFD').first()
self.status_rts = Status.query.filter_by(code='RTS').first()
self.status_wip = Status.query.filter_by(code='WIP').first()
self.status_prev = Status.query.filter_by(code='PREV').first()
self.status_hrev = Status.query.filter_by(code='HREV').first()
self.status_drev = Status.query.filter_by(code='DREV').first()
self.status_cmpl = Status.query.filter_by(code='CMPL').first()
self.project_status_list = StatusList(
target_entity_type='Project',
statuses=[
self.status_new, self.status_wip, self.status_cmpl
]
)
DBSession.add(self.project_status_list)
self.temp_path = tempfile.mkdtemp()
self.repo = Repository(
name='Test Repository',
linux_path=self.temp_path,
windows_path=self.temp_path,
osx_path=self.temp_path
)
DBSession.add(self.repo)
self.structure = Structure(
name='Test Project Structure'
)
DBSession.add(self.structure)
self.project = Project(
name='Test Project',
code='TP',
lead=self.user1,
status_list=self.project_status_list,
repository=self.repo
)
DBSession.add(self.project)
self.task1 = Task(
name='Test Task 1',
project=self.project,
resources=[self.user1]
)
DBSession.add(self.task1)
self.task2 = Task(
name='Test Task 2',
project=self.project
)
DBSession.add(self.task2)
self.task3 = Task(
name='Test Task 3',
parent=self.task2,
resources=[self.user1]
)
DBSession.add(self.task3)
self.kwargs = {
'task': self.task1,
'reviewer': self.user1
}
#self.review = Review(**self.kwargs)
#DBSession.add(self.review)
# add everything to the db
DBSession.commit()
def tearDown(self):
"""clean up test
"""
DBSession.remove()
def test_task_argument_is_skipped(self):
"""testing if a TypeError will be raised when the task argument is
skipped
"""
self.kwargs.pop('task')
self.assertRaises(TypeError, Review, **self.kwargs)
def test_task_argument_is_None(self):
"""testing if a TypeError will be raised when the task argument is None
"""
self.kwargs['task'] = None
self.assertRaises(TypeError, Review, **self.kwargs)
def test_task_argument_is_not_a_Task_instance(self):
"""testing if a TypeError will be raised when the task argument value
is not a Task instance
"""
self.kwargs['task'] = 'not a Task instance'
self.assertRaises(TypeError, Review, **self.kwargs)
# def test_task_attribute_is_read_only(self):
# """testing if a the task attribute is read only
# """
# now = datetime.datetime.now()
# self.task1.create_time_log(
# resource=self.task1.resources[0],
# start=now,
# end=now + datetime.timedelta(hours=1)
# )
# reviews = self.task1.request_review()
# review = reviews[0]
# self.assertRaises(AttributeError, setattr, review, 'task', self.task1)
def test_task_argument_is_not_a_leaf_task(self):
"""testing if a ValueError will be raised when the task given in task
argument is not a leaf task
"""
task1 = Task(
name='Task1',
project=self.project
)
task2 = Task(
name='Task2',
parent=task1
)
self.kwargs['task'] = task1
self.assertRaises(ValueError, Review, **self.kwargs)
def test_task_argument_is_working_properly(self):
"""testing if the task argument value is passed to the task argument
properly
"""
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
self.assertEqual(reviews[0].task, self.task1)
def test_auto_name_is_true(self):
"""testing if review instances are named automatically
"""
self.assertTrue(Review.__auto_name__)
def test_status_is_new_for_a_newly_created_review_instance(self):
"""testing if the status is NEW for a newly created review instance
"""
review = Review(**self.kwargs)
self.assertEqual(review.status, self.status_new)
def test_review_number_attribute_is_a_read_only_attribute(self):
"""testing if the review_number attribute is a read only attribute
"""
review = Review(**self.kwargs)
self.assertRaises(
AttributeError, setattr, review, 'review_number', 2
)
def test_review_number_attribute_is_initialized_to_the_task_review_number_plus_1(self):
"""testing if the review_number attribute is initialized with
task.review_number + 1
"""
review = Review(**self.kwargs)
self.assertEqual(1, review.review_number)
def test_review_number_for_multiple_responsible_task_is_equal_to_each_other(self):
"""testing if the review.review_number attribute for each review
instance created for a task with multiple responsible are equal to each
other
"""
self.task1.responsible = [self.user1, self.user2, self.user3]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
expected_review_number = self.task1.review_number + 1
self.assertEqual(3, len(reviews))
self.assertEqual(
expected_review_number,
reviews[0].review_number
)
self.assertEqual(
expected_review_number,
reviews[1].review_number
)
self.assertEqual(
expected_review_number,
reviews[2].review_number
)
def test_reviewer_argument_is_skipped(self):
"""testing if a TypeError will be raised when the reviewer argument is
skipped
"""
self.kwargs.pop('reviewer')
self.assertRaises(TypeError, Review, **self.kwargs)
def test_reviewer_argument_is_None(self):
"""testing if a TypeError will be raised when the reviewer argument is
None
"""
self.kwargs['reviewer'] = None
self.assertRaises(TypeError, Review, **self.kwargs)
def test_reviewer_attribute_is_set_to_None(self):
"""testing if a TypeError will be raised when the reviewer attribute is
set to None
"""
review = Review(**self.kwargs)
self.assertRaises(TypeError, setattr, review, 'reviewer', None)
def test_reviewer_argument_is_not_a_User_instance(self):
"""testing if a TeypeError will be raised when the reviewer argument is
not a User instance
"""
self.kwargs['reviewer'] = 'not a user instance'
self.assertRaises(TypeError, Review, **self.kwargs)
def test_reviewer_attribute_is_not_a_User_instance(self):
"""testing if a TypeError will be raised when the reviewer attribute is
set to a value other than a User instance
"""
review = Review(**self.kwargs)
self.assertRaises(TypeError, setattr, review, 'reviewer', 'not a user')
def test_reviewer_argument_is_not_in_Task_responsible_list(self):
"""testing if it is possible to use some other user which is not in the
Task.responsible list as the reviewer
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user2
review = Review(**self.kwargs)
self.assertEqual(review.reviewer, self.user2)
def test_reviewer_attribute_is_not_in_Task_responsible_list(self):
"""testing if it is possible to use some other user which is not in the
Task.responsible list as the reviewer
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
review.reviewer = self.user2
self.assertEqual(review.reviewer, self.user2)
def test_reviewer_argument_is_working_properly(self):
"""testing if the reviewer argument value is correctly passed to
reviewer attribute
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
self.assertEqual(
self.user1,
review.reviewer
)
def test_reviewer_attribute_is_working_properly(self):
"""testing if the reviewer attribute is working properly
"""
self.task1.responsible = [self.user1, self.user2]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
review.reviewer = self.user2
self.assertEqual(
self.user2,
review.reviewer
)
# TODO: add tests for the same user is being the reviewer for all reviews
# at the same level with same task
def test_approve_method_updates_task_status_correctly_for_a_single_responsible_task(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with only one responsible
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
self.assertNotEqual(
self.status_cmpl,
self.task1.status
)
review = Review(**self.kwargs)
review.approve()
self.assertEqual(
self.status_cmpl,
self.task1.status
)
def test_approve_method_updates_task_status_correctly_for_a_multi_responsible_task_when_all_approve(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.approve()
# still pending review
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.approve()
self.assertEqual(
self.status_cmpl,
self.task1.status
)
def test_approve_method_updates_task_parent_status(self):
"""testing if approve method will also update the task parent status
"""
self.task3.status = self.status_rts
now = datetime.datetime.now()
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
self.assertEqual(
self.task3.status, self.status_prev
)
review1 = reviews[0]
review1.approve()
self.assertEqual(
self.task3.status, self.status_cmpl
)
self.assertEqual(
self.task2.status, self.status_cmpl
)
def test_approve_method_updates_task_status_correctly_for_a_multi_responsible_task_when_one_approve(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
td = datetime.timedelta
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision()
# one requst review should be enough to set the status to hrev,
# note that this is another tests duty to check
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.approve()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_status_correctly_for_a_single_responsible_task(self):
"""testing if the Review.request_revision() method will update the task
status correctly to HREV for a Task with only one responsible
"""
self.task1.responsible = [self.user1]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
review = reviews[0]
review.request_revision()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_status_correctly_for_a_multi_responsible_task_when_one_request_revision(self):
"""testing if the Review.request_revision() method will update the
task status correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.approve()
self.assertEqual(
self.status_prev,
self.task1.status
)
review2.request_revision()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_status_correctly_for_a_multi_responsible_task_when_all_request_revision(self):
"""testing if the Review.request_revision() method will update the
task status correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision()
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.request_revision()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_when_all_request_revision(self):
"""testing if the Review.request_revision() method will update the task
timing values correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
self.assertEqual(
self.status_rts,
self.task1.status
)
dt = datetime.datetime
td = datetime.timedelta
now = dt.now()
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
self.assertEqual(len(reviews), 2)
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
self.assertEqual(
self.status_hrev,
self.task1.status
)
# check the timing values
self.assertEqual(self.task1.schedule_timing, 8)
self.assertEqual(self.task1.schedule_unit, 'h')
def test_review_set_property_return_all_the_revision_instances_with_same_review_number(self):
"""testing if review_set property returns all the Review instances of
the same task with the same review_number
"""
self.task1.responsible = [self.user1, self.user2, self.user3]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + datetime.timedelta(hours=1)
)
self.task1.status = self.status_wip
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review3 = reviews[2]
self.assertEqual(review1.review_number, 1)
self.assertEqual(review2.review_number, 1)
self.assertEqual(review3.review_number, 1)
self.task1.approve()
review4 = self.task1.request_revision(reviewer=self.user1)
self.task1.status = self.status_wip
self.assertEqual(review4.review_number, 2)
# enter new time log to turn it into WIP
self.task1.create_time_log(
resource=self.user1,
start=now + datetime.timedelta(hours=1),
end=now + datetime.timedelta(hours=2)
)
review_set2 = self.task1.request_review()
review5 = review_set2[0]
review6 = review_set2[1]
review7 = review_set2[2]
self.assertEqual(review5.review_number, 3)
self.assertEqual(review6.review_number, 3)
self.assertEqual(review7.review_number, 3)
class ReviewTestCase(unittest.TestCase):
"""tests the stalker.models.review.Review class
"""
def setUp(self):
"""set up the test
"""
db.setup()
db.init()
self.user1 = User(
name='Test User 1',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user1)
self.user2 = User(
name='Test User 2',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user2)
self.user3 = User(
name='Test User 2',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user3)
# Review Statuses
self.status_new = Status.query.filter_by(code='NEW').first()
self.status_rrev = Status.query.filter_by(code='RREV').first()
self.status_app = Status.query.filter_by(code='APP').first()
# Task Statuses
self.status_wfd = Status.query.filter_by(code='WFD').first()
self.status_rts = Status.query.filter_by(code='RTS').first()
self.status_wip = Status.query.filter_by(code='WIP').first()
self.status_prev = Status.query.filter_by(code='PREV').first()
self.status_hrev = Status.query.filter_by(code='HREV').first()
self.status_drev = Status.query.filter_by(code='DREV').first()
self.status_cmpl = Status.query.filter_by(code='CMPL').first()
self.project_status_list = StatusList(
target_entity_type='Project',
statuses=[
self.status_new, self.status_wip, self.status_cmpl
]
)
DBSession.add(self.project_status_list)
self.temp_path = tempfile.mkdtemp()
self.repo = Repository(
name='Test Repository',
linux_path=self.temp_path,
windows_path=self.temp_path,
osx_path=self.temp_path
)
DBSession.add(self.repo)
self.structure = Structure(
name='Test Project Structure'
)
DBSession.add(self.structure)
self.project = Project(
name='Test Project',
code='TP',
status_list=self.project_status_list,
repository=self.repo
)
DBSession.add(self.project)
self.task1 = Task(
name='Test Task 1',
project=self.project,
resources=[self.user1],
responsible=[self.user2]
)
DBSession.add(self.task1)
self.task2 = Task(
name='Test Task 2',
project=self.project,
responsible=[self.user1]
)
DBSession.add(self.task2)
self.task3 = Task(
name='Test Task 3',
parent=self.task2,
resources=[self.user1]
)
DBSession.add(self.task3)
self.task4 = Task(
name='Test Task 4',
project=self.project,
resources=[self.user1],
depends=[self.task3],
responsible=[self.user2],
schedule_timing=2,
schedule_unit='h'
)
DBSession.add(self.task4)
self.task5 = Task(
name='Test Task 5',
project=self.project,
resources=[self.user2],
depends=[self.task3],
responsible=[self.user2],
schedule_timing=2,
schedule_unit='h'
)
DBSession.add(self.task5)
self.task6 = Task(
name='Test Task 6',
project=self.project,
resources=[self.user3],
depends=[self.task3],
responsible=[self.user2],
schedule_timing=2,
schedule_unit='h'
)
DBSession.add(self.task6)
self.kwargs = {
'task': self.task1,
'reviewer': self.user1
}
#self.review = Review(**self.kwargs)
#DBSession.add(self.review)
# add everything to the db
DBSession.commit()
def tearDown(self):
"""clean up test
"""
DBSession.remove()
# def test_task_argument_is_skipped(self):
# """testing if a TypeError will be raised when the task argument is
# skipped
# """
# self.kwargs.pop('task')
# self.assertRaises(TypeError, Review, **self.kwargs)
# def test_task_argument_is_None(self):
# """testing if a TypeError will be raised when the task argument is None
# """
# self.kwargs['task'] = None
# self.assertRaises(TypeError, Review, **self.kwargs)
def test_task_argument_is_not_a_Task_instance(self):
"""testing if a TypeError will be raised when the task argument value
is not a Task instance
"""
self.kwargs['task'] = 'not a Task instance'
self.assertRaises(TypeError, Review, **self.kwargs)
# def test_task_attribute_is_read_only(self):
# """testing if a the task attribute is read only
# """
# now = datetime.datetime.now()
# self.task1.create_time_log(
# resource=self.task1.resources[0],
# start=now,
# end=now + datetime.timedelta(hours=1)
# )
# reviews = self.task1.request_review()
# review = reviews[0]
# self.assertRaises(AttributeError, setattr, review, 'task', self.task1)
def test_task_argument_is_not_a_leaf_task(self):
"""testing if a ValueError will be raised when the task given in task
argument is not a leaf task
"""
task1 = Task(
name='Task1',
project=self.project
)
task2 = Task(
name='Task2',
parent=task1
)
self.kwargs['task'] = task1
self.assertRaises(ValueError, Review, **self.kwargs)
def test_task_argument_is_working_properly(self):
"""testing if the task argument value is passed to the task argument
properly
"""
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
self.assertEqual(reviews[0].task, self.task1)
def test_auto_name_is_true(self):
"""testing if review instances are named automatically
"""
self.assertTrue(Review.__auto_name__)
def test_status_is_new_for_a_newly_created_review_instance(self):
"""testing if the status is NEW for a newly created review instance
"""
review = Review(**self.kwargs)
self.assertEqual(review.status, self.status_new)
def test_review_number_attribute_is_a_read_only_attribute(self):
"""testing if the review_number attribute is a read only attribute
"""
review = Review(**self.kwargs)
self.assertRaises(
AttributeError, setattr, review, 'review_number', 2
)
def test_review_number_attribute_is_initialized_to_the_task_review_number_plus_1(self):
"""testing if the review_number attribute is initialized with
task.review_number + 1
"""
review = Review(**self.kwargs)
self.assertEqual(1, review.review_number)
def test_review_number_for_multiple_responsible_task_is_equal_to_each_other(self):
"""testing if the review.review_number attribute for each review
instance created for a task with multiple responsible are equal to each
other
"""
self.task1.responsible = [self.user1, self.user2, self.user3]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
expected_review_number = self.task1.review_number + 1
self.assertEqual(3, len(reviews))
self.assertEqual(
expected_review_number,
reviews[0].review_number
)
self.assertEqual(
expected_review_number,
reviews[1].review_number
)
self.assertEqual(
expected_review_number,
reviews[2].review_number
)
def test_reviewer_argument_is_skipped(self):
"""testing if a TypeError will be raised when the reviewer argument is
skipped
"""
self.kwargs.pop('reviewer')
self.assertRaises(TypeError, Review, **self.kwargs)
def test_reviewer_argument_is_None(self):
"""testing if a TypeError will be raised when the reviewer argument is
None
"""
self.kwargs['reviewer'] = None
self.assertRaises(TypeError, Review, **self.kwargs)
def test_reviewer_attribute_is_set_to_None(self):
"""testing if a TypeError will be raised when the reviewer attribute is
set to None
"""
review = Review(**self.kwargs)
self.assertRaises(TypeError, setattr, review, 'reviewer', None)
def test_reviewer_argument_is_not_a_User_instance(self):
"""testing if a TypeError will be raised when the reviewer argument is
not a User instance
"""
self.kwargs['reviewer'] = 'not a user instance'
self.assertRaises(TypeError, Review, **self.kwargs)
def test_reviewer_attribute_is_not_a_User_instance(self):
"""testing if a TypeError will be raised when the reviewer attribute is
set to a value other than a User instance
"""
review = Review(**self.kwargs)
self.assertRaises(TypeError, setattr, review, 'reviewer', 'not a user')
def test_reviewer_argument_is_not_in_Task_responsible_list(self):
"""testing if it is possible to use some other user which is not in the
Task.responsible list as the reviewer
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user2
review = Review(**self.kwargs)
self.assertEqual(review.reviewer, self.user2)
def test_reviewer_attribute_is_not_in_Task_responsible_list(self):
"""testing if it is possible to use some other user which is not in the
Task.responsible list as the reviewer
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
review.reviewer = self.user2
self.assertEqual(review.reviewer, self.user2)
def test_reviewer_argument_is_working_properly(self):
"""testing if the reviewer argument value is correctly passed to
reviewer attribute
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
self.assertEqual(
self.user1,
review.reviewer
)
def test_reviewer_attribute_is_working_properly(self):
"""testing if the reviewer attribute is working properly
"""
self.task1.responsible = [self.user1, self.user2]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
review.reviewer = self.user2
self.assertEqual(
self.user2,
review.reviewer
)
# TODO: add tests for the same user is being the reviewer for all reviews
# at the same level with same task
def test_approve_method_updates_task_status_correctly_for_a_single_responsible_task(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with only one responsible
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
self.assertNotEqual(
self.status_cmpl,
self.task1.status
)
review = Review(**self.kwargs)
review.approve()
self.assertEqual(
self.status_cmpl,
self.task1.status
)
def test_approve_method_updates_task_status_correctly_for_a_multi_responsible_task_when_all_approve(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.approve()
# still pending review
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.approve()
self.assertEqual(
self.status_cmpl,
self.task1.status
)
def test_approve_method_updates_task_parent_status(self):
"""testing if approve method will also update the task parent status
"""
self.task3.status = self.status_rts
now = datetime.datetime.now()
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
self.assertEqual(
self.task3.status, self.status_prev
)
review1 = reviews[0]
review1.approve()
self.assertEqual(
self.task3.status, self.status_cmpl
)
self.assertEqual(
self.task2.status, self.status_cmpl
)
def test_approve_method_updates_task_dependent_statuses(self):
"""testing if approve method will also update the task dependent
statuses
"""
self.task3.status = self.status_rts
now = datetime.datetime.now()
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
self.assertEqual(
self.task3.status, self.status_prev
)
review1 = reviews[0]
review1.approve()
self.assertEqual(
self.task3.status, self.status_cmpl
)
self.assertEqual(
self.task4.status, self.status_rts
)
self.assertEqual(
self.task5.status, self.status_rts
)
self.assertEqual(
self.task6.status, self.status_rts
)
# create time logs for task4 to make it wip
self.task4.create_time_log(
resource=self.task4.resources[0],
start=now + td(hours=1),
end=now + td(hours=2),
)
self.assertEqual(self.task4.status, self.status_wip)
# now request revision to task3
self.task3.request_revision(reviewer=self.task3.responsible[0])
# check statuses of task4 and task4
self.assertEqual(self.task4.status, self.status_drev)
self.assertEqual(self.task5.status, self.status_wfd)
self.assertEqual(self.task6.status, self.status_wfd)
# now approve task3
reviews = self.task3.review_set()
for rev in reviews:
rev.approve()
# check the task statuses again
self.assertEqual(self.task4.status, self.status_hrev)
self.assertEqual(self.task5.status, self.status_rts)
self.assertEqual(self.task5.status, self.status_rts)
def test_approve_method_updates_task_dependent_timings(self):
"""testing if approve method will also update the task dependent
timings for DREV tasks with no effort left
"""
self.task3.status = self.status_rts
now = datetime.datetime.now()
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
self.assertEqual(
self.task3.status, self.status_prev
)
review1 = reviews[0]
review1.approve()
self.assertEqual(
self.task3.status, self.status_cmpl
)
self.assertEqual(
self.task4.status, self.status_rts
)
self.assertEqual(
self.task5.status, self.status_rts
)
self.assertEqual(
self.task6.status, self.status_rts
)
# create time logs for task4 and task5 to make them wip
self.task4.create_time_log(
resource=self.task4.resources[0],
start=now + td(hours=1),
end=now + td(hours=2),
)
self.task5.create_time_log(
resource=self.task5.resources[0],
start=now + td(hours=1),
end=now + td(hours=2),
)
# no time log for task6
self.assertEqual(self.task4.status, self.status_wip)
self.assertEqual(self.task5.status, self.status_wip)
self.assertEqual(self.task6.status, self.status_rts)
# now request revision to task3
self.task3.request_revision(reviewer=self.task3.responsible[0])
# check statuses of task4 and task4
self.assertEqual(self.task4.status, self.status_drev)
self.assertEqual(self.task5.status, self.status_drev)
self.assertEqual(self.task6.status, self.status_wfd)
# TODO: add a new dependent task with schedule_model is not 'effort'
# enter a new time log for task4 to complete its allowed time
self.task4.create_time_log(
resource=self.task4.resources[0],
start=now + td(hours=2),
end=now + td(hours=3),
)
# the task should have not effort left
self.assertEqual(
self.task4.schedule_seconds,
self.task4.total_logged_seconds
)
# task5 should have an extra time
self.assertEqual(
self.task5.schedule_seconds,
self.task5.total_logged_seconds + 3600
)
# task6 should be intact
self.assertEqual(
self.task6.total_logged_seconds,
0
)
# now approve task3
reviews = self.task3.review_set()
for rev in reviews:
rev.approve()
# check the task statuses again
self.assertEqual(self.task4.status, self.status_hrev)
self.assertEqual(self.task5.status, self.status_hrev)
self.assertEqual(self.task6.status, self.status_rts)
# and check if task4 is expanded by the timing resolution
self.assertEqual(
self.task4.schedule_seconds,
self.task4.total_logged_seconds + 3600
)
# and task5 still has 1 hours
self.assertEqual(
self.task4.schedule_seconds,
self.task4.total_logged_seconds + 3600
)
# and task6 intact
self.assertEqual(
self.task6.total_logged_seconds,
0
)
def test_approve_method_updates_task_timings(self):
"""testing if approve method will also update the task timings
"""
self.task3.status = self.status_rts
now = datetime.datetime.now()
td = datetime.timedelta
self.task3.schedule_timing = 2
self.task3.schedule_unit = 'h'
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
self.assertEqual(
self.task3.status, self.status_prev
)
self.assertNotEqual(
self.task3.total_logged_seconds,
self.task3.schedule_seconds
)
review1 = reviews[0]
review1.approve()
self.assertEqual(
self.task3.status, self.status_cmpl
)
self.assertEqual(
self.task3.total_logged_seconds,
self.task3.schedule_seconds
)
def test_approve_method_updates_task_status_correctly_for_a_multi_responsible_task_when_one_approve(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
td = datetime.timedelta
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision()
# one request review should be enough to set the status to hrev,
# note that this is another tests duty to check
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.approve()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_status_correctly_for_a_single_responsible_task(self):
"""testing if the Review.request_revision() method will update the task
status correctly to HREV for a Task with only one responsible
"""
self.task1.responsible = [self.user1]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
review = reviews[0]
review.request_revision()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_status_correctly_for_a_multi_responsible_task_when_one_request_revision(self):
"""testing if the Review.request_revision() method will update the
task status correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.approve()
self.assertEqual(
self.status_prev,
self.task1.status
)
review2.request_revision()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_status_correctly_for_a_multi_responsible_task_when_all_request_revision(self):
"""testing if the Review.request_revision() method will update the
task status correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision()
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.request_revision()
self.assertEqual(
self.status_hrev,
self.task1.status
)
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_when_all_request_revision(self):
"""testing if the Review.request_revision() method will update the task
timing values correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
self.task1.schedule_timing = 3
self.task1.schedule_unit = 'h'
self.assertEqual(
self.status_rts,
self.task1.status
)
dt = datetime.datetime
td = datetime.timedelta
now = dt.now()
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
self.assertEqual(len(reviews), 2)
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
self.assertEqual(
self.status_hrev,
self.task1.status
)
# check the timing values
self.assertEqual(self.task1.schedule_timing, 8)
self.assertEqual(self.task1.schedule_unit, 'h')
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_with_exactly_the_same_amount_of_schedule_timing_as_the_given_revision_timing(self):
"""testing if the Review.request_revision() method will update the task
timing values for a Task with multiple responsible and has the same
amount of schedule timing left with the given revision without
expanding the task more then the total amount of revision requested.
"""
self.task1.responsible = [self.user1, self.user2]
self.task1.schedule_timing = 8
self.task1.schedule_unit = 'h'
self.assertEqual(
self.status_rts,
self.task1.status
)
dt = datetime.datetime
td = datetime.timedelta
now = dt.now()
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
# we should have 7 hours left
# first reviewer requests a revision
reviews = self.task1.request_review()
self.assertEqual(len(reviews), 2)
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
self.assertEqual(
self.status_hrev,
self.task1.status
)
# check the timing values
self.assertEqual(self.task1.schedule_timing, 8)
self.assertEqual(self.task1.schedule_unit, 'h')
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_with_more_schedule_timing_then_given_revision_timing(self):
"""testing if the Review.request_revision() method will update the task
timing values for a Task with multiple responsible and still has more
schedule timing then the given revision without expanding the task more
then the total amount of revision requested.
"""
self.task1.responsible = [self.user1, self.user2]
self.task1.schedule_timing = 100
self.task1.schedule_unit = 'h'
self.assertEqual(
self.status_rts,
self.task1.status
)
dt = datetime.datetime
td = datetime.timedelta
now = dt.now()
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
# we should have 8 hours left
# first reviewer requests a revision
reviews = self.task1.request_review()
self.assertEqual(len(reviews), 2)
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
self.assertEqual(
self.status_prev,
self.task1.status
)
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
self.assertEqual(
self.status_hrev,
self.task1.status
)
# check the timing values
self.assertEqual(self.task1.schedule_timing, 100)
self.assertEqual(self.task1.schedule_unit, 'h')
def test_review_set_property_return_all_the_revision_instances_with_same_review_number(self):
"""testing if review_set property returns all the Review instances of
the same task with the same review_number
"""
self.task1.responsible = [self.user1, self.user2, self.user3]
now = datetime.datetime.now()
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + datetime.timedelta(hours=1)
)
self.task1.status = self.status_wip
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review3 = reviews[2]
self.assertEqual(review1.review_number, 1)
self.assertEqual(review2.review_number, 1)
self.assertEqual(review3.review_number, 1)
review1.approve()
review2.approve()
review3.approve()
review4 = self.task1.request_revision(reviewer=self.user1)
self.task1.status = self.status_wip
self.assertEqual(review4.review_number, 2)
# enter new time log to turn it into WIP
self.task1.create_time_log(
resource=self.user1,
start=now + datetime.timedelta(hours=1),
end=now + datetime.timedelta(hours=2)
)
review_set2 = self.task1.request_review()
review5 = review_set2[0]
review6 = review_set2[1]
review7 = review_set2[2]
self.assertEqual(review5.review_number, 3)
self.assertEqual(review6.review_number, 3)
self.assertEqual(review7.review_number, 3)
class ReviewTestDBCase(UnitTestDBBase):
"""tests the stalker.models.review.Review class
"""
def setUp(self):
"""set up the test
"""
super(ReviewTestDBCase, self).setUp()
from stalker import User
self.user1 = User(
name='Test User 1',
login='******',
email='*****@*****.**',
password='******'
)
from stalker.db.session import DBSession
DBSession.add(self.user1)
self.user2 = User(
name='Test User 2',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user2)
self.user3 = User(
name='Test User 2',
login='******',
email='*****@*****.**',
password='******'
)
DBSession.add(self.user3)
# Review Statuses
from stalker import Status
with DBSession.no_autoflush:
self.status_new = Status.query.filter_by(code='NEW').first()
self.status_rrev = Status.query.filter_by(code='RREV').first()
self.status_app = Status.query.filter_by(code='APP').first()
# Task Statuses
self.status_wfd = Status.query.filter_by(code='WFD').first()
self.status_rts = Status.query.filter_by(code='RTS').first()
self.status_wip = Status.query.filter_by(code='WIP').first()
self.status_prev = Status.query.filter_by(code='PREV').first()
self.status_hrev = Status.query.filter_by(code='HREV').first()
self.status_drev = Status.query.filter_by(code='DREV').first()
self.status_cmpl = Status.query.filter_by(code='CMPL').first()
from stalker import Repository
self.repo = Repository(
name='Test Repository',
linux_path='/mnt/T/',
windows_path='T:/',
osx_path='/Volumes/T/'
)
DBSession.add(self.repo)
from stalker import Structure
self.structure = Structure(
name='Test Project Structure'
)
DBSession.add(self.structure)
from stalker import Project
self.project = Project(
name='Test Project',
code='TP',
repository=self.repo
)
DBSession.add(self.project)
from stalker import Task
self.task1 = Task(
name='Test Task 1',
project=self.project,
resources=[self.user1],
responsible=[self.user2]
)
DBSession.add(self.task1)
self.task2 = Task(
name='Test Task 2',
project=self.project,
responsible=[self.user1]
)
DBSession.add(self.task2)
self.task3 = Task(
name='Test Task 3',
parent=self.task2,
resources=[self.user1]
)
DBSession.add(self.task3)
self.task4 = Task(
name='Test Task 4',
project=self.project,
resources=[self.user1],
depends=[self.task3],
responsible=[self.user2],
schedule_timing=2,
schedule_unit='h'
)
DBSession.add(self.task4)
self.task5 = Task(
name='Test Task 5',
project=self.project,
resources=[self.user2],
depends=[self.task3],
responsible=[self.user2],
schedule_timing=2,
schedule_unit='h'
)
DBSession.add(self.task5)
self.task6 = Task(
name='Test Task 6',
project=self.project,
resources=[self.user3],
depends=[self.task3],
responsible=[self.user2],
schedule_timing=2,
schedule_unit='h'
)
DBSession.add(self.task6)
self.kwargs = {
'task': self.task1,
'reviewer': self.user1
}
# add everything to the db
DBSession.commit()
def test_task_argument_is_not_a_Task_instance(self):
"""testing if a TypeError will be raised when the task argument value
is not a Task instance
"""
self.kwargs['task'] = 'not a Task instance'
with pytest.raises(TypeError) as cm:
Review(**self.kwargs)
assert str(cm.value) == \
'Review.task should be an instance of stalker.models.task.Task, ' \
'not str'
def test_task_argument_is_not_a_leaf_task(self):
"""testing if a ValueError will be raised when the task given in task
argument is not a leaf task
"""
from stalker import Task
task1 = Task(
name='Task1',
project=self.project
)
task2 = Task(
name='Task2',
parent=task1
)
self.kwargs['task'] = task1
with pytest.raises(ValueError) as cm:
Review(**self.kwargs)
assert str(cm.value) == \
'It is only possible to create a review for a leaf tasks, and ' \
'<Task1 (Task)> is not a leaf task.'
def test_task_argument_is_working_properly(self):
"""testing if the task argument value is passed to the task argument
properly
"""
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
assert reviews[0].task == self.task1
def test_auto_name_is_true(self):
"""testing if review instances are named automatically
"""
assert Review.__auto_name__ is True
def test_status_is_new_for_a_newly_created_review_instance(self):
"""testing if the status is NEW for a newly created review instance
"""
review = Review(**self.kwargs)
assert review.status == self.status_new
def test_review_number_attribute_is_a_read_only_attribute(self):
"""testing if the review_number attribute is a read only attribute
"""
review = Review(**self.kwargs)
with pytest.raises(AttributeError) as cm:
review.review_number = 2
assert str(cm.value) == "can't set attribute"
def test_review_number_attribute_is_initialized_to_the_task_review_number_plus_1(self):
"""testing if the review_number attribute is initialized with
task.review_number + 1
"""
review = Review(**self.kwargs)
assert review.review_number == 1
def test_review_number_for_multiple_responsible_task_is_equal_to_each_other(self):
"""testing if the review.review_number attribute for each review
instance created for a task with multiple responsible are equal to each
other
"""
self.task1.responsible = [self.user1, self.user2, self.user3]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
expected_review_number = self.task1.review_number + 1
assert len(reviews) == 3
assert reviews[0].review_number == expected_review_number
assert reviews[1].review_number == expected_review_number
assert reviews[2].review_number == expected_review_number
def test_reviewer_argument_is_skipped(self):
"""testing if a TypeError will be raised when the reviewer argument is
skipped
"""
self.kwargs.pop('reviewer')
with pytest.raises(TypeError) as cm:
Review(**self.kwargs)
assert str(cm.value) == \
'Review.reviewer should be set to a stalker.models.auth.User ' \
'instance, not NoneType'
def test_reviewer_argument_is_None(self):
"""testing if a TypeError will be raised when the reviewer argument is
None
"""
self.kwargs['reviewer'] = None
with pytest.raises(TypeError) as cm:
Review(**self.kwargs)
assert str(cm.value) == \
'Review.reviewer should be set to a stalker.models.auth.User ' \
'instance, not NoneType'
def test_reviewer_attribute_is_set_to_None(self):
"""testing if a TypeError will be raised when the reviewer attribute is
set to None
"""
review = Review(**self.kwargs)
with pytest.raises(TypeError) as cm:
review.reviewer = None
assert str(cm.value) == \
'Review.reviewer should be set to a stalker.models.auth.User ' \
'instance, not NoneType'
def test_reviewer_argument_is_not_a_User_instance(self):
"""testing if a TypeError will be raised when the reviewer argument is
not a User instance
"""
self.kwargs['reviewer'] = 'not a user instance'
with pytest.raises(TypeError) as cm:
Review(**self.kwargs)
assert str(cm.value) == \
'Review.reviewer should be set to a stalker.models.auth.User ' \
'instance, not str'
def test_reviewer_attribute_is_not_a_User_instance(self):
"""testing if a TypeError will be raised when the reviewer attribute is
set to a value other than a User instance
"""
review = Review(**self.kwargs)
with pytest.raises(TypeError) as cm:
review.reviewer = 'not a user'
assert str(cm.value) == \
'Review.reviewer should be set to a stalker.models.auth.User ' \
'instance, not str'
def test_reviewer_argument_is_not_in_Task_responsible_list(self):
"""testing if it is possible to use some other user which is not in the
Task.responsible list as the reviewer
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user2
review = Review(**self.kwargs)
assert review.reviewer == self.user2
def test_reviewer_attribute_is_not_in_Task_responsible_list(self):
"""testing if it is possible to use some other user which is not in the
Task.responsible list as the reviewer
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
review.reviewer = self.user2
assert review.reviewer == self.user2
def test_reviewer_argument_is_working_properly(self):
"""testing if the reviewer argument value is correctly passed to
reviewer attribute
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
assert review.reviewer == self.user1
def test_reviewer_attribute_is_working_properly(self):
"""testing if the reviewer attribute is working properly
"""
self.task1.responsible = [self.user1, self.user2]
self.kwargs['reviewer'] = self.user1
review = Review(**self.kwargs)
review.reviewer = self.user2
assert review.reviewer == self.user2
# TODO: add tests for the same user is being the reviewer for all reviews
# at the same level with same task
def test_approve_method_updates_task_status_correctly_for_a_single_responsible_task(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with only one responsible
"""
self.task1.responsible = [self.user1]
self.kwargs['reviewer'] = self.user1
assert self.task1.status != self.status_cmpl
review = Review(**self.kwargs)
review.approve()
assert self.task1.status == self.status_cmpl
def test_approve_method_updates_task_status_correctly_for_a_multi_responsible_task_when_all_approve(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.approve()
# still pending review
assert self.task1.status == self.status_prev
# first reviewer
review2.approve()
assert self.task1.status == self.status_cmpl
def test_approve_method_updates_task_parent_status(self):
"""testing if approve method will also update the task parent status
"""
self.task3.status = self.status_rts
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
assert self.task3.status == self.status_prev
review1 = reviews[0]
review1.approve()
assert self.task3.status == self.status_cmpl
assert self.task2.status == self.status_cmpl
def test_approve_method_updates_task_dependent_statuses(self):
"""testing if approve method will also update the task dependent
statuses
"""
self.task3.status = self.status_rts
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
assert self.task3.status == self.status_prev
review1 = reviews[0]
review1.approve()
assert self.task3.status == self.status_cmpl
assert self.task4.status == self.status_rts
assert self.task5.status == self.status_rts
assert self.task6.status == self.status_rts
# create time logs for task4 to make it wip
self.task4.create_time_log(
resource=self.task4.resources[0],
start=now + td(hours=1),
end=now + td(hours=2),
)
assert self.task4.status == self.status_wip
# now request revision to task3
self.task3.request_revision(reviewer=self.task3.responsible[0])
# check statuses of task4 and task4
assert self.task4.status == self.status_drev
assert self.task5.status == self.status_wfd
assert self.task6.status == self.status_wfd
# now approve task3
reviews = self.task3.review_set()
for rev in reviews:
rev.approve()
# check the task statuses again
assert self.task4.status == self.status_hrev
assert self.task5.status == self.status_rts
assert self.task5.status == self.status_rts
def test_approve_method_updates_task_dependent_timings(self):
"""testing if approve method will also update the task dependent
timings for DREV tasks with no effort left
"""
self.task3.status = self.status_rts
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
td = datetime.timedelta
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
assert self.task3.status == self.status_prev
review1 = reviews[0]
review1.approve()
assert self.task3.status == self.status_cmpl
assert self.task4.status == self.status_rts
assert self.task5.status == self.status_rts
assert self.task6.status == self.status_rts
# create time logs for task4 and task5 to make them wip
self.task4.create_time_log(
resource=self.task4.resources[0],
start=now + td(hours=1),
end=now + td(hours=2),
)
self.task5.create_time_log(
resource=self.task5.resources[0],
start=now + td(hours=1),
end=now + td(hours=2),
)
# no time log for task6
assert self.task4.status == self.status_wip
assert self.task5.status == self.status_wip
assert self.task6.status == self.status_rts
# now request revision to task3
self.task3.request_revision(reviewer=self.task3.responsible[0])
# check statuses of task4 and task4
assert self.task4.status == self.status_drev
assert self.task5.status == self.status_drev
assert self.task6.status == self.status_wfd
# TODO: add a new dependent task with schedule_model is not 'effort'
# enter a new time log for task4 to complete its allowed time
self.task4.create_time_log(
resource=self.task4.resources[0],
start=now + td(hours=2),
end=now + td(hours=3),
)
from stalker.db.session import DBSession
DBSession.commit()
# the task should have not effort left
assert self.task4.schedule_seconds == self.task4.total_logged_seconds
# task5 should have an extra time
assert self.task5.schedule_seconds == \
self.task5.total_logged_seconds + 3600
# task6 should be intact
assert self.task6.total_logged_seconds == 0
# now approve task3
reviews = self.task3.review_set()
for rev in reviews:
rev.approve()
DBSession.commit()
# check the task statuses again
assert self.task4.status == self.status_hrev
assert self.task5.status == self.status_hrev
assert self.task6.status == self.status_rts
# and check if task4 is expanded by the timing resolution
assert self.task4.schedule_seconds == \
self.task4.total_logged_seconds + 3600
# and task5 still has 1 hours
assert self.task4.schedule_seconds == \
self.task4.total_logged_seconds + 3600
# and task6 intact
assert self.task6.total_logged_seconds == 0
def test_approve_method_updates_task_timings(self):
"""testing if approve method will also update the task timings
"""
self.task3.status = self.status_rts
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
td = datetime.timedelta
self.task3.schedule_timing = 2
self.task3.schedule_unit = 'h'
self.task3.create_time_log(
resource=self.task3.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task3.request_review()
assert self.task3.status == self.status_prev
assert self.task3.total_logged_seconds != self.task3.schedule_seconds
review1 = reviews[0]
review1.approve()
assert self.task3.status == self.status_cmpl
assert self.task3.total_logged_seconds == self.task3.schedule_seconds
def test_approve_method_updates_task_status_correctly_for_a_multi_responsible_task_when_one_approve(self):
"""testing if the Review.approve() method will update the task status
correctly for a task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
td = datetime.timedelta
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + td(hours=1)
)
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision()
# one request review should be enough to set the status to hrev,
# note that this is another tests duty to check
assert self.task1.status == self.status_prev
# first reviewer
review2.approve()
assert self.task1.status == self.status_hrev
def test_request_revision_method_updates_task_status_correctly_for_a_single_responsible_task(self):
"""testing if the Review.request_revision() method will update the task
status correctly to HREV for a Task with only one responsible
"""
self.task1.responsible = [self.user1]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
reviews = self.task1.request_review()
review = reviews[0]
review.request_revision()
assert self.task1.status == self.status_hrev
def test_request_revision_method_updates_task_status_correctly_for_a_multi_responsible_task_when_one_request_revision(self):
"""testing if the Review.request_revision() method will update the
task status correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.approve()
assert self.task1.status == self.status_prev
review2.request_revision()
assert self.task1.status == self.status_hrev
def test_request_revision_method_updates_task_status_correctly_for_a_multi_responsible_task_when_all_request_revision(self):
"""testing if the Review.request_revision() method will update the
task status correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.task1.resources[0],
start=now,
end=now + datetime.timedelta(hours=1)
)
# first reviewer requests a revision
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision()
assert self.task1.status == self.status_prev
# first reviewer
review2.request_revision()
assert self.task1.status == self.status_hrev
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_when_all_request_revision(self):
"""testing if the Review.request_revision() method will update the task
timing values correctly for a Task with multiple responsible
"""
self.task1.responsible = [self.user1, self.user2]
self.task1.schedule_timing = 3
self.task1.schedule_unit = 'h'
assert self.task1.status == self.status_rts
import datetime
dt = datetime.datetime
td = datetime.timedelta
import pytz
now = dt.now(pytz.utc)
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
from stalker.db.session import DBSession
DBSession.commit()
# first reviewer requests a revision
reviews = self.task1.request_review()
assert len(reviews) == 2
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
assert self.task1.status == self.status_prev
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
assert self.task1.status == self.status_hrev
# check the timing values
assert self.task1.schedule_timing == 8
assert self.task1.schedule_unit == 'h'
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_with_exactly_the_same_amount_of_schedule_timing_as_the_given_revision_timing(self):
"""testing if the Review.request_revision() method will update the task
timing values for a Task with multiple responsible and has the same
amount of schedule timing left with the given revision without
expanding the task more then the total amount of revision requested.
"""
self.task1.responsible = [self.user1, self.user2]
self.task1.schedule_timing = 8
self.task1.schedule_unit = 'h'
assert self.task1.status == self.status_rts
import datetime
dt = datetime.datetime
td = datetime.timedelta
import pytz
now = dt.now(pytz.utc)
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
# we should have 7 hours left
# first reviewer requests a revision
reviews = self.task1.request_review()
assert len(reviews) == 2
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
assert self.task1.status == self.status_prev
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
assert self.task1.status == self.status_hrev
# check the timing values
assert self.task1.schedule_timing == 8
assert self.task1.schedule_unit == 'h'
def test_request_revision_method_updates_task_timing_correctly_for_a_multi_responsible_task_with_more_schedule_timing_then_given_revision_timing(self):
"""testing if the Review.request_revision() method will update the task
timing values for a Task with multiple responsible and still has more
schedule timing then the given revision without expanding the task more
then the total amount of revision requested.
"""
self.task1.responsible = [self.user1, self.user2]
self.task1.schedule_timing = 100
self.task1.schedule_unit = 'h'
assert self.task1.status == self.status_rts
import datetime
dt = datetime.datetime
td = datetime.timedelta
import pytz
now = dt.now(pytz.utc)
# create 1 hour time log
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + td(hours=1)
)
# we should have 8 hours left
# first reviewer requests a revision
reviews = self.task1.request_review()
assert len(reviews) == 2
review1 = reviews[0]
review2 = reviews[1]
review1.request_revision(
schedule_timing=2,
schedule_unit='h',
description='do some 2 hours extra work'
)
assert self.task1.status == self.status_prev
# first reviewer
review2.request_revision(
schedule_timing=5,
schedule_unit='h',
description='do some 5 hours extra work'
)
assert self.task1.status == self.status_hrev
# check the timing values
assert self.task1.schedule_timing == 100
assert self.task1.schedule_unit == 'h'
def test_review_set_property_return_all_the_revision_instances_with_same_review_number(self):
"""testing if review_set property returns all the Review instances of
the same task with the same review_number
"""
self.task1.responsible = [self.user1, self.user2, self.user3]
import datetime
import pytz
now = datetime.datetime.now(pytz.utc)
self.task1.create_time_log(
resource=self.user1,
start=now,
end=now + datetime.timedelta(hours=1)
)
self.task1.status = self.status_wip
reviews = self.task1.request_review()
review1 = reviews[0]
review2 = reviews[1]
review3 = reviews[2]
assert review1.review_number == 1
assert review2.review_number == 1
assert review3.review_number == 1
review1.approve()
review2.approve()
review3.approve()
review4 = self.task1.request_revision(reviewer=self.user1)
self.task1.status = self.status_wip
assert review4.review_number == 2
# enter new time log to turn it into WIP
self.task1.create_time_log(
resource=self.user1,
start=now + datetime.timedelta(hours=1),
end=now + datetime.timedelta(hours=2)
)
review_set2 = self.task1.request_review()
review5 = review_set2[0]
review6 = review_set2[1]
review7 = review_set2[2]
assert review5.review_number == 3
assert review6.review_number == 3
assert review7.review_number == 3
