def test_stable_versions(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/to_add',
'verbose_name': 'to_add',
},
]
tags_data = [
{
'identifier': '0.9',
'verbose_name': '0.9',
},
{
'identifier': '0.8',
'verbose_name': '0.8',
},
]
self.assertRaises(
Version.DoesNotExist,
Version.objects.get,
slug=STABLE,
)
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '0.9')
def test_pre_release_are_not_stable(self):
tags_data = [
{
'identifier': '1.0a1',
'verbose_name': '1.0a1'
},
{
'identifier': '0.9',
'verbose_name': '0.9'
},
{
'identifier': '0.9b1',
'verbose_name': '0.9b1'
},
{
'identifier': '0.8',
'verbose_name': '0.8'
},
{
'identifier': '0.8rc2',
'verbose_name': '0.8rc2'
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '0.9')
def test_stable_version_same_id_tag_branch(self):
branches_data = [
# old 1.0 development branch
{
'identifier': 'origin/1.0',
'verbose_name': '1.0'
},
]
tags_data = [
# tagged 1.0 final version
{
'identifier': '1.0',
'verbose_name': '1.0'
},
{
'identifier': '0.9',
'verbose_name': '0.9'
},
]
self.pip.update_stable_version()
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0')
self.assertEqual(version_stable.type, 'tag')
def test_proper_url_no_slash(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/to_add',
'verbose_name': 'to_add',
},
]
self.assertEqual(
set(self.pip.versions.all().values_list('slug', flat=True)),
{'master', 'latest', 'stable', '0.8.1', '0.8', 'to_delete'},
)
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
self.assertEqual(
set(self.pip.versions.all().values_list('slug', flat=True)),
{'master', 'latest', 'stable', '0.8.1', '0.8', 'to_add'},
)
def test_automation_rule_activate_version(self):
tags_data = [
{
'identifier': 'new_tag',
'verbose_name': 'new_tag',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
RegexAutomationRule.objects.create(
project=self.pip,
priority=0,
match_arg=r'^new_tag$',
action=VersionAutomationRule.ACTIVATE_VERSION_ACTION,
version_type=TAG,
)
self.assertFalse(
self.pip.versions.filter(verbose_name='new_tag').exists())
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
new_tag = self.pip.versions.get(verbose_name='new_tag')
self.assertTrue(new_tag.active)
def test_automation_rule_dont_delete_default_version(self):
tags_data = [
{
'identifier': 'new_tag',
'verbose_name': 'new_tag',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
version_slug = '0.8'
RegexAutomationRule.objects.create(
project=self.pip,
priority=0,
match_arg=r'^0\.8$',
action=VersionAutomationRule.DELETE_VERSION_ACTION,
version_type=TAG,
)
version = self.pip.versions.get(slug=version_slug)
self.assertTrue(version.active)
self.pip.default_version = version_slug
self.pip.save()
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
self.assertTrue(self.pip.versions.filter(slug=version_slug).exists())
def test_automation_rule_set_default_version(self):
tags_data = [
{
'identifier': 'new_tag',
'verbose_name': 'new_tag',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
RegexAutomationRule.objects.create(
project=self.pip,
priority=0,
match_arg=r'^new_tag$',
action=VersionAutomationRule.SET_DEFAULT_VERSION_ACTION,
version_type=TAG,
)
self.assertEqual(self.pip.get_default_version(), LATEST)
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
self.pip.refresh_from_db()
self.assertEqual(self.pip.get_default_version(), 'new_tag')
def test_machine_attr_when_user_define_latest_tag_and_delete_it(self):
"""The user creates a tag named ``latest`` on an existing repo, when
syncing the versions, the RTD's ``latest`` is lost (set to
machine=False) and doesn't update automatically anymore, when the tag is
deleted on the user repository, the RTD's ``latest`` is back (set to
machine=True)."""
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
# User new stable
{
'identifier': '1abc2def3',
'verbose_name': 'latest',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# The tag is the new latest
version_latest = self.pip.versions.get(slug='latest')
self.assertEqual(
'1abc2def3',
version_latest.identifier,
)
# Deleting the tag should return the RTD's latest
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
# The latest isn't stuck with the previous commit
version_latest = self.pip.versions.get(slug='latest')
self.assertEqual(
'master',
version_latest.identifier,
)
self.assertTrue(version_latest.machine)
def test_user_defined_latest_version_tag(self):
# TODO: the ``latest`` versions are created
# as a BRANCH, then here we will have a
# ``latest_a`` version.
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
# A new user-defined latest tag
{
'identifier': '1abc2def3',
'verbose_name': 'latest',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# Did update to user-defined latest version
version_latest = self.pip.versions.get(slug='latest')
self.assertFalse(version_latest.machine)
self.assertTrue(version_latest.active)
self.assertEqual(
'1abc2def3',
version_latest.identifier,
)
# There aren't others latest slugs like latest_a
other_latest = self.pip.versions.filter(slug__startswith='latest_', )
self.assertFalse(other_latest.exists())
# Check that syncing again doesn't change anything from current state.
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_latest = self.pip.versions.get(slug='latest')
self.assertFalse(version_latest.machine)
self.assertTrue(version_latest.active)
self.assertEqual(
'1abc2def3',
version_latest.identifier,
)
other_latest = self.pip.versions.filter(slug__startswith='latest_', )
self.assertFalse(other_latest.exists())
def test_unicode(self):
tags_data = [
{
'identifier': 'foo-£',
'verbose_name': 'foo-£'
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
def test_stable_version_tags_over_branches(self):
branches_data = [
# 2.0 development
{
'identifier': 'origin/2.0',
'verbose_name': '2.0'
},
{
'identifier': 'origin/0.9.1rc1',
'verbose_name': '0.9.1rc1'
},
]
tags_data = [
{
'identifier': '1.0rc1',
'verbose_name': '1.0rc1'
},
{
'identifier': '0.9',
'verbose_name': '0.9'
},
]
self.pip.update_stable_version()
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# If there is a branch with a higher version, tags takes preferences
# over the branches to select the stable version
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '0.9')
tags_data.append({
'identifier': '1.0',
'verbose_name': '1.0',
})
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0')
def test_user_defined_latest_version_branch(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
# A new user-defined latest branch
{
'identifier': 'origin/latest',
'verbose_name': 'latest',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
# Did update to user-defined latest version
version_latest = self.pip.versions.get(slug='latest')
self.assertFalse(version_latest.machine)
self.assertTrue(version_latest.active)
self.assertEqual(
'origin/latest',
version_latest.identifier,
)
# There aren't others latest slugs like latest_a
other_latest = self.pip.versions.filter(slug__startswith='latest_', )
self.assertFalse(other_latest.exists())
# Check that posting again doesn't change anything from current state.
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
version_latest = self.pip.versions.get(slug='latest')
self.assertFalse(version_latest.machine)
self.assertTrue(version_latest.active)
self.assertEqual(
'origin/latest',
version_latest.identifier,
)
other_latest = self.pip.versions.filter(slug__startswith='latest_', )
self.assertFalse(other_latest.exists())
def test_new_tag_dont_update_inactive(self):
Version.objects.create(
project=self.pip,
identifier='0.8.3',
verbose_name='0.8.3',
type=TAG,
active=False,
)
self.pip.update_stable_version()
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/to_add',
'verbose_name': 'to_add',
},
]
tags_data = [
{
'identifier': '0.9',
'verbose_name': '0.9',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# Version 0.9 becomes the stable version, but it's inactive
version_9 = self.pip.versions.get(slug='0.9')
self.assertEqual(
version_9.identifier,
self.pip.get_stable_version().identifier,
)
self.assertFalse(version_9.active)
# Version 0.8.3 is still inactive
version_8 = Version.objects.get(slug='0.8.3')
self.assertFalse(version_8.active)
def test_new_tag_update_active(self):
Version.objects.create(
project=self.pip,
identifier='0.8.3',
verbose_name='0.8.3',
active=True,
)
self.pip.update_stable_version()
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/to_add',
'verbose_name': 'to_add',
},
]
tags_data = [
{
'identifier': '0.9',
'verbose_name': '0.9',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_9 = Version.objects.get(slug='0.9')
self.assertTrue(version_9.active)
# Version 0.9 becomes the stable version
self.assertEqual(
version_9.identifier,
self.pip.get_stable_version().identifier,
)
def test_update_inactive_stable_version(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
{
'identifier': '0.9',
'verbose_name': '0.9',
},
]
self.pip.update_stable_version()
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertEqual(version_stable.identifier, '0.9')
version_stable.active = False
version_stable.save()
tags_data.append({
'identifier': '1.0.0',
'verbose_name': '1.0.0',
})
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# The identifier of stable is updated
# but the version is still not active
version_stable = Version.objects.get(slug=STABLE)
self.assertFalse(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0.0')
def test_post_releases_are_stable(self):
tags_data = [
{
'identifier': '1.0',
'verbose_name': '1.0'
},
{
'identifier': '1.0.post1',
'verbose_name': '1.0.post1'
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0.post1')
def test_automation_rules_are_triggered_for_new_versions(
self, run_automation_rules):
Version.objects.create(
project=self.pip,
identifier='0.8.3',
verbose_name='0.8.3',
active=True,
type=TAG,
)
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/new_branch',
'verbose_name': 'new_branch',
},
]
tags_data = [
{
'identifier': 'new_tag',
'verbose_name': 'new_tag',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
run_automation_rules.assert_called_with(
self.pip,
{'new_branch', 'new_tag'},
{'0.8', '0.8.1'},
)
def test_delete_version(self):
Version.objects.create(
project=self.pip,
identifier='0.8.3',
verbose_name='0.8.3',
active=False,
)
Version.objects.create(
project=self.pip,
identifier='external',
verbose_name='external',
type=EXTERNAL,
active=False,
)
self.pip.update_stable_version()
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
self.assertTrue(Version.objects.filter(slug='0.8.3').exists(), )
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
# There isn't a v0.8.3
self.assertFalse(Version.objects.filter(slug='0.8.3').exists(), )
# The inactive external version isn't deleted
self.assertTrue(Version.objects.filter(slug='external').exists(), )
def test_invalid_version_numbers_are_not_stable(self):
self.pip.versions.all().delete()
tags_data = [
{
'identifier': 'this.is.invalid',
'verbose_name': 'this.is.invalid',
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
self.assertFalse(Version.objects.filter(slug=STABLE).exists())
tags_data = [
{
'identifier': '1.0',
'verbose_name': '1.0',
},
{
'identifier': 'this.is.invalid',
'verbose_name': 'this.is.invalid',
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
version_stable = Version.objects.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0')
def test_proper_url_no_slash(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/to_add',
'verbose_name': 'to_add',
},
]
added_versions, deleted_versions = sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
self.assertEqual(deleted_versions, ['to_delete'])
self.assertEqual(added_versions, ['to_add'])
def sync_versions(self, request, **kwargs): # noqa
"""
Sync the version data in the repo (on the build server).
Version data in the repo is synced with what we have in the database.
:returns: the identifiers for the versions that have been deleted.
.. note::
This endpoint is deprecated in favor of `sync_versions_task`.
"""
project = get_object_or_404(
Project.objects.api(request.user),
pk=kwargs['pk'],
)
added_versions = []
deleted_versions = []
try:
data = request.data
# Calling the task synchronically to keep backward compatibility
added_versions, deleted_versions = sync_versions_task(
project_pk=project.pk,
tags_data=data.get('tags', []),
branches_data=data.get('branches', []),
)
except Exception as e:
log.exception('Sync Versions Error')
return Response(
{
'error': str(e),
},
status=status.HTTP_400_BAD_REQUEST,
)
return Response({
'added_versions': added_versions,
'deleted_versions': deleted_versions,
})
def test_user_defined_stable_version_branch_with_tags(self):
Version.objects.create(
project=self.pip,
identifier='0.8.3',
verbose_name='0.8.3',
active=True,
)
# A pre-existing active stable branch that was machine created
Version.objects.create(
project=self.pip,
identifier='foo',
type=BRANCH,
verbose_name='stable',
active=True,
machine=True,
)
self.pip.update_stable_version()
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
# A new user-defined stable branch
{
'identifier': 'origin/stable',
'verbose_name': 'stable',
},
]
tags_data = [
{
'identifier': '0.9',
'verbose_name': '0.9',
},
{
'identifier': '0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# Didn't update to newest tag
version_9 = self.pip.versions.get(slug='0.9')
self.assertFalse(version_9.active)
# Did update to user-defined stable version
version_stable = self.pip.versions.get(slug='stable')
self.assertFalse(version_stable.machine)
self.assertTrue(version_stable.active)
self.assertEqual(
'origin/stable',
self.pip.get_stable_version().identifier,
)
# There aren't others stable slugs like stable_a
other_stable = self.pip.versions.filter(slug__startswith='stable_', )
self.assertFalse(other_stable.exists())
# Check that syncing again doesn't change anything from current state.
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_stable = self.pip.versions.get(slug='stable')
self.assertFalse(version_stable.machine)
self.assertTrue(version_stable.active)
self.assertEqual(
'origin/stable',
self.pip.get_stable_version().identifier,
)
other_stable = self.pip.versions.filter(slug__startswith='stable_', )
self.assertFalse(other_stable.exists())
def test_machine_attr_when_user_define_stable_branch_and_delete_it(self):
"""
The user creates a branch named ``stable`` on an existing repo,
when syncing the versions, the RTD's ``stable`` is lost
(set to machine=False) and doesn't update automatically anymore,
when the branch is deleted on the user repository, the RTD's ``stable``
is back (set to machine=True).
"""
# Project with just branches
self.pip.versions.filter(type=TAG).delete()
Version.objects.create(
project=self.pip,
identifier='0.8.3',
verbose_name='0.8.3',
type=BRANCH,
active=False,
machine=False,
)
self.pip.update_stable_version()
current_stable = self.pip.get_stable_version()
# 0.8.3 is the current stable
self.assertEqual(
'0.8.3',
current_stable.identifier,
)
self.assertTrue(current_stable.machine)
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
# User new stable
{
'identifier': 'origin/stable',
'verbose_name': 'stable',
},
{
'identifier': 'origin/0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
current_stable = self.pip.get_stable_version()
self.assertEqual(
'origin/stable',
current_stable.identifier,
)
# Deleting the branch should return the RTD's stable
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
# The version 8 should be the new stable.
# The stable isn't stuck with the previous branch
current_stable = self.pip.get_stable_version()
self.assertEqual(
'origin/0.8.3',
current_stable.identifier,
)
self.assertTrue(current_stable.machine)
def test_machine_attr_when_user_define_stable_branch_and_delete_it_new_project(
self):
"""The user imports a new project with a branch named ``stable``, when
syncing the versions, the RTD's ``stable`` is lost (set to
machine=False) and doesn't update automatically anymore, when the branch
is deleted on the user repository, the RTD's ``stable`` is back (set to
machine=True)."""
# There isn't a stable version yet
self.pip.versions.exclude(slug='master').delete()
current_stable = self.pip.get_stable_version()
self.assertIsNone(current_stable)
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
# User stable
{
'identifier': 'origin/stable',
'verbose_name': 'stable',
},
{
'identifier': 'origin/0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
current_stable = self.pip.get_stable_version()
self.assertEqual(
'origin/stable',
current_stable.identifier,
)
# User activates the stable version
current_stable.active = True
current_stable.save()
# Deleting the branch should return the RTD's stable
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
{
'identifier': 'origin/0.8.3',
'verbose_name': '0.8.3',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=[],
)
# The version 8 should be the new stable.
# The stable isn't stuck with the previous commit
current_stable = self.pip.get_stable_version()
self.assertEqual(
'origin/0.8.3',
current_stable.identifier,
)
self.assertTrue(current_stable.machine)
def test_update_stable_version(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
{
'identifier': '0.9',
'verbose_name': '0.9',
},
{
'identifier': '0.8',
'verbose_name': '0.8',
},
]
self.pip.update_stable_version()
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
version_stable = self.pip.versions.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '0.9')
tags_data = [
{
'identifier': '1.0.0',
'verbose_name': '1.0.0',
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
version_stable = self.pip.versions.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0.0')
tags_data = [
{
'identifier': '0.7',
'verbose_name': '0.7',
},
]
sync_versions_task(
self.pip.pk,
branches_data=[],
tags_data=tags_data,
)
version_stable = self.pip.versions.get(slug=STABLE)
self.assertTrue(version_stable.active)
self.assertEqual(version_stable.identifier, '1.0.0')
def test_deletes_version_with_same_identifier(self):
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
{
'identifier': '1234',
'verbose_name': 'one',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# We only have one version with an identifier `1234`
self.assertEqual(
self.pip.versions.filter(identifier='1234').count(),
1,
)
# We add a new tag with the same identifier
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
{
'identifier': '1234',
'verbose_name': 'two',
},
{
'identifier': '1234',
'verbose_name': 'one',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# We have two versions with an identifier `1234`
self.assertEqual(
self.pip.versions.filter(identifier='1234').count(),
2,
)
# We delete one version with identifier `1234`
branches_data = [
{
'identifier': 'origin/master',
'verbose_name': 'master',
},
]
tags_data = [
{
'identifier': '1234',
'verbose_name': 'one',
},
]
sync_versions_task(
self.pip.pk,
branches_data=branches_data,
tags_data=tags_data,
)
# We have only one version with an identifier `1234`
self.assertEqual(
self.pip.versions.filter(identifier='1234').count(),
1,
)
