def test_update_hypervisor_features(make_mock_vm):
"""
Test changing the hypervisor features of a guest
"""
xml_def = """
<domain type="kvm">
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>linux</type>
<kernel>/usr/lib/grub2/x86_64-xen/grub.xen</kernel>
</os>
<features>
<kvm>
<hint-dedicated state="on"/>
</kvm>
</features>
<on_reboot>restart</on_reboot>
</domain>
"""
domain_mock = make_mock_vm(xml_def)
# Update with no change to the features
ret = virt.update("my_vm",
hypervisor_features={"kvm-hint-dedicated": True})
assert not ret["definition"]
# Alter the features
ret = virt.update("my_vm",
hypervisor_features={"kvm-hint-dedicated": False})
assert ret["definition"]
setxml = ET.fromstring(virt.libvirt.openAuth().defineXML.call_args[0][0])
assert "off" == setxml.find("features/kvm/hint-dedicated").get("state")
# Add the features
xml_def = """
<domain type="kvm">
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>linux</type>
<kernel>/usr/lib/grub2/x86_64-xen/grub.xen</kernel>
</os>
</domain>
"""
domain_mock = make_mock_vm(xml_def)
ret = virt.update("my_vm",
hypervisor_features={"kvm-hint-dedicated": True})
assert ret["definition"]
setxml = ET.fromstring(virt.libvirt.openAuth().defineXML.call_args[0][0])
assert "on" == setxml.find("features/kvm/hint-dedicated").get("state")
def test_update_approx_mem(make_mock_vm):
"""
test virt.update with memory parameter unchanged thought not exactly equals to the current value.
This may happen since libvirt sometimes rounds the memory value.
"""
xml_def = """
<domain type="kvm">
<name>my_vm</name>
<memory unit='KiB'>3177680</memory>
<currentMemory unit='KiB'>3177680</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>hvm</type>
</os>
<on_reboot>restart</on_reboot>
</domain>
"""
domain_mock = make_mock_vm(xml_def)
ret = virt.update("my_vm",
mem={
"boot": "3253941043B",
"current": "3253941043B"
})
assert not ret["definition"]
def test_update_xen_disk_volumes(make_mock_vm, make_mock_storage_pool):
xml_def = """
<domain type='xen'>
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>linux</type>
<kernel>/usr/lib/grub2/x86_64-xen/grub.xen</kernel>
</os>
<devices>
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none' io='native'/>
<source file='/path/to/default/vm03_system'/>
<target dev='xvda' bus='xen'/>
</disk>
<disk type='block' device='disk'>
<driver name='qemu' type='raw' cache='none' io='native'/>
<source dev='/path/to/my-iscsi/unit:0:0:1'/>
<target dev='xvdb' bus='xen'/>
</disk>
<controller type='xenbus' index='0'/>
</devices>
</domain>"""
domain_mock = make_mock_vm(xml_def)
make_mock_storage_pool("default", "dir", ["my_vm_system"])
make_mock_storage_pool("my-iscsi", "iscsi", ["unit:0:0:1"])
make_mock_storage_pool("vdb", "disk", ["vdb1"])
ret = virt.update(
"my_vm",
disks=[
{
"name": "system",
"pool": "default"
},
{
"name": "iscsi-data",
"pool": "my-iscsi",
"source_file": "unit:0:0:1"
},
{
"name": "vdb-data",
"pool": "vdb",
"source_file": "vdb1"
},
],
)
assert ret["definition"]
define_mock = virt.libvirt.openAuth().defineXML
setxml = ET.fromstring(define_mock.call_args[0][0])
assert "block" == setxml.find(".//disk[3]").get("type")
assert "/path/to/vdb/vdb1" == setxml.find(".//disk[3]/source").get("dev")
def test_update_stop_on_reboot(make_mock_vm):
"""
Test virt.update to add the on_reboot=destroy flag
"""
xml_def = """
<domain type='kvm'>
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>hvm</type>
</os>
</domain>"""
domain_mock = make_mock_vm(xml_def)
ret = virt.update("my_vm", stop_on_reboot=True)
assert ret["definition"]
define_mock = virt.libvirt.openAuth().defineXML
setxml = ET.fromstring(define_mock.call_args[0][0])
assert "destroy" == setxml.find("./on_reboot").text
def test_update_clock(make_mock_vm):
"""
test virt.update with clock parameter
"""
xml_def = """
<domain type="kvm">
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>linux</type>
<kernel>/usr/lib/grub2/x86_64-xen/grub.xen</kernel>
</os>
<clock offset="localtime" adjustment="-3600">
<timer name="tsc" frequency="3504000000" mode="native" />
<timer name="kvmclock" present="no" />
</clock>
<on_reboot>restart</on_reboot>
</domain>
"""
domain_mock = make_mock_vm(xml_def)
# Update with no change to the features
ret = virt.update(
"my_vm",
clock={
"utc": False,
"adjustment": -3600,
"timers": {
"tsc": {
"frequency": 3504000000,
"mode": "native"
},
"kvmclock": {
"present": False
},
},
},
)
assert not ret["definition"]
# Update
ret = virt.update(
"my_vm",
clock={
"timezone": "CEST",
"timers": {
"rtc": {
"track": "wall",
"tickpolicy": "catchup",
"slew": 4636,
"threshold": 123,
"limit": 2342,
},
"hpet": {
"present": True
},
},
},
)
assert ret["definition"]
setxml = ET.fromstring(virt.libvirt.openAuth().defineXML.call_args[0][0])
assert "timezone" == setxml.find("clock").get("offset")
assert "CEST" == setxml.find("clock").get("timezone")
assert {"rtc",
"hpet"} == {t.get("name")
for t in setxml.findall("clock/timer")}
assert "catchup" == setxml.find("clock/timer[@name='rtc']").get(
"tickpolicy")
assert "wall" == setxml.find("clock/timer[@name='rtc']").get("track")
assert {
"slew": "4636",
"threshold": "123",
"limit": "2342"
} == setxml.find("clock/timer[@name='rtc']/catchup").attrib
assert "yes" == setxml.find("clock/timer[@name='hpet']").get("present")
# Revert to UTC
ret = virt.update("my_vm",
clock={
"utc": True,
"adjustment": None,
"timers": None
})
assert ret["definition"]
setxml = ET.fromstring(virt.libvirt.openAuth().defineXML.call_args[0][0])
assert {"offset": "utc"} == setxml.find("clock").attrib
assert setxml.find("clock/timer") is None
def test_update_hostdev_changes(running, live, make_mock_device, make_mock_vm,
test):
"""
Test the virt.update function with host device changes
"""
xml_def = """
<domain type='kvm'>
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>hvm</type>
</os>
<on_reboot>restart</on_reboot>
<devices>
<hostdev mode='subsystem' type='pci' managed='yes'>
<source>
<address domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
</source>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</hostdev>
</devices>
</domain>"""
domain_mock = make_mock_vm(xml_def, running)
make_mock_device("""
<device>
<name>usb_3_1_3</name>
<path>/sys/devices/pci0000:00/0000:00:1d.6/0000:06:00.0/0000:07:02.0/0000:3e:00.0/usb3/3-1/3-1.3</path>
<devnode type='dev'>/dev/bus/usb/003/004</devnode>
<parent>usb_3_1</parent>
<driver>
<name>usb</name>
</driver>
<capability type='usb_device'>
<bus>3</bus>
<device>4</device>
<product id='0x6006'>AUKEY PC-LM1E Camera</product>
<vendor id='0x0458'>KYE Systems Corp. (Mouse Systems)</vendor>
</capability>
</device>
""")
make_mock_device("""
<device>
<name>pci_1002_71c4</name>
<parent>pci_8086_27a1</parent>
<capability type='pci'>
<class>0xffffff</class>
<domain>0</domain>
<bus>1</bus>
<slot>0</slot>
<function>0</function>
<product id='0x71c4'>M56GL [Mobility FireGL V5200]</product>
<vendor id='0x1002'>ATI Technologies Inc</vendor>
<numa node='1'/>
</capability>
</device>
""")
ret = virt.update("my_vm",
host_devices=["usb_3_1_3"],
test=test,
live=live)
define_mock = virt.libvirt.openAuth().defineXML
assert_called(define_mock, not test)
# Test that the XML is updated with the proper devices
usb_device_xml = strip_xml("""
<hostdev mode="subsystem" type="usb">
<source>
<vendor id="0x0458" />
<product id="0x6006" />
</source>
</hostdev>
""")
if not test:
set_xml = ET.fromstring(define_mock.call_args[0][0])
actual_hostdevs = [
ET.tostring(xmlutil.strip_spaces(node))
for node in set_xml.findall("./devices/hostdev")
]
assert [usb_device_xml] == actual_hostdevs
if not test and live:
attach_xml = strip_xml(domain_mock.attachDevice.call_args[0][0])
assert usb_device_xml == attach_xml
pci_device_xml = strip_xml("""
<hostdev mode='subsystem' type='pci' managed='yes'>
<source>
<address domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
</source>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</hostdev>
""")
detach_xml = strip_xml(domain_mock.detachDevice.call_args[0][0])
assert pci_device_xml == detach_xml
else:
domain_mock.attachDevice.assert_not_called()
domain_mock.detachDevice.assert_not_called()
def test_update_hostdev_nochange(make_mock_device, make_mock_vm):
"""
Test the virt.update function with no host device changes
"""
xml_def = """
<domain type='kvm'>
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>hvm</type>
</os>
<on_reboot>restart</on_reboot>
<devices>
<hostdev mode='subsystem' type='pci' managed='yes'>
<source>
<address domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
</source>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</hostdev>
<hostdev mode='subsystem' type='usb' managed='no'>
<source>
<vendor id='0x0458'/>
<product id='0x6006'/>
<address bus='3' device='4'/>
</source>
<alias name='hostdev0'/>
<address type='usb' bus='0' port='1'/>
</hostdev>
</devices>
</domain>"""
domain_mock = make_mock_vm(xml_def)
make_mock_device("""
<device>
<name>usb_3_1_3</name>
<path>/sys/devices/pci0000:00/0000:00:1d.6/0000:06:00.0/0000:07:02.0/0000:3e:00.0/usb3/3-1/3-1.3</path>
<devnode type='dev'>/dev/bus/usb/003/004</devnode>
<parent>usb_3_1</parent>
<driver>
<name>usb</name>
</driver>
<capability type='usb_device'>
<bus>3</bus>
<device>4</device>
<product id='0x6006'>AUKEY PC-LM1E Camera</product>
<vendor id='0x0458'>KYE Systems Corp. (Mouse Systems)</vendor>
</capability>
</device>
""")
make_mock_device("""
<device>
<name>pci_1002_71c4</name>
<parent>pci_8086_27a1</parent>
<capability type='pci'>
<class>0xffffff</class>
<domain>0</domain>
<bus>1</bus>
<slot>0</slot>
<function>0</function>
<product id='0x71c4'>M56GL [Mobility FireGL V5200]</product>
<vendor id='0x1002'>ATI Technologies Inc</vendor>
<numa node='1'/>
</capability>
</device>
""")
ret = virt.update("my_vm", host_devices=["pci_1002_71c4", "usb_3_1_3"])
assert not ret["definition"]
define_mock = virt.libvirt.openAuth().defineXML
define_mock.assert_not_called()
def test_update_nic_hostdev_nochange(make_mock_network, make_mock_vm, test):
"""
Test the virt.update function with a running host with hostdev nic
"""
xml_def_template = """
<domain type='kvm'>
<name>my_vm</name>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<os>
<type arch='x86_64'>hvm</type>
</os>
<on_reboot>restart</on_reboot>
<devices>
{}
</devices>
</domain>
"""
inactive_nic = """
<interface type='hostdev' managed='yes'>
<mac address='52:54:00:67:b2:08'/>
<driver name='vfio'/>
<source network="test-hostdev"/>
<model type='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>
"""
running_nic = """
<interface type='hostdev' managed='yes'>
<mac address='52:54:00:67:b2:08'/>
<driver name='vfio'/>
<source>
<address type='pci' domain='0x0000' bus='0x3d' slot='0x02' function='0x0'/>
</source>
<model type='virtio'/>
<alias name='hostdev0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>
"""
domain_mock = make_mock_vm(
xml_def_template.format(running_nic),
running="running",
inactive_def=xml_def_template.format(inactive_nic),
)
make_mock_network("""
<network connections='1'>
<name>test-hostdev</name>
<uuid>51d0aaa5-7530-4c60-8498-5bc3ab8c655b</uuid>
<forward mode='hostdev' managed='yes'>
<pf dev='eth0'/>
<address type='pci' domain='0x0000' bus='0x3d' slot='0x02' function='0x0'/>
<address type='pci' domain='0x0000' bus='0x3d' slot='0x02' function='0x1'/>
</forward>
</network>
""")
ret = virt.update(
"my_vm",
interfaces=[{
"name": "eth0",
"type": "network",
"source": "test-hostdev"
}],
test=test,
live=True,
)
assert not ret.get("definition")
assert not ret.get("interface").get("attached")
assert not ret.get("interface").get("detached")
define_mock = virt.libvirt.openAuth().defineXML
define_mock.assert_not_called()
domain_mock.attachDevice.assert_not_called()
domain_mock.detachDevice.assert_not_called()