def collect_memobj_attrs(el, namespace, image, machine): """Collect the attributes of a memory section like element.""" assert el is not None values = image.new_attrs(namespace) if el.tag == "stack" or el.tag == "heap": values.name = el.tag else: values.name = el.name assert el.name is not None values.file = getattr(el, 'file', values.file) values.size = getattr(el, 'size', values.size) values.virt_addr = getattr(el, 'virt_addr', values.virt_addr) values.phys_addr = getattr(el, 'phys_addr', values.phys_addr) values.direct = getattr(el, 'direct', values.direct) values.virtpool = getattr(el, 'virtpool', values.virtpool) values.physpool = getattr(el, 'physpool', values.physpool) values.align = getattr(el, 'align', values.align) values.scrub = getattr(el, 'zero', values.scrub) values.usermap = getattr(el, 'user_map', values.usermap) if hasattr(el, 'attach'): values.attach = attach_to_elf_flags(el.attach) if hasattr(el, 'pager'): values.pager = make_pager_attr(el.pager) if hasattr(el, 'cache_policy'): values.cache_policy = machine.get_cache_policy(el.cache_policy) return values
def setup_pools(el, image, pd, bootinfo): virtpool = getattr(el, 'virtpool', None) physpool = getattr(el, 'physpool', None) direct = getattr(el, 'direct', None) pd.set_platform_control(getattr(el, "platform_control", False)) if hasattr(el, 'pager'): pager = make_pager_attr(el.pager) else: pager = None # Push the overriding attributes for the program. image.push_attrs(virtual = virtpool, physical = physpool, pager = pager, direct = direct) pd.set_default_pools(image, bootinfo)
def collect_memobj_attrs(el, namespace, image, machine): """Collect the attributes of a memory section like element.""" assert el is not None if el.tag == "stack" or el.tag == "heap": name = el.tag else: assert el.name is not None name = el.name values = image.new_attrs(namespace.add_namespace(name)) values.file = getattr(el, 'file', values.file) values.size = getattr(el, 'size', values.size) values.virt_addr = getattr(el, 'virt_addr', values.virt_addr) values.phys_addr = getattr(el, 'phys_addr', values.phys_addr) values.direct = getattr(el, 'direct', values.direct) values.virtpool = getattr(el, 'virtpool', values.virtpool) values.physpool = getattr(el, 'physpool', values.physpool) values.align = getattr(el, 'align', values.align) values.scrub = getattr(el, 'zero', values.scrub) values.user_map = getattr(el, 'mem_type', values.user_map) if hasattr(el, 'mem_type'): values.mem_type = translate_mem_types(el.mem_type) if hasattr(el, 'attach'): values.attach = attach_to_elf_flags(el.attach) if hasattr(el, 'pager'): values.pager = make_pager_attr(el.pager) if hasattr(el, 'cache_policy'): values.cache_policy = machine.get_cache_policy(el.cache_policy) return values
def collect_pd_element(pd_el, ignore_name, namespace, image, machine, bootinfo, pools): """Collect the attributes of a PD element.""" # New namespace for objects living in the PD. pd_namespace = namespace.add_namespace(pd_el.name) pd = weaver.bootinfo.PD(pd_el.name, pd_namespace, image, machine, pools) virtpool = getattr(pd_el, 'virtpool', None) physpool = getattr(pd_el, 'physpool', None) direct = getattr(pd_el, 'direct', None) pd.set_platform_control(getattr(pd_el, "platform_control", False)) if hasattr(pd_el, 'pager'): pager = make_pager_attr(pd_el.pager) else: pager = None # Push the overriding attributes for the pd. image.push_attrs(virtual = virtpool, physical = physpool, pager = pager, direct = direct) pd.set_default_pools(image, bootinfo) # Collect the object environment env = collect_environment_element(pd_el.find_child('environment'), pd_namespace, machine, pools, image, bootinfo) if hasattr(pd_el, "file"): elf = PreparedElfFile(filename=pd_el.file) if elf.elf_type != ET_EXEC: raise MergeError, "All the merged ELF files must be of EXEC type." segment_els = pd_el.find_all_children("segment") segs = collect_elf_segments(elf, image.PROGRAM, segment_els, pd_el.name, pd_namespace, image, machine, pools) segs_ms = [bootinfo.record_segment_info(pd_el.name, seg, image, machine, pools) for seg in segs] for seg_ms in segs_ms: pd.attach_memsection(seg_ms) # Record any patches being made to the program. patch_els = pd_el.find_children("patch") collect_patches(elf, patch_els, image) # Collect threads in the PD. for thread_el in pd_el.find_children('thread'): if not ignore_name.match(thread_el.name): thread = collect_thread(elf, thread_el, ignore_name, pd_namespace, image, machine, pools, entry = "_thread_start") pd.add_thread(thread) # Record the thread and its stack in the environment. env.add_entry(key = thread.get_name(), cap_name = thread.get_name() + '/master') env.add_entry(key = thread.get_name() + "/STACK", cap_name = thread.get_name() + '/stack/master', attach = thread.get_stack().get_attrs().attach) # Collect memsections in the PD. for ms_el in pd_el.find_children('memsection'): if not ignore_name.match(ms_el.name): ms = collect_memsection_element(ms_el, ignore_name, pd_namespace, image, machine, pools) pd.attach_memsection(ms) image.add_group(0, [ms.get_ms()]) env.add_entry(key = ms.get_name(), cap_name = ms.get_name() + '/master', attach = ms.get_attrs().attach) # Collect any zones in the program. for zone_el in pd_el.find_children('zone'): (zone, non_zone_ms) = \ collect_zone_element(zone_el, ignore_name, pd_namespace, pools, image, bootinfo, machine) pd.attach_zone(zone) # Attach zones that aren't part of the zone to the program. for ms in non_zone_ms: pd.attach_memsection(ms) image.add_group(0, [ms.get_ms()]) env.add_entry(key = ms.get_name(), cap_name = ms.get_name() + '/master', attach = ms.get_attrs().attach) pd.add_environment(env) bootinfo.add_pd(pd) image.pop_attrs()
def collect_program_element(program_el, ignore_name, namespace, image, machine, bootinfo, pools): """Collect the attributes of a program element.""" # New namespace for objects living in the program's PD. prog_namespace = namespace.add_namespace(program_el.name) pd = weaver.bootinfo.PD(program_el.name, prog_namespace, image, machine, pools) elf = UnpreparedElfFile(filename=program_el.file) if elf.elf_type != ET_EXEC: raise MergeError, "All the merged ELF files must be of EXEC type." bootinfo.add_elf_info(name = program_el.file, elf_type = image.PROGRAM, entry_point = elf.entry_point) pd.elf = elf virtpool = getattr(program_el, 'virtpool', None) physpool = getattr(program_el, 'physpool', None) direct = getattr(program_el, 'direct', None) pd.set_platform_control(getattr(program_el, "platform_control", False)) if hasattr(program_el, 'pager'): pager = make_pager_attr(program_el.pager) else: pager = None # Push the overriding attributes for the program. image.push_attrs(virtual = virtpool, physical = physpool, pager = pager, direct = direct) pd.set_default_pools(image, bootinfo) # Collect the object environment env = collect_environment_element(program_el.find_child('environment'), prog_namespace, machine, pools, image, bootinfo) segment_els = program_el.find_all_children("segment") segs = collect_elf_segments(elf, image.PROGRAM, segment_els, program_el.name, prog_namespace, image, machine, pools) segs_ms = [bootinfo.record_segment_info(program_el.name, seg, image, machine, pools) for seg in segs] for seg_ms in segs_ms: pd.attach_memsection(seg_ms) # Record any patches being made to the program. patch_els = program_el.find_children("patch") collect_patches(elf, patch_els, program_el.file, image) # Collect the main thread. thread = collect_thread(elf, program_el, ignore_name, prog_namespace, image, machine, pools, entry = elf.entry_point, name = program_el.name, namespace_thread_name = "main") pd.add_thread(thread) pd.set_server_thread(thread) # Add the virtual device elements # Virtual devices always get added to the global namespace because they # should be globally unique server_spawn_nvdevs = 0 dev_ns = namespace.root.get_namespace("dev") if dev_ns is None: raise MergeError, "Device namespace does not exist!" for v_el in program_el.find_children('virt_device'): virt_dev = pd.add_virt_dev(v_el.name, program_el.name, pd, thread, server_spawn_nvdevs) create_alias_cap(virt_dev, dev_ns) server_spawn_nvdevs += 1 # Record the main thread and its stack in the environment. env.add_entry(key = "MAIN", cap_name = 'main/master') env.add_entry(key = "MAIN/STACK", cap_name = 'main/stack/master', attach = thread.get_stack().get_attrs().attach) # If marked, sure that the program is exported to every # environment so that it can be found by other programs. # if hasattr(program_el, 'server'): bootinfo.add_server( key = program_el.server, cap_name = prog_namespace.abs_name('main') + '/stack/master') # Collect remaining threads. elf = pd.elf = pd.elf.prepare(image.wordsize, image.endianess) for thread_el in program_el.find_children('thread'): if not ignore_name.match(thread_el.name): thread = collect_thread(elf, thread_el, ignore_name, prog_namespace, image, machine, pools, entry = "_thread_start") pd.add_thread(thread) # Record the thread and its stack in the environment. env.add_entry(key = thread.get_name(), cap_name = thread.get_name() + '/master') env.add_entry(key = thread.get_name() + "/STACK", cap_name = thread.get_name() + '/stack/master', attach = thread.get_stack().get_attrs().attach) # Collect any other memsections in the program. for ms_el in program_el.find_children('memsection'): if not ignore_name.match(ms_el.name): ms = collect_memsection_element(ms_el, ignore_name, prog_namespace, image, machine, pools) pd.attach_memsection(ms) image.add_group(0, [ms.get_ms()]) env.add_entry(key = ms.get_name(), cap_name = ms.get_name() + '/master', attach = ms.get_attrs().attach) # Collect any zones in the program. for zone_el in program_el.find_children('zone'): (zone, non_zone_ms) = \ collect_zone_element(zone_el, ignore_name, prog_namespace, pools, image, bootinfo, machine) pd.attach_zone(zone) # Attach memsections that aren't part of the zone to the program. for ms in non_zone_ms: pd.attach_memsection(ms) image.add_group(0, [ms.get_ms()]) env.add_entry(key = ms.get_name(), cap_name = ms.get_name() + '/master', attach = ms.get_attrs().attach) # Collect the heap. Is there no element, create a fake one for # the collection code to use. heap_el = program_el.find_child('heap') if heap_el is None: heap_el = ParsedElement('heap') heap_ms = collect_memsection_element(heap_el, ignore_name, prog_namespace, image, machine, pools) pd.attach_heap(heap_ms) image.add_group(0, [heap_ms.get_ms()]) # Fill env with default values. env.add_entry(key = "HEAP", cap_name = 'heap/master', attach = heap_ms.get_attrs().attach) env.add_entry(key = "HEAP_BASE", base = heap_ms) env.add_entry(key = "HEAP_SIZE", value = heap_ms.get_attrs().size) pd.add_environment(env) bootinfo.add_pd(pd) image.pop_attrs()
def collect_xml(self, okl4_el, ignore_name, namespace, machine, pools, kernel, image): """Handle an Iguana Server Compound Object""" self.cell = \ kernel.register_cell(okl4_el.name, okl4_el.kernel_heap, max_caps = getattr(okl4_el, "caps", None), max_priority = getattr(okl4_el, "max_priority", None)) self.name = okl4_el.name self.namespace = namespace.add_namespace(self.name) self.space = \ self.cell.register_space(self.namespace, "MAIN", is_privileged = True, max_clists = getattr(okl4_el, "clists", None), max_spaces = getattr(okl4_el, "spaces", None), max_mutexes = getattr(okl4_el, "mutexes", None), max_threads = getattr(okl4_el, "threads", None), max_priority = getattr(okl4_el, "max_priority", None), plat_control = \ getattr(okl4_el, "platform_control", False)) image.push_attrs(virtual=getattr(okl4_el, "virtpool", None), physical=getattr(okl4_el, "physpool", None), pager=make_pager_attr(getattr(okl4_el, "pager", None)), direct=getattr(okl4_el, "direct", None)) (self.def_virtpool, self.def_physpool) = image.current_pools() self.collect_mutexes(okl4_el, self.namespace, self.space) env_el = okl4_el.find_child("environment") self.env = CellEnvironment(okl4_el.name, self.namespace, machine, image, kernel, self.space.mappings) if env_el != None: self._collect_environment(env_el, self.env) # Set these up now even though we can't actually assign values # till later self.phys_attrs = image.new_attrs( self.namespace.add_namespace("default_physpool")) self.phys_attrs.attach = PF_R | PF_W | PF_X self.phys_attrs.mem_type = self.phys_attrs.unmapped mapping = self.space.register_mapping(self.phys_attrs) self.env.add_physmem_segpool_entry("MAIN_PHYSMEM_SEGPOOL", mapping) self.virt_attrs = image.new_attrs( self.namespace.add_namespace("default_virtpool")) self.env.add_virtmem_pool_entry("MAIN_VIRTMEM_POOL", self.virt_attrs) self.space.utcb = image.new_attrs( self.namespace.add_namespace("main_utcb_area")) self.space.utcb.attach = PF_R filename = os.path.join(okl4_el._path, okl4_el.file) self.elf = UnpreparedElfFile(filename=filename) if self.elf.elf_type != ET_EXEC: raise MergeError("All the merged ELF files must be of EXEC type.") # Find out which version of libokl4 that the cell was built # against sym = self.elf.find_symbol("okl4_api_version") if sym == None: raise MergeError( "Unable to locate the symbol 'okl4_api_version' in file \"%s\". Cells must link with libokl4." % filename) self.api_version = self.elf.get_value(sym.value, sym.size, self.elf.endianess) if self.api_version == None: raise MergeError( "Unable to read the symbol 'okl4_api_version' in file \"%s\". Cells must link with libokl4." % filename) self.env.add_elf_info_entry(os.path.basename(okl4_el.file), image.PROGRAM, self.elf.entry_point) segment_els = okl4_el.find_children("segment") segs = collect_elf_segments(self.elf, image.PROGRAM, segment_els, filename, [], self.namespace, image, machine, pools) self.elf_prog_segments = segs for seg in segs: self.env.add_elf_segment_entry( okl4_el.name + '.' + seg.attrs.ns_node.name, seg.segment) seg_ns = seg.attrs.ns_node mapping = self.space.register_mapping(seg.attrs) self.add_standard_mem_caps(seg_ns, mapping, seg.attrs) patch_els = okl4_el.find_children("patch") collect_patches(self.elf, patch_els, filename, image) # Record any IRQs that are assigned to the initial program. for irq_el in okl4_el.find_children("irq"): self.space.register_irq(irq_el.value) self.env.add_device_irq_list("NO_DEVICE", [irq_el.value for irq_el \ in okl4_el.find_children("irq")]) # Collect the implicit thread if not hasattr(okl4_el, 'priority'): okl4_el.priority = kernel.kernel.MAX_PRIORITY threads = [] threads.append( self.collect_thread(self.elf, okl4_el, self.namespace, image, machine, pools, kernel, self.space, self.elf.entry_point, "main", True)) # FIXME: Need to check up on actual entry point's for thread_el in okl4_el.find_children("thread"): threads.append( self.collect_thread(self.elf, thread_el, self.namespace, image, machine, pools, kernel, self.space, "thread_start", cell_create_thread=True)) device_mem = \ self.collect_use_devices(okl4_el, self.space, self.namespace, image, machine, pools) memsection_objs = \ self.collect_memsections(okl4_el, self.space, self.namespace, image, machine, pools) # Collect all data for any extra spaces defined in the XML for space_el in okl4_el.find_children("space"): space_ns = self.namespace.add_namespace(space_el.name) space = self.cell.register_space(space_ns, space_el.name, max_priority = getattr(space_el, "max_priority", \ getattr(okl4_el, "max_priority", None))) image.push_attrs(virtual=getattr(space_el, "virtpool", None), physical=getattr(space_el, "physpool", None), pager=make_pager_attr( getattr(space_el, "pager", None)), direct=getattr(space_el, "direct", None)) for thread_el in space_el.find_children("thread"): threads.append( self.collect_thread(self.elf, thread_el, space_ns, image, machine, pools, kernel, space, "thread_start", cell_create_thread=True)) self.collect_mutexes(space_el, space_ns, space) device_mem.extend( self.collect_use_devices(space_el, space, space_ns, image, machine, pools)) memsection_objs.extend( self.collect_memsections(space_el, space, space_ns, image, machine, pools)) self.env.add_kspace_entry(space_el.name + "_KSPACE", space) space.utcb = image.new_attrs( space_ns.add_namespace(space_el.name + "_utcb_area")) space.utcb.attach = PF_R # Weave a kclist for the main space. main_kclist = self.env.add_kclist_entry("MAIN_KCLIST", self.cell) # Weave the root kspace object. main_kspace = self.env.add_kspace_entry("MAIN_KSPACE", self.space) # Weave the root protection domain object. self.env.add_pd_entry("MAIN_PD", self.space, main_kspace, 32, machine.min_page_size(), self.elf) # Find heap and add it heap_el = okl4_el.find_child('heap') if heap_el is None: heap_el = ParsedElement('heap') heap_attr = collect_memobj_attrs(heap_el, self.namespace, image, machine) if heap_attr.size == None: heap_attr.size = DEFAULT_HEAP_SIZE self.heap_ms = image.add_memsection(heap_attr, machine, pools) self.cell.heap = self.heap_ms.attrs mapping = self.space.register_mapping(self.heap_ms.attrs) self.add_standard_mem_caps(heap_attr.ns_node, mapping, heap_attr) self.elf_segments = \ [thread.get_stack_ms() for thread in threads] + \ [self.heap_ms] + memsection_objs + device_mem self.env.add_kernel_info_entry(0, 0, kernel) # Add command line arguments commandline_el = okl4_el.find_child("commandline") if commandline_el is not None: args = [ arg_el.value for arg_el in commandline_el.find_children("arg") ] else: args = [] self.env.add_arg_list(args) self.cell.env = self.env
def collect_xml(self, okl4_el, ignore_name, namespace, machine, pools, kernel, image): """Handle an Iguana Server Compound Object""" self.cell = \ kernel.register_cell(okl4_el.name, okl4_el.kernel_heap, max_caps = getattr(okl4_el, "caps", None), max_priority = getattr(okl4_el, "max_priority", None)) self.name = okl4_el.name self.namespace = namespace.add_namespace(self.name) self.space = \ self.cell.register_space(self.namespace, "MAIN", is_privileged = True, max_clists = getattr(okl4_el, "clists", None), max_spaces = getattr(okl4_el, "spaces", None), max_mutexes = getattr(okl4_el, "mutexes", None), max_threads = getattr(okl4_el, "threads", None), max_priority = getattr(okl4_el, "max_priority", None), plat_control = \ getattr(okl4_el, "platform_control", False)) image.push_attrs( virtual = getattr(okl4_el, "virtpool", None), physical = getattr(okl4_el, "physpool", None), pager = make_pager_attr(getattr(okl4_el, "pager", None)), direct = getattr(okl4_el, "direct", None)) (self.def_virtpool, self.def_physpool) = image.current_pools() self.collect_mutexes(okl4_el, self.namespace, self.space) env_el = okl4_el.find_child("environment") self.env = CellEnvironment(okl4_el.name, self.namespace, machine, image, kernel, self.space.mappings) if env_el != None: self._collect_environment(env_el, self.env) # Set these up now even though we can't actually assign values # till later self.phys_attrs = image.new_attrs(self.namespace.add_namespace("default_physpool")) self.phys_attrs.attach = PF_R | PF_W | PF_X self.phys_attrs.mem_type = self.phys_attrs.unmapped mapping = self.space.register_mapping(self.phys_attrs) self.env.add_physmem_segpool_entry("MAIN_PHYSMEM_SEGPOOL", mapping) self.virt_attrs = image.new_attrs(self.namespace.add_namespace("default_virtpool")) self.env.add_virtmem_pool_entry("MAIN_VIRTMEM_POOL", self.virt_attrs) self.space.utcb = image.new_attrs(self.namespace.add_namespace("main_utcb_area")) self.space.utcb.attach = PF_R filename = os.path.join(okl4_el._path, okl4_el.file) self.elf = UnpreparedElfFile(filename=filename) if self.elf.elf_type != ET_EXEC: raise MergeError("All the merged ELF files must be of EXEC type.") # Find out which version of libokl4 that the cell was built # against sym = self.elf.find_symbol("okl4_api_version") if sym == None: raise MergeError("Unable to locate the symbol 'okl4_api_version' in file \"%s\". Cells must link with libokl4." % filename) self.api_version = self.elf.get_value(sym.value, sym.size, self.elf.endianess) if self.api_version == None: raise MergeError("Unable to read the symbol 'okl4_api_version' in file \"%s\". Cells must link with libokl4." % filename) self.env.add_elf_info_entry(os.path.basename(okl4_el.file), image.PROGRAM, self.elf.entry_point) segment_els = okl4_el.find_children("segment") segs = collect_elf_segments(self.elf, image.PROGRAM, segment_els, filename, [], self.namespace, image, machine, pools) self.elf_prog_segments = segs for seg in segs: self.env.add_elf_segment_entry(okl4_el.name + '.' + seg.attrs.ns_node.name, seg.segment) seg_ns = seg.attrs.ns_node mapping = self.space.register_mapping(seg.attrs) self.add_standard_mem_caps(seg_ns, mapping, seg.attrs) patch_els = okl4_el.find_children("patch") collect_patches(self.elf, patch_els, filename, image) # Record any IRQs that are assigned to the initial program. for irq_el in okl4_el.find_children("irq"): self.space.register_irq(irq_el.value) self.env.add_device_irq_list("NO_DEVICE", [irq_el.value for irq_el \ in okl4_el.find_children("irq")]) # Collect the implicit thread if not hasattr(okl4_el, 'priority'): okl4_el.priority = kernel.kernel.MAX_PRIORITY threads = [] threads.append(self.collect_thread(self.elf, okl4_el, self.namespace, image, machine, pools, kernel, self.space, self.elf.entry_point, "main", True)) # FIXME: Need to check up on actual entry point's for thread_el in okl4_el.find_children("thread"): threads.append(self.collect_thread(self.elf, thread_el, self.namespace, image, machine, pools, kernel, self.space, "thread_start", cell_create_thread = True)) device_mem = \ self.collect_use_devices(okl4_el, self.space, self.namespace, image, machine, pools) memsection_objs = \ self.collect_memsections(okl4_el, self.space, self.namespace, image, machine, pools) # Collect all data for any extra spaces defined in the XML for space_el in okl4_el.find_children("space"): space_ns = self.namespace.add_namespace(space_el.name) space = self.cell.register_space(space_ns, space_el.name, max_priority = getattr(space_el, "max_priority", \ getattr(okl4_el, "max_priority", None))) image.push_attrs( virtual = getattr(space_el, "virtpool", None), physical = getattr(space_el, "physpool", None), pager = make_pager_attr(getattr(space_el, "pager", None)), direct = getattr(space_el, "direct", None)) for thread_el in space_el.find_children("thread"): threads.append(self.collect_thread(self.elf, thread_el, space_ns, image, machine, pools, kernel, space, "thread_start", cell_create_thread = True)) self.collect_mutexes(space_el, space_ns, space) device_mem.extend( self.collect_use_devices(space_el, space, space_ns, image, machine, pools)) memsection_objs.extend( self.collect_memsections(space_el, space, space_ns, image, machine, pools)) self.env.add_kspace_entry(space_el.name + "_KSPACE", space) space.utcb = image.new_attrs(space_ns.add_namespace(space_el.name + "_utcb_area")) space.utcb.attach = PF_R # Weave a kclist for the main space. main_kclist = self.env.add_kclist_entry("MAIN_KCLIST", self.cell) # Weave the root kspace object. main_kspace = self.env.add_kspace_entry("MAIN_KSPACE", self.space) # Weave the root protection domain object. self.env.add_pd_entry("MAIN_PD", self.space, main_kspace, 32, machine.min_page_size(), self.elf) # Find heap and add it heap_el = okl4_el.find_child('heap') if heap_el is None: heap_el = ParsedElement('heap') heap_attr = collect_memobj_attrs(heap_el, self.namespace, image, machine) if heap_attr.size == None: heap_attr.size = DEFAULT_HEAP_SIZE self.heap_ms = image.add_memsection(heap_attr, machine, pools) self.cell.heap = self.heap_ms.attrs mapping = self.space.register_mapping(self.heap_ms.attrs) self.add_standard_mem_caps(heap_attr.ns_node, mapping, heap_attr) self.elf_segments = \ [thread.get_stack_ms() for thread in threads] + \ [self.heap_ms] + memsection_objs + device_mem self.env.add_kernel_info_entry(0, 0, kernel) # Add command line arguments commandline_el = okl4_el.find_child("commandline") if commandline_el is not None: args = [arg_el.value for arg_el in commandline_el.find_children("arg")] else: args = [] self.env.add_arg_list(args) self.cell.env = self.env