def testActionDependencies(self):
""" Verify correct functioning of action dependencies. """
# ActionResizeDevice
# an action that shrinks a device should require the action that
# shrinks the device's format
lv_root = self.storage.devicetree.getDeviceByName("VolGroup-lv_root")
self.assertNotEqual(lv_root, None)
lv_root.format._minInstanceSize = Size("10 MiB")
lv_root.format._targetSize = lv_root.format._minInstanceSize
# lv_root.format._resizable = True
shrink_format = ActionResizeFormat(lv_root, lv_root.size - Size("5 GiB"))
shrink_format.apply()
shrink_device = ActionResizeDevice(lv_root, lv_root.size - Size("5 GiB"))
shrink_device.apply()
self.assertEqual(shrink_device.requires(shrink_format), True)
self.assertEqual(shrink_format.requires(shrink_device), False)
shrink_format.cancel()
shrink_device.cancel()
# ActionResizeDevice
# an action that grows a format should require the action that
# grows the device
orig_size = lv_root.currentSize
grow_device = ActionResizeDevice(lv_root, orig_size + Size("100 MiB"))
grow_device.apply()
grow_format = ActionResizeFormat(lv_root, orig_size + Size("100 MiB"))
grow_format.apply()
self.assertEqual(grow_format.requires(grow_device), True)
self.assertEqual(grow_device.requires(grow_format), False)
# create something like uncommitted autopart
self.destroyAllDevices()
sda = self.storage.devicetree.getDeviceByName("sda")
sdb = self.storage.devicetree.getDeviceByName("sdb")
sda1 = self.newDevice(device_class=PartitionDevice, name="sda1", size=Size("500 MiB"), parents=[sda])
sda1_format = self.newFormat("ext4", mountpoint="/boot", device=sda1.path)
self.scheduleCreateDevice(sda1)
self.scheduleCreateFormat(device=sda1, fmt=sda1_format)
sda2 = self.newDevice(device_class=PartitionDevice, name="sda2", size=Size("99.5 GiB"), parents=[sda])
sda2_format = self.newFormat("lvmpv", device=sda2.path)
self.scheduleCreateDevice(sda2)
self.scheduleCreateFormat(device=sda2, fmt=sda2_format)
sdb1 = self.newDevice(device_class=PartitionDevice, name="sdb1", size=Size("100 GiB"), parents=[sdb])
sdb1_format = self.newFormat("lvmpv", device=sdb1.path)
self.scheduleCreateDevice(sdb1)
self.scheduleCreateFormat(device=sdb1, fmt=sdb1_format)
vg = self.newDevice(device_class=LVMVolumeGroupDevice, name="VolGroup", parents=[sda2, sdb1])
self.scheduleCreateDevice(vg)
lv_root = self.newDevice(
device_class=LVMLogicalVolumeDevice, name="lv_root", parents=[vg], size=Size("160 GiB")
)
self.scheduleCreateDevice(lv_root)
fmt = self.newFormat("ext4", device=lv_root.path, mountpoint="/")
self.scheduleCreateFormat(device=lv_root, fmt=fmt)
lv_swap = self.newDevice(device_class=LVMLogicalVolumeDevice, name="lv_swap", parents=[vg], size=Size("4 GiB"))
self.scheduleCreateDevice(lv_swap)
fmt = self.newFormat("swap", device=lv_swap.path)
self.scheduleCreateFormat(device=lv_swap, fmt=fmt)
# ActionCreateDevice
# creation of an LV should require the actions that create the VG,
# its PVs, and the devices that contain the PVs
lv_root = self.storage.devicetree.getDeviceByName("VolGroup-lv_root")
self.assertNotEqual(lv_root, None)
actions = self.storage.devicetree.actions.find(action_type="create", object_type="device", device=lv_root)
self.assertEqual(len(actions), 1, "wrong number of device create actions for lv_root: " "%d" % len(actions))
create_lv_action = actions[0]
vgs = [d for d in self.storage.vgs if d.name == "VolGroup"]
self.assertNotEqual(vgs, [])
vg = vgs[0]
actions = self.storage.devicetree.actions.find(action_type="create", object_type="device", device=vg)
self.assertEqual(len(actions), 1, "wrong number of device create actions for VolGroup")
create_vg_action = actions[0]
self.assertEqual(create_lv_action.requires(create_vg_action), True)
create_pv_actions = []
pvs = [d for d in self.storage.pvs if d in vg.pvs]
self.assertNotEqual(pvs, [])
for pv in pvs:
# include device and format create actions for each pv
actions = self.storage.devicetree.actions.find(action_type="create", device=pv)
self.assertEqual(len(actions), 2, "wrong number of device create actions for " "pv %s" % pv.name)
create_pv_actions.append(actions[0])
for pv_action in create_pv_actions:
self.assertEqual(create_lv_action.requires(pv_action), True)
# also check that the vg create action requires the pv actions
self.assertEqual(create_vg_action.requires(pv_action), True)
# ActionCreateDevice
# the higher numbered partition of two that are scheduled to be
# created on a single disk should require the action that creates the
# lower numbered of the two, eg: create sda2 before creating sda3
sdc = self.storage.devicetree.getDeviceByName("sdc")
self.assertNotEqual(sdc, None)
sdc1 = self.newDevice(device_class=PartitionDevice, name="sdc1", parents=[sdc], size=Size("50 GiB"))
create_sdc1 = self.scheduleCreateDevice(sdc1)
self.assertEqual(isinstance(create_sdc1, ActionCreateDevice), True)
sdc2 = self.newDevice(device_class=PartitionDevice, name="sdc2", parents=[sdc], size=Size("50 GiB"))
create_sdc2 = self.scheduleCreateDevice(sdc2)
self.assertEqual(isinstance(create_sdc2, ActionCreateDevice), True)
self.assertEqual(create_sdc2.requires(create_sdc1), True)
self.assertEqual(create_sdc1.requires(create_sdc2), False)
# ActionCreateDevice
# actions that create partitions on two separate disks should not
# require each other, regardless of the partitions' numbers
sda1 = self.storage.devicetree.getDeviceByName("sda1")
self.assertNotEqual(sda1, None)
actions = self.storage.devicetree.actions.find(action_type="create", object_type="device", device=sda1)
self.assertEqual(len(actions), 1, "wrong number of create actions found for sda1")
create_sda1 = actions[0]
self.assertEqual(create_sdc2.requires(create_sda1), False)
self.assertEqual(create_sda1.requires(create_sdc1), False)
# ActionDestroyDevice
# an action that destroys a device containing an mdmember format
# should require the action that destroys the md array it is a
# member of if an array is defined
self.destroyAllDevices(disks=["sdc", "sdd"])
sdc = self.storage.devicetree.getDeviceByName("sdc")
self.assertNotEqual(sdc, None)
sdd = self.storage.devicetree.getDeviceByName("sdd")
self.assertNotEqual(sdd, None)
sdc1 = self.newDevice(device_class=PartitionDevice, name="sdc1", parents=[sdc], size=Size("40 GiB"))
self.scheduleCreateDevice(sdc1)
fmt = self.newFormat("mdmember", device=sdc1.path)
self.scheduleCreateFormat(device=sdc1, fmt=fmt)
sdd1 = self.newDevice(device_class=PartitionDevice, name="sdd1", parents=[sdd], size=Size("40 GiB"))
self.scheduleCreateDevice(sdd1)
fmt = self.newFormat("mdmember", device=sdd1.path)
self.scheduleCreateFormat(device=sdd1, fmt=fmt)
md0 = self.newDevice(
device_class=MDRaidArrayDevice,
name="md0",
level="raid0",
minor=0,
memberDevices=2,
totalDevices=2,
parents=[sdc1, sdd1],
)
self.scheduleCreateDevice(md0)
fmt = self.newFormat("ext4", device=md0.path, mountpoint="/home")
self.scheduleCreateFormat(device=md0, fmt=fmt)
destroy_md0_format = self.scheduleDestroyFormat(md0)
destroy_md0 = self.scheduleDestroyDevice(md0)
destroy_members = [self.scheduleDestroyDevice(sdc1)]
destroy_members.append(self.scheduleDestroyDevice(sdd1))
for member in destroy_members:
# device and format destroy actions for md members should require
# both device and format destroy actions for the md array
for array in [destroy_md0_format, destroy_md0]:
self.assertEqual(member.requires(array), True)
# ActionDestroyDevice
# when there are two actions that will each destroy a partition on the
# same disk, the action that will destroy the lower-numbered
# partition should require the action that will destroy the higher-
# numbered partition, eg: destroy sda2 before destroying sda1
self.destroyAllDevices(disks=["sdc", "sdd"])
sdc1 = self.newDevice(device_class=PartitionDevice, name="sdc1", parents=[sdc], size=Size("50 GiB"))
self.scheduleCreateDevice(sdc1)
sdc2 = self.newDevice(device_class=PartitionDevice, name="sdc2", parents=[sdc], size=Size("40 GiB"))
self.scheduleCreateDevice(sdc2)
destroy_sdc1 = self.scheduleDestroyDevice(sdc1)
destroy_sdc2 = self.scheduleDestroyDevice(sdc2)
self.assertEqual(destroy_sdc1.requires(destroy_sdc2), True)
self.assertEqual(destroy_sdc2.requires(destroy_sdc1), False)
self.destroyAllDevices(disks=["sdc", "sdd"])
sdc = self.storage.devicetree.getDeviceByName("sdc")
self.assertNotEqual(sdc, None)
sdd = self.storage.devicetree.getDeviceByName("sdd")
self.assertNotEqual(sdd, None)
sdc1 = self.newDevice(device_class=PartitionDevice, name="sdc1", parents=[sdc], size=Size("50 GiB"))
create_pv = self.scheduleCreateDevice(sdc1)
fmt = self.newFormat("lvmpv", device=sdc1.path)
create_pv_format = self.scheduleCreateFormat(device=sdc1, fmt=fmt)
testvg = self.newDevice(device_class=LVMVolumeGroupDevice, name="testvg", parents=[sdc1])
create_vg = self.scheduleCreateDevice(testvg)
testlv = self.newDevice(
device_class=LVMLogicalVolumeDevice, name="testlv", parents=[testvg], size=Size("30 GiB")
)
create_lv = self.scheduleCreateDevice(testlv)
fmt = self.newFormat("ext4", device=testlv.path)
create_lv_format = self.scheduleCreateFormat(device=testlv, fmt=fmt)
# ActionCreateFormat
# creation of a format on a non-existent device should require the
# action that creates the device
self.assertEqual(create_lv_format.requires(create_lv), True)
# ActionCreateFormat
# an action that creates a format on a device should require an action
# that creates a device that the format's device depends on
self.assertEqual(create_lv_format.requires(create_pv), True)
self.assertEqual(create_lv_format.requires(create_vg), True)
# ActionCreateFormat
# an action that creates a format on a device should require an action
# that creates a format on a device that the format's device depends on
self.assertEqual(create_lv_format.requires(create_pv_format), True)
# XXX from here on, the devices are existing but not in the tree, so
# we instantiate and use actions directly
self.destroyAllDevices(disks=["sdc", "sdd"])
sdc1 = self.newDevice(
device_class=PartitionDevice, exists=True, name="sdc1", parents=[sdc], size=Size("50 GiB")
)
sdc1.format = self.newFormat("lvmpv", device=sdc1.path, exists=True, device_instance=sdc1)
testvg = self.newDevice(
device_class=LVMVolumeGroupDevice, exists=True, name="testvg", parents=[sdc1], size=Size("50 GiB")
)
testlv = self.newDevice(
device_class=LVMLogicalVolumeDevice, exists=True, size=Size("30 GiB"), name="testlv", parents=[testvg]
)
testlv.format = self.newFormat("ext4", device=testlv.path, exists=True, device_instance=testlv)
# ActionResizeDevice
# an action that resizes a device should require an action that grows
# a device that the first action's device depends on, eg: grow
# device containing PV before resize of VG or LVs
sdc1.format._resizable = True # override lvmpv.resizable
sdc1.exists = True
sdc1.format.exists = True
grow_pv = ActionResizeDevice(sdc1, sdc1.size + Size("10 GiB"))
grow_pv.apply()
grow_lv = ActionResizeDevice(testlv, testlv.size + Size("5 GiB"))
grow_lv.apply()
grow_lv_format = ActionResizeFormat(testlv, testlv.size + Size("5 GiB"))
grow_lv_format.apply()
sdc1.exists = False
sdc1.format.exists = False
self.assertEqual(grow_lv.requires(grow_pv), True)
self.assertEqual(grow_pv.requires(grow_lv), False)
# ActionResizeFormat
# an action that grows a format should require the action that grows
# the format's device
self.assertEqual(grow_lv_format.requires(grow_lv), True)
self.assertEqual(grow_lv.requires(grow_lv_format), False)
# ActionResizeFormat
# an action that resizes a device's format should depend on an action
# that grows a device the first device depends on
self.assertEqual(grow_lv_format.requires(grow_pv), True)
self.assertEqual(grow_pv.requires(grow_lv_format), False)
# ActionResizeFormat
# an action that resizes a device's format should depend on an action
# that grows a format on a device the first device depends on
# XXX resize of PV format is not allowed, so there's no real-life
# example of this to test
grow_lv_format.cancel()
grow_lv.cancel()
grow_pv.cancel()
# ActionResizeDevice
# an action that resizes a device should require an action that grows
# a format on a device that the first action's device depends on, eg:
# grow PV format before resize of VG or LVs
# XXX resize of PV format is not allowed, so there's no real-life
# example of this to test
# ActionResizeDevice
# an action that resizes a device should require an action that
# shrinks a device that depends on the first action's device, eg:
# shrink LV before resizing VG or PV devices
testlv.format._minInstanceSize = Size("10 MiB")
testlv.format._targetSize = testlv.format._minInstanceSize
shrink_lv = ActionResizeDevice(testlv, testlv.size - Size("10 GiB"))
shrink_lv.apply()
sdc1.exists = True
sdc1.format.exists = True
shrink_pv = ActionResizeDevice(sdc1, sdc1.size - Size("5 GiB"))
shrink_pv.apply()
sdc1.exists = False
sdc1.format.exists = False
self.assertEqual(shrink_pv.requires(shrink_lv), True)
self.assertEqual(shrink_lv.requires(shrink_pv), False)
# ActionResizeDevice
# an action that resizes a device should require an action that
# shrinks a format on a device that depends on the first action's
# device, eg: shrink LV format before resizing VG or PV devices
shrink_lv_format = ActionResizeFormat(testlv, testlv.size)
shrink_lv_format.apply()
self.assertEqual(shrink_pv.requires(shrink_lv_format), True)
self.assertEqual(shrink_lv_format.requires(shrink_pv), False)
# ActionResizeFormat
# an action that resizes a device's format should depend on an action
# that shrinks a device that depends on the first device
# XXX can't think of a real-world example of this since PVs and MD
# member devices are not resizable in anaconda
# ActionResizeFormat
# an action that resizes a device's format should depend on an action
# that shrinks a format on a device that depends on the first device
# XXX can't think of a real-world example of this since PVs and MD
# member devices are not resizable in anaconda
shrink_lv_format.cancel()
shrink_lv.cancel()
shrink_pv.cancel()
# ActionCreateFormat
# an action that creates a format on a device should require an action
# that resizes a device that the format's device depends on
# XXX Really? Is this always so?
# ActionCreateFormat
# an action that creates a format on a device should require an action
# that resizes a format on a device that the format's device depends on
# XXX Same as above.
# ActionCreateFormat
# an action that creates a format on a device should require an action
# that resizes the device that will contain the format
grow_lv = ActionResizeDevice(testlv, testlv.size + Size("1 GiB"))
fmt = self.newFormat("disklabel", device=testlv.path)
format_lv = ActionCreateFormat(testlv, fmt)
self.assertEqual(format_lv.requires(grow_lv), True)
self.assertEqual(grow_lv.requires(format_lv), False)
# ActionDestroyFormat
# an action that destroys a format should require an action that
# destroys a device that depends on the format's device
destroy_pv_format = ActionDestroyFormat(sdc1)
destroy_lv_format = ActionDestroyFormat(testlv)
destroy_lv = ActionDestroyDevice(testlv)
self.assertEqual(destroy_pv_format.requires(destroy_lv), True)
self.assertEqual(destroy_lv.requires(destroy_pv_format), False)
# ActionDestroyFormat
# an action that destroys a format should require an action that
# destroys a format on a device that depends on the first format's
# device
self.assertEqual(destroy_pv_format.requires(destroy_lv_format), True)
self.assertEqual(destroy_lv_format.requires(destroy_pv_format), False)
sdc2 = self.newDevice(device_class=PartitionDevice, name="sdc2", size=Size("5 GiB"), parents=[sdc])
create_sdc2 = self.scheduleCreateDevice(sdc2)
# create actions should always require destroy actions -- even for
# unrelated devices -- since, after pruning, it should always be the
# case that destroy actions are processed before create actions (no
# create/destroy loops are allowed)
self.assertEqual(create_sdc2.requires(destroy_lv), True)
# similarly, create actions should also require resize actions
self.assertEqual(create_sdc2.requires(grow_lv), True)
def testActionApplyCancel(self):
lv_root = self.storage.devicetree.getDeviceByName("VolGroup-lv_root")
# ActionResizeFormat
lv_root.format._minInstanceSize = Size("10 MiB")
lv_root.format._size = lv_root.size
lv_root.format._targetSize = lv_root.size
original_format_size = lv_root.format.currentSize
target_size = lv_root.size - Size("1 GiB")
# lv_root.format._resizable = True
action = ActionResizeFormat(lv_root, target_size)
self.assertEqual(lv_root.format.size, original_format_size)
action.apply()
self.assertEqual(lv_root.format.size, target_size)
action.cancel()
self.assertEqual(lv_root.format.size, original_format_size)
# ActionResizeDevice
original_device_size = lv_root.currentSize
action = ActionResizeDevice(lv_root, target_size)
self.assertEqual(lv_root.size, original_device_size)
action.apply()
self.assertEqual(lv_root.size, target_size)
action.cancel()
self.assertEqual(lv_root.size, original_device_size)
# ActionDestroyFormat
original_format = lv_root.format
action = ActionDestroyFormat(lv_root)
self.assertEqual(lv_root.format, original_format)
self.assertNotEqual(lv_root.format.type, None)
action.apply()
self.assertEqual(lv_root.format.type, None)
action.cancel()
self.assertEqual(lv_root.format, original_format)
sdc = self.storage.devicetree.getDeviceByName("sdc")
sdc.format = None
pv_fmt = self.newFormat("lvmpv", device_instance=sdc, device=sdc.path)
self.scheduleCreateFormat(device=sdc, fmt=pv_fmt)
vg = self.storage.devicetree.getDeviceByName("VolGroup")
original_pvs = vg.parents[:]
# ActionAddMember
# XXX ActionAddMember and ActionRemoveMember make no effort to restore
# the original ordering of the container's parents list when
# canceled.
pvs = original_pvs[:]
action = ActionAddMember(vg, sdc)
self.assertEqual(list(vg.parents), original_pvs)
action.apply()
pvs.append(sdc)
self.assertEqual(list(vg.parents), pvs)
action.cancel()
pvs.remove(sdc)
self.assertEqual(list(vg.parents), original_pvs)
# ActionRemoveMember
pvs = original_pvs[:]
sdb1 = self.storage.devicetree.getDeviceByName("sdb1")
action = ActionRemoveMember(vg, sdb1)
self.assertEqual(list(vg.parents), original_pvs)
action.apply()
pvs.remove(sdb1)
self.assertEqual(list(vg.parents), pvs)
action.cancel()
self.assertEqual(list(vg.parents), original_pvs)
def testActionRegistration(self):
""" Verify correct operation of action registration and cancelling. """
# self.setUp has just been run, so we should have something like
# a preexisting autopart config in the devicetree.
# registering a destroy action for a non-leaf device should fail
vg = self.storage.devicetree.getDeviceByName("VolGroup")
self.assertNotEqual(vg, None)
self.assertEqual(vg.isleaf, False)
a = ActionDestroyDevice(vg)
with self.assertRaises(ValueError):
self.storage.devicetree.registerAction(a)
# registering any action other than create for a device that's not in
# the devicetree should fail
sdc = self.storage.devicetree.getDeviceByName("sdc")
self.assertNotEqual(sdc, None)
sdc1 = self.newDevice(
device_class=PartitionDevice, name="sdc1", size=Size("100 GiB"), parents=[sdc], exists=True
)
sdc1_format = self.newFormat("ext2", device=sdc1.path, mountpoint="/")
create_sdc1_format = ActionCreateFormat(sdc1, sdc1_format)
create_sdc1_format.apply()
with self.assertRaises(blivet.errors.DeviceTreeError):
self.storage.devicetree.registerAction(create_sdc1_format)
sdc1_format.exists = True
sdc1_format._resizable = True
resize_sdc1_format = ActionResizeFormat(sdc1, sdc1.size - Size("10 GiB"))
resize_sdc1_format.apply()
with self.assertRaises(blivet.errors.DeviceTreeError):
self.storage.devicetree.registerAction(resize_sdc1_format)
resize_sdc1 = ActionResizeDevice(sdc1, sdc1.size - Size("10 GiB"))
resize_sdc1.apply()
with self.assertRaises(blivet.errors.DeviceTreeError):
self.storage.devicetree.registerAction(resize_sdc1)
resize_sdc1.cancel()
resize_sdc1_format.cancel()
destroy_sdc1_format = ActionDestroyFormat(sdc1)
with self.assertRaises(blivet.errors.DeviceTreeError):
self.storage.devicetree.registerAction(destroy_sdc1_format)
destroy_sdc1 = ActionDestroyDevice(sdc1)
with self.assertRaises(blivet.errors.DeviceTreeError):
self.storage.devicetree.registerAction(destroy_sdc1)
# registering a device destroy action should cause the device to be
# removed from the devicetree
lv_root = self.storage.devicetree.getDeviceByName("VolGroup-lv_root")
self.assertNotEqual(lv_root, None)
a = ActionDestroyDevice(lv_root)
self.storage.devicetree.registerAction(a)
lv_root = self.storage.devicetree.getDeviceByName("VolGroup-lv_root")
self.assertEqual(lv_root, None)
self.storage.devicetree.cancelAction(a)
# registering a device create action should cause the device to be
# added to the devicetree
sdd = self.storage.devicetree.getDeviceByName("sdd")
self.assertNotEqual(sdd, None)
sdd1 = self.storage.devicetree.getDeviceByName("sdd1")
self.assertEqual(sdd1, None)
sdd1 = self.newDevice(device_class=PartitionDevice, name="sdd1", size=Size("100 GiB"), parents=[sdd])
a = ActionCreateDevice(sdd1)
self.storage.devicetree.registerAction(a)
sdd1 = self.storage.devicetree.getDeviceByName("sdd1")
self.assertNotEqual(sdd1, None)