def test_s3_update_policy_to_add_statement_existing_policy():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
policy = {
'Version': '2012-10-17',
'Statement': [
{
'Sid': 'goodtablesio_policy_statement_test-gtio-1',
'Effect': 'Allow',
'Principal': {
'AWS': settings.S3_GT_ACCOUNT_ID
},
'Action': [
's3:ListBucket',
's3:GetBucketLocation',
's3:GetBucketNotification'
],
'Resource': 'arn:aws:s3:::test-gtio-1'
}
]
}
expected_policy = None
new_policy = client._update_policy_to_add_statement(policy, 'test-gtio-1')
assert new_policy == expected_policy
def test_s3_client_check_connection_other_error():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error('head_bucket')
with pytest.raises(botocore.exceptions.ClientError):
client.check_connection('test_bucket')
def test_s3_client_check_connection():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'head_bucket',
'')
client.check_connection('test_bucket')
def test_s3_client_add_bucket_policy_already_exists():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy)
assert client.add_policy_for_lambda('test-gtio-1') is None
def test_s3_client_remove_policy_bucket_statement_does_not_exist():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy)
assert client.remove_policy_for_lambda('test-gtio-2') is None
def test_s3_client_add_notification():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'put_bucket_notification_configuration',
mock_responses.s3_put_bucket_notification_configuration)
client.add_notification('test-gtio-2')
def test_s3_client_remove_notification_other_exception_get():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_notification_configuration',
'EndpointConnectionError')
with pytest.raises(botocore.exceptions.ClientError):
client.remove_notification('test-gtio-2')
def test_s3_client_check_connection_invalid_key():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error('head_bucket', 'InvalidAccessKeyId')
with pytest.raises(S3Exception) as exc:
client.check_connection('test_bucket')
assert 'Invalid Access Key' in str(exc.value)
def test_s3_client_remove_policy_bucket_policy_does_not_exist():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_policy',
'NoSuchBucketPolicy')
assert client.remove_policy_for_lambda('test-gtio-2') is None
def test_s3_client_get_bucket_policy_other_error():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_policy',
'EndpointConnectionError')
with pytest.raises(botocore.exceptions.ClientError):
client.get_bucket_policy('test-gtio-1')
def test_s3_client_check_connection_wrong_arn():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error('head_bucket', 'NoSuchBucket')
with pytest.raises(S3Exception) as exc:
client.check_connection('test_bucket')
assert 'Bucket not found' in str(exc.value)
def test_s3_client_get_bucket_policy_no_policy():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_policy',
'NoSuchBucketPolicy')
policy = client.get_bucket_policy('test-gtio-1')
assert policy is None
def test_s3_remove_notification_conf_lambda_empty_dict():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
conf = {
}
expected_conf = {}
new_conf = client._update_conf_to_remove_lambda_notification(
conf, 'test-gtio-1')
assert new_conf == expected_conf
def test_s3_client_check_connection_error():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'head_bucket', 'EndpointConnectionError')
with pytest.raises(S3Exception) as exc:
client.check_connection('test_bucket')
assert 'Could not connect' in str(exc.value)
def test_s3_client_check_connection_access_denied():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'head_bucket', 'AccessDeniedException')
with pytest.raises(S3Exception) as exc:
client.check_connection('test_bucket')
assert 'Access denied' in str(exc.value)
def test_s3_client_get_bucket_policy():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy)
policy = client.get_bucket_policy('test-gtio-1')
assert policy == mock_responses.policy
def test_s3_client_remove_notification_access_denied_get():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_notification_configuration',
'AccessDenied')
with pytest.raises(S3Exception) as exc:
client.remove_notification('test-gtio-2')
assert 'Access denied' in str(exc.value)
def test_s3_client_add_notification_no_perms_on_lamda():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'put_bucket_notification_configuration',
'InvalidArgument')
with pytest.raises(S3Exception) as exc:
client.add_notification('test-gtio-2')
assert 'Bucket does not have permission on lambda' in str(exc.value)
def test_s3_client_add_notification_bucket_not_found():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'put_bucket_notification_configuration',
'NoSuchBucket')
with pytest.raises(S3Exception) as exc:
client.add_notification('test-not-found')
assert 'Bucket not found' in str(exc.value)
def test_s3_client_get_bucket_policy_access_denied():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_policy',
'AccessDenied')
with pytest.raises(S3Exception) as exc:
client.get_bucket_policy('test-gtio-1')
assert 'Access denied' in str(exc.value)
def test_s3_client_get_bucket_policy_bucket_not_found():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_client_error(
'get_bucket_policy',
'NoSuchBucket')
with pytest.raises(S3Exception) as exc:
client.get_bucket_policy('test-not-found')
assert 'Bucket not found' in str(exc.value)
def test_s3_client_add_bucket_policy():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy)
stubber.add_response(
'put_bucket_policy',
mock_responses.s3_put_bucket_policy)
client.add_policy_for_lambda('test-gtio-2')
def test_s3_client_remove_policy_bucket_statement_statement_many():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy_many_statements)
stubber.add_response(
'put_bucket_policy',
mock_responses.s3_put_bucket_policy)
client.remove_policy_for_lambda('test-gtio-1')
def test_s3_client_remove_policy_other_exception():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy)
stubber.add_client_error(
'delete_bucket_policy',
'EndpointConnectionError')
with pytest.raises(botocore.exceptions.ClientError):
client.remove_policy_for_lambda('test-gtio-1')
def test_s3_client_check_connection_invalid_bucket_name():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
# Hack: the botocore stubber does not support raising ParamValidationError
def mock_make_api_call(self, operation_name, kwarg):
if operation_name == 'HeadBucket':
raise botocore.exceptions.ParamValidationError(
report='Wrong params')
with mock.patch('botocore.client.BaseClient._make_api_call',
new=mock_make_api_call):
with pytest.raises(S3Exception) as exc:
client.check_connection('test_bucket')
assert 'Invalid bucket name' in str(exc.value)
def test_s3_client_remove_policy_access_denied():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
with Stubber(client.client) as stubber:
stubber.add_response(
'get_bucket_policy',
mock_responses.s3_get_bucket_policy)
stubber.add_client_error(
'delete_bucket_policy',
'AccessDenied')
with pytest.raises(S3Exception) as exc:
client.remove_policy_for_lambda('test-gtio-1')
assert 'Access denied' in str(exc.value)
def test_s3_remove_notification_conf_lambda_empty_other():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
conf = {
'LambdaFunctionConfigurations': [],
'TopicConfigurations': [{'a': 'b'}],
'QueueConfigurations': [{'a': 'b'}],
}
expected_conf = {
'TopicConfigurations': [{'a': 'b'}],
'QueueConfigurations': [{'a': 'b'}],
}
new_conf = client._update_conf_to_remove_lambda_notification(
conf, 'test-gtio-1')
assert new_conf == expected_conf
def test_s3_remove_notification_conf_lambda_present_other_id():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
conf = {
'LambdaFunctionConfigurations': [
{
'Events': ['s3:ObjectCreated:*'],
'Id': 'goodtablesio_notification_test-gtio-2',
'LambdaFunctionArn': settings.S3_LAMBDA_ARN
}
],
'TopicConfigurations': [{'a': 'b'}],
'QueueConfigurations': [{'a': 'b'}],
}
expected_conf = conf
new_conf = client._update_conf_to_remove_lambda_notification(
conf, 'test-gtio-1')
assert new_conf == expected_conf
def test_s3_client_statement_id_for_bucket():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
assert (client._statement_id_for_bucket('test') ==
'goodtablesio_policy_statement_test')
def test_s3_client_notification_id_for_bucket():
client = S3Client('mock_access_key_id', 'mock_secret_access_key')
assert (client._notification_id_for_bucket('test') ==
'goodtablesio_notification_test')