def test_warning_reviews_not_current_no_warning_on_accepted_diff(phabdouble): phab = phabdouble.get_phabricator_client() d = phabdouble.diff() r = phabdouble.revision(diff=d) phabdouble.reviewer( r, phabdouble.user(username="******"), on_diff=d, status=ReviewerStatus.ACCEPTED, ) revision = phab.call_conduit( "differential.revision.search", constraints={"phids": [r["phid"]]}, attachments={ "reviewers": True, "reviewers-extra": True, "projects": True }, )["data"][0] reviewers = get_collated_reviewers(revision) diff = phab.call_conduit( "differential.diff.search", constraints={"phids": [d["phid"]]}, attachments={"commits": True}, )["data"][0] assert (warning_reviews_not_current( revision=revision, diff=diff, reviewers=reviewers) is None)
def test_warning_reviews_not_current_warns_on_unreviewed_revision(phabdouble): phab = phabdouble.get_phabricator_client() d = phabdouble.diff() r = phabdouble.revision(diff=d) # Don't create any reviewers. revision = phab.call_conduit( "differential.revision.search", constraints={"phids": [r["phid"]]}, attachments={ "reviewers": True, "reviewers-extra": True, "projects": True }, )["data"][0] reviewers = get_collated_reviewers(revision) diff = phab.call_conduit( "differential.diff.search", constraints={"phids": [d["phid"]]}, attachments={"commits": True}, )["data"][0] assert (warning_reviews_not_current(revision=revision, diff=diff, reviewers=reviewers) is not None)
def test_warning_reviews_not_current_no_warning_on_accepted_diff(phabdouble): phab = phabdouble.get_phabricator_client() d = phabdouble.diff() r = phabdouble.revision(diff=d) phabdouble.reviewer( r, phabdouble.user(username='******'), on_diff=d, status=ReviewerStatus.ACCEPTED ) revision = phab.call_conduit( 'differential.revision.search', constraints={'phids': [r['phid']]}, attachments={ 'reviewers': True, 'reviewers-extra': True, } )['data'][0] reviewers = get_collated_reviewers(revision) diff = phab.call_conduit( 'differential.diff.search', constraints={'phids': [d['phid']]}, attachments={'commits': True} )['data'][0] assert warning_reviews_not_current( revision=revision, diff=diff, reviewers=reviewers ) is None
def test_warning_reviews_not_current_warns_on_unreviewed_revision(phabdouble): phab = phabdouble.get_phabricator_client() d = phabdouble.diff() r = phabdouble.revision(diff=d) # Don't create any reviewers. revision = phab.call_conduit( 'differential.revision.search', constraints={'phids': [r['phid']]}, attachments={ 'reviewers': True, 'reviewers-extra': True, } )['data'][0] reviewers = get_collated_reviewers(revision) diff = phab.call_conduit( 'differential.diff.search', constraints={'phids': [d['phid']]}, attachments={'commits': True} )['data'][0] assert warning_reviews_not_current( revision=revision, diff=diff, reviewers=reviewers ) is not None
def test_warning_reviews_not_current_warns_on_unreviewed_revision(phabdouble): d = phabdouble.diff() r = phabdouble.revision(diff=d) # Don't create any reviewers. revision = phabdouble.api_object_for( r, attachments={"reviewers": True, "reviewers-extra": True, "projects": True} ) reviewers = get_collated_reviewers(revision) diff = phabdouble.api_object_for(d, attachments={"commits": True}) assert ( warning_reviews_not_current(revision=revision, diff=diff, reviewers=reviewers) is not None )
def test_warning_reviews_not_current_no_warning_on_accepted_diff(phabdouble): d = phabdouble.diff() r = phabdouble.revision(diff=d) phabdouble.reviewer( r, phabdouble.user(username="******"), on_diff=d, status=ReviewerStatus.ACCEPTED, ) revision = phabdouble.api_object_for( r, attachments={"reviewers": True, "reviewers-extra": True, "projects": True} ) reviewers = get_collated_reviewers(revision) diff = phabdouble.api_object_for(d, attachments={"commits": True}) assert ( warning_reviews_not_current(revision=revision, diff=diff, reviewers=reviewers) is None )