def _add_new_reviewer(cls, unit_id, submission_key, reviewee_key,
reviewer_key):
summary = peer.ReviewSummary(assigned_count=1,
reviewee_key=reviewee_key,
submission_key=submission_key,
unit_id=unit_id)
# Synthesize summary key to avoid a second synchronous put op.
summary_key = db.Key.from_path(
peer.ReviewSummary.kind(),
peer.ReviewSummary.key_name(submission_key))
step = peer.ReviewStep(assigner_kind=domain.ASSIGNER_KIND_HUMAN,
review_summary_key=summary_key,
reviewee_key=reviewee_key,
reviewer_key=reviewer_key,
state=domain.REVIEW_STATE_ASSIGNED,
submission_key=submission_key,
unit_id=unit_id)
# pylint: disable=unbalanced-tuple-unpacking,unpacking-non-sequence
step_key, written_summary_key = entities.put([step, summary])
if summary_key != written_summary_key:
COUNTER_ADD_REVIEWER_BAD_SUMMARY_KEY.inc()
raise AssertionError('Synthesized invalid review summary key %s' %
repr(summary_key))
COUNTER_ADD_REVIEWER_CREATE_REVIEW_STEP.inc()
return step_key
def setUp(self):
super(ReviewStepTest, self).setUp()
self.reviewee_email = '*****@*****.**'
self.reviewee_key = models.Student(key_name=self.reviewee_email).put()
self.reviewer_email = '*****@*****.**'
self.reviewer_key = models.Student(key_name=self.reviewer_email).put()
self.unit_id = 'unit_id'
self.submission_key = student_work.Submission(
reviewee_key=self.reviewee_key, unit_id=self.unit_id).put()
self.review_key = student_work.Review(reviewee_key=self.reviewee_key,
reviewer_key=self.reviewer_key,
unit_id=self.unit_id).put()
self.review_summary_key = peer.ReviewSummary(
reviewee_key=self.reviewee_key,
submission_key=self.submission_key,
unit_id=self.unit_id).put()
self.step = peer.ReviewStep(assigner_kind=domain.ASSIGNER_KIND_AUTO,
review_key=self.review_key,
review_summary_key=self.review_summary_key,
reviewee_key=self.reviewee_key,
reviewer_key=self.reviewer_key,
state=domain.REVIEW_STATE_ASSIGNED,
submission_key=self.submission_key,
unit_id=self.unit_id)
self.step_key = self.step.put()
def test_constructor_sets_key_name(self):
"""Tests construction of key_name, put of entity with key_name set."""
unit_id = 'unit_id'
reviewee_key = models.Student(key_name='*****@*****.**').put()
reviewer_key = models.Student(key_name='*****@*****.**').put()
submission_key = student_work.Submission(
reviewee_key=reviewee_key, unit_id=unit_id).put()
step_key = peer.ReviewStep(
assigner_kind=domain.ASSIGNER_KIND_AUTO,
reviewee_key=reviewee_key, reviewer_key=reviewer_key,
state=domain.REVIEW_STATE_ASSIGNED,
submission_key=submission_key, unit_id=unit_id).put()
self.assertEqual(
peer.ReviewStep.key_name(submission_key, reviewer_key),
step_key.name())
def _attempt_review_assignment(cls, review_summary_key, reviewer_key,
last_change_date):
COUNTER_GET_NEW_REVIEW_ASSIGNMENT_ATTEMPTED.inc()
summary = entities.get(review_summary_key)
if not summary:
raise KeyError('No review summary found with key %s' %
repr(review_summary_key))
if summary.change_date != last_change_date:
# The summary has changed since we queried it. We cannot know for
# sure what the edit was, but let's skip to the next one because it
# was probably a review assignment.
COUNTER_GET_NEW_REVIEW_SUMMARY_CHANGED.inc()
return
step = peer.ReviewStep.get_by_key_name(
peer.ReviewStep.key_name(summary.submission_key, reviewer_key))
if not step:
step = peer.ReviewStep(assigner_kind=domain.ASSIGNER_KIND_AUTO,
review_summary_key=summary.key(),
reviewee_key=summary.reviewee_key,
reviewer_key=reviewer_key,
state=domain.REVIEW_STATE_ASSIGNED,
submission_key=summary.submission_key,
unit_id=summary.unit_id)
else:
if step.state == domain.REVIEW_STATE_COMPLETED:
# Reviewer has previously done this review and the review
# has been deleted. Skip to the next one.
COUNTER_GET_NEW_REVIEW_CANNOT_UNREMOVE_COMPLETED.inc()
return
if step.removed:
# We can reassign the existing review step.
COUNTER_GET_NEW_REVIEW_REASSIGN_EXISTING.inc()
step.removed = False
step.assigner_kind = domain.ASSIGNER_KIND_AUTO
step.state = domain.REVIEW_STATE_ASSIGNED
else:
# Reviewee has already reviewed or is already assigned to review
# this submission, so we cannot reassign the step.
COUNTER_GET_NEW_REVIEW_ALREADY_ASSIGNED.inc()
return
summary.increment_count(domain.REVIEW_STATE_ASSIGNED)
return entities.put([step, summary])[0]
def _submit_review(self, assessment):
"""Submits a review by the current student.
Creates a new user that completes the assessment as well,
so that the student can review it.
Args:
assessment: The assessment to review.
"""
reviewer_key = self.student.get_key()
reviewee = models.Student(key_name='*****@*****.**')
reviewee_key = reviewee.put()
submission_key = db.Key.from_path(
student_work.Submission.kind(),
student_work.Submission.key_name(reviewee_key=reviewee_key,
unit_id=str(assessment.unit_id)))
summary_key = peer.ReviewSummary(assigned_count=1,
reviewee_key=reviewee_key,
submission_key=submission_key,
unit_id=str(
assessment.unit_id)).put()
review_key = student_work.Review(contents='old_contents',
reviewee_key=reviewee_key,
reviewer_key=reviewer_key,
unit_id=str(
assessment.unit_id)).put()
step_key = peer.ReviewStep(assigner_kind=domain.ASSIGNER_KIND_HUMAN,
review_key=review_key,
review_summary_key=summary_key,
reviewee_key=reviewee_key,
reviewer_key=reviewer_key,
submission_key=submission_key,
state=domain.REVIEW_STATE_ASSIGNED,
unit_id=str(assessment.unit_id)).put()
updated_step_key = review_module.Manager.write_review(
step_key, 'new_contents')
self.assertEqual(step_key, updated_step_key)
def test_records_indexed_by_user_id_removed(self):
"""Test a sampling of types whose index is or contains the user ID."""
user_id = None
user = actions.login(self.STUDENT_EMAIL)
actions.register(self, self.STUDENT_EMAIL, course=self.COURSE)
# Get IDs of those students; make an event for each.
with common_utils.Namespace(self.NAMESPACE):
student = models.Student.get_by_user(user)
user_id = student.user_id
# Indexed by user ID suffixed with a string.
p = models.StudentPropertyEntity.create(student, 'foo')
p.value = 'foo'
p.put()
invitation.InvitationStudentProperty.load_or_default(student).put()
questionnaire.StudentFormEntity.load_or_default(
student, 'a_form').put()
# User ID plus skill name.
cm = competency.BaseCompetencyMeasure.load(user_id, 1)
cm.save()
# models.student_work.KeyProperty - a foreign key to Student.
reviewee_key = db.Key.from_path(models.Student.kind(), user_id)
reviewer_key = db.Key.from_path(models.Student.kind(), 'xyzzy')
student_work.Review(contents='abcdef', reviewee_key=reviewee_key,
reviewer_key=reviewer_key, unit_id='7').put()
submission_key = student_work.Submission(
unit_id='7', reviewee_key=reviewee_key).put()
peer.ReviewSummary(submission_key=submission_key,
reviewee_key=reviewee_key, unit_id='7').put()
peer.ReviewStep(
submission_key=submission_key, reviewee_key=reviewee_key,
reviewer_key=reviewer_key, unit_id='7',
state=domain.REVIEW_STATE_ASSIGNED,
assigner_kind=domain.ASSIGNER_KIND_AUTO).put()
# Assure ourselves that we have all of the items we just added.
with common_utils.Namespace(self.NAMESPACE):
l = list(models.StudentPropertyEntity.all().run())
self.assertEquals(2, len(l)) # 'foo', 'linear-course-completion'
l = list(invitation.InvitationStudentProperty.all().run())
self.assertEquals(1, len(l))
l = list(questionnaire.StudentFormEntity.all().run())
self.assertEquals(1, len(l))
l = list(competency.CompetencyMeasureEntity.all().run())
self.assertEquals(1, len(l))
l = list(student_work.Review.all().run())
self.assertEquals(1, len(l))
l = list(student_work.Submission.all().run())
self.assertEquals(1, len(l))
l = list(peer.ReviewSummary.all().run())
self.assertEquals(1, len(l))
l = list(peer.ReviewStep.all().run())
self.assertEquals(1, len(l))
self._unregister_and_request_data_removal(self.COURSE)
self._complete_removal()
# Assure ourselves that all added items are now gone.
with common_utils.Namespace(self.NAMESPACE):
l = list(models.StudentPropertyEntity.all().run())
self.assertEquals(0, len(l))
l = list(invitation.InvitationStudentProperty.all().run())
self.assertEquals(0, len(l))
l = list(questionnaire.StudentFormEntity.all().run())
self.assertEquals(0, len(l))
l = list(competency.CompetencyMeasureEntity.all().run())
self.assertEquals(0, len(l))
l = list(student_work.Review.all().run())
self.assertEquals(0, len(l))
l = list(student_work.Submission.all().run())
self.assertEquals(0, len(l))
l = list(peer.ReviewSummary.all().run())
self.assertEquals(0, len(l))
l = list(peer.ReviewStep.all().run())
self.assertEquals(0, len(l))
